GNU bug report logs -
#57688
[PATCH] gnu: Add wiggle.
Previous Next
Reported by: jgart <jgart <at> dismail.de>
Date: Thu, 8 Sep 2022 23:16:02 UTC
Severity: normal
Tags: patch
Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
On 09-09-2022 06:14, jgart wrote:
> + (arguments
> + (list #:make-flags
> + #~(list "-I. -O3"
> + (string-append "CC=" #$(cc-for-target))
> + "INSTALL=\"install\""
> + "STRIP=-s"
> + (string-append "BINDIR=" #$output "/bin")
> + (string-append "MANDIR=" #$output "/share/man")
> + (string-append "CC=" #$(cc-for-target))
> + (string-append "PREFIX=" #$output))
> + #:phases
> + '(modify-phases %standard-phases
Nitpick: using G-exp for #:make-flags but not #:phases is inconsistent,
though that's something a committer could adjust without any trouble.
> + (delete 'configure)
> + (replace 'check
> + (lambda* (#:key inputs ouputs tests? #:allow-other-keys)
> + (when tests?
> + (invoke "./dotest")))))))
That's what I had in mind, thanks. For completeness, ideally someone
would check the sources for malware, but otherwise LGTM.
Greetings,
Maxime.
[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]
This bug report was last modified 2 years and 308 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.