GNU bug report logs - #57688
[PATCH] gnu: Add wiggle.

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 57688 <at> debbugs.gnu.org
Subject: [bug#57688] [PATCH] gnu: Add wiggle.
Date: Fri, 9 Sep 2022 01:51:52 +0200

[Message part 1 (text/plain, inline)]

On 09-09-2022 01:15, jgart via Guix-patches via wrote:
> +       `(#:make-flags
> +         (list "-I. -O3"
> +               (string-append "CC=" ,(cc-for-target))
> +               "INSTALL=\"install\""
> +               "STRIP=-s"
> +               (string-append "BINDIR=" %output "/bin")
> +               (string-append "MANDIR=" %output "/share/man")
> +               (string-append "CC=" ,(cc-for-target))
> +               (string-append "PREFIX=" %output))

%output is undocumented.  Use #$output instead.

> +          #:phases
> +          (modify-phases %standard-phases
> +            (delete 'configure)
> +            (replace 'check
> +              (lambda* (#:key inputs ouputs #:allow-other-keys)
> +                (invoke "./dotest"))))))

Being unconditional, this breaks --without-tests.  Have you run
"./pre-inst-env guix lint wiggle"?  There's a linter for detecting that.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.