Subject: Re: [bug#57688] [PATCH] gnu: Add wiggle.

From: Maxime Devos <[email-masked]>
Date: Fri, 9 Sep 2022 01:51:52 +0200

On 09-09-2022 01:15, jgart via Guix-patches via wrote:
> +       `(#:make-flags
> +         (list "-I. -O3"
> +               (string-append "CC=" ,(cc-for-target))
> +               "INSTALL=\"install\""
> +               "STRIP=-s"
> +               (string-append "BINDIR=" %output "/bin")
> +               (string-append "MANDIR=" %output "/share/man")
> +               (string-append "CC=" ,(cc-for-target))
> +               (string-append "PREFIX=" %output))

%output is undocumented.  Use #$output instead.

> +          #:phases
> +          (modify-phases %standard-phases
> +            (delete 'configure)
> +            (replace 'check
> +              (lambda* (#:key inputs ouputs #:allow-other-keys)
> +                (invoke "./dotest"))))))

Being unconditional, this breaks --without-tests.  Have you run
"./pre-inst-env guix lint wiggle"?  There's a linter for detecting that.

Greetings,
Maxime.