GNU bug report logs - #57667
[PATCH] gnu: Add emacs-flymake-collection.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 57667 <at> debbugs.gnu.org
Cc: jgart <at> dismail.de
Subject: [bug#57667] [PATCH] gnu: Add emacs-flymake-collection.
Date: Fri, 09 Sep 2022 09:24:34 +0200

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable.

Thanks. Some comments below.

> +(define-public emacs-flymake-collection
> +  (package
> +    (name "emacs-flymake-collection")
> +    (version "20220612.1340")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/flymake-collection-"
> +                           version ".tar"))

We don't fetch tarballs from MELPA because those are not stable. Could
you use Github as upstream instead?

> +       (sha256
> +        (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/mohkale/flymake-collection/")
> +    (synopsis "Collection of checkers for flymake")

Nitpick: Flymake

> +    (description
> +"This package tries to provide a comprehensive list of

This package provides…

> +diagnostic-functions for use with flymake, give users the tools to
> +easily define new syntax checkers and help selectively enable or disable
> +diagnostic-functions based on major-modes.")

Nitpick: major modes

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.