GNU bug report logs - #57652
29.0.50; Warning setting attribute of face ‘term’

Previous Next

Package: emacs;

Reported by: David Ponce <da_vid <at> orange.fr>

Date: Wed, 7 Sep 2022 18:50:01 UTC

Severity: normal

Found in version 29.0.50

Full log


View this message in rfc822 format

From: Po Lu <luangruo <at> yahoo.com>
To: David Ponce <da_vid <at> orange.fr>
Cc: 57652 <at> debbugs.gnu.org, gregory <at> heytings.org
Subject: bug#57652: 29.0.50; Warning setting attribute of face ‘term’
Date: Thu, 08 Sep 2022 13:02:20 +0800
David Ponce <da_vid <at> orange.fr> writes:

> diff --git a/term.el b/term.el
> index 797fb18074..c564a5429a 100644
> --- a/term.el
> +++ b/term.el
> @@ -755,17 +755,19 @@ ansi-term-color-vector
>     term-color-bright-cyan
>     term-color-bright-white])
>
> -(defcustom term-default-fg-color nil
> -  "If non-nil, default color for foreground in Term mode."
> +(defcustom term-default-fg-color 'unspecified
> +  "Default color for foreground in Term mode."
>    :group 'term
> -  :type '(choice (const nil) (string :tag "color")))
> +  :type '(choice (const unspecified)
> +                 (string :tag "color")))

Doesn't that change behavior?

i.e. wouldn't it be better to test that term-default-fg-color is not nil
wherever the face is actually made that color?




This bug report was last modified 2 years and 279 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.