Subject: bug#57652: 29.0.50; Warning setting attribute of face ‘term’

From: Po Lu <[email-masked]>
Date: Thu, 08 Sep 2022 13:02:20 +0800

David Ponce <[email-masked]> writes:

> diff --git a/term.el b/term.el
> index 797fb18074..c564a5429a 100644
> --- a/term.el
> +++ b/term.el
> @@ -755,17 +755,19 @@ ansi-term-color-vector
>     term-color-bright-cyan
>     term-color-bright-white])
>
> -(defcustom term-default-fg-color nil
> -  "If non-nil, default color for foreground in Term mode."
> +(defcustom term-default-fg-color 'unspecified
> +  "Default color for foreground in Term mode."
>    :group 'term
> -  :type '(choice (const nil) (string :tag "color")))
> +  :type '(choice (const unspecified)
> +                 (string :tag "color")))

Doesn't that change behavior?

i.e. wouldn't it be better to test that term-default-fg-color is not nil
wherever the face is actually made that color?