GNU bug report logs - #57642
[PATCH] gnu: linux: Fix unnecessary let clause in make-linux-libre.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#57642: closed ([PATCH] gnu: linux: Fix unnecessary let clause
 in make-linux-libre.)
Date: Wed, 07 Sep 2022 12:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 07 Sep 2022 14:53:28 +0200
with message-id <87y1uvz6pj.fsf <at> gnu.org>
and subject line Re: bug#57642: [PATCH] gnu: linux: Fix unnecessary let clause in make-linux-libre.
has caused the debbugs.gnu.org bug report #57642,
regarding [PATCH] gnu: linux: Fix unnecessary let clause in make-linux-libre.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
57642: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57642
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: muradm <mail <at> muradm.net>
To: bug-guix <at> gnu.org
Subject: [PATCH] gnu: linux: Fix unnecessary let clause in make-linux-libre.
Date: Wed,  7 Sep 2022 15:02:16 +0300

* gnu/packages/linux.scm (make-linux-libre*)[arguments]:
Remove unnecessary let clause in 'configure phase.
---
 gnu/packages/linux.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index f4880f164c..ee6e592183 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -852,8 +852,7 @@ (define* (make-linux-libre* version gnu-revision source supported-systems
                            #$(and extra-version
                                   (string-append "-" extra-version)))
 
-                   (let ((build  (assoc-ref %standard-phases 'build))
-                         (config (assoc-ref inputs "kconfig")))
+                   (let ((config (assoc-ref inputs "kconfig")))
 
                      ;; Use a custom kernel configuration file or a default
                      ;; configuration file.
-- 
2.37.2

[Message part 3 (message/rfc822, inline)]

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: muradm <mail <at> muradm.net>
Cc: 57642-done <at> debbugs.gnu.org
Subject: Re: bug#57642: [PATCH] gnu: linux: Fix unnecessary let clause in
 make-linux-libre.
Date: Wed, 07 Sep 2022 14:53:28 +0200

Hey,

> * gnu/packages/linux.scm (make-linux-libre*)[arguments]:
> Remove unnecessary let clause in 'configure phase.

You should send such patches to "guix-patches <at> gnu.org" instead as it is
not a bug report nor correction. Pushed as 2183db8d2 :).

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.