GNU bug report logs - #57639
[PATCH] Add new command 'toggle-theme'

Previous Next

Full log

Message #239 received at 57639 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: larsi <at> gnus.org, 57639 <at> debbugs.gnu.org, info <at> protesilaos.com
Subject: Re: bug#57639: [PATCH] Add new command 'toggle-theme'
Date: Thu, 13 Oct 2022 13:34:25 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  57639 <at> debbugs.gnu.org,  Protesilaos
>  Stavrou <info <at> protesilaos.com>
> Date: Thu, 13 Oct 2022 08:50:34 +0000
> 
> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> 
> > Philip Kaludercic <philipk <at> posteo.net> writes:
> >
> >> Great, can you point me to the places I would have to make changes for
> >> this to work:
> >>
> >>         add a function to loaddefs-gen that only fetched those for the
> >>         Emacs build (it'd almost be trivial -- we just bind
> >>         lisp-mode-autoload-regexp to ";;;###theme-autoload" and then
> >>         point the scraping function at etc/themes).
> >
> > I think you'd basically put something like the following into
> > `loaddefs-generate--emacs-batch' --
> >
> > (let ((lisp-mode-autoload-regexp
> >         "^;;;###\\(\\(noexist\\)-\\)?\\(theme-autoload\\)"))
> >   (loaddefs-generate
> >     (expand-file-name "../etc/themes/" lisp-directory)
> >     (expand-file-name "theme-loaddefs.el" lisp-directory)))
> >
> > Then you have to teach `loaddefs-generate--make-autoload' to generate
> > the correct forms as a result of the `deftheme' -- which should be some
> > `put's.
> 
> OK, it looks like this worked.  Just to recap, these are the proposed
> changes:

What, if anything, does this mean for themes that aren't bundled with
Emacs?

Also, this needs a NEWS entry.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.