GNU bug report logs - #57639
[PATCH] Add new command 'toggle-theme'

Previous Next

Full log

View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57639 <at> debbugs.gnu.org, Protesilaos Stavrou <info <at> protesilaos.com>
Subject: bug#57639: [PATCH] Add new command 'toggle-theme'
Date: Thu, 13 Oct 2022 08:50:34 +0000

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> Great, can you point me to the places I would have to make changes for
>> this to work:
>>
>>         add a function to loaddefs-gen that only fetched those for the
>>         Emacs build (it'd almost be trivial -- we just bind
>>         lisp-mode-autoload-regexp to ";;;###theme-autoload" and then
>>         point the scraping function at etc/themes).
>
> I think you'd basically put something like the following into
> `loaddefs-generate--emacs-batch' --
>
> (let ((lisp-mode-autoload-regexp
>         "^;;;###\\(\\(noexist\\)-\\)?\\(theme-autoload\\)"))
>   (loaddefs-generate
>     (expand-file-name "../etc/themes/" lisp-directory)
>     (expand-file-name "theme-loaddefs.el" lisp-directory)))
>
> Then you have to teach `loaddefs-generate--make-autoload' to generate
> the correct forms as a result of the `deftheme' -- which should be some
> `put's.

OK, it looks like this worked.  Just to recap, these are the proposed
changes:

[0001-Tag-themes-with-properties.patch (text/x-patch, attachment)]

[0001-Handle-theme-autoload-comments-in-etc-themes.patch (text/x-patch, attachment)]

[Message part 4 (text/plain, inline)]

Note that this includes changes to both the Leuven and Modus themes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.