GNU bug report logs - #57639
[PATCH] Add new command 'toggle-theme'

Previous Next

Full log

View this message in rfc822 format

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, Philip Kaludercic <philipk <at> posteo.net>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57639 <at> debbugs.gnu.org
Subject: bug#57639: [PATCH] Add new command 'toggle-theme'
Date: Mon, 10 Oct 2022 04:17:38 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sun,  9 Oct 2022 22:32:49 +0200
>
> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> --8<---------------cut here---------------start------------->8---
>> ;;;###autoload
>> (when (and (boundp 'custom-theme-load-path)
>>            load-file-name)
>>   ;; Add theme folder to `custom-theme-load-path' when installing over MELPA.
>>   (add-to-list 'custom-theme-load-path
>>                (file-name-as-directory (file-name-directory load-file-name))))
>> --8<---------------cut here---------------end--------------->8---
>>
>> from leuven-theme.el to be removed.
>
> Why would the above be necessary for leuven-theme.el in particular?
>
> I've never had a problem loading themes installed from MELPA, so I don't
> understand why it should need any special treatment.

Note that the modus-themes.el have this:

    ;;;###autoload
    (when load-file-name
      (let ((dir (file-name-directory load-file-name)))
        (unless (equal dir (expand-file-name "themes/" data-directory))
          (add-to-list 'custom-theme-load-path dir))))

It is (was?) necessary to make the theme available when installing with
package.el (GNU ELPA).

-- 
Protesilaos Stavrou
https://protesilaos.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.