GNU bug report logs - #57639
[PATCH] Add new command 'toggle-theme'

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57639 <at> debbugs.gnu.org
Subject: bug#57639: [PATCH] Add new command 'toggle-theme'
Date: Wed, 21 Sep 2022 13:02:29 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

>> autoloads: $(lisp)/emacs-lisp/loaddefs-gen.elc gen-lisp
>> 	$(AM_V_GEN)$(emacs) \
>>             -l $(lisp)/emacs-lisp/loaddefs-gen.elc \
>> 	    -f loaddefs-generate--emacs-batch ${SUBDIRS_ALMOST}
>>
>> We can add ../etc/themes there after ${SUBDIRS_ALMOST}, though.
>
> Would there be a disadvantage to doing so?

There's no problems when doing

;;;###autoload(put ...)

because those are entered into the loaddefs.el file literally.  There
may be some confusion if people start putting

;;;###autoload
(defun ...)

into the theme files, because the etc/themes directory is not in
`load-path' (so those autoloads will fail).

So it has a slightly inconsistent effect, but I don't think there'll be
a problem in practice, because people don't put functions into the theme
files.  *knocks on wood*

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.