GNU bug report logs - #57639
[PATCH] Add new command 'toggle-theme'

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57639 <at> debbugs.gnu.org
Subject: bug#57639: [PATCH] Add new command 'toggle-theme'
Date: Mon, 19 Sep 2022 09:58:13 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

> One last additional, I've added a property to all the themes indicating
> that they are colour schemes.  This would make it easier to toggle
> between dark and light modes if multiple themes are enabled of which
> only one is a colour theme:

Makes sense.  One thing that occurred to me now that I didn't think of
before is:

>  (deftheme adwaita
>    "Face colors similar to the default theme of Gnome 3 (Adwaita).
>  The colors are chosen to match Adwaita window decorations and the
> -default look of the Gnome 3 desktop.")
> +default look of the Gnome 3 desktop."
> +  :background-mode 'light
> +  :kind 'color-scheme)

Is this backwards compatible, and is that something we need to care
about?  I know that some (many?) themes are also distributed outside of
Emacs, and should work under a range of Emacs versions.  I don't think
extending `deftheme' in this way would be backwards compatible, though,
even if it makes sense from a language design point of view.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.