GNU bug report logs - #57608
Upstreaming KDE Plasma and rest of packages

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Maxime Devos <maximedevos <at> telenet.be>, Brendan Tildesley <mail <at> brendan.scot>, Leo Famulari <leo <at> famulari.name>, "marekpasnikowski <at> protonmail.com" <marekpasnikowski <at> protonmail.com>, "marius <at> gnu.org" <marius <at> gnu.org>, Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 57608 <at> debbugs.gnu.org
Subject: [bug#57608] Upstreaming KDE Plasma and rest of packages
Date: Sat, 24 Sep 2022 15:12:55 +0200

Hi!

An impressive patch series.  :-)

phodina <phodina <at> protonmail.com> skribis:

> From ce8fab8c61ade5c317445a5df26189e51061c1ec Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Wed, 7 Sep 2022 07:48:41 +0200
> Subject: [PATCH] gnu: Add fwupd service.
>
> * gnu/services/firmware.scm (fwupd): New variable.

Simply:

  * gnu/services/firmware.scm: New file.
  * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

… and actually add it to gnu/local.mk.

> +++ b/gnu/services/firmware.scm
> @@ -0,0 +1,70 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright ?? 2022 Petr Hodina <phodina <at> protonmail.com>

Typo.

> +(define-record-type* <fwupd-configuration> fwupd-configuration
> +                     make-fwupd-configuration fwupd-configuration?
> +                     (fwupd fwupd-configuration-fwupd
> +                            (default fwupd)))

Please indent in the same way as done elsewhere.

We’ll also need an entry in the manual for this one, maybe under
“Desktop Services”?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.