Subject: [bug#57608] Upstreaming KDE Plasma and rest of packages

From: Ludovic Courtès <[email-masked]>
Date: Sat, 24 Sep 2022 15:12:55 +0200

Hi!

An impressive patch series.  :-)

phodina <[email-masked]> skribis:

> From ce8fab8c61ade5c317445a5df26189e51061c1ec Mon Sep 17 00:00:00 2001
> From: Petr Hodina <[email-masked]>
> Date: Wed, 7 Sep 2022 07:48:41 +0200
> Subject: [PATCH] gnu: Add fwupd service.
>
> * gnu/services/firmware.scm (fwupd): New variable.

Simply:

  * gnu/services/firmware.scm: New file.
  * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

… and actually add it to gnu/local.mk.

> +++ b/gnu/services/firmware.scm
> @@ -0,0 +1,70 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright ?? 2022 Petr Hodina <[email-masked]>

Typo.

> +(define-record-type* <fwupd-configuration> fwupd-configuration
> +                     make-fwupd-configuration fwupd-configuration?
> +                     (fwupd fwupd-configuration-fwupd
> +                            (default fwupd)))

Please indent in the same way as done elsewhere.

We’ll also need an entry in the manual for this one, maybe under
“Desktop Services”?

Ludo’.