GNU bug report logs - #57598
[PATCH] doc: Update contribution guidelines on patches, etc.

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 57598 <at> debbugs.gnu.org, guix-maintainers <at> gnu.org
Subject: [bug#57598] [PATCH] doc: Update contribution guidelines on patches, etc.
Date: Sun, 25 Sep 2022 19:59:55 +0200

[Message part 1 (text/plain, inline)]

On 24-09-2022 15:03, Ludovic Courtès wrote:
> Hi!
> 
> Thanks for this welcome addition!  Modulo the cosmetic suggestions
> below, I think it’s fine.
> 
> Maintainers, if you have something to say on the guidelines, now’s the
> time!
> 
>    https://issues.guix.gnu.org/57598
> 
> Maxime Devos <maximedevos <at> telenet.be> skribis:
> 
>> * doc/contributing.texi (Modifying Sources): Replaced with ...
>> ("Modifying Sources"): ... this.  List more use cases and some principles.
>>
>> This patch incorporates some text written by Liliana Marie Prikler.  The
>> structure is based on a proposal by Julien Lepiller.  The text has been
>> revised based on reviews by David Larsson and blake.
>>
>> (! remove following text before committing !)
> 
> You can write comments below the --- and diffstats.  That way, ‘git am’
> will ignore them when applying the patch.

I know of '---', but AFAICT this is undocumented behaviour, so I'm 
hesitant to rely on that.

> [...]
> Could you send an updated version?

I intend to do so after bringing antiox to 100%.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.