From unknown Sun Jun 22 22:40:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#57590 <57590@debbugs.gnu.org> To: bug#57590 <57590@debbugs.gnu.org> Subject: Status: [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted. Reply-To: bug#57590 <57590@debbugs.gnu.org> Date: Mon, 23 Jun 2025 05:40:21 +0000 retitle 57590 [PATCH] Adding libldm: Manager for Windows dynamic disks incl= uding software RAID. It creates device mapper entries for dynamic disks all= owing them to be mounted. reassign 57590 guix-patches submitter 57590 Lukasz Olszewski severity 57590 normal tag 57590 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 05 02:43:10 2022 Received: (at submit) by debbugs.gnu.org; 5 Sep 2022 06:43:10 +0000 Received: from localhost ([127.0.0.1]:46231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oV5p7-0000QC-5z for submit@debbugs.gnu.org; Mon, 05 Sep 2022 02:43:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:41304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUxOy-0003NN-FK for submit@debbugs.gnu.org; Sun, 04 Sep 2022 17:43:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUxOy-000692-3p for guix-patches@gnu.org; Sun, 04 Sep 2022 17:43:36 -0400 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]:40946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oUxOv-0005dG-U0 for guix-patches@gnu.org; Sun, 04 Sep 2022 17:43:35 -0400 Received: by mail-ot1-x32a.google.com with SMTP id z22-20020a056830129600b0063711f456ceso5099117otp.7 for ; Sun, 04 Sep 2022 14:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lukaszolszewski-info.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=uyuGMi2B5LPfA6WWwwUORfkG/ESTVfiA8bahNhcexGo=; b=VdYsh8kGahW3deWwLVUGc1TqR0vRzMNxzZc9G4fbsQcvnm4/Lm4iLPZwTnx+OsIB4S 8ETRmc5sctaICMTPonAMLt+/KkQ/b1FA7kV07eEcMZV5PYrd0/evgkTdDXEgu8BucFe5 A948TUGiQVNOZztYssEoi2bxWizWG4sUThxFEtcVcM20Uw9xHtv+OlqRX1tVcmnazZHX 9EYR0P0SAoe3ZnlkpY/mePMlC0zYoMtQ1/SWEwHg35G3r/mrUThANaCFoz7d/x7huaNg +TGoeEgB9TPV4ArFHEnHTG9WHZPw4Ivl0s8Tf1eTp5+8UmnCz0C3AsWyb/Sura4bsV47 YDLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=uyuGMi2B5LPfA6WWwwUORfkG/ESTVfiA8bahNhcexGo=; b=tpyXSbP7xDc5KVW2B6fzy8/WNtqJelyNZ6NFt1shwBqAowmPQ7CBn0lXqckKz+z4q8 tsCRyceqAf/y93zCqg2LFFR0bUMgksbNmE+S5Ij0azAP7U1KMBGnT32vtVjn7nsG/DTt ToPUmH2nW2qIGp8zPxeHQyc1Nyrh9uHgYqTpBgwYUf9h57ESPJzCL1EAy2lUB+piqsew vqKtGaJSQ0OEz+5d9Uwe0/fSvU3BUiiDpVMaZw6ksZQc9670uhEQhJvnFmrQvRUVtcMd r9wab6zGsZ2w8HakMsLgIhAC/bdh1I04CvaY2xyR9N+6S7USkocvStAEfDiwjDiNIxrQ Z+5g== X-Gm-Message-State: ACgBeo32qi9wvGXOyLtdlQUNAQtF43iySaTFop+beyTPmtpgw/vzGMh3 /dAhRkIMhWM5gRYUR9mAC9kvP4HyFXe/gVSC3cYeYtO4STmbEw== X-Google-Smtp-Source: AA6agR7npVycvx7HlMwKXeBGWcxyuOye7SpOb7PYoW+GNWxM6ynzoXQ2BOiMzVORFnxAwJpYSOuUT99+x0fkURc6ygw= X-Received: by 2002:a9d:5a88:0:b0:638:911a:d7fd with SMTP id w8-20020a9d5a88000000b00638911ad7fdmr18392279oth.6.1662327811475; Sun, 04 Sep 2022 14:43:31 -0700 (PDT) MIME-Version: 1.0 From: Lukasz Olszewski Date: Sun, 4 Sep 2022 23:42:55 +0200 Message-ID: Subject: [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted. To: guix-patches@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=2607:f8b0:4864:20::32a; envelope-from=email@lukaszolszewski.info; helo=mail-ot1-x32a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 05 Sep 2022 02:43:07 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --- gnu/packages/libldm.scm | 70 +++++++++++++++++++++++++++++++++++++++++ gnu/services/libldm.scm | 47 +++++++++++++++++++++++++++ 2 files changed, 117 insertions(+) create mode 100644 gnu/packages/libldm.scm create mode 100644 gnu/services/libldm.scm diff --git a/gnu/packages/libldm.scm b/gnu/packages/libldm.scm new file mode 100644 index 0000000000..38fb5e218e --- /dev/null +++ b/gnu/packages/libldm.scm @@ -0,0 +1,70 @@ +(define-module (gnu packages libldm) + #:use-module (gnu packages) + #:use-module (guix packages) + #:use-module ((guix licenses) + #:prefix license:) + #:use-module (guix build-system gnu) + #:use-module (gnu packages base) + #:use-module (gnu packages autotools) + #:use-module (gnu packages m4) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages gnome) + #:use-module (gnu packages glib) + #:use-module (gnu packages compression) + #:use-module (gnu packages readline) + #:use-module (gnu packages linux) + #:use-module (gnu packages xml) + #:use-module (gnu packages docbook) + #:use-module (gnu packages gtk) + #:use-module (guix git-download)) + +(define-public libldm + (package + (name "libldm") + (version "0.2.5") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/mdbooth/libldm.git") + (commit (string-append "libldm-" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "08iz3kq4ci79abpyxwwqmzi3bayyk4s29n8h1jqgdgk5yskwgnrn")))) + (build-system gnu-build-system) + (inputs (list json-glib + glib + zlib + readline + lvm2 + libgudev)) + (native-inputs (list which + m4 + libtool + autoconf-wrapper + automake + pkg-config + `(,glib "bin") + gtk-doc + libxml2 + libxslt + docbook-xsl)) + (arguments + '(#:tests? #f + #:parallel-build? #t + #:phases (modify-phases %standard-phases + (add-before 'configure 'set-env + (lambda _ + (setenv "CONFIG_SHELL" + (which "")) #t)) + (add-before 'bootstrap 'run-gtkdocize + (lambda _ + (invoke "gtkdocize"))) + (replace 'bootstrap + (lambda _ + (invoke "autoreconf" "-fiv")))))) + (home-page "https://github.com/mdbooth/libldm") + (synopsis "Manager for Microsoft Windows dynamic disks") + (description + "Libldm is a library for managing Microsoft Windows dynamic disks, which use Microsoft's LDM metadata. It can inspect them, and also create and remove device-mapper block devices which can be mounted.") + (license license:gpl3))) diff --git a/gnu/services/libldm.scm b/gnu/services/libldm.scm new file mode 100644 index 0000000000..00e19540f0 --- /dev/null +++ b/gnu/services/libldm.scm @@ -0,0 +1,47 @@ +(define-module (gnu services libldm) + #:use-module (guix records) + #:use-module (guix gexp) + #:use-module (guix diagnostics) + #:use-module (guix i18n) + #:use-module (srfi srfi-1) + #:use-module (srfi srfi-26) + #:use-module (ice-9 match) + #:use-module (guix gexp) + #:use-module (gnu services) + #:use-module (guix modules) + #:use-module (gnu services base) + #:use-module (gnu services shepherd) + #:use-module (gnu packages libldm) + #:export (libldm-configuration libldm-configuration? libldm-service-type)) + +(define-record-type* + libldm-configuration + make-libldm-configuration + libldm-configuration? + (package + libldm-configuration-package + (default libldm)) + (action libldm-configuration-action + (default '("create" "all")))) + +(define (libldm-shepherd-service config) + "Return a for libldm with CONFIG" + (let* ((libldm (libldm-configuration-package config)) + (action (libldm-configuration-action config))) + (list (shepherd-service (documentation + "Run ldmtool to create Windows dynamic disc device nodes at startup.") + (provision '(libldmd)) + (one-shot? #t) + (start #~(make-forkexec-constructor (append (list (string-append #$libldm + "/bin/ldmtool")) + '(#$@action)))) + (stop #~(make-kill-destructor)))))) + +(define libldm-service-type + (service-type (name 'libldm) + (extensions (list (service-extension + shepherd-root-service-type + libldm-shepherd-service))) + (default-value (libldm-configuration)) + (description + "Run ldmtool to create device nodes for Windows dynamic discs so they can be mounted"))) base-commit: 41bce2414a286836b4071d90b660fb457ee76e32 -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 09:20:30 2022 Received: (at 57590) by debbugs.gnu.org; 11 Sep 2022 13:20:31 +0000 Received: from localhost ([127.0.0.1]:41115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXMsw-00072I-E2 for submit@debbugs.gnu.org; Sun, 11 Sep 2022 09:20:30 -0400 Received: from mail-oa1-f48.google.com ([209.85.160.48]:43784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oX8Yn-0006NX-TY for 57590@debbugs.gnu.org; Sat, 10 Sep 2022 18:02:46 -0400 Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-1279948d93dso13279648fac.10 for <57590@debbugs.gnu.org>; Sat, 10 Sep 2022 15:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lukaszolszewski-info.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :mime-version:from:to:cc:subject:date; bh=Vws6/N2RnRtI3X+xO6vpHy9d44wInl4FBYkB8oAEj8U=; b=pNT0DxO3gCke1MBl9vKGYJsNkSMvpA9OMt98zuBrzc8URdi5AvxegYmbOhKbTeNI2M O7q3PP9vsqa5qNNhuIlA/OK8jbggdyC0ranfR+9gJoV8Ts4IwGRJZYGZmEQdZhgAyx3g qVMi+yNfk87jEBlPTTKxJWYEgST9vqDywGyDaJSjxknN8aAdRo4QshyB6AZgT70Bu/Mq T0lVnhQVzIWgZJVQ4qbLCUh+3ZG0sdI688uAD41cc+holJ6GkLsnnmyf1nMXGxfGcpsc itWzrBrDiS05dzX0oIw2VtEBWnbwdxxK3SlP9oF/gopvMWXMPE8Ve3/pTpVXiJgk/Tyw r9AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Vws6/N2RnRtI3X+xO6vpHy9d44wInl4FBYkB8oAEj8U=; b=QseSKv8QYdYHdZI/fiTb8dietmRFdsd7UpD6gL3hbBtur91o+PwFRCJO+oN9k8J9le 03kF7Dcc0z//zYztkIFwCfAKaesH27JUmfsBE0nwsS0C+I+g/Rn62ciwvimzNXxAVzm7 NWYulu86YQbd3O/w0zQUC3EL81rrdusaR7PexIUttsntzjvb7BShM9bNb6rJOFK+C5EK yzw01Bog9xXX8Q3t9t4JuyeV48kJE4dBcIK5ib0c4k0xjxX7MohUQuO3QBnjprtQ7ZAT tjkRGWZqmRBsWaz6HTXrGZ4FD6r+o50sBQPKa+NoTa4wogfdy1MFQ0P5THaMZP04zCJL +khw== X-Gm-Message-State: ACgBeo1FVgCGfQ2bRCzk5pbXjRkJKlwSGmX524U4ARGCYwlUnPeapMne qUMP06lKmEMRAnBTUbqjD01v7MFUoRVUCD3dRXd7zsoUfT7JFw== X-Google-Smtp-Source: AA6agR550eiGIKs5MTI/Vk1ECqNmzK4sK2n7E2SJaVsMdWbLfzhS4nVU8ePAtk2qT9om+L/XQ30RPsThCXGD9vpX8rE= X-Received: by 2002:a54:4188:0:b0:345:4cd0:20db with SMTP id 8-20020a544188000000b003454cd020dbmr6612239oiy.231.1662847359901; Sat, 10 Sep 2022 15:02:39 -0700 (PDT) MIME-Version: 1.0 From: Lukasz Olszewski Date: Sun, 11 Sep 2022 00:02:04 +0200 Message-ID: Subject: [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted. To: 57590@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57590 X-Mailman-Approved-At: Sun, 11 Sep 2022 09:20:28 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Adding licensing headers to two new files. --- gnu/packages/libldm.scm | 19 +++++++++++++++++++ gnu/services/libldm.scm | 19 +++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/gnu/packages/libldm.scm b/gnu/packages/libldm.scm index 38fb5e218e..b8f68d433d 100644 --- a/gnu/packages/libldm.scm +++ b/gnu/packages/libldm.scm @@ -1,3 +1,22 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2022 Lukasz Olszewski +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + (define-module (gnu packages libldm) #:use-module (gnu packages) #:use-module (guix packages) diff --git a/gnu/services/libldm.scm b/gnu/services/libldm.scm index 00e19540f0..875ebf69da 100644 --- a/gnu/services/libldm.scm +++ b/gnu/services/libldm.scm @@ -1,3 +1,22 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2022 Lukasz Olszewski +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + (define-module (gnu services libldm) #:use-module (guix records) #:use-module (guix gexp) -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 04:04:06 2022 Received: (at 57590) by debbugs.gnu.org; 17 Oct 2022 08:04:06 +0000 Received: from localhost ([127.0.0.1]:47143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okL6T-0003SG-Sr for submit@debbugs.gnu.org; Mon, 17 Oct 2022 04:04:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okL6P-0003Rh-JE for 57590@debbugs.gnu.org; Mon, 17 Oct 2022 04:04:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okL6G-0006sQ-Iz; Mon, 17 Oct 2022 04:03:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=F/oB9Ufmo0XJqu2a6MFDJr44puiwaZm/7KT2G5INb9c=; b=pHw3t91eNUpfGybptz3P YOpgwwk3p2GlTgfFRV7rjahOpbtc2jDg8BsgLCfAXC340euOED+4KJoeh70aBHJBQvZxhf78bAyvG vXeffaTxINl8cZrmI0nGiUV19cdGVk0Aeuuu9/4BkugNtbjBbNcuUktdeVqoGoDNoiPR4hOAeehCE 79dOXfzV07zwGHhyFOtdwS+eiALCC9mHqZFeQyFlU9BnMt8csGyUDaeRd7gPp1O1eUTDyulhb8UKL bHumRuqtC25Nerr7UGhfPRXeNBH5vKdAOg/e4Sr7wcdt1vo7nY3/ET0F+lByTm/lWxSYJGd6BSizO PwYnwd4TF4dyEw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=46000 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okL6F-00072k-Jz; Mon, 17 Oct 2022 04:03:52 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Lukasz Olszewski Subject: Re: bug#57590: [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted. References: Date: Mon, 17 Oct 2022 10:03:49 +0200 In-Reply-To: (Lukasz Olszewski's message of "Sun, 4 Sep 2022 23:42:55 +0200") Message-ID: <87tu42ho62.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57590 Cc: 57590@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Lukasz, Apologies for the delay! I think the patch series is close to being ready; we=E2=80=99ll need a few changes before we=E2=80=99re done. Lukasz Olszewski skribis: > --- > gnu/packages/libldm.scm | 70 +++++++++++++++++++++++++++++++++++++++++ > gnu/services/libldm.scm | 47 +++++++++++++++++++++++++++ Please make one patch adding the package, and another one adding the service. In each patch, please make sure to add the new file to gnu/local.mk (you can check the Git history for examples.) > +++ b/gnu/packages/libldm.scm > @@ -0,0 +1,70 @@ > +(define-module (gnu packages libldm) We=E2=80=99ll need the license/copyright header as you noted. > + (arguments > + '(#:tests? #f Please add a comment explaining why tests are skipped. That should be a last resort. > + #:parallel-build? #t This is unnecessary. > + #:phases (modify-phases %standard-phases > + (add-before 'configure 'set-env > + (lambda _ > + (setenv "CONFIG_SHELL" > + (which "")) #t)) I don=E2=80=99t think this can work because (which "") returns #f but =E2= =80=98setenv=E2=80=99 expects a string. > + (replace 'bootstrap > + (lambda _ > + (invoke "autoreconf" "-fiv")))))) Is it necessary? The default =E2=80=98bootstrap=E2=80=99 phase does someth= ing similar. > + (license license:gpl3))) This should be =E2=80=98license:gpl3+=E2=80=99 because source file headers = carry the =E2=80=9Cor any later version=E2=80=9D wording. > +(define-record-type* > + libldm-configuration > + make-libldm-configuration > + libldm-configuration? > + (package > + libldm-configuration-package > + (default libldm)) > + (action libldm-configuration-action > + (default '("create" "all")))) Indentation is off here (I noticed that =E2=80=98guix style=E2=80=99 got it= wrong so I=E2=80=99m fixing it now=E2=80=A6). > +(define (libldm-shepherd-service config) > + "Return a for libldm with CONFIG" > + (let* ((libldm (libldm-configuration-package config)) > + (action (libldm-configuration-action config))) > + (list (shepherd-service (documentation > + "Run ldmtool to create Windows dynamic > disc device nodes at startup.") Maybe s/disc/disk/ throughout for consistency? > +(define libldm-service-type > + (service-type (name 'libldm) > + (extensions (list (service-extension > + shepherd-root-service-type > + libldm-shepherd-service))) > + (default-value (libldm-configuration)) > + (description > + "Run ldmtool to create device nodes for Windows > dynamic discs so they can be mounted"))) Please add a period at the end, and write @command{ldmtool}. One last thing: could you add documentation for the service in doc/guix.texi, maybe under =E2=80=9CVirtualization=E2=80=9D or in some new = section? Please include a paragraph giving some context and an example. Could you send updated patches? Thanks in advance! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 19:03:05 2022 Received: (at 57590) by debbugs.gnu.org; 17 Oct 2022 23:03:05 +0000 Received: from localhost ([127.0.0.1]:50402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okZ8S-00082o-As for submit@debbugs.gnu.org; Mon, 17 Oct 2022 19:03:05 -0400 Received: from mail-oa1-f43.google.com ([209.85.160.43]:42659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okO2o-0002hx-PF for 57590@debbugs.gnu.org; Mon, 17 Oct 2022 07:12:31 -0400 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1370acb6588so12814442fac.9 for <57590@debbugs.gnu.org>; Mon, 17 Oct 2022 04:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lukaszolszewski-info.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hqwq3fJb6i7eOQ9945UHe2F0kjvvy5//ZlgfshCTHW8=; b=q+uqxf/F3cNkFtUmZ8lA28SIB9wwShetY7XIHs/aOJ8yD6jSspDNUChEesrmjUQO35 AEvNtx9eH9ouNJv+D0M91ojPSCVHTUZdWMd6+1R0npCx/DW3M9zsNe30W8VTjiuOvbz1 ntn0SlsRPHfEiIA+RuYtTz1cuhe5kMY9xenHQkGN8OxeDTvhI4Nvnduz8oKZBZddlJxv M+L/u3icSZkKJuarPfsFIFCXB+3cvIX/Lg68+yWWLbF6oh/zpwDSm1jmgS7AXsBx7Gc0 ljzNUzydDhFu0LBkNYWBBhkFNrG298dkfq8vpcu53QRPZowB+WgyWSd6bQhB9CnHHTdd 9ukQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hqwq3fJb6i7eOQ9945UHe2F0kjvvy5//ZlgfshCTHW8=; b=lGYX6R1zKk6w2fde1XKk8sIawcsfF7z82enwQgUkDJ7TdP4qqsiQz12qfwYNcXVSRK BU6CuFh0VM9yMAaNBRRgzCytyLTTaeWv09KxJvQCy/meVt178GQl0d6+ySoG+tBhBh1y jwaLrgr/sRUGXK65xyrntiOkNmYHhzfEwDkFIKCkrDDSresXKZ6zUGLAk61ZNdlbuFLS coDhGyPNDQ026JMzEBWTGoLCjF1n1w6mQrcdgU5P9gQLnpgef6iDlPy+wvTPS2uLRLgt AHPvuB64sKZZQxSOb9vVYOy08n+T+NzC6X3UQhtl4OXyNICTxXff9abDJpL3Fc0IA9A2 ZqlA== X-Gm-Message-State: ACrzQf3libWxXog5owO1lo5tHGeHWE97tqM+SBOoOVHwBYvbsccDV0yj 3TmUSg1mhUuvyU1ecrn1q+92hOFJTQbxgN8xFfXKaA== X-Google-Smtp-Source: AMsMyM5L3Hbwy0cvEtA8wcjof7zmLD6M2n/J51f+ospByjGIilOsUsaHeKsBYrBeJ1HxYQFT6XN4xFwpvX6pOMa8s2M= X-Received: by 2002:a05:6870:c084:b0:132:f48a:b488 with SMTP id c4-20020a056870c08400b00132f48ab488mr15154370oad.94.1666005144789; Mon, 17 Oct 2022 04:12:24 -0700 (PDT) MIME-Version: 1.0 References: <87tu42ho62.fsf@gnu.org> In-Reply-To: <87tu42ho62.fsf@gnu.org> From: Lukasz Olszewski Date: Mon, 17 Oct 2022 13:12:13 +0200 Message-ID: Subject: Re: bug#57590: [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted. To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/alternative; boundary="000000000000d97c0005eb390c1c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57590 X-Mailman-Approved-At: Mon, 17 Oct 2022 19:03:02 -0400 Cc: 57590@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000d97c0005eb390c1c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, No problem at all regarding the delay. Unfortunately I've been busier than usual in last few weeks (this is likely to continue for few more weeks). Regarding the comments please see inline below. On Mon, 17 Oct 2022, 10:03 Ludovic Court=C3=A8s, wrote: > Hi Lukasz, > > Apologies for the delay! > > I think the patch series is close to being ready; we=E2=80=99ll need a fe= w > changes before we=E2=80=99re done. > > Lukasz Olszewski skribis: > > > --- > > gnu/packages/libldm.scm | 70 +++++++++++++++++++++++++++++++++++++++++ > > gnu/services/libldm.scm | 47 +++++++++++++++++++++++++++ > > Please make one patch adding the package, and another one adding the > service. > > In each patch, please make sure to add the new file to gnu/local.mk (you > can check the Git history for examples.) > Ok, will do. > > +++ b/gnu/packages/libldm.scm > > @@ -0,0 +1,70 @@ > > +(define-module (gnu packages libldm) > > We=E2=80=99ll need the license/copyright header as you noted. > I've posted a later patch that included those, but it was posted as a patch on top of a patch so perhaps it wasn't well visible. I'll integrate it in the next version. > > + (arguments > > + '(#:tests? #f > > Please add a comment explaining why tests are skipped. That should be a > last resort. > > > + #:parallel-build? #t > > This is unnecessary. > Are parallel builds enabled by default? Or is there a convention not to enable then unless some requirements are met? > > + #:phases (modify-phases %standard-phases > > + (add-before 'configure 'set-env > > + (lambda _ > > + (setenv "CONFIG_SHELL" > > + (which "")) #t)) > > I don=E2=80=99t think this can work because (which "") returns #f but =E2= =80=98setenv=E2=80=99 > expects a string. > I'll have to test it without. If setenv indeed fails now then it should continue to work without it. > > + (replace 'bootstrap > > + (lambda _ > > + (invoke "autoreconf" "-fiv")))))) > > Is it necessary? The default =E2=80=98bootstrap=E2=80=99 phase does some= thing similar. > I've copied this phase from another package. If I remember correctly the configure phase failed without. I'll have to test again to check. > > + (license license:gpl3))) > > This should be =E2=80=98license:gpl3+=E2=80=99 because source file header= s carry the =E2=80=9Cor > any later version=E2=80=9D wording. > Ok, will do. > > +(define-record-type* > > + libldm-configuration > > + make-libldm-configuration > > + libldm-configuration? > > + (package > > + libldm-configuration-package > > + (default libldm)) > > + (action libldm-configuration-action > > + (default '("create" "all")))) > > Indentation is off here (I noticed that =E2=80=98guix style=E2=80=99 got = it wrong so I=E2=80=99m > fixing it now=E2=80=A6). > OK, I'll keep the above. > > +(define (libldm-shepherd-service config) > > + "Return a for libldm with CONFIG" > > + (let* ((libldm (libldm-configuration-package config)) > > + (action (libldm-configuration-action config))) > > + (list (shepherd-service (documentation > > + "Run ldmtool to create Windows dynamic > > disc device nodes at startup.") > > Maybe s/disc/disk/ throughout for consistency? > Ok > > +(define libldm-service-type > > + (service-type (name 'libldm) > > + (extensions (list (service-extension > > + shepherd-root-service-type > > + libldm-shepherd-service))) > > + (default-value (libldm-configuration)) > > + (description > > + "Run ldmtool to create device nodes for Windows > > dynamic discs so they can be mounted"))) > > Please add a period at the end, and write @command{ldmtool}. > > One last thing: could you add documentation for the service in > doc/guix.texi, maybe under =E2=80=9CVirtualization=E2=80=9D or in some ne= w section? > Please include a paragraph giving some context and an example. > OK, will do. > Could you send updated patches? > If I don't manage to do it this week, then on the weekend. > > Thanks in advance! > > Ludo=E2=80=99. > Regards, Lukasz > --000000000000d97c0005eb390c1c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,=C2=A0

No problem=C2=A0at all regarding the delay. Unfortunately I'v= e been busier than usual in last few weeks (this is likely to continue for = few more weeks).=C2=A0

R= egarding the comments please see inline below.=C2=A0

On Mon, 17 O= ct 2022, 10:03 Ludovic Court=C3=A8s, <lu= do@gnu.org> wrote:
Hi Lukas= z,

Apologies for the delay!

I think the patch series is close to being ready; we=E2=80=99ll need a few<= br> changes before we=E2=80=99re done.

Lukasz Olszewski <dev@lukaszolszewski.info> skribis:

> ---
>=C2=A0 gnu/packages/libldm.scm | 70 +++++++++++++++++++++++++++++++++++= ++++++
>=C2=A0 gnu/services/libldm.scm | 47 +++++++++++++++++++++++++++

Please make one patch adding the package, and another one adding the
service.

In each patch, please make sure to add the new file to gnu/local.mk (y= ou
can check the Git history for examples.)

Ok, will do.=C2=A0

=

> +++ b/gnu/packages/libldm.scm
> @@ -0,0 +1,70 @@
> +(define-module (gnu packages libldm)

We=E2=80=99ll need the license/copyright header as you noted.

I've poste= d a later patch that included those, but it was posted as a patch on top of= a patch so perhaps it wasn't well visible. I'll integrate it in th= e next version.=C2=A0


> +=C2=A0 =C2=A0 (arguments
> +=C2=A0 =C2=A0 =C2=A0'(#:tests? #f

Please add a comment explaining why tests are skipped.=C2=A0 That should be= a
last resort.

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0#:parallel-build? #t

This is unnecessary.

Are parallel builds enabled by default? Or is there a c= onvention not to enable then unless some requirements are met?=C2=A0
<= div dir=3D"auto">

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0#:phases (modify-phases %standard-phases > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (add-b= efore 'configure 'set-env
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (lambda _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (setenv "CONFIG_SHELL"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (which "")) #t))

I don=E2=80=99t think this can work because (which "") returns #f= but =E2=80=98setenv=E2=80=99
expects a string.

<= div dir=3D"auto">I'll have to test it without. If setenv indeed fails n= ow then it should continue to work without it.=C2=A0


> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (repla= ce 'bootstrap
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (lambda _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (invoke "autoreconf" "-fiv"))))))

Is it necessary?=C2=A0 The default =E2=80=98bootstrap=E2=80=99 phase does s= omething similar.

<= div dir=3D"auto">I've copied this phase from another package. If I reme= mber correctly the configure phase failed without. I'll have to test ag= ain to check.=C2=A0


> +=C2=A0 =C2=A0 (license license:gpl3)))

This should be =E2=80=98license:gpl3+=E2=80=99 because source file headers = carry the =E2=80=9Cor
any later version=E2=80=9D wording.

Ok, will do.=C2=A0


> +(define-record-type* <libldm-configuration>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0libldm-configuration
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0make-libldm-configuration
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0libldm-configuration?
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(package
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0libldm-configuration-package
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(default libldm))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(action libldm-configuration-action
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(default '("create" "= all"))))

Indentation is off here (I noticed that =E2=80=98guix style=E2=80=99 got it= wrong so I=E2=80=99m
fixing it now=E2=80=A6).

=
OK, I'll keep the above.=C2=A0

=

> +(define (libldm-shepherd-service config)
> +=C2=A0 "Return a <shepherd-service> for libldm with CONFIG= "
> +=C2=A0 (let* ((libldm (libldm-configuration-package config))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(action (libldm-configuration-actio= n config)))
> +=C2=A0 =C2=A0 (list (shepherd-service (documentation
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Run ldmtool to create Windows dyna= mic
> disc device nodes at startup.")

Maybe s/disc/disk/ throughout for consistency?
=

Ok

> +(define libldm-service-type
> +=C2=A0 (service-type (name 'libldm)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (extensions (= list (service-extension
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0shepherd-root-servi= ce-type
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libldm-shepherd-ser= vice)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (default-valu= e (libldm-configuration))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (description<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"R= un ldmtool to create device nodes for Windows
> dynamic discs so they can be mounted")))

Please add a period at the end, and write @command{ldmtool}.

One last thing: could you add documentation for the service in
doc/guix.texi, maybe under =E2=80=9CVirtualization=E2=80=9D or in some new = section?
Please include a paragraph giving some context and an example.

OK, will do.= =C2=A0


Could you send updated patches?

If I don't manage to do it this week, th= en on the weekend.=C2=A0



Thanks in advance!

Ludo=E2=80=99.

Regards,=C2=A0
Lukasz=C2=A0
--000000000000d97c0005eb390c1c-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 11:20:31 2022 Received: (at 57590) by debbugs.gnu.org; 18 Oct 2022 15:20:31 +0000 Received: from localhost ([127.0.0.1]:53797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoOM-0007l4-NI for submit@debbugs.gnu.org; Tue, 18 Oct 2022 11:20:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoOH-0007kZ-Mx for 57590@debbugs.gnu.org; Tue, 18 Oct 2022 11:20:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoOB-0006ma-1P; Tue, 18 Oct 2022 11:20:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ZxV62GULYNdjnVHdD8CkxADLKtmcNcjN+I48WR6hexs=; b=pxrgWSYMPru3xlsW6ray laLS1GiEjez4X6AGf6SNyD6nYuJjBAYLuE75JwYv7C2Tuvq2uZUFfM9C3yE1qAS73uEuYnwy8azup N9tn5TOB1wFEJHrSlCxeWpy/xYx+C4UTemCZjuyKSMTJgFJhJaXaEh0Z7fblDwOeGDADKtOh2ja1j +V1sN3XwM+NCXW6C6JNZ22R9LX+UAMQ5Hbolt0L8s0qrA48iyFaS/V51wEWVbZxjwsgf7xjQllYDS F48Q85KP11o9ux+WKBLHdbFahmYJOW+dYCdCJDZpdsoj3rMp36ejFeZcSBPKTvtvfQoqyU7dwisPt bZvC8HLjYAWUzw==; Received: from [193.50.110.209] (port=50876 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoO9-0006Bu-4u; Tue, 18 Oct 2022 11:20:18 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Lukasz Olszewski Subject: Re: bug#57590: [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted. References: <87tu42ho62.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 27 =?utf-8?Q?Vend=C3=A9miaire?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Piment X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 18 Oct 2022 17:20:15 +0200 In-Reply-To: (Lukasz Olszewski's message of "Mon, 17 Oct 2022 13:12:13 +0200") Message-ID: <878rldma4w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57590 Cc: 57590@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Lukasz Olszewski skribis: >> > +++ b/gnu/packages/libldm.scm >> > @@ -0,0 +1,70 @@ >> > +(define-module (gnu packages libldm) >> >> We=E2=80=99ll need the license/copyright header as you noted. >> > > I've posted a later patch that included those, but it was posted as a pat= ch > on top of a patch so perhaps it wasn't well visible. I'll integrate it in > the next version. I did see it (thanks!). It would be great though if you could send a single =E2=80=9Cv2=E2=80=9D patch that includes everything. >> > + #:parallel-build? #t >> >> This is unnecessary. >> > > Are parallel builds enabled by default? Yes, that=E2=80=99s why. >> > + (replace 'bootstrap >> > + (lambda _ >> > + (invoke "autoreconf" "-fiv")))))) >> >> Is it necessary? The default =E2=80=98bootstrap=E2=80=99 phase does som= ething similar. >> > > I've copied this phase from another package. If I remember correctly the > configure phase failed without. I'll have to test again to check. Yes please. Thanks, Ludo=E2=80=99.