From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 04 04:11:53 2022 Received: (at submit) by debbugs.gnu.org; 4 Sep 2022 08:11:53 +0000 Received: from localhost ([127.0.0.1]:43410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUkjQ-0002vd-WC for submit@debbugs.gnu.org; Sun, 04 Sep 2022 04:11:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:42298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUkjP-0002vW-Np for submit@debbugs.gnu.org; Sun, 04 Sep 2022 04:11:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUkjG-0008Ff-Qy for bug-guix@gnu.org; Sun, 04 Sep 2022 04:11:46 -0400 Received: from icts-p-cavspool-1.kulnet.kuleuven.be ([2a02:2c40:0:c0::25:194]:38274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUkjC-0000pB-6V for bug-guix@gnu.org; Sun, 04 Sep 2022 04:11:40 -0400 Received: from icts-p-cavuit-1.kulnet.kuleuven.be (icts-p-cavuit-1.kulnet.kuleuven.be [IPv6:2a02:2c40:0:c0::25:132]) by icts-p-cavspool-1.kulnet.kuleuven.be (Postfix) with ESMTP id 311B410D1 for ; Sun, 4 Sep 2022 10:11:36 +0200 (CEST) X-KULeuven-Envelope-From: maxime.devos@student.kuleuven.be X-Spam-Status: not spam, SpamAssassin (not cached, score=-51.009, required 5, autolearn=disabled, ALL_TRUSTED -1.00, RCVD_SMTPS -50.00, T_SCC_BODY_TEXT_LINE -0.01, URIBL_BLOCKED 0.00) X-KULeuven-Scanned: Found to be clean X-KULeuven-ID: A4931205EE.AAD51 X-KULeuven-Information: Katholieke Universiteit Leuven Received: from icts-p-ceifnet-smtps-0.kuleuven.be (icts-p-ceifnet-smtps.service.icts.svcd [IPv6:2a02:2c40:0:51:181:242:ac11:13]) by icts-p-cavuit-1.kulnet.kuleuven.be (Postfix) with ESMTP id A4931205EE for ; Sun, 4 Sep 2022 10:11:10 +0200 (CEST) BCmilterd-Mark-Subject: no BCmilterd-Errors: BCmilterd-Report: X-CAV-Cluster: smtps Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] (ptr-bvsjgyig5nh0salm0pi.18120a2.ip6.access.telenet.be [IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by icts-p-ceifnet-smtps-0.kuleuven.be (Postfix) with ESMTPSA id 429BAD4FB53F8 for ; Sun, 4 Sep 2022 10:11:10 +0200 (CEST) Message-ID: <0a60e3de-9f73-28e5-1adb-af13bfc6a870@student.kuleuven.be> Date: Sun, 4 Sep 2022 10:11:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: bug-guix X-Kuleuven: This mail passed the K.U.Leuven mailcluster From: Maxime Devos Subject: disarchive: Test "[prop] Writing is reversible" fails Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a02:2c40:0:c0::25:194; envelope-from=maxime.devos@student.kuleuven.be; helo=icts-p-cavspool-1.kulnet.kuleuven.be X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) X-Debbugs-CC: Timothy Sample Hi, disarchive fails to build (on core-updates, more precisely as part of the antiox jobset on ci.guix.gnu.org). The failing test is: > test-name: [prop] Writing is reversible > location: tests/kinds/octal.scm:128 > source: > + (test-assert > +   "[prop] Writing is reversible" > +   (quickcheck > +     (property > +       ((octal $octal)) > +       (test-when > +         (valid-octal? octal) > +         (begin > +           (equal? > +             octal > +             (decode-octal (encode-octal octal)))))))) > Falsifiable after 25 tests. > Seed: 318171092 > octal = #< value: 0 source: #< value: > "0" trailer: "?">> > actual-value: #f > result: FAIL (This appears to be a different test failure than in ) TBI ... Greetings, Maxime. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 04 04:24:27 2022 Received: (at 57573) by debbugs.gnu.org; 4 Sep 2022 08:24:27 +0000 Received: from localhost ([127.0.0.1]:43430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUkvb-0003Fd-Cd for submit@debbugs.gnu.org; Sun, 04 Sep 2022 04:24:27 -0400 Received: from icts-p-cavuit-3.kulnet.kuleuven.be ([134.58.240.133]:56908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUkvX-0003FS-Nn for 57573@debbugs.gnu.org; Sun, 04 Sep 2022 04:24:25 -0400 X-KULeuven-Envelope-From: maxime.devos@student.kuleuven.be X-Spam-Status: not spam, SpamAssassin (not cached, score=-51.011, required 5, autolearn=disabled, ALL_TRUSTED -1.00, NICE_REPLY_A -0.00, RCVD_SMTPS -50.00, T_SCC_BODY_TEXT_LINE -0.01) X-KULeuven-Scanned: Found to be clean X-KULeuven-ID: 231D4207A3.A957D X-KULeuven-Information: Katholieke Universiteit Leuven Received: from icts-p-ceifnet-smtps-1.kuleuven.be (icts-p-ceifnet-smtps.service.icts.svcd [IPv6:2a02:2c40:0:51:133:242:ac11:14]) by icts-p-cavuit-3.kulnet.kuleuven.be (Postfix) with ESMTP id 231D4207A3; Sun, 4 Sep 2022 10:24:17 +0200 (CEST) BCmilterd-Mark-Subject: no BCmilterd-Errors: BCmilterd-Report: X-CAV-Cluster: smtps Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] (ptr-bvsjgyig5nh0salm0pi.18120a2.ip6.access.telenet.be [IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by icts-p-ceifnet-smtps-1.kuleuven.be (Postfix) with ESMTPSA id 47014D4F834DC; Sun, 4 Sep 2022 10:24:16 +0200 (CEST) Message-ID: <7c6a2480-072e-e88a-08d7-e22c22cfaf6d@student.kuleuven.be> Date: Sun, 4 Sep 2022 10:24:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: bug#57573: disarchive: Test "[prop] Writing is reversible" fails Content-Language: en-US X-Kuleuven: This mail passed the K.U.Leuven mailcluster From: Maxime Devos To: 57573@debbugs.gnu.org References: <0a60e3de-9f73-28e5-1adb-af13bfc6a870@student.kuleuven.be> In-Reply-To: <0a60e3de-9f73-28e5-1adb-af13bfc6a870@student.kuleuven.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57573 Cc: timothy sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Here's a reproducer: (define o (make-unstructured-octal 0 (make-zero-string "0" #\䤄))) (test-equal "Writing is reversible (#57573)"         o (decode-octal (encode-octal octal))) From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 04 05:06:10 2022 Received: (at 57573) by debbugs.gnu.org; 4 Sep 2022 09:06:10 +0000 Received: from localhost ([127.0.0.1]:43473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUlZx-0004KI-LJ for submit@debbugs.gnu.org; Sun, 04 Sep 2022 05:06:09 -0400 Received: from icts-p-cavuit-1.kulnet.kuleuven.be ([134.58.240.132]:42104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUlZs-0004K4-33 for 57573@debbugs.gnu.org; Sun, 04 Sep 2022 05:06:08 -0400 X-KULeuven-Envelope-From: maxime.devos@student.kuleuven.be X-Spam-Status: not spam, SpamAssassin (not cached, score=-51.011, required 5, autolearn=disabled, ALL_TRUSTED -1.00, NICE_REPLY_A -0.00, RCVD_SMTPS -50.00, T_SCC_BODY_TEXT_LINE -0.01) X-KULeuven-Scanned: Found to be clean X-KULeuven-ID: A5ADF20710.A9E8E X-KULeuven-Information: Katholieke Universiteit Leuven Received: from icts-p-ceifnet-smtps-1.kuleuven.be (icts-p-ceifnet-smtps.service.icts.svcd [IPv6:2a02:2c40:0:51:133:242:ac11:14]) by icts-p-cavuit-1.kulnet.kuleuven.be (Postfix) with ESMTP id A5ADF20710; Sun, 4 Sep 2022 11:06:00 +0200 (CEST) BCmilterd-Mark-Subject: no BCmilterd-Errors: BCmilterd-Report: X-CAV-Cluster: smtps Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] (ptr-bvsjgyig5nh0salm0pi.18120a2.ip6.access.telenet.be [IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by icts-p-ceifnet-smtps-1.kuleuven.be (Postfix) with ESMTPSA id 724FFD4F834DC; Sun, 4 Sep 2022 11:06:00 +0200 (CEST) Message-ID: <6a051c77-21f9-c597-7225-727020dccb25@student.kuleuven.be> Date: Sun, 4 Sep 2022 11:05:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: bug#57573: disarchive: Test "[prop] Writing is reversible" fails Content-Language: en-US X-Kuleuven: This mail passed the K.U.Leuven mailcluster From: Maxime Devos To: 57573@debbugs.gnu.org References: <0a60e3de-9f73-28e5-1adb-af13bfc6a870@student.kuleuven.be> <7c6a2480-072e-e88a-08d7-e22c22cfaf6d@student.kuleuven.be> In-Reply-To: <7c6a2480-072e-e88a-08d7-e22c22cfaf6d@student.kuleuven.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57573 Cc: timothy sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 04-09-2022 10:24, Maxime Devos wrote: > Here's a reproducer: > > (define o (make-unstructured-octal 0 (make-zero-string "0" #\䤄))) > (test-equal "Writing is reversible (#57573)" >         o (decode-octal (encode-octal octal))) > That was bogus (octal is undefined), try > > (define o (make-unstructured-octal 0 (make-zero-string "0" "䤄"))) > (unless (valid-octal? o) (error "oops")) > (test-equal "Writing is reversible (#57573)" >         o (decode-octal (encode-octal o))) instead. Error message: > test-name: Writing is reversible (#57573) > location: tests/kinds/octal.scm:130 > source: > + (test-equal > +   "Writing is reversible (#57573)" > +   o > +   (decode-octal (encode-octal o))) > expected-value: #< value: 0 source: > #< value: "0" trailer: "䤄">> > actual-value: #< value: 0 width: 1 padding: #\0 trailer: > "䤄"> > result: FAIL Greetings, Maxime. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 14:21:44 2022 Received: (at 57573) by debbugs.gnu.org; 8 Sep 2022 18:21:44 +0000 Received: from localhost ([127.0.0.1]:60050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWM9n-0002Jo-Vo for submit@debbugs.gnu.org; Thu, 08 Sep 2022 14:21:44 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:41709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWM9m-0002JX-1m for 57573@debbugs.gnu.org; Thu, 08 Sep 2022 14:21:42 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 3E4713200906; Thu, 8 Sep 2022 14:21:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 08 Sep 2022 14:21:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1662661293; x= 1662747693; bh=slIFj35k2P4tvR6BqgJg+gqe2ZtQssaw9eU28xJ6+XA=; b=V Myg2yAPSgXu1SjFAbwj/NpFIvpvBJXUcpwkiGlEGTEslWrcxdsglhE/jWBJpDJ8F Oe2Bl7+kezQnblZlqq6mB8EIb5qOBEoNAqmeAZCQ6SMXdymTBuclds3rgV1BZdgy VARjCNgG+racHidYLLFKclKamdj2PNcEPZAsPY7DMutBGXlCr+iilugbx2Qpz/PB gXASUTGYBQEar+W4j1mTIYj277OSyYe6xHJByykvwZuHGPOReBi6/SL6OKM4Advu 9JGAB3vq8os6paLpRMndKlUOCfHh9ohouKUYK/7FUqO1aeyBS0DLq0ubS/jSniGa R/KXA0ZYyKOq9DuvWDV2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedtfedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufhffjgfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhm ohhthhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtf frrghtthgvrhhnpedtkeevgfekveegffehtdfgveetvddukeefffehvdevteegtdevudei gfeftdetvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsrghmphhlvghtsehnghihrhhordgtohhm X-ME-Proxy: Feedback-ID: i4721425c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Sep 2022 14:21:32 -0400 (EDT) From: Timothy Sample To: Maxime Devos Subject: Re: bug#57573: disarchive: Test "[prop] Writing is reversible" fails References: <0a60e3de-9f73-28e5-1adb-af13bfc6a870@student.kuleuven.be> <7c6a2480-072e-e88a-08d7-e22c22cfaf6d@student.kuleuven.be> <6a051c77-21f9-c597-7225-727020dccb25@student.kuleuven.be> Date: Thu, 08 Sep 2022 12:21:31 -0600 In-Reply-To: <6a051c77-21f9-c597-7225-727020dccb25@student.kuleuven.be> (Maxime Devos's message of "Sun, 4 Sep 2022 11:05:59 +0200") Message-ID: <871qsllob8.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57573 Cc: 57573@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Maxime, Maxime Devos writes: > (define o (make-unstructured-octal 0 (make-zero-string "0" "=E4=A4=84"))) > (unless (valid-octal? o) (error "oops")) > (test-equal "Writing is reversible (#57573)" > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 o (decode-octal (encode-octal o))) Right. That unstructured octal should be invalid. By the definition in the code, it has too much =E2=80=9Cstructure=E2=80=9D. It=E2=80=99s a test= issue, the actual code is fine. I=E2=80=99ll patch the tests and make a point release in the coming days. Thanks for the heads up and the analysis, and sorry for the inconvenience! -- Tim P.S. I=E2=80=99m excited about antioxidant =E2=80=93 good work and happy ha= cking!