GNU bug report logs - #57532
Restructure mailcap-add-mailcap-entry to improve readability

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Felix Dietrich <felix.dietrich <at> sperrhaken.name>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Restructure mailcap-add-mailcap-entry to improve readability
Date: Thu, 01 Sep 2022 23:37:41 +0200

[Message part 1 (text/plain, inline)]

Package: emacs
Tags: patch
Severity: wishlist

Hello,

‘mailcap-add-mailcap-entry’ is written in a way that makes it hard to
follow.  My patch aims to improve its readability.  In order to show
that my modification retains the original functionality, another Patch
adds ERT test cases for this function.  The new version also shows
clearer an issue with the current implementation that causes some
mailcap entries to be forgotten; this is mentioned in a comment.  A
docstring for the function is added as well.

As was suggested by Lars in March on the emacs-devel mailing list [1], I
am submitting my patches now to the bug tracker for them not to be
forgotten (which I should have done then – but life got in the way).  By
now, I have signed the copyright assignment papers, and they have been
processed.


Footnotes:
[1]  Message-ID: <878rt3nync.fsf <at> gnus.org>
     https://lists.gnu.org/archive/html/emacs-devel/2022-03/msg00593.html

-- 
Felix Dietrich

[0001-Add-tests-for-mailcap-add-mailcap-entry.patch (text/x-diff, attachment)]

[0001-Restructure-mailcap-add-mailcap-entry.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.