From unknown Tue Jun 24 22:40:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57513] [PATCH] installer: Fix segfault on double logical partition removal. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 31 Aug 2022 21:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 57513@debbugs.gnu.org Cc: Josselin Poiret X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166198103810730 (code B ref -1); Wed, 31 Aug 2022 21:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Aug 2022 21:23:58 +0000 Received: from localhost ([127.0.0.1]:40670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTVBk-0002my-6Q for submit@debbugs.gnu.org; Wed, 31 Aug 2022 17:23:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:56738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTVBX-0002me-CI for submit@debbugs.gnu.org; Wed, 31 Aug 2022 17:23:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTVBX-0005kc-7V for guix-patches@gnu.org; Wed, 31 Aug 2022 17:23:43 -0400 Received: from jpoiret.xyz ([206.189.101.64]:45314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTVBV-0005kZ-BK for guix-patches@gnu.org; Wed, 31 Aug 2022 17:23:42 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id CD43718530A; Wed, 31 Aug 2022 21:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1661981016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1aCCzBGoANm9qVdDmA1iynVd7cPFl4EtihbMGkJ5RFA=; b=Yq9tg3endjWWEfbQm+/OPGdE2aKYSUQAu78cO2eOQDsZbh5h+zqrGLEORLHMUaxXWDJCoB I6++zJIUrxqaBFsQDjDZmZ38ygfI+bCUeAsS8LQef4rIonVGCOimg3QSfbC2Jk2NB9xgg7 FPovUW1ZfLbt/RCeUpkDP3Q675eDOI2g6lxKpnWd4s3hfojLUFE736NLK09V0PoSR9cgRN T1GUPbyxwUt3x9ch3Z7y7ZuMVnrSulA9BV++QzzdF2g2mdGqp6hIs6TaMxpRgkj2j06git irKwVuNrAqkmQBNZT0yP5FXz+mt43AjLwNZ1HAr+NI2FJKqm2M8Vzf+mZVIRnQ== From: Josselin Poiret Date: Wed, 31 Aug 2022 23:22:55 +0200 Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: 19 X-Spam_score: 1.9 X-Spam_bar: + X-Spam_report: (1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.001, FROM_SUSPICIOUS_NTLD_FP=1.999, PDS_OTHER_BAD_TLD=1.999, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 4.9 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/installer/parted.scm (auto-partition!): Avoid removing logical partitions twice. --- gnu/installer/parted.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index 641a1f45e8..84fdbe24fb 100644 --- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -2,6 +2,7 @@ ;;; Copyright =?UTF-8?Q?=C2=A9?= 2018 [...] Content analysis details: (4.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=dev%40jpoiret.xyz;ip=209.51.188.17;r=debbugs.gnu.org] 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) * gnu/installer/parted.scm (auto-partition!): Avoid removing logical partitions twice. --- gnu/installer/parted.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index 641a1f45e8..84fdbe24fb 100644 --- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2018, 2019 Mathieu Othacehe ;;; Copyright © 2019, 2020, 2022 Ludovic Courtès ;;; Copyright © 2020 Tobias Geerinckx-Rice +;;; Copyright © 2022 Josselin Poiret ;;; ;;; This file is part of GNU Guix. ;;; @@ -983,6 +984,11 @@ (define* (auto-partition! disk (for-each (lambda (partition) (and (data-partition? partition) + ;; Do not remove logical partitions ourselves, since + ;; disk-remove-partition* will remove all the logical partitions + ;; residing on an extended partition, which would lead to a + ;; double-remove and ensuing SEGFAULT. + (not (logical-partition? partition)) (disk-remove-partition* disk partition))) non-boot-partitions) base-commit: 47c11772dfe840a536ed7ec438fe832878f51054 -- 2.37.2 From unknown Tue Jun 24 22:40:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Josselin Poiret Subject: bug#57513: closed (Re: bug#57513: [PATCH] installer: Fix segfault on double logical partition removal.) Message-ID: References: <87y1v32g7g.fsf@gnu.org> X-Gnu-PR-Message: they-closed 57513 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 57513@debbugs.gnu.org Date: Thu, 01 Sep 2022 16:50:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1662051002-26935-1" This is a multi-part message in MIME format... ------------=_1662051002-26935-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #57513: [PATCH] installer: Fix segfault on double logical partition removal. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 57513@debbugs.gnu.org. --=20 57513: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D57513 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1662051002-26935-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 57513-done) by debbugs.gnu.org; 1 Sep 2022 16:49:03 +0000 Received: from localhost ([127.0.0.1]:44029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTnNH-0006z6-0b for submit@debbugs.gnu.org; Thu, 01 Sep 2022 12:49:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTnNG-0006ye-4o for 57513-done@debbugs.gnu.org; Thu, 01 Sep 2022 12:49:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36488) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTnNA-00058Y-NW; Thu, 01 Sep 2022 12:48:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=UZ83+gW+XbOCOgIb/H461ofCOltubg5pwMdOngHbsxU=; b=OmRalB7j2HRyZ5Wfti4A Ua9ORZm7SzrK5iyE456y1APz5RMmksYZDoEyTXopIUveySW45Af2n0Rw5ATRImAPwJAa4Mx/BERtK OLu5VaJUDXx2ZAtxzjLDHdVuFCB23th7akLamm77lC+rdxPe4QfTKGPnKapqNtCvFnr4XjQS3jNpR VXu7rN8Fnz5uF3bvGjlcmQKFozFONZk9WHEw8b8UZka6u3v9GIdpZIB2uCzDJJc962YEOBU4BXEN5 Zyu/Iio8KlybmMN2bDohOIEWauwFLLY7VLQTCbMgItpAVL9tUSnxM/d1litNB0lO/GP7xYmOIKY8S r5ZcMt3N/OoNFA==; Received: from pop.92-184-97-57.mobile.abo.orange.fr ([92.184.97.57]:37502 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTnN9-0000g5-9b; Thu, 01 Sep 2022 12:48:56 -0400 From: Mathieu Othacehe To: Josselin Poiret Subject: Re: bug#57513: [PATCH] installer: Fix segfault on double logical partition removal. References: Date: Thu, 01 Sep 2022 18:48:51 +0200 In-Reply-To: (Josselin Poiret's message of "Wed, 31 Aug 2022 23:22:55 +0200") Message-ID: <87y1v32g7g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57513-done Cc: 57513-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > * gnu/installer/parted.scm (auto-partition!): Avoid removing logical > partitions twice. I was able to reproduce the issue by creating an extended partition containing a single logical partition using the manual partitioning tool then, the automatic one right after. It resulted in a segfault, which is fixed by your patch, that's a very nice catch! Pushed as 4989f6acff3b3fcfbd9dde3e3c2767bd2cd6d49e. Thanks, Mathieu ------------=_1662051002-26935-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 31 Aug 2022 21:23:58 +0000 Received: from localhost ([127.0.0.1]:40670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTVBk-0002my-6Q for submit@debbugs.gnu.org; Wed, 31 Aug 2022 17:23:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:56738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTVBX-0002me-CI for submit@debbugs.gnu.org; Wed, 31 Aug 2022 17:23:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTVBX-0005kc-7V for guix-patches@gnu.org; Wed, 31 Aug 2022 17:23:43 -0400 Received: from jpoiret.xyz ([206.189.101.64]:45314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTVBV-0005kZ-BK for guix-patches@gnu.org; Wed, 31 Aug 2022 17:23:42 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id CD43718530A; Wed, 31 Aug 2022 21:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1661981016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1aCCzBGoANm9qVdDmA1iynVd7cPFl4EtihbMGkJ5RFA=; b=Yq9tg3endjWWEfbQm+/OPGdE2aKYSUQAu78cO2eOQDsZbh5h+zqrGLEORLHMUaxXWDJCoB I6++zJIUrxqaBFsQDjDZmZ38ygfI+bCUeAsS8LQef4rIonVGCOimg3QSfbC2Jk2NB9xgg7 FPovUW1ZfLbt/RCeUpkDP3Q675eDOI2g6lxKpnWd4s3hfojLUFE736NLK09V0PoSR9cgRN T1GUPbyxwUt3x9ch3Z7y7ZuMVnrSulA9BV++QzzdF2g2mdGqp6hIs6TaMxpRgkj2j06git irKwVuNrAqkmQBNZT0yP5FXz+mt43AjLwNZ1HAr+NI2FJKqm2M8Vzf+mZVIRnQ== From: Josselin Poiret To: guix-patches@gnu.org Subject: [PATCH] installer: Fix segfault on double logical partition removal. Date: Wed, 31 Aug 2022 23:22:55 +0200 Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: 19 X-Spam_score: 1.9 X-Spam_bar: + X-Spam_report: (1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.001, FROM_SUSPICIOUS_NTLD_FP=1.999, PDS_OTHER_BAD_TLD=1.999, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 4.9 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/installer/parted.scm (auto-partition!): Avoid removing logical partitions twice. --- gnu/installer/parted.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index 641a1f45e8..84fdbe24fb 100644 --- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2018 [...] Content analysis details: (4.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=dev%40jpoiret.xyz;ip=209.51.188.17;r=debbugs.gnu.org] 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD X-Debbugs-Envelope-To: submit Cc: Josselin Poiret X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) * gnu/installer/parted.scm (auto-partition!): Avoid removing logical partitions twice. --- gnu/installer/parted.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index 641a1f45e8..84fdbe24fb 100644 --- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2018, 2019 Mathieu Othacehe ;;; Copyright © 2019, 2020, 2022 Ludovic Courtès ;;; Copyright © 2020 Tobias Geerinckx-Rice +;;; Copyright © 2022 Josselin Poiret ;;; ;;; This file is part of GNU Guix. ;;; @@ -983,6 +984,11 @@ (define* (auto-partition! disk (for-each (lambda (partition) (and (data-partition? partition) + ;; Do not remove logical partitions ourselves, since + ;; disk-remove-partition* will remove all the logical partitions + ;; residing on an extended partition, which would lead to a + ;; double-remove and ensuing SEGFAULT. + (not (logical-partition? partition)) (disk-remove-partition* disk partition))) non-boot-partitions) base-commit: 47c11772dfe840a536ed7ec438fe832878f51054 -- 2.37.2 ------------=_1662051002-26935-1-- From unknown Tue Jun 24 22:40:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57513] [PATCH] installer: Fix segfault on double logical partition removal. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Sep 2022 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 57513-done@debbugs.gnu.org Received: via spool by 57513-done@debbugs.gnu.org id=D57513.166205977425366 (code D ref 57513); Thu, 01 Sep 2022 19:17:02 +0000 Received: (at 57513-done) by debbugs.gnu.org; 1 Sep 2022 19:16:14 +0000 Received: from localhost ([127.0.0.1]:44188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTpff-0006b0-2I for submit@debbugs.gnu.org; Thu, 01 Sep 2022 15:16:14 -0400 Received: from jpoiret.xyz ([206.189.101.64]:47052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTpfa-0006aq-VV for 57513-done@debbugs.gnu.org; Thu, 01 Sep 2022 15:16:08 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id EF9F5184F2D; Thu, 1 Sep 2022 19:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1662059763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r3D5CYHaBSts2G+2kNfeP3nhAb+jWc3PCbDdn0KWGYI=; b=P3LAIJFuA63j+Yc0FmWMDSKFs4/izgTQ/t10YrEoLPv7bUCR1GRkJjvbEZRi0ADgd1Q1UW ZG0i+Hci7O73iYssrYT/+22odfQWSK98qd3uG3UoteyK8RkUvRH4MG2sex692+o6YhsS0z zwTeMlaoUPFMpKioNj+zmlA4DIR8aQVf98nsk3tdaZtfD6ZhjhIizNTg01AZ8P+wUR6TnQ IpqAl8auWo7M2/TTtQlaT1oIDed4/wPhbEQRt6HthLfC4e2qh4eHVnXqg38UX0DJRyZ9Er UHZ0Nj5ba2jtE0dJOfgC1ZANX5VVleLrHNMbzEhc5R+GIzBza83DemVLZjsIDw== From: Josselin Poiret In-Reply-To: <87y1v32g7g.fsf@gnu.org> References: <87y1v32g7g.fsf@gnu.org> Date: Thu, 01 Sep 2022 21:16:02 +0200 Message-ID: <87tu5qzz0t.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hey Mathieu, Mathieu Othacehe writes: > I was able to reproduce the issue by creating an extended partition > containing a single logical partition using the manual partitioning tool > then, the automatic one right after. > > It resulted [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hey Mathieu, Mathieu Othacehe writes: > I was able to reproduce the issue by creating an extended partition > containing a single logical partition using the manual partitioning tool > then, the automatic one right after. > > It resulted [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.0 T_SPF_TEMPERROR SPF: test of record failed (temperror) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hey Mathieu, Mathieu Othacehe writes: > I was able to reproduce the issue by creating an extended partition > containing a single logical partition using the manual partitioning tool > then, the automatic one right after. > > It resulted in a segfault, which is fixed by your patch, that's a very > nice catch! I have to thank KE0VVT on IRC, who provided a core dump file! This was surprisingly easier to debug than I thought, for those interested, I built the installer using the same Guix commit, and loaded the guile core dump file in gdb. I then used `guix build parted --with-debug-info=parted` and loaded the resulting libparted.so library using `info sections` to find out where the .text of libparted.so was loaded in the core file, and `add-symbol-file /gnu/store/path/to/libparted.so 0xaddress` to load the symbols. That way, I could see that ped_disk_remove_partition was invoked for a disk that had an empty partition list, hence leading me to this double remove problem! > Pushed as 4989f6acff3b3fcfbd9dde3e3c2767bd2cd6d49e. > > Thanks, > > Mathieu Thank you for reviewing this so fast! Best, -- Josselin Poiret From unknown Tue Jun 24 22:40:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57513] [PATCH] installer: Fix segfault on double logical partition removal. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 02 Sep 2022 07:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 57513-done@debbugs.gnu.org Received: via spool by 57513-done@debbugs.gnu.org id=D57513.16621050632292 (code D ref 57513); Fri, 02 Sep 2022 07:52:02 +0000 Received: (at 57513-done) by debbugs.gnu.org; 2 Sep 2022 07:51:03 +0000 Received: from localhost ([127.0.0.1]:44757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU1SA-0000au-Ub for submit@debbugs.gnu.org; Fri, 02 Sep 2022 03:51:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU1S7-0000aN-7i for 57513-done@debbugs.gnu.org; Fri, 02 Sep 2022 03:51:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU1S1-0001rS-VT; Fri, 02 Sep 2022 03:50:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fZxPReGtFuzSaHI3WPxzc6UHyKdTCO8EavlfHA/jh9Q=; b=Oz2S2pZXCwirxA2Sxazt eUclGki+E7FrniItcZf6C+0Ygc6R6yYnKu4zLYI1QHI/H6kvejEs+tiJ3DOGM6eUpB4FetaoRuEtn OwrOvSUNL/3MkkL0PbyoFpYsOrAqdX2ah+Ix32Hr7H3EzUU803XFAyRwCCuO18az78OthOI31lpL+ hEovPVKhy6/Plsd6u6mtZ+9J8uX2b/o77Whf7ugfqVGFqDGCIAlkMMkCAMCdg5Zo2Gk4YoUrmgI1n odZYreJ2/st4bM1vXWBjM9rMEnLoMdsGA/K7q/Kc+2hlnba++tT+OPG6R6iW2r7kvNNkXmJNN+hQV c9Zvx8trgPtzaQ==; Received: from pop.92-184-117-132.mobile.abo.orange.fr ([92.184.117.132]:39248 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU1S1-0008Hd-EF; Fri, 02 Sep 2022 03:50:53 -0400 From: Mathieu Othacehe References: <87y1v32g7g.fsf@gnu.org> <87tu5qzz0t.fsf@jpoiret.xyz> Date: Fri, 02 Sep 2022 09:50:51 +0200 In-Reply-To: <87tu5qzz0t.fsf@jpoiret.xyz> (Josselin Poiret's message of "Thu, 01 Sep 2022 21:16:02 +0200") Message-ID: <871qsub4f8.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > I have to thank KE0VVT on IRC, who provided a core dump file! This was > surprisingly easier to debug than I thought, for those interested, I > built the installer using the same Guix commit, and loaded the guile > core dump file in gdb. I then used `guix build parted > --with-debug-info=parted` and loaded the resulting libparted.so library > using `info sections` to find out where the .text of libparted.so was > loaded in the core file, and `add-symbol-file > /gnu/store/path/to/libparted.so 0xaddress` to load the symbols. That > way, I could see that ped_disk_remove_partition was invoked for a disk > that had an empty partition list, hence leading me to this double remove > problem! I remember resorting to way less convenient solutions in the past to achieve something similar. Feel free to add this little memo to the documentation or as a code comment if you have the opportunity :). Thanks again, Mathieu