GNU bug report logs - #57502
29.0.50; Issue with `or' clause of buffer-match-p

Previous Next

Full log

View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57502 <at> debbugs.gnu.org, arstoffel <at> gmail.com
Subject: bug#57502: 29.0.50; Issue with `or' clause of buffer-match-p
Date: Sat, 03 Sep 2022 11:19:55 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 57502 <at> debbugs.gnu.org
>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Date: Sat, 03 Sep 2022 11:04:20 +0000
>> 
>> Are there any objections against applying this change?  From what I see
>> pcase is used elsewhere in seq, so it should be possible to recognise
>> and expand the macro, right?
>
> I think we should avoid using pcase in subr.el, since subr.el is
> loaded by loadup.el before pcase.  But I see that this ship has sailed
> already, sigh.

There is no insistence from my end to use pcase, especially because at
first I assumed it ought not to be used in subr.el.  But from what I see
there have been instances of the macro (in `called-interactively-p') for
almost ten years now.  So unless there is a plan to revert this trend,
I'd use pcase to avoid simple issues like the one that caused this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.