GNU bug report logs - #57499
Documentation bug in the docstring of set-face-attribute?

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 57499-done <at> debbugs.gnu.org
Subject: bug#57499: Documentation bug in the docstring of set-face-attribute?
Date: Thu, 01 Sep 2022 14:33:12 +0300

> Date: Thu, 01 Sep 2022 09:02:50 +0000
> From: Gregory Heytings <gregory <at> heytings.org>
> cc: 57499-done <at> debbugs.gnu.org
> 
> >> So this call is already included in the previous one.  Why should we 
> >> tell users to add such a redundant call in their code?
> >
> > The new text doesn't say the call with FRAME = t should be an additional 
> > call.
> >
> 
> It doesn't say so explicitly indeed, but without reading the code of 
> set-face-attribute everyone understands that it should be an additional 
> call.

I disagree with your certainty that everyone will understand that.
The text deliberately doesn't say that.

> Would the patch below be okay?  This would be another way to clarify the 
> matter.

No.  I don't want to lose this compatibility feature because lots of
people still use nil.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.