From unknown Sun Aug 17 01:00:31 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5747: 24.0.50; Unstable C-mode indentation Resent-From: Ari Roponen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Mar 2010 13:31:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: report 5747 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 5747@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12691782075964 (code B ref -1); Sun, 21 Mar 2010 13:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Mar 2010 13:30:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtLEE-0001Y8-4h for submit@debbugs.gnu.org; Sun, 21 Mar 2010 09:30:06 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtKaI-0001G7-G4 for submit@debbugs.gnu.org; Sun, 21 Mar 2010 08:48:50 -0400 Received: from lists.gnu.org ([199.232.76.165]:53103) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NtKaC-0006VV-Se for submit@debbugs.gnu.org; Sun, 21 Mar 2010 08:48:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NtKaC-00040a-Ak for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2010 08:48:44 -0400 Received: from [140.186.70.92] (port=60843 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NtKaA-000404-H1 for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2010 08:48:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NtKa9-0001SG-0b for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2010 08:48:42 -0400 Received: from mail-ew0-f216.google.com ([209.85.219.216]:59157) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtKa8-0001S0-SV for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2010 08:48:40 -0400 Received: by ewy8 with SMTP id 8so342655ewy.8 for ; Sun, 21 Mar 2010 05:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:mime-version:content-type; bh=s6mBN52t63gL/thUtESjzfcNSLsH76D0c59+uPkz19c=; b=WEgMAzbfbfECx7TAlFoUd/4/iauAsSLjcA4JPaYwSgQKmdXnUlJCPZf3ATtN3KRGuq tTVpgTEZqYYfAQxH54Z5CHkYNvgYExrzk/KsR7y9ySqRmZuVlS26SHeG9cQfIBkwKhnz PXcF6YZtQdocq0CQVSpWh4a6ICfYDOqTltO7s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; b=A3fzyu1aFzArXExJR3aEtgIQTgRKw10XBZOMgxN9Cq9giJVl5OEtR+HNIc9BInIvqT 4vcPQj9w2unb/+ijzuHSAoPkrpGrsDaW4FGPyc+9Ip7aCAtfwYsT+ypj+zmf0QEuu5vW CZrgjm5Mhh7eIz4IWrU8Q69eSF+RGQ+NAvQyE= Received: by 10.213.52.19 with SMTP id f19mr2218673ebg.87.1269175719040; Sun, 21 Mar 2010 05:48:39 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fecbdf00-152.dhcp.inet.fi [80.223.203.152]) by mx.google.com with ESMTPS id 15sm2136048ewy.12.2010.03.21.05.48.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 21 Mar 2010 05:48:38 -0700 (PDT) From: Ari Roponen Date: Sun, 21 Mar 2010 14:48:34 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.1 (----) X-Mailman-Approved-At: Sun, 21 Mar 2010 09:30:05 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Hi, the indentation of C-mode is not stable. Here is the recipe to reproduce the problem: 1. Eval this form in "emacs -Q": (progn (switch-to-buffer "tmp.c") (erase-buffer) (c-mode) (insert "int fun (void)\n{\n int a = foo ();\n}") (c-indent-line-or-region) (backward-sexp) (c-indent-line-or-region)) 2. Now every time you press TAB-key the indentation of the bracket alternates between two positions. By bisecting the source (using the GIT-repo) I found that the problem comes from: acm@muc.de-20091203160210-5u4g9gppsv3zts3e committer: Alan Mackenzie timestamp: Thu 2009-12-03 16:02:10 +0000 message: Enhance `c-parse-state' to run efficiently in "brace desserts". After reverting that the problem goes away. In GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.19.7) of 2010-03-18 on arirop Windowing system distributor `Fedora Project', version 11.0.10799901 -- Ari Roponen From unknown Sun Aug 17 01:00:31 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5747: 24.0.50; Unstable C-mode indentation Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Mar 2010 11:29:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5747 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ari Roponen Cc: Chong Yidong , Michael Welsh Duggan , Jan =?UTF-8?Q?Dj=C3=A4rv?= , 5747@debbugs.gnu.org, Paul Pogonyshev Received: via spool by 5747-submit@debbugs.gnu.org id=B5747.12692573175193 (code B ref 5747); Mon, 22 Mar 2010 11:29:02 +0000 Received: (at 5747) by debbugs.gnu.org; 22 Mar 2010 11:28:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtfoC-0001Li-QU for submit@debbugs.gnu.org; Mon, 22 Mar 2010 07:28:37 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtfoB-0001Ld-Ci for 5747@debbugs.gnu.org; Mon, 22 Mar 2010 07:28:36 -0400 Received: (qmail 75343 invoked by uid 3782); 22 Mar 2010 11:28:29 -0000 Received: from acm.muc.de (pD9E2385A.dip.t-dialin.net [217.226.56.90]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Mon, 22 Mar 2010 12:28:26 +0100 Received: (qmail 1861 invoked by uid 1000); 22 Mar 2010 11:36:31 -0000 Date: Mon, 22 Mar 2010 11:36:31 +0000 Message-ID: <20100322113631.GA1741@muc.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Hi, Ari and everybody else! On Sun, Mar 21, 2010 at 02:48:34PM +0200, Ari Roponen wrote: > Hi, the indentation of C-mode is not stable. Here is the recipe > to reproduce the problem: > 1. Eval this form in "emacs -Q": > (progn > (switch-to-buffer "tmp.c") > (erase-buffer) > (c-mode) > (insert "int fun (void)\n{\n int a = foo ();\n}") > (c-indent-line-or-region) > (backward-sexp) > (c-indent-line-or-region)) > 2. Now every time you press TAB-key the indentation of the > bracket alternates between two positions. > By bisecting the source (using the GIT-repo) I found that the > problem comes from: > acm@muc.de-20091203160210-5u4g9gppsv3zts3e > committer: Alan Mackenzie > timestamp: Thu 2009-12-03 16:02:10 +0000 > message: > Enhance `c-parse-state' to run efficiently in "brace desserts". > After reverting that the problem goes away. That is one absolutely tremendous bug report! Thank you very much indeed for it! With all the information you've given me, I was able to track down an off-by-one error very quickly. Would you please (all) try the following patch, which I'm hopeful will fix all the recent instabilities in CC Modes indentation. *** cc-engine.el~ 2010-03-22 11:15:40.248931952 +0000 --- cc-engine.el 2010-03-22 11:24:04.981200984 +0000 *************** *** 2624,2630 **** (< (point-max) c-state-old-cpp-end))) (point-max) (min (point-max) c-state-old-cpp-beg))) ! (while (and c-state-cache (> (c-state-cache-top-lparen) upper-lim)) (setq c-state-cache (cdr c-state-cache))) ;; If `upper-lim' is inside the last recorded brace pair, remove its ;; RBrace and indicate we'll need to search backwards for a previous --- 2624,2630 ---- (< (point-max) c-state-old-cpp-end))) (point-max) (min (point-max) c-state-old-cpp-beg))) ! (while (and c-state-cache (>= (c-state-cache-top-lparen) upper-lim)) (setq c-state-cache (cdr c-state-cache))) ;; If `upper-lim' is inside the last recorded brace pair, remove its ;; RBrace and indicate we'll need to search backwards for a previous > -- > Ari Roponen -- Alan Mackenzie (Nuremberg, Germany). From unknown Sun Aug 17 01:00:31 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5747: 24.0.50; Unstable C-mode indentation Resent-From: Ari Roponen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Mar 2010 12:04:01 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5747 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: Michael Welsh Duggan , 5747@debbugs.gnu.org, Chong Yidong , Pogonyshev , Paul, Jan =?UTF-8?Q?Dj=C3=A4rv?= Received: via spool by 5747-submit@debbugs.gnu.org id=B5747.12692594278163 (code B ref 5747); Mon, 22 Mar 2010 12:04:01 +0000 Received: (at 5747) by debbugs.gnu.org; 22 Mar 2010 12:03:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtgMF-00027c-IR for submit@debbugs.gnu.org; Mon, 22 Mar 2010 08:03:47 -0400 Received: from mail-ew0-f221.google.com ([209.85.219.221]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtgMD-00027W-9m for 5747@debbugs.gnu.org; Mon, 22 Mar 2010 08:03:45 -0400 Received: by ewy21 with SMTP id 21so1001492ewy.5 for <5747@debbugs.gnu.org>; Mon, 22 Mar 2010 05:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=amhcnm4Vr4HsLph9kra/lEDWvfzhYKpMEewmmL+In/o=; b=nC+MYVC3v5OfCcxAPxM6IjQppXJQfswi1O54AoVdTUOjU09c6FrHHSvJxJ5EgHkAWX FDze1P4EvNGSAy9Xf2P2HV82GG9bMUgL5Isbrvc0dlMe9eU1gpZFH4651zxHYZD/MG5I gAA5HbfWN4QXSELEvspfRAsDIqWIDo0i47ocQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=lQJTNCgKvR3kIT3erOmEZNwjOa4CfsEdHo+fcVb6xgQZnhm9egBHLtRa3Pqz1R+ikH I83C62Q48ZwV6voy1/uILuj5adFU+ZtVxbigzkJEf/UbyRZErJvc0YK8SeHIp1LJUZbs UzL37H8lI/Q657XAtvJarXXD27yTDXlAyq3qU= Received: by 10.213.79.77 with SMTP id o13mr2475698ebk.4.1269259418438; Mon, 22 Mar 2010 05:03:38 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fecbdf00-152.dhcp.inet.fi [80.223.203.152]) by mx.google.com with ESMTPS id 14sm1907498ewy.14.2010.03.22.05.03.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 22 Mar 2010 05:03:37 -0700 (PDT) From: Ari Roponen References: <20100322113631.GA1741@muc.de> Date: Mon, 22 Mar 2010 14:03:39 +0200 In-Reply-To: <20100322113631.GA1741@muc.de> (Alan Mackenzie's message of "Mon, 22 Mar 2010 11:36:31 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.8 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Hi, > Would you please (all) try the following patch, which I'm hopeful will > fix all the recent instabilities in CC Modes indentation. > this patch fixes the problem I reported. Thank you. > > *** cc-engine.el~ 2010-03-22 11:15:40.248931952 +0000 > --- cc-engine.el 2010-03-22 11:24:04.981200984 +0000 > *************** > *** 2624,2630 **** > (< (point-max) c-state-old-cpp-end))) > (point-max) > (min (point-max) c-state-old-cpp-beg))) > ! (while (and c-state-cache (> (c-state-cache-top-lparen) upper-lim)) > (setq c-state-cache (cdr c-state-cache))) > ;; If `upper-lim' is inside the last recorded brace pair, remove its > ;; RBrace and indicate we'll need to search backwards for a previous > --- 2624,2630 ---- > (< (point-max) c-state-old-cpp-end))) > (point-max) > (min (point-max) c-state-old-cpp-beg))) > ! (while (and c-state-cache (>= (c-state-cache-top-lparen) upper-lim)) > (setq c-state-cache (cdr c-state-cache))) > ;; If `upper-lim' is inside the last recorded brace pair, remove its > ;; RBrace and indicate we'll need to search backwards for a previous > -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 22 17:31:22 2010 Received: (at control) by debbugs.gnu.org; 22 Mar 2010 21:31:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtpDW-0005po-HL for submit@debbugs.gnu.org; Mon, 22 Mar 2010 17:31:22 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtpDV-0005ph-BY for control@debbugs.gnu.org; Mon, 22 Mar 2010 17:31:21 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NtpDR-00063x-3w; Mon, 22 Mar 2010 17:31:17 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19367.57765.29581.658450@fencepost.gnu.org> Date: Mon, 22 Mar 2010 17:31:17 -0400 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: cyan X-Ran: yA{]J+I3o~bY,FlW'ev}=rVN$_>bB8:vgD!!L$xJ!bDgNuo*I7pe*@<~tZ)!DAclwV;('H X-Debbugs-No-Ack: yes X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) merge 5741 5747 merge 5748 5749 severity 5739 minor severity 5740 minor severity 5744 minor reassign 5750 emacs,ns tags 5725 patch severity 5725 wishlist tags 5722 moreinfo From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 15:13:57 2010 Received: (at control) by debbugs.gnu.org; 28 Mar 2010 19:13:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nvxvo-0006T5-RC for submit@debbugs.gnu.org; Sun, 28 Mar 2010 15:13:57 -0400 Received: from pantheon-po35.its.yale.edu ([130.132.50.83]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nvxvo-0006T0-0U for control@debbugs.gnu.org; Sun, 28 Mar 2010 15:13:56 -0400 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po35.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o2SJDpHe011976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 28 Mar 2010 15:13:51 -0400 Received: by furry (Postfix, from userid 1000) id 6EC0BC05D; Sun, 28 Mar 2010 15:13:51 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 5747 Date: Sun, 28 Mar 2010 15:13:51 -0400 Message-ID: <87wrwwi7io.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) close 5747 thanks