From unknown Sat Aug 09 13:07:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#57433 <57433@debbugs.gnu.org> To: bug#57433 <57433@debbugs.gnu.org> Subject: Status: Emacs no longer moves point into visible port of the buffer Reply-To: bug#57433 <57433@debbugs.gnu.org> Date: Sat, 09 Aug 2025 20:07:17 +0000 retitle 57433 Emacs no longer moves point into visible port of the buffer reassign 57433 emacs submitter 57433 Paul Pogonyshev severity 57433 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 26 12:32:33 2022 Received: (at submit) by debbugs.gnu.org; 26 Aug 2022 16:32:33 +0000 Received: from localhost ([127.0.0.1]:54401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRcG0-0002cl-LH for submit@debbugs.gnu.org; Fri, 26 Aug 2022 12:32:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:46512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRcFz-0002ce-58 for submit@debbugs.gnu.org; Fri, 26 Aug 2022 12:32:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRcFy-0000cJ-Lh for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 12:32:31 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:33284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRcFw-0001xf-OE for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 12:32:30 -0400 Received: by mail-ej1-x62b.google.com with SMTP id cu2so4209672ejb.0 for ; Fri, 26 Aug 2022 09:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc; bh=c3wg8CVfLHowgo5gUib9zxvog6nwl9RvJoXJxb9Ulyk=; b=lXkAHYSbA17XuMgwLO3Y2rMMKlaJ2EOfG9xFMA3iBJa2/ktR9FcxolBXwtrxLnukNs 98Mxx0QokBk2DCh9I8bLZZGJGiuaERr0eg397s1JHCClUvMK5WOH2pNHrfrCq92kr3cd 5j0UpAIWzR7cRNlxpGyqr+7AkPOBBNRWfp+R3n4Wd2ZyLi7v4dn2oytvVSRtauZFR5Vt tFudb9P97BopzCIK1PNFk0IwDLfysJQVAYGF/Js0MjiD+HdwsN2Ovtg3D+2Ndrc7mBnt pTWugLk25MvtSlR/RFREly3t61t3YFygOMi72dEw617h9lz/Hk1RagYdf1XOVtES63bT cdkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc; bh=c3wg8CVfLHowgo5gUib9zxvog6nwl9RvJoXJxb9Ulyk=; b=BEnY5ZsEmPgTj5LPthsrSxmEOZFxDz01s26cQSKHRfC8SWTko9qBdwsv4lD7Rxtu6s mb/7RxoIJpQCNEID4nDnBrxmJTlj+8S91WtKELGPb/6ORwohhPmfLGHroo+tax7n87or O5siwn0RBP8byYAp0QnbwAoxWislv47Ien5frtPnGD5TDP8Zc/3Gb7YqlpkgnJsKW7Sn gVGm8cqVPO8lkIgE7vt+xiX+l/NBlxCN6APnjcA5yrbLa2A0Ahx3yrvYVIlS7p2PNxkl l8UJwAmDtWoSBNCXZUzzPCXj9piVvjTh0+q+r1GMlAYinnkqy32Osx1KlNr6jdcG+Tw2 KqOQ== X-Gm-Message-State: ACgBeo11u0g9kb+0GZTGDtQKdXLN0hu84AQq7hHM4Cx+bPyVkS8ihHmF N9DNJF8TudZtSvFNsoVjY2PBpuRZc4qXQHOo95F3zLH8OA== X-Google-Smtp-Source: AA6agR4h5S9SmlulVPBI2TpEGO/tFoMxleoOKNdn8izP9Urkdg9EB8reF9IcaGgmkeUqyq8L/kMjE+sCivSUofwjT8g= X-Received: by 2002:a17:907:9688:b0:739:afd7:eeb2 with SMTP id hd8-20020a170907968800b00739afd7eeb2mr5719957ejc.57.1661531546146; Fri, 26 Aug 2022 09:32:26 -0700 (PDT) MIME-Version: 1.0 From: Paul Pogonyshev Date: Fri, 26 Aug 2022 18:32:14 +0200 Message-ID: Subject: Emacs no longer moves point into visible port of the buffer To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="0000000000009760d605e727759e" Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=pogonyshev@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000009760d605e727759e Content-Type: text/plain; charset="UTF-8" Git commit 233c91d32a. Has been broken at least for a few days: my previous build also exhibited this. No idea how to create a short test in Elisp. >From user point of view: open a Magit buffer in a directory with at least two locally modified and uncommitted files. The buffer shows sth. like this: ... Staged changes (N) modified file1 modified file2 ... Move the point with C-n to the line with `file2'. Press TAB. Magit section for the file is not opened. Use `M-x describe-char'. From the resulting buffer you can say that the point is actually on an invisible char '@', i.e. start of (hidden) diff for the first file. It may be necessary to restart Emacs if you have used Magit in this directory previously. This used to work fine (i.e. point was never on an invisible character) both in Emacs 28 and earlier snapshots of `master'. Paul --0000000000009760d605e727759e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Git commit=C2=A0233c91d32a. Has been broken at least = for a few days: my previous build also exhibited this.

= No idea how to create a short test in Elisp.

From user p= oint=C2=A0of view: open a Magit buffer in a directory with at least two loc= ally modified and uncommitted files. The buffer shows sth. like this:
=

...
Staged changes (N)
modified=C2= =A0 =C2=A0file1
modified=C2=A0 =C2=A0file2
...

Move the point with C-n to the line with `file2'. Pres= s TAB. Magit section for the file is not opened. Use `M-x describe-char'= ;. From the resulting buffer you can say that the point is actually on an i= nvisible char '@', i.e. start of (hidden) diff for the first file.<= /div>

It may be necessary to restart Emacs if you have u= sed Magit in this directory previously.

This used = to work fine (i.e. point was never on an invisible character) both in Emacs= 28 and earlier snapshots of `master'.

Paul
--0000000000009760d605e727759e-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 02:56:01 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 06:56:01 +0000 Received: from localhost ([127.0.0.1]:55028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRpjd-0001lg-06 for submit@debbugs.gnu.org; Sat, 27 Aug 2022 02:56:01 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:51716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRpja-0001lQ-Nj for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 02:55:59 -0400 Received: by mail-wm1-f43.google.com with SMTP id ay12so1828082wmb.1 for <57433@debbugs.gnu.org>; Fri, 26 Aug 2022 23:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc; bh=WOAuAbh8p9AHqZna82bqKDeu+qt1uJPcAfIvYOyXUKM=; b=JF3vZgBwUgw7TRzD5E75IB0/dVn/YSty3MawrBd8m1Yioqzc/fN0IKGSy/fMOlRCNb kFNdscSs/sXxjjc6vPCKNDRlMJGnm+eP0/rvDMGxOsStdXEtFzcYAFpiSz4al5Ao1FEY HovarLe5I/cdYX3ZhqmOYhP1no278KMUf1kiNaFhiHzYS7khVYsGNPh8cweGTHQhmVGY BQW8DCLgq3QKs1Nol4voYJPL31iOkNmWOmb4m1MbEN4F5S5E6dWWAzwI/MR9iKcCmBkn 26l0kbnKA+3Z0SRRkw83CxfKBoPzigY5EBPc7pJo6Cdk3Ht7q+a9xGv4xENW8VsoHLuC Vq4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=WOAuAbh8p9AHqZna82bqKDeu+qt1uJPcAfIvYOyXUKM=; b=YWogLTsh1qKOfRRWhd4LJ1Vkke3xuOKrC1tzUrFrgFiFLNR2jW8+e6Dz0BVCMTyp/f 4ERVuTHlhDNX4jBKwIvbOQEintAkaqlc9GKf6rA3xi31eL6Z5BQX0j5eXqOKbW5El6eR FeJw+MGFLNhD7X9NOyc8zkQf6d1LzmgV/8sopCCBuDfIHBcmZpUqC5G1H9lwAFOR5H4Q dtw57tFN5n7cg7PPRbJVeDsBhQMJQoKBfnvgHQjzjMF9+dS7gbGkYMOnjPBdajhcjCOV k/lMa7zO+JxqOQ6HA4yF3FLm+G/lTy431legazFopwVUgZKDLvA1KNuQal6OSTB2xaVn shdQ== X-Gm-Message-State: ACgBeo0p2R0k6IKZaBJCuKw5PNvcp13FxcgbQM79+V/ylwRXa6G1ukwm U2Tu02X8qdnD+V7SPjnso24EWngFyhs= X-Google-Smtp-Source: AA6agR7wrqcjHuuaY9SCy2SxKkL9rK15zgyjn9b2INOHWZ0ks9+1vvowmffr5jtJk4NJMmWqHWHxBg== X-Received: by 2002:a05:600c:3ac3:b0:3a5:e1de:5994 with SMTP id d3-20020a05600c3ac300b003a5e1de5994mr1542596wms.133.1661583351462; Fri, 26 Aug 2022 23:55:51 -0700 (PDT) Received: from Mini.fritz.box (p54b0c4c1.dip0.t-ipconnect.de. [84.176.196.193]) by smtp.gmail.com with ESMTPSA id u11-20020a05600c19cb00b003a5a5069107sm702204wmq.24.2022.08.26.23.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 23:55:50 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Paul Pogonyshev Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer In-Reply-To: (Paul Pogonyshev's message of "Fri, 26 Aug 2022 18:32:14 +0200") References: Date: Sat, 27 Aug 2022 08:55:49 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Paul Pogonyshev writes: > Git commit 233c91d32a. Has been broken at least for a few days: my previous build also exhibited this. > > No idea how to create a short test in Elisp. > > From user point of view: open a Magit buffer in a directory with at least two locally modified and uncommitted files. The buffer shows sth. like > this: > > ... > Staged changes (N) > modified file1 > modified file2 > ... > > Move the point with C-n to the line with `file2'. Press TAB. Magit section for the file is not opened. Use `M-x describe-char'. From the resulting > buffer you can say that the point is actually on an invisible char '@', i.e. start of (hidden) diff for the first file. > > It may be necessary to restart Emacs if you have used Magit in this directory previously. > > This used to work fine (i.e. point was never on an invisible character) both in Emacs 28 and earlier snapshots of `master'. > > Paul I can reproduce this. Bisecting. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 04:08:39 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 08:08:39 +0000 Received: from localhost ([127.0.0.1]:55077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRqrv-0003Xb-3O for submit@debbugs.gnu.org; Sat, 27 Aug 2022 04:08:39 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:36483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRqrt-0003XO-FE for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 04:08:37 -0400 Received: by mail-wr1-f50.google.com with SMTP id bu22so3907486wrb.3 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 01:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc; bh=QF8Ac42iJOGy17SM059dBLvGD5SCwU2tIMe7Dhc7Q0g=; b=E4wRuedf1LYfj75PHWmbKF7fsiNeJKQp+POo2x0o7qLqtMAhbSC4IgXu6T2RR0dXQb /vVyNyJhRKCQG0NIyh/ObNi2mC8m5aVgX6ITBsFgzRHOIBc4Y1RGTK0aBiOYAMRElEfC PphoqPIgmsp75AGHxNs3avcPw6Lbc64c4s44n6JCLCDYA89vGrPuOqhWKgzR3JNnUcib Z0/uc1sZChb0evWiV7CvcPc6p/R69lfq7PGTZ35OsWFkdJUEu+Rg1ryi6VbBlkQXzAFM /STVxPoIvTZEap2C1l8RSk9x3XG5Hq7F7u09RZ1vwlZikWlSueNHI4ZoXo+/WYMoj6KC JPlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc; bh=QF8Ac42iJOGy17SM059dBLvGD5SCwU2tIMe7Dhc7Q0g=; b=Av3QHCJDdkSo+f+/8U/c50VNMn4uat/xBpHf40dDJ0cczCpNB6ICNLquei+so0zO7p NKjMUvH0P2wD0s4S34uFml+FawK2+TTqLZFFI8d7y0dzuDRIKKjzeAtPIf3t1nbbRe7S aoOm3Vbdf5t0wQ9ueW2V9nwQfdJRRjaJ+C34JqbrAiTuhmHTu8W41tFXs3U8mh/xH8hX ELUkvMH6TcbQW1Rg0tM7SY2Ko0tPuQbqNbZ5K38RNkpX4ePwyvWqPlIM68l7ZNQpztBj xdoURD3Qpbfn44HMHkcT1eV+TBXECrw9Be2kgZ/FEYBdDN7QHQlkJwGjiWW7c5I4n8EA 2Cmg== X-Gm-Message-State: ACgBeo2jkVVKr2+OJcEiUD5ZqHpf5mV4UIJVrPpCeg5xgMdRGEVijVzJ j8pq+QtYUgyhU46rejcLTj/4pccIkMw= X-Google-Smtp-Source: AA6agR6rUBCJJ5QFkk/aTYXycU+ZUM9RFanlcIzrPIdgS7vwcfCt3FRu+MSzJbp7gg5dnpHTs3DF/Q== X-Received: by 2002:adf:ecc1:0:b0:226:d378:50e4 with SMTP id s1-20020adfecc1000000b00226d37850e4mr505734wro.12.1661587708139; Sat, 27 Aug 2022 01:08:28 -0700 (PDT) Received: from Mini.fritz.box (p54b0c4c1.dip0.t-ipconnect.de. [84.176.196.193]) by smtp.gmail.com with ESMTPSA id 1-20020a05600c230100b003a643ac2b08sm1915758wmo.8.2022.08.27.01.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 01:08:27 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Paul Pogonyshev Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Sat, 27 Aug 2022 08:55:49 +0200") References: Date: Sat, 27 Aug 2022 10:08:26 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann writes: a71c05b44de74fe16691f680df34c4534992e472 is the first bad commit commit a71c05b44de74fe16691f680df34c4534992e472 Author: Eli Zaretskii Date: Sun Aug 14 15:47:59 2022 +0300 Further speedups of redisplay of long and truncated lines =20=20=20=20 * src/xdisp.c (mode_line_update_needed, redisplay_window) (decode_mode_spec): Don't avoid calling current_column, as it is now fast enough. (redisplay_window) : Don't call 'move_it_to' if its result will not be used. (Flong_line_optimizations_p): New primitive. * src/indent.c (Fcurrent_column): Doc fix. (current_column, scan_for_column): When in a buffer with long and/or truncated lines, quickly return an approximate value. * src/window.c (Frecenter): Use the old text-mode code when the buffer has very long lines. =20=20=20=20 * lisp/simple.el (line-move): Avoid costly calls to 'line-move-partial' and 'line-move-visual' when lines are truncated and/or very long. (move-beginning-of-line): Call 'line-beginning-position' instead of the slower 'skip-chars-backward'. =20=20=20=20 * etc/NEWS: Announce 'long-line-optimizations-p'. etc/NEWS | 3 +++ lisp/simple.el | 31 ++++++++++++++++++++--- src/indent.c | 60 ++++++++++++++++++++++++++++++++++++++------ src/window.c | 9 ++++--- src/xdisp.c | 79 +++++++++++++++++++++++++++++-------------------------= ---- 5 files changed, 129 insertions(+), 53 deletions(-) I will look at the changes in simple.el soon if no-one beats me. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 04:53:48 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 08:53:48 +0000 Received: from localhost ([127.0.0.1]:55142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRrZc-0004hq-EL for submit@debbugs.gnu.org; Sat, 27 Aug 2022 04:53:48 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:37752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRrZZ-0004hX-Jj for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 04:53:46 -0400 Received: by mail-wm1-f43.google.com with SMTP id c187-20020a1c35c4000000b003a30d88fe8eso5531648wma.2 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 01:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc; bh=o4sCd740jZcSU3heusFDQH4RA+MvUdz23jgYd7s5seg=; b=ILsxmtR/aRmlc43AKZV5g82qlSW2Dm+EwiP0xQ5tZYFybyzW/08tzfU5LnPm9swlQW 9on4mqYOkYFn9Yg94qAozNW1uxSsK+duPX2D2WjGPEHGkID/Pb61SmipBpDlT8cAlH/5 X5BMxo1lrT4XYD/cqSbEAG6f3hxkGuHkYGyFMWtx7Oo054h89xKfY5bThQBnFFnTXY5E 49Onqb3/BSQknYw2Fe+R3FIIPD+Y6ExxH3uug82KUTvX/Ynw5Z4RQV92keq2z/E/ihDu cdOzoEiLywyl/+5oG6HQiwYlWDAMKPpK/vlk6ZQy/3qh8gTlxDYavxYHOY2S0OYliC4x MI7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc; bh=o4sCd740jZcSU3heusFDQH4RA+MvUdz23jgYd7s5seg=; b=VYnYR66j7EAKXdOmBNAV0sGuOW/mqFQbRGoE/HCLplEkp7TDkG+6BYbShSJJbckxxx jATSZPYVyuH7uSi4gLs4K1bmo1ToURcPmbahkFR/bkGMYUpKs8h83NwvNQu2xFTA59Ae MLqhrSTGHsV2xdxwMN17YeueGwlJUHF6ecTvIkcxIMW3TPwBzjEMDMzNd6KMIv0PRhcF u6xx3cERmDEGf4WNtnXXnQZdJaKc1ZgfCFGKji8JBK+JdQuNSuS3fAiYU1bEPC0R6vms WGUepUspGrf7G45T2VMqJC6L9Rg7N3gccOMcsdft9Y/u2HwPeuQNxtlGgC//H2zlxhnV ckIQ== X-Gm-Message-State: ACgBeo0bl90irIcdJDU7XpbvV3PDRWXEVgF2yfs+OU3rUEFpKVBy1tts Q/U5rRU9IYsiQU3DZenj0a14c3pw1BA= X-Google-Smtp-Source: AA6agR4D0rOyMv22sQt3y2QGWXR2jF1749mO2UpFraxTs1sED05w6TlP1zqNybVe3B4C8K0yMoV37g== X-Received: by 2002:a05:600c:35d0:b0:3a5:f7ee:82be with SMTP id r16-20020a05600c35d000b003a5f7ee82bemr1705200wmq.206.1661590419305; Sat, 27 Aug 2022 01:53:39 -0700 (PDT) Received: from Mini.fritz.box (p54b0c4c1.dip0.t-ipconnect.de. [84.176.196.193]) by smtp.gmail.com with ESMTPSA id r22-20020a05600c35d600b003a5b6086381sm1964275wmq.48.2022.08.27.01.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 01:53:38 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Paul Pogonyshev Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Sat, 27 Aug 2022 10:08:26 +0200") References: Date: Sat, 27 Aug 2022 10:53:37 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann writes: > Gerd M=C3=B6llmann writes: > > a71c05b44de74fe16691f680df34c4534992e472 is the first bad commit > > I will look at the changes in simple.el soon if no-one beats me. Hm, I must admit that I don't understand the change in line-move, or better said the context in which it was made. So if I fix this I probably break some optimization. I have a simple recipe now, though. emacs -Q Insert and eval this function: (defun hansi () (insert "line 1\n") (insert (propertize "+invisible 1\ninvisible2-\n" 'invisible t)) (insert "line 2\n")) M-: (hansi) RET C-p C-x =3D =3D> Char: + (43, #o53, #x2b) point=3D330 of 365 (90%) column=3D0 That's something for Eli, I'd say. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 05:33:43 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 09:33:43 +0000 Received: from localhost ([127.0.0.1]:55208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsCF-0007u5-7K for submit@debbugs.gnu.org; Sat, 27 Aug 2022 05:33:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsCD-0007ts-Nk for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 05:33:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42024) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRsC8-000201-FN; Sat, 27 Aug 2022 05:33:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cvSzxde0exXxYudIboTYxrZUCVR0qL3hNXZO4jYdQEg=; b=SYlvcXaDK413FNcaLUNG XWWfQQ4znHc5K69e2Ppy5+pxbfM5/GrJrBI2EctaqTT/G3wYfRQkOoTYtmaWcSwP+3ByUONDo6ciO afK8mpyjNMCoIhk7qrJb+N8o+EHzuBDmT3KThlh4HUaIqU07+Jj7I62OuoSx2Q6JPcoOBWWkKGFWS f9EajfmybTsfuq1bDrwetRlQxv+FP+azaQPhWI2eK4KPUJYMdv8tF7NxNfe3Y06TzDUNwuC43Vhrp Nc4nGFnTaQ1GByaE3VVX+6HItsKAL23cDwkLtXAkjtUrnJk2koDXKUbZlS4MmIwEr0y3wGeV1FBuI gIPApOL4hpfOXA==; Received: from [87.69.77.57] (port=3552 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRsC5-0007lZ-Uy; Sat, 27 Aug 2022 05:33:36 -0400 Date: Sat, 27 Aug 2022 12:33:49 +0300 Message-Id: <83y1vayqrm.fsf@gnu.org> From: Eli Zaretskii To: Gerd =?utf-8?Q?M=C3=B6llmann?= In-Reply-To: (message from Gerd =?utf-8?Q?M=C3=B6llmann?= on Sat, 27 Aug 2022 10:53:37 +0200) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 57433@debbugs.gnu.org > From: Gerd Möllmann > Date: Sat, 27 Aug 2022 10:53:37 +0200 > > Gerd Möllmann writes: > > > Gerd Möllmann writes: > > > > a71c05b44de74fe16691f680df34c4534992e472 is the first bad commit > > > > I will look at the changes in simple.el soon if no-one beats me. > > Hm, I must admit that I don't understand the change in line-move, or > better said the context in which it was made. So if I fix this I > probably break some optimization. The changes in line-move should only affect buffers with very long lines. > I have a simple recipe now, though. > > emacs -Q > > Insert and eval this function: > > (defun hansi () > (insert "line 1\n") > (insert (propertize "+invisible 1\ninvisible2-\n" 'invisible t)) > (insert "line 2\n")) > > M-: (hansi) RET > C-p > C-x = > => > Char: + (43, #o53, #x2b) point=330 of 365 (90%) column=0 Why is that a problem? I get the same result on the emacs-28 branch, where the changes in this commit were not installed. And the OP said the problem is new on master. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 05:47:13 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 09:47:13 +0000 Received: from localhost ([127.0.0.1]:55225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsPJ-0008EE-Ag for submit@debbugs.gnu.org; Sat, 27 Aug 2022 05:47:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsPH-0008E2-Qt for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 05:47:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRsPC-0003or-HQ; Sat, 27 Aug 2022 05:47:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4qukpQiOT4WqD9LZWNvvivVZ8RYHvk0gsd/FtYKKQsU=; b=m6jF7fh/qznY /eG8PFOClxqoh/wyNpr1zEIumyC6Rqr8w4dsVy44yvgCNzzCVEgykLMrlk/D6eu7K19FMzJyeTQcr jIdGknTzGhmG/xYYM+a13g2pR/mT01Dtv5vJKN97N6lo61Q2jr1Tb7DgvzHt3WylBK/ynTabwz4je HpiwXOEgKwM9wORyl6aPXTSyDlZ9aCnFE6rqxZ0CR9Y6TrMfn68MY5WTR1yt+VUdPsv6J529CqSQ/ aT4mkOGAUvv5nvfiORuim6f20Xb4IkbVb+vvNcCbz+WNpVE0AVjm86N0NKEthhMzK8ulczgX2UWJ1 X/xQI0rN30c6Sk0+6NpmIg==; Received: from [87.69.77.57] (port=4402 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRsPB-0000TX-NP; Sat, 27 Aug 2022 05:47:06 -0400 Date: Sat, 27 Aug 2022 12:47:19 +0300 Message-Id: <83wnauyq54.fsf@gnu.org> From: Eli Zaretskii To: Paul Pogonyshev In-Reply-To: (message from Paul Pogonyshev on Fri, 26 Aug 2022 18:32:14 +0200) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Paul Pogonyshev > Date: Fri, 26 Aug 2022 18:32:14 +0200 > > Git commit 233c91d32a. Has been broken at least for a few days: my previous build also exhibited this. > > No idea how to create a short test in Elisp. > > From user point of view: open a Magit buffer in a directory with at least two locally modified and uncommitted > files. The buffer shows sth. like this: > > ... > Staged changes (N) > modified file1 > modified file2 > ... > > Move the point with C-n to the line with `file2'. Press TAB. Magit section for the file is not opened. Use `M-x > describe-char'. From the resulting buffer you can say that the point is actually on an invisible char '@', i.e. > start of (hidden) diff for the first file. Can you tell what is the actual buffer text and where are the invisible text properties on it? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 05:55:21 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 09:55:21 +0000 Received: from localhost ([127.0.0.1]:55229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsXB-0008SZ-8t for submit@debbugs.gnu.org; Sat, 27 Aug 2022 05:55:21 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:36785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsX9-0008SH-Ml for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 05:55:20 -0400 Received: by mail-wm1-f54.google.com with SMTP id v7-20020a1cac07000000b003a6062a4f81so5586389wme.1 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 02:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc; bh=vtuOIc4YHR7dI7xn5bclxbN7d4HOnkO2bVJsvi7gMVg=; b=iN9Ixkro7fmSmfNzQQd3WhBXQ8gqC2o/Vr/mqE7v1jL/S/J9NOQZ+ZcddTd33KC+US Pa9H2XmoTZe88H/Z2xEfef3nwldPCSg0gzPZABXT3wjnMg7Bk2vShIbBDMMHhPNwiHx3 rMO5UC+NHhAgbg3TUYG1W5Y2QmyJDw1i3dBjkMbWFllFIWnV9Mpx3kKdfH9Wg55AZh4X J5RUf7ktHN8JkG7zOce2IHwZ+pkgdQ/cf3q4ppvnExiE2NzPZKftWmMjpKhqm5qTbQwg 9uPftNoxktKIizyj6sjJSXtbDUOutNOOMS0nGL1tdtLX3k73xJG1wyATYD3/4PNOBEKq RVTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=vtuOIc4YHR7dI7xn5bclxbN7d4HOnkO2bVJsvi7gMVg=; b=Y9hwuId72KW6r38nOL/aG3iTq1P3U+dzoHkm9X2FBBajrA2ggpu++IQCDKkBF4g1gO GyS/CNXQT2IBWkVTnuTOLwb5fv6MlhOFDxJdQrDaXaalKbzanZ55ceGlezMlpo6mUrp8 gv1XR4rTeQdnR+1dPCfwFvXXyCuAbdWCkwupNopCDLu6zywSgbDpJ8fYeQCUMaQnJQbg t6GQplmwcjod8ApPZBOH0GswNTxvr6xB14vNzDdP5rQZCkHGIj1B/jVtNELcoBKOTYZj wRhG4u4GdyKM+LPBW2X0NVHu9EbtHLTPPROgHZb9NqTtnb0+NgDmRtlsJTwtJdvtV1C8 V9Ww== X-Gm-Message-State: ACgBeo0bHBPFr8NEhFe8QSZvLakNAk+hGtUk2dg3vWn0qnCcKz2J/+ay jTTspZDupXtto+ed9NlFf0I= X-Google-Smtp-Source: AA6agR7uDq82MwYQJmv1QoqV+Bxek94wd5jSDvlw/o3OaF9TaMrkjTGU4LeSteBcer3xlI43DG9b0g== X-Received: by 2002:a05:600c:410d:b0:3a6:1db8:b419 with SMTP id j13-20020a05600c410d00b003a61db8b419mr1839054wmi.119.1661594113820; Sat, 27 Aug 2022 02:55:13 -0700 (PDT) Received: from Mini.fritz.box (p54b0c4c1.dip0.t-ipconnect.de. [84.176.196.193]) by smtp.gmail.com with ESMTPSA id n8-20020a5d4848000000b00226d01a4635sm1933783wrs.35.2022.08.27.02.55.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 02:55:13 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Eli Zaretskii Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer In-Reply-To: <83y1vayqrm.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Aug 2022 12:33:49 +0300") References: <83y1vayqrm.fsf@gnu.org> Date: Sat, 27 Aug 2022 11:55:12 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Char: + (43, #o53, #x2b) point=330 of 365 (90%) column=0 > > Why is that a problem? I get the same result on the emacs-28 branch, > where the changes in this commit were not installed. And the OP said > the problem is new on master. Then it's probably not the right recipe, sorry. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 05:58:37 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 09:58:37 +0000 Received: from localhost ([127.0.0.1]:55234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsaK-00005Y-S2 for submit@debbugs.gnu.org; Sat, 27 Aug 2022 05:58:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsaJ-00005A-K6 for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 05:58:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRsaE-0005QX-CF; Sat, 27 Aug 2022 05:58:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=fpAdh4/66dVigcw7Lt4C1s3fpCpkvZ5Y7giNp95vWkY=; b=E7/h2UNkhutQ15xAd1O/ UPWGGZTrAH4FVBFwOe6MAQa1bB32+Cwxijh2cHJ0MHjgVSuH4tZ+WEm5i4FxI+Hz2YuyNWzWIxrol e/kyKt47C/s6WUfzL7bjR88dPrsco0ULt8Te/2/1811yTx/vdDtirlH2x5OyPheWGsdUJGKjfmf9p eASRUPXzITzME5Q+YASgpkSDF/eAekxNr6hwR2v6v7J/lW+lCP6hzYeZSBum9SWbJhetxtrvdsIHu h+qDW2JU5drw0PTAmay5lO/mS0tOaFE8ErRhIiTAiLfXi28Ax8FWsGaBhaZCtHCCKcD0mCDxM/WIE fAkzBmj5ybU6Eg==; Received: from [87.69.77.57] (port=1128 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRsaD-0005uq-Lq; Sat, 27 Aug 2022 05:58:30 -0400 Date: Sat, 27 Aug 2022 12:58:42 +0300 Message-Id: <83v8qeypm5.fsf@gnu.org> From: Eli Zaretskii To: gerd.moellmann@gmail.com In-Reply-To: <83y1vayqrm.fsf@gnu.org> (message from Eli Zaretskii on Sat, 27 Aug 2022 12:33:49 +0300) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: <83y1vayqrm.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com > Date: Sat, 27 Aug 2022 12:33:49 +0300 > From: Eli Zaretskii > > > Cc: 57433@debbugs.gnu.org > > From: Gerd Möllmann > > Date: Sat, 27 Aug 2022 10:53:37 +0200 > > > > Gerd Möllmann writes: > > > > > Gerd Möllmann writes: > > > > > > a71c05b44de74fe16691f680df34c4534992e472 is the first bad commit > > > > > > I will look at the changes in simple.el soon if no-one beats me. > > > > Hm, I must admit that I don't understand the change in line-move, or > > better said the context in which it was made. So if I fix this I > > probably break some optimization. > > The changes in line-move should only affect buffers with very long > lines. Does Magit turn on truncate-lines in the affected buffer, or cause them be truncated due to partial-width windows? If it does, I might have an idea what could cause the OP's problem. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 06:02:41 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 10:02:41 +0000 Received: from localhost ([127.0.0.1]:55238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRseH-0000Db-Hv for submit@debbugs.gnu.org; Sat, 27 Aug 2022 06:02:41 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:42829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRseG-0000DL-4V for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 06:02:40 -0400 Received: by mail-wm1-f42.google.com with SMTP id d12-20020a05600c34cc00b003a83d20812fso387272wmq.1 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 03:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc; bh=Xhv6ZAuevCaGpfX8WDCWRRDXhrlAyEIlykKpeDze71E=; b=X1XnO8YO/j+dihxEmRfjunXM3g2RwYRQUtnqoc0WwqeVgWbQoGFWsxenQjm2suKxir SrVXV9Z0atbG285SqObzxdiHgOw1AJwl7Uhml2BsYnCK01ER9U+GtxqzLNizNh6o4R/t rkZizQKqYeIKgWQWKhZ/fdMKszfxCE/ABdwQK4JbzuSY052fAx/BF0uiQnlGIX2stqkv zfUlH92xft3PpSy8VJYPSSrTfsHWzE3Me/Yo5Ki3pDjQns3UXf6pie0iW8o/Nzjj980P kFPboUmMWGmrYvKfZs9NY8LMJwTfYGmCcarGmavrq+wM5G+S6rZgjHylvpGrKl5U7ObS WCgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Xhv6ZAuevCaGpfX8WDCWRRDXhrlAyEIlykKpeDze71E=; b=RzDd5L53dqL3w3rRovS7sxLKvCa97NF7fk2+B0gg5ORBpjRxuK9bE/T6DS26xXHFgu JS1sPN2ILcEjfjbtIsmemnVutr1kViYRXIX+DUyvb3eVd0BjZMGDITd2I+zJUKQXRgU1 CMqJA2pm/TAn9UdDGVjZhu75Io6R7mT5VsAK2fmApZj8+bCJKHrq9thBxNS7g+I7MuuY Fxby/pmBRuYYZHg/bHkGC2Z3fU87azB0DnBZ4fPD/wiwoO6A9TwJuEuYiQKmc3ehIcic DGhlQVrarBtx1LVwcAyWYPQ1oMmofaLvNJ4avNkdZbGhB3tc7ZOo9rEdGVHp2UNA6K24 QC9g== X-Gm-Message-State: ACgBeo1YNA+MNrL0yyoNRFFeipJOFhvFd2bw3kRogwnVL//Vv/zVAPe0 oxQo+E+jDmbQOsdwzzTLdJ4= X-Google-Smtp-Source: AA6agR4HyBnG2IaEi3npeLFXRFKD/v3IbpJ+isZjDpdOtdsU7c6S3Oj3aWp5PALVd147PJ9PXM4kbQ== X-Received: by 2002:a05:600c:4148:b0:3a5:4f94:577b with SMTP id h8-20020a05600c414800b003a54f94577bmr1944114wmm.167.1661594554227; Sat, 27 Aug 2022 03:02:34 -0700 (PDT) Received: from Mini.fritz.box (p54b0c4c1.dip0.t-ipconnect.de. [84.176.196.193]) by smtp.gmail.com with ESMTPSA id k33-20020a05600c1ca100b003a38606385esm22384719wms.3.2022.08.27.03.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 03:02:33 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Eli Zaretskii Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer In-Reply-To: <83v8qeypm5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Aug 2022 12:58:42 +0300") References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> Date: Sat, 27 Aug 2022 12:02:32 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Does Magit turn on truncate-lines in the affected buffer, or cause > them be truncated due to partial-width windows? If it does, I might > have an idea what could cause the OP's problem. Yes, truncate-lines it t. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 06:19:13 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 10:19:13 +0000 Received: from localhost ([127.0.0.1]:55274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsuG-0000dD-Rr for submit@debbugs.gnu.org; Sat, 27 Aug 2022 06:19:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRsuE-0000cy-Qv for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 06:19:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52354) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRsu9-00008j-EV; Sat, 27 Aug 2022 06:19:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3YbcCGzOFTkrpKJguYTr25ZEiqc/uaiNYQ+R3kqcMTg=; b=jti+Y+AnZwiQtha2XPn6 e1iwrdOQY7D6gSINIUGSjAXABRxuJVYdp7JYLeIIpReI/4WCeaVv/7aFLe6mXkNnv4gvFkFDMTXUW O9hmu/XEDLITvpxcIfAVBqRRkIEbHyqdyIP61iUhw3eOxvWJWGGRxf9+kKcj3Wbfp3e5MYK0ay4g5 t1NNkNC4BfKvGPhJVc6pSjH0UGXAa4+9JtKnZYQ0fj4C4tHC3LA2Q5ll/MWz74TaECIhSOOKnnnEi 2rGu/64iWMKmqNvO/F1c9MwIPAp3UvlxeNuialK2JgaXlbXh7e5j0j3Y4ggcC0PE2t8rELa5faHGK WoNIWiBhbsaHPA==; Received: from [87.69.77.57] (port=2403 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRsu8-0007Yi-8o; Sat, 27 Aug 2022 06:19:04 -0400 Date: Sat, 27 Aug 2022 13:19:20 +0300 Message-Id: <83sfliyonr.fsf@gnu.org> From: Eli Zaretskii To: Gerd =?iso-8859-1?Q?M=F6llmann?= In-Reply-To: (message from Gerd =?iso-8859-1?Q?M=F6llmann?= on Sat, 27 Aug 2022 12:02:32 +0200) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Gerd Möllmann > Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com > Date: Sat, 27 Aug 2022 12:02:32 +0200 > > Eli Zaretskii writes: > > > Does Magit turn on truncate-lines in the affected buffer, or cause > > them be truncated due to partial-width windows? If it does, I might > > have an idea what could cause the OP's problem. > > Yes, truncate-lines it t. In that case, can you see if the patch below solves the original issue with Magit? diff --git a/lisp/simple.el b/lisp/simple.el index ee765c8..d18d54c 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -7717,13 +7717,15 @@ line-move (not goal-column) ;; Lines aren't truncated. (not - (or truncate-lines - (and (integerp truncate-partial-width-windows) - (< (window-width) - truncate-partial-width-windows)) - (and truncate-partial-width-windows - (not (integerp truncate-partial-width-windows)) - (not (window-full-width-p))))) + (and + (or truncate-lines + (and (integerp truncate-partial-width-windows) + (< (window-total-width) + truncate-partial-width-windows)) + (and truncate-partial-width-windows + (not (integerp truncate-partial-width-windows)) + (not (window-full-width-p)))) + (long-line-optimizations-p))) ;; When the text in the window is scrolled to the left, ;; display-based motion doesn't make sense (because each ;; logical line occupies exactly one screen line). From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 06:43:27 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 10:43:27 +0000 Received: from localhost ([127.0.0.1]:55298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRtHj-0001P1-EN for submit@debbugs.gnu.org; Sat, 27 Aug 2022 06:43:27 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:42514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRtHh-0001Oo-NN for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 06:43:26 -0400 Received: by mail-wr1-f54.google.com with SMTP id m16so4513453wru.9 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 03:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc; bh=e5mwTFhTI7GjdZq0KQUc7BFcYmepIIz/aainryXHzq8=; b=WG4htAU5vD8NoB3eKjT0oQNjbfZ5djEVbes813GuAmFyReEzBDHY2JkXxx02fmKeRk v0b87XC8L+8Ku0wUQVoyr9V5TOAKHDuqT9x0weUyacRBjL3MAVwEx8eZbmrAfI9bS8Xu L9Onhxf3njyu10F2shNlsR4nkIeYzo3SdLqBfvZNoEDroKqAfTjZvrJsG3YKbZ4F/LGq RylKGPjG0zauh4C1yiMwxXVYCqObQVpNzDttH2tFSGjR3g8LQrjVR3Hm00Ly2lQ/yfJY /Qdl2/FiM5qHPyTNrG/DFkIVl24DO4GdB+NDu8njeEt0Y5AoDTGxySj03oZn0ei6Jdh3 arTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc; bh=e5mwTFhTI7GjdZq0KQUc7BFcYmepIIz/aainryXHzq8=; b=5g0Q2YRSya4F3wzNM+2VqURThRBS0jqvmWWfrhlsn+/SNlHK0r37slKelvk7eW83dr z0g8PIHnaR5dXN1awGRGcd9EKJG9DFsdGIorIbBBTmT08jcEJuBLJjZkFidcqdry1whU yyIV8vZtLUu4xT8DdZvX7p6josfojzVLr3YGQL/PlvjkyPhg6YEwRikp3vBQLvrOrkl4 wENXQog+HogGfuysHhm8GO826b65uulktDc52y4rqSsSCNIzbcCN7E4AgHc28x/G9Gqs XX6er+2W6gPVAvC6R4sfS+QYxdlxWfK+VA2HlW1NJLQ6Ngc0McijX3+T3nIs47QFUrkL Bq1g== X-Gm-Message-State: ACgBeo332ajP/FCavmLU5mzUkgWUskyuQGH2FebDKGMuWL7p/qrCG78y o/iC6vGFWQvesXFbFfiV2lU= X-Google-Smtp-Source: AA6agR7nZiqIqt0T9V1N9SwqkS0eoGG6QuF90PK2oV8KKfuLU31dVXoeJqgj88y8kzbU9CBpI7HVvA== X-Received: by 2002:a5d:64ca:0:b0:225:4a7f:6e91 with SMTP id f10-20020a5d64ca000000b002254a7f6e91mr1867872wri.133.1661597000016; Sat, 27 Aug 2022 03:43:20 -0700 (PDT) Received: from Mini.fritz.box (p54b0c4c1.dip0.t-ipconnect.de. [84.176.196.193]) by smtp.gmail.com with ESMTPSA id i10-20020a1c3b0a000000b003a601707174sm2358911wma.33.2022.08.27.03.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 03:43:19 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Eli Zaretskii Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer In-Reply-To: <83sfliyonr.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Aug 2022 13:19:20 +0300") References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> Date: Sat, 27 Aug 2022 12:43:18 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com >> Date: Sat, 27 Aug 2022 12:02:32 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> > Does Magit turn on truncate-lines in the affected buffer, or cause >> > them be truncated due to partial-width windows? If it does, I might >> > have an idea what could cause the OP's problem. >>=20 >> Yes, truncate-lines it t. > > In that case, can you see if the patch below solves the original issue > with Magit? Works for me. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 07:08:19 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 11:08:20 +0000 Received: from localhost ([127.0.0.1]:55317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRtfn-00022d-Ix for submit@debbugs.gnu.org; Sat, 27 Aug 2022 07:08:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRtfl-00022O-Oa for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 07:08:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRtfg-0008T1-Gn; Sat, 27 Aug 2022 07:08:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=0DKGdnrCwHh5vxczzOD8l1F2wW1P1SBO35ma2SYHriY=; b=bSsSTxM06AX4ShN39X8y iX2tNQ29rVmRh2JF3vqqvbD91m+OCptLBic2ocmU+wnb/MDFVoeJbI2hzSriGSUbH7nlTe9T07BEd eY1nEDEY/aGt3+cpRsVZFyebj/uIUT0OC3vIDI0kVY6L9s8sFLGE7bU1aTufP9O1wCyyyQXUm/sLx Y9KC5Abzi+9oVG3KOvF0w+GxqFSxTyZgSqUpkUZ9PH/nWDma3NQUOErgCAxIPkiCJTr0Tap5Oskw7 EeCgpazqmwYXz8iBxdotO65M/uaBKX2WdiAZxYLO6QPmWdJpPWKJlXbZw7ke/s3NpCB/cg0S/NRXx hmpfutXzlUrsTw==; Received: from [87.69.77.57] (port=1845 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRtff-0003Kv-N8; Sat, 27 Aug 2022 07:08:12 -0400 Date: Sat, 27 Aug 2022 14:08:27 +0300 Message-Id: <83pmgmymdw.fsf@gnu.org> From: Eli Zaretskii To: Gerd =?utf-8?Q?M=C3=B6llmann?= In-Reply-To: (message from Gerd =?utf-8?Q?M=C3=B6llmann?= on Sat, 27 Aug 2022 12:43:18 +0200) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Gerd Möllmann > Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com > Date: Sat, 27 Aug 2022 12:43:18 +0200 > > Eli Zaretskii writes: > > >> From: Gerd Möllmann > >> Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com > >> Date: Sat, 27 Aug 2022 12:02:32 +0200 > >> > >> Eli Zaretskii writes: > >> > >> > Does Magit turn on truncate-lines in the affected buffer, or cause > >> > them be truncated due to partial-width windows? If it does, I might > >> > have an idea what could cause the OP's problem. > >> > >> Yes, truncate-lines it t. > > > > In that case, can you see if the patch below solves the original issue > > with Magit? > > Works for me. Thanks! Thanks, installed. Paul, please see that your original problem is now solved. (Btw, I think it's a subtle bug in Magit that it assumes cursor motion will never end up on invisible text in such buffers.) From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 10:08:10 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 14:08:10 +0000 Received: from localhost ([127.0.0.1]:56711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRwTp-0004zc-Is for submit@debbugs.gnu.org; Sat, 27 Aug 2022 10:08:09 -0400 Received: from mail-ej1-f54.google.com ([209.85.218.54]:46852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRwTo-0004zR-8p for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 10:08:08 -0400 Received: by mail-ej1-f54.google.com with SMTP id bj12so7769184ejb.13 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 07:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=7lArpK/SlX+mEV5gt5itJsDXfYyFWYnYJM0glxhKQKc=; b=L7X4Qufl9ogRqLFOFNC7wAO6vVU/FkSOLX4SRRhglDECtyudSv6g+J4r/g0RIq1iLZ PPQci4KUuKke5lH+AX7ybIIGAwM2b98M+K0bxc/HtcvN5JAKKNkwqjPWeze+wDuNiPRs tL9gbR5U4mEN2MxfJtsFpehrNxqmTac3kB+zEW3s4o7ZjfSMVKDTrprXJ9mry4E+s5BT Ne5x3mp0CpBinrlaDqkVFXZs5is/IE/xa6toiDxPNXRN4O4eC/vD/7jUngSzvBByScXs FrFJZ08i816oVzLslX/Ot4nH2a6j5KgvvljNDC/cfKPh7BHJoKuiG2V0n8m81PWEKCkl Jmuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=7lArpK/SlX+mEV5gt5itJsDXfYyFWYnYJM0glxhKQKc=; b=Hq+zFUynALfhisZRHi1kkeQH0MS+zZPU6AQTdZBG6aiWXEs9pOpOndHRwFBkJh2vo9 2uXyjeWIJNcqXVx4fUhDx+pXSN2xLjHK+zZKoare2df5gvAlFG4JKcXc5vRLYdJ/o8vv P2khlreSgynwTBNzvuZxcpYJTD6FSFYEx+IG9QhBhqd/sfyk0s8OzxhU4nSGpLZUu9dO wkHveb/Y6sr6V8kv2eqngid9IO9GcxIoIUksutVe/TCKf4hW0WFgR0KUpVRzl36yAAZ2 nefZlWxEILaPL8KV7gA5/wTlT9SsroRFLRdhqwJZQN4KD3p6bTEnLBcehXojiKlSkkEu 568g== X-Gm-Message-State: ACgBeo0gwOvzfJlwdi/QesQFsa+EcBTb4gafqTCZzERc/Fq7cRhWOY9x G+Awby5+SSi03qBDLFX6emxDirpd19g0bG9j0EguYNJ1dQ== X-Google-Smtp-Source: AA6agR712EVYockHfoovbXyveMIUTvozhc3FoyEppUJg1oIOUCjlopWG+0u9e5IaRY29s6Fjqb+gk92iRMntKoVackw= X-Received: by 2002:a17:907:b10:b0:73d:bedd:3121 with SMTP id h16-20020a1709070b1000b0073dbedd3121mr7915916ejl.530.1661609282453; Sat, 27 Aug 2022 07:08:02 -0700 (PDT) MIME-Version: 1.0 References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> In-Reply-To: <83pmgmymdw.fsf@gnu.org> From: Paul Pogonyshev Date: Sat, 27 Aug 2022 16:07:49 +0200 Message-ID: Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000009461905e7398f09" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000009461905e7398f09 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Paul, please see that your original problem is now solved. No, don't see any change in behavior. > (Btw, I think it's a subtle bug in Magit that it assumes cursor motion > will never end up on invisible text in such buffers.) I don't think it is a bug. It is explicitly promised in Elisp manual as I see: > 22.6 Adjusting Point After Commands > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > Emacs cannot display the cursor when point is in the middle of a > sequence of text that has the =E2=80=98display=E2=80=99 or =E2=80=98compo= sition=E2=80=99 property, or is > *invisible*. Therefore, after a command finishes and returns to the > command loop, if point is within such a sequence, the command loop > normally moves point to the edge of the sequence, making this sequence > effectively intangible. That's why, btw, I couldn't create a testcase: I don't know how to emulate command loop. Paul On Sat, 27 Aug 2022 at 13:08, Eli Zaretskii wrote: > > From: Gerd M=C3=B6llmann > > Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com > > Date: Sat, 27 Aug 2022 12:43:18 +0200 > > > > Eli Zaretskii writes: > > > > >> From: Gerd M=C3=B6llmann > > >> Cc: 57433@debbugs.gnu.org, pogonyshev@gmail.com > > >> Date: Sat, 27 Aug 2022 12:02:32 +0200 > > >> > > >> Eli Zaretskii writes: > > >> > > >> > Does Magit turn on truncate-lines in the affected buffer, or cause > > >> > them be truncated due to partial-width windows? If it does, I mig= ht > > >> > have an idea what could cause the OP's problem. > > >> > > >> Yes, truncate-lines it t. > > > > > > In that case, can you see if the patch below solves the original issu= e > > > with Magit? > > > > Works for me. Thanks! > > Thanks, installed. > > Paul, please see that your original problem is now solved. > > (Btw, I think it's a subtle bug in Magit that it assumes cursor motion > will never end up on invisible text in such buffers.) > --00000000000009461905e7398f09 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Paul, please see that your original problem is now so= lved.

No, don't see any change in behavior.

> (Btw, I think it's a subtle bug in Magit that= it assumes cursor motion
> will never end up on invisible text in su= ch buffers.)

I don't think it is a bug. It= is explicitly promised in Elisp manual as I see:

= > 22.6 Adjusting Point After Commands
>=C2=A0=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D
>=C2=A0
>=C2=A0Emacs cannot display the cursor when p= oint is in the middle of a
>=C2=A0sequence of text that has the =E2= =80=98display=E2=80=99 or =E2=80=98composition=E2=80=99 property, or is
= >=C2=A0invisible.=C2=A0 Therefore, after a command finishes and r= eturns to the
>=C2=A0command loop, if point is within such a sequence= , the command loop
>=C2=A0normally moves point to the edge of the seq= uence, making this sequence
>=C2=A0effectively intangible.
<= div>
That's why, btw, I couldn't create a testcase: I= don't know how to emulate
command loop.

=
Paul

On Sat, 27 Aug 2022 at 13:08, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Gerd M=C3=B6llmann <gerd.moellmann@gmail= .com>
> Cc: 57433@d= ebbugs.gnu.org,=C2=A0 pogonyshev@gmail.com
> Date: Sat, 27 Aug 2022 12:43:18 +0200
>
> Eli Zaretskii <el= iz@gnu.org> writes:
>
> >> From: Gerd M=C3=B6llmann <gerd.moellmann@gmail.com>
> >> Cc: 57433@debbugs.gnu.org,=C2=A0 pogonyshev@gmail.com
> >> Date: Sat, 27 Aug 2022 12:02:32 +0200
> >>
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >>
> >> > Does Magit turn on truncate-lines in the affected buffer= , or cause
> >> > them be truncated due to partial-width windows?=C2=A0 If= it does, I might
> >> > have an idea what could cause the OP's problem.
> >>
> >> Yes, truncate-lines it t.
> >
> > In that case, can you see if the patch below solves the original = issue
> > with Magit?
>
> Works for me.=C2=A0 Thanks!

Thanks, installed.

Paul, please see that your original problem is now solved.

(Btw, I think it's a subtle bug in Magit that it assumes cursor motion<= br> will never end up on invisible text in such buffers.)
--00000000000009461905e7398f09-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 10:28:45 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 14:28:46 +0000 Received: from localhost ([127.0.0.1]:56730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRwnl-0005UG-Ng for submit@debbugs.gnu.org; Sat, 27 Aug 2022 10:28:45 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:39693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRwnh-0005U1-Io for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 10:28:44 -0400 Received: by mail-wr1-f50.google.com with SMTP id az27so4955827wrb.6 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 07:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc; bh=tb2lJC5PvDkYpBfTyDl7ooxmjOMMw8LP5Tyf1F1t5jw=; b=J6AEA5sVxOLzYZPZVD9FU6rLp3Jtxj1dKbpaVU4FFpdyVggkkTux9DhKFV5Sid5igx AsfSdS5NGAio1QyOHpjokKAnk9gQ5vd4PQizWv05Q5u+RCXgAokRQO8ZUue91D8/7R22 PGtZE4CiHkgAMrt87wsbGaVWTgiQUoSeTywesI1kZyqFiLIXDjxlX7oBrERSL8bTnIfw /QYzo8YXCXPphavsBS5Dr2u9mc54nMZbQhX9MaRo6lFh8ibZ3J82IZxHb5JDH9ihqyXO RQKW/cRZGgg44ZKTWx25hWFtAHhEt+u8JAELWENXBHYA4JKewxCWLw7R1aGno9BshQY8 dMpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=tb2lJC5PvDkYpBfTyDl7ooxmjOMMw8LP5Tyf1F1t5jw=; b=GgRU5D5IMwhCkJcrOCtpkF7RpPOEfmvCqeBK7E9RSSnkkX+KO2kIEcAM11XXOQGOw4 t2HItWSAxjPSyt+fiD8JigV/sfLqh+l2WeI1JjixJLZS+5lr5QvvhhyKr7IBTZCAtDYB W/VLRGqVqQt38lMkXs3qhxiH1KmZXmHM3xQbNpk3b7JD5rijucMWvoH5kz4tulp+UtGC thyvG0AKV8CLqyN23zRKQfsvSPyczfrqm+99I8K2NHX8ChW+Z5gvWIlzbbaod88b6MV9 J51GK4Wung3CqJ1nH3Pu2Cx9R25c8x8DtZXxBmXWdYKgDl/Z0FFWFX5cHh4Xb++wh9ml U9yw== X-Gm-Message-State: ACgBeo1MraP8Z4OnevP4DwiHqe6ZD9aytVBGOx36agmm4NOWwlHJSxN3 PUfGm891t2N+ZNh3kWMLOhrWxfNCR+ftsQ== X-Google-Smtp-Source: AA6agR6RPEJ7WkFxmtOQnhUV/XUts3QT5Km9QC2fRigORrcXVDMghpooDvPPNDHYCY9wroyMnFvxvQ== X-Received: by 2002:adf:f6d1:0:b0:225:7923:f5d8 with SMTP id y17-20020adff6d1000000b002257923f5d8mr2346790wrp.411.1661610515216; Sat, 27 Aug 2022 07:28:35 -0700 (PDT) Received: from Mini.fritz.box (p54b0c4c1.dip0.t-ipconnect.de. [84.176.196.193]) by smtp.gmail.com with ESMTPSA id g11-20020a05600c4ecb00b003a4c6e67f01sm3438083wmq.6.2022.08.27.07.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 07:28:34 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Paul Pogonyshev Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer In-Reply-To: (Paul Pogonyshev's message of "Sat, 27 Aug 2022 16:07:49 +0200") References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> Date: Sat, 27 Aug 2022 16:28:33 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Paul Pogonyshev writes: >> Paul, please see that your original problem is now solved. > > No, don't see any change in behavior. Strange. Could you please double-check that you have commit a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 11:13:05 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 15:13:05 +0000 Received: from localhost ([127.0.0.1]:56786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRxUe-0000Nr-Mt for submit@debbugs.gnu.org; Sat, 27 Aug 2022 11:13:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRxUY-0000NJ-V6 for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 11:13:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRxUP-0002Pv-Rc; Sat, 27 Aug 2022 11:12:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SBUEjcaI2nMCQhMa0x55TOB6eDBXlU8SALr7h2HY2RM=; b=ggmIyPuD1ycrxjEuUSRd FmITQsGzsQuJhfpGrpfuHCIXud3pEXTOEfDFq0SN8Yi6SR6S2pEEU3idarTY5kQ410ZbpnL3NrwIm IU+0pv2hHYF9BifV2msnhRe/dsaNssbrjOqbc4Gi2QpTLxDy/RkTddSse/iwvSyC9685e/EDXny1m b+t6Cp74DAL5e/gcAspL26orFM4E+WdeY7eAKENVk4d6Vdu2OIKXQGIfjT80CMoefEOYx2O3P6+e1 uMPBC8h3fHDvxXUq1pAhAlYofxldfNo5xcZAspi+iurn2Zd6BeJO4LlHwK9PLE4PYi6a5K1dD4Dla NaegN3Z5OcBeZw==; Received: from [87.69.77.57] (port=1661 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRxUP-0008Th-A4; Sat, 27 Aug 2022 11:12:49 -0400 Date: Sat, 27 Aug 2022 18:13:04 +0300 Message-Id: <83k06tzpmn.fsf@gnu.org> From: Eli Zaretskii To: Paul Pogonyshev In-Reply-To: (message from Paul Pogonyshev on Sat, 27 Aug 2022 16:07:49 +0200) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433 Cc: gerd.moellmann@gmail.com, 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Paul Pogonyshev > Date: Sat, 27 Aug 2022 16:07:49 +0200 > Cc: Gerd Möllmann , > 57433@debbugs.gnu.org > > > Paul, please see that your original problem is now solved. > > No, don't see any change in behavior. Then I guess what you see is a separate and different problem. > > (Btw, I think it's a subtle bug in Magit that it assumes cursor motion > > will never end up on invisible text in such buffers.) > > I don't think it is a bug. It is explicitly promised in Elisp manual as I see: > > > 22.6 Adjusting Point After Commands > > =================================== > > > > Emacs cannot display the cursor when point is in the middle of a > > sequence of text that has the ‘display’ or ‘composition’ property, or is > > invisible. Therefore, after a command finishes and returns to the > > command loop, if point is within such a sequence, the command loop > > normally moves point to the edge of the sequence, making this sequence > > effectively intangible. I think you are reading too much into what that text says. It says that point moves to the edge of such a sequence, and that is what happens here. No more, no less. > That's why, btw, I couldn't create a testcase: I don't know how to emulate > command loop. Exactly. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 11:48:00 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 15:48:01 +0000 Received: from localhost ([127.0.0.1]:56848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRy2S-0003UM-Cx for submit@debbugs.gnu.org; Sat, 27 Aug 2022 11:48:00 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:46633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRy2I-0003SY-4S for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 11:47:54 -0400 Received: by mail-ej1-f46.google.com with SMTP id bj12so8060466ejb.13 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 08:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=H1bWZHHAU9wCePQj33b/Pk+/ZoXeuGA+95XkHobdiGs=; b=aGt71PbGrQHefqtLmHEP2FjJlysKoLpPLf0FWo40UgEyaMf8fdYVY6k3c+qzRHyHbe AASzOUF6EJxE+pX0lZDjTGu2RDUf4VX/evLYI4/yfgSZmoirKvMTT+nmo6g/qhstOMhM JhMhWwJ8/tsVt2dbZjNEFdqUxyRN2UW7p+FvgKzXiuBRKYl23616VMhPVWv/ar3UrUSZ g+AggfhynMANFqV8/hcKLtw5Tl5BTWKpZlhVJJVfgGGU/ShHJw4JOJQ4zj6qYKn4f8rO N2PTPg8VhQoO/Gzbr5nbrz04yRx01ZfzvYGz4R02eMGQXaAyxh6654Djqf2e7zWVJ3yB 83rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=H1bWZHHAU9wCePQj33b/Pk+/ZoXeuGA+95XkHobdiGs=; b=Mt2vQcUgb5vVJ6sHMZxRDxd0hN/OCLfsAoYkNtKJonUCR/oO+5mZH6wgjlWk9JRnEN 2HveiZ9cA/AdO+ouin7Uw9bypp+VsCfAewiCU9N6w5qhO4fcYfSgHXSRpVF3dQQK3VAp ATGw0FcCW7MFefNKJaWGzIIDL2Dj6Z5luqa/Hkf7iIWhZtxIyXsRYMjtPGT6xhH+eJMo 8lQlqy6i+FRUiWRoSjBCbzad7yM8quYPOfLUCd6AlijafXlYUezO/Wun37SuAtR8cGJI x00rTLQdy02DGTVWp36IRuwwoNyOjiE7PAVhwwLFqpLBcFnf3Bs3nxVFtN3bXy3q/E83 O5XQ== X-Gm-Message-State: ACgBeo0kzJrnjx4BKpf/TtRm3u0uaEVm5+ne8DAbNzs/Xmqtbvk8KOIL G3HLqkwHjy+o4Ov9tBt9zO61UQI/HIPB6IZCoQ== X-Google-Smtp-Source: AA6agR6Pt3LmKOvBv+m3ddHohQ3ipJAQ78vdvrq0ZTqA1hCHDsN5NiMJgrRO8V/klNAKZ6qvKjAlkc/wGgIRcdtvBy8= X-Received: by 2002:a17:907:7b95:b0:731:113a:d7a2 with SMTP id ne21-20020a1709077b9500b00731113ad7a2mr8153936ejc.377.1661615264294; Sat, 27 Aug 2022 08:47:44 -0700 (PDT) MIME-Version: 1.0 References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> In-Reply-To: From: Paul Pogonyshev Date: Sat, 27 Aug 2022 17:47:32 +0200 Message-ID: Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= Content-Type: multipart/alternative; boundary="00000000000094ee8905e73af320" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: 57433@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000094ee8905e73af320 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Strange. Could you please double-check that you have commit > a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree? I have rebuilt Emacs and now it works. I previously tried with applying the patch from "In that case, can you see if the patch below solves the original issue with Magit?" locally, but apparently did something wrong. So yes, it works for me now, sorry. > I think you are reading too much into what that text says. It says > that point moves to the edge of such a sequence, and that is what > happens here. No more, no less. Yeah, I see now that if you move with C-b, the point disappears within the diff for the previous file, even with Emacs 28, and then Magit misbehaves. To be honest, I'm not sure if that is useful (or maybe there is some reason for moving "*to the edge*" rather than *outside* an invisible sequence), but that's certainly not a regression in Emacs. Paul On Sat, 27 Aug 2022 at 16:28, Gerd M=C3=B6llmann wrote: > Paul Pogonyshev writes: > > >> Paul, please see that your original problem is now solved. > > > > No, don't see any change in behavior. > > Strange. Could you please double-check that you have commit > a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree? > --00000000000094ee8905e73af320 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Strange.=C2=A0 Could you please double-check that you= have commit
> a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your workt= ree?

I have rebuilt Emacs and now it works. I previously= tried with applying
the patch from "In that case, can you s= ee if the patch below solves the
original issue with Magit?"= locally, but apparently did something wrong.

= So yes, it works for me now, sorry.

> I think y= ou are reading too much into what that text says.=C2=A0 It says
> tha= t point moves to the edge of such a sequence, and that is what
> happ= ens here.=C2=A0 No more, no less.

Yeah, I see = now that if you move with C-b, the point disappears within
the di= ff for the previous file, even with Emacs 28, and then Magit
misb= ehaves. To be honest, I'm not sure if that is useful (or maybe there
is some reason for moving "to the edge" rather tha= n outside an
invisible sequence), but that's certainly= not a regression in Emacs.

Paul


On Sat, 27 Aug 2022 at 16:28= , Gerd M=C3=B6llmann <gerd.m= oellmann@gmail.com> wrote:
Paul Pogonyshev <pogonyshev@gmail.com> writes:

>> Paul, please see that your original problem is now solved.
>
> No, don't see any change in behavior.

Strange.=C2=A0 Could you please double-check that you have commit
a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree?
--00000000000094ee8905e73af320-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 11:55:44 2022 Received: (at 57433-done) by debbugs.gnu.org; 27 Aug 2022 15:55:44 +0000 Received: from localhost ([127.0.0.1]:56867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRy9w-0003hW-7y for submit@debbugs.gnu.org; Sat, 27 Aug 2022 11:55:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRy9u-0003hI-2K for 57433-done@debbugs.gnu.org; Sat, 27 Aug 2022 11:55:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRy9o-0000ze-Q8; Sat, 27 Aug 2022 11:55:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Zx6+F17GZ12BR5l6gh5pVGS544o/l0gcwT47FkyV6tA=; b=Kdju4PN1XhBu TMZU7Or4jGda14JTmWpsRc4AknR39n3hSxcKzf+n+Gu88tENmPI/S68yjzbO9wCpS276vjsuvBZBm 5eqqjNInVZ6JMgKbaVEyCBi2Bu85xY+PDjar3XAOXFM2BuVZixHgcixZXgKLdXau3dnZbVFUU5wsp Pz5tiWPY7teZ4VCi8WXcswH2tvnkpTAzh2XSYcKg8hjd+0r8ANshv6UmosQ4X6d6Qy31KXp9eDnda /RnG1Jc1hAdaw/9QGw1ujF4tXJ3p1ntMpkf7bcp/lMVnGCnemCkmRVdzTSzsZvimasF+GFBqFDPZl mVWgIAqfzvmDBWdMnGiXzg==; Received: from [87.69.77.57] (port=4270 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRy9c-0008Co-JV; Sat, 27 Aug 2022 11:55:34 -0400 Date: Sat, 27 Aug 2022 18:55:40 +0300 Message-Id: <83h71xznnn.fsf@gnu.org> From: Eli Zaretskii To: Paul Pogonyshev In-Reply-To: (message from Paul Pogonyshev on Sat, 27 Aug 2022 17:47:32 +0200) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433-done Cc: gerd.moellmann@gmail.com, 57433-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Paul Pogonyshev > Date: Sat, 27 Aug 2022 17:47:32 +0200 > Cc: Eli Zaretskii , 57433@debbugs.gnu.org > > > Strange. Could you please double-check that you have commit > > a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree? > > I have rebuilt Emacs and now it works. I previously tried with applying > the patch from "In that case, can you see if the patch below solves the > original issue with Magit?" locally, but apparently did something wrong. > > So yes, it works for me now, sorry. No need to be sorry, thanks for testing the fix. I'm therefore closing the bug. > > I think you are reading too much into what that text says. It says > > that point moves to the edge of such a sequence, and that is what > > happens here. No more, no less. > > Yeah, I see now that if you move with C-b, the point disappears within > the diff for the previous file, even with Emacs 28, and then Magit > misbehaves. To be honest, I'm not sure if that is useful (or maybe there > is some reason for moving "to the edge" rather than outside an > invisible sequence), but that's certainly not a regression in Emacs. The "reason" is largely a side-effect of the implementation, I suspect. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 12:07:31 2022 Received: (at 57433-done) by debbugs.gnu.org; 27 Aug 2022 16:07:31 +0000 Received: from localhost ([127.0.0.1]:56895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyLK-000413-FC for submit@debbugs.gnu.org; Sat, 27 Aug 2022 12:07:30 -0400 Received: from mail-ed1-f50.google.com ([209.85.208.50]:43570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyL7-00040N-EF for 57433-done@debbugs.gnu.org; Sat, 27 Aug 2022 12:07:29 -0400 Received: by mail-ed1-f50.google.com with SMTP id w20so5389987edd.10 for <57433-done@debbugs.gnu.org>; Sat, 27 Aug 2022 09:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=12VMJih3u1JwD1pSJV5JEB6sfPhqPPwYnz0kAECCxfA=; b=Ak5T/P7Wj0NGdcUcaM4sRQPHpLvilvHN9A61+atSGxqrh7+3sERyYshl8NL4otYnmm agNISbgFKGZTJEDt4TgFfqImlerUPnXQQ7tYD4q6OaRQCzs3bsnu03PoAF+Fu92g57vh V2cCHBi4L1qsx34QVmRfyeYmbLlks+a8vHBVTLjsVVX2xzt45GqRpJkt7Drr7aUzhUDJ +l+oqRGNQkBDhAcX+CJJn3TmQQ/0NFSJW5sx/7IK8j32KAc/Do9j3ytYWHSZeC0JFj9v PLemF3Rq474m8/brYO8qrq3Z8roqK9gVhSEoTRvYQ+osYUgi2shxkZQlQ/GvKJvcBjBc Iygw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=12VMJih3u1JwD1pSJV5JEB6sfPhqPPwYnz0kAECCxfA=; b=5NLWCrlEBmb3UTw5k1wfICGTSWXsUJ9brl8xLWQV+dQxf6USWlmfNi9IAQh7x7t8Vc jltdcC2GJqHfe746doQvV21YI9YiI2um79TWPDq/1oF19DgSAyTI7CFwlfvLyPRhK0DG u+hnuRZPjGa4OO68jGytUrLdIIcQjZeGq2u5DXkomyO/isCs7rUzOFJshcvUh7zm7zYR nQ0gnSyd/M885Wn5zIOayUoNiQSWMGdjaskMKQXCKFcGaIG7GLF9IAJhuDmQy+PGL5yl 8Mv8fKjTe2060JsN8pkqJB/6tuRKQ2ER0US0YmBSczoluE+yTB7BQb2al7gdNIP1FGmp Ag4A== X-Gm-Message-State: ACgBeo1TSrJGateT4t8lCWM9yKDDk1MGlcZYbzDDQKChI7BKgC08Dr9y Nrq7wXK59eNv74n7xY0U0Yh5bhModhjHmDY1SQ== X-Google-Smtp-Source: AA6agR5F2oqYoqGVy1ralZG3z8dGDtCX228FYz2oopuBz24mhvm+uOS3vekFZeuC7ruPC36jWI7Wb6AifjGcirDnqv0= X-Received: by 2002:a05:6402:4282:b0:43e:612c:fcf7 with SMTP id g2-20020a056402428200b0043e612cfcf7mr10390315edc.242.1661616431586; Sat, 27 Aug 2022 09:07:11 -0700 (PDT) MIME-Version: 1.0 References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> <83h71xznnn.fsf@gnu.org> In-Reply-To: <83h71xznnn.fsf@gnu.org> From: Paul Pogonyshev Date: Sat, 27 Aug 2022 18:06:59 +0200 Message-ID: Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000028634105e73b39cd" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433-done Cc: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , 57433-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000028634105e73b39cd Content-Type: text/plain; charset="UTF-8" > The "reason" is largely a side-effect of the implementation, I > suspect. Would it then not be a good idea to improve it (not as part of this bug, of course)? E.g. currently the behavior is like below. Setup: Magit buffer with staged files, at least two. It looks like this: Staged changes (N) modified file1 [invisible diff of file1] modified file2 [invisible diff of file2] so essentially I, as a user, only see this in UI: Staged changes (N) modified file1 modified file2 Now, I put the point at the beginning of the third line ([^] is the point): Staged changes (N) modified file1 [^]modified file2 I press C-b, expecting that the point is moved to the end of the previous line that I see. But it is not moved there, this is the result: Staged changes (N) modified file1 [^]modified file2 In reality, the point is in the invisible (to me, as the user) diff for file1. If I press C-b again, only now point is moved like I expected it to be moved the last time: Staged changes (N) modified file1[^] modified file2 So, the presence of invisible text between lines 2 and 3 changes the way C-b behaves and breaks my (as a user of Emacs) expectations, disrupting established editing flow. I'd say that the invisible text should count as implementation details and shouldn't affect user- visible results at all. What do you think? Paul On Sat, 27 Aug 2022 at 17:55, Eli Zaretskii wrote: > > From: Paul Pogonyshev > > Date: Sat, 27 Aug 2022 17:47:32 +0200 > > Cc: Eli Zaretskii , 57433@debbugs.gnu.org > > > > > Strange. Could you please double-check that you have commit > > > a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree? > > > > I have rebuilt Emacs and now it works. I previously tried with applying > > the patch from "In that case, can you see if the patch below solves the > > original issue with Magit?" locally, but apparently did something wrong. > > > > So yes, it works for me now, sorry. > > No need to be sorry, thanks for testing the fix. I'm therefore > closing the bug. > > > > I think you are reading too much into what that text says. It says > > > that point moves to the edge of such a sequence, and that is what > > > happens here. No more, no less. > > > > Yeah, I see now that if you move with C-b, the point disappears within > > the diff for the previous file, even with Emacs 28, and then Magit > > misbehaves. To be honest, I'm not sure if that is useful (or maybe there > > is some reason for moving "to the edge" rather than outside an > > invisible sequence), but that's certainly not a regression in Emacs. > > The "reason" is largely a side-effect of the implementation, I > suspect. > --00000000000028634105e73b39cd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> The "reason" is largely a side-effect of th= e implementation, I
> suspect.

Would it then n= ot be a good idea to improve it (not as part of this bug,
of cour= se)? E.g. currently the behavior is like below.

Se= tup: Magit buffer with staged files, at least two. It looks like this:

Staged changes (N)
modified=C2=A0 =C2=A0 fil= e1
[invisible diff of file1]
modified=C2=A0 =C2=A0= file2
[invisible diff of file2]

s= o essentially I, as a user, only see this in UI:

<= div>Staged changes (N)
modified=C2=A0 =C2=A0 file1
modi= fied=C2=A0 =C2=A0 file2

Now, = I put the point at the beginning of the third line ([^] is the point):

Staged changes (N)
modified=C2=A0 =C2= =A0 file1
[^]modified=C2=A0 =C2=A0 file2

=
I press C-b, expecting that the point is moved to the end of the
=
previous line that I see. But it is not moved there, this is the resul= t:

Staged changes (N)
modified=C2= =A0 =C2=A0 file1
[^]modified=C2=A0 =C2=A0 file2
In reality, the point is in the invisible (to me, as the = user) diff for file1.
If I press C-b again, only now point is mov= ed like I expected it to be
moved the last time:

Staged changes (N)
modified=C2=A0 =C2=A0 file1[^]
modified=C2=A0 =C2=A0 file2

So,= the presence of invisible text between lines 2 and 3 changes the
way C-b behaves and breaks my (as a user of Emacs) expectations,
disrupting established editing flow. I'd say that the invisible text
should count as implementation details and shouldn't affect us= er-
visible results at all.

What do you = think?

Paul

<= /div>
O= n Sat, 27 Aug 2022 at 17:55, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Paul Pogonyshev <pogonyshev@gmail.com>
> Date: Sat, 27 Aug 2022 17:47:32 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, 57433@debbugs.gnu.org
>
> > Strange.=C2=A0 Could you please double-check that you have commit=
> > a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree?
>
> I have rebuilt Emacs and now it works. I previously tried with applyin= g
> the patch from "In that case, can you see if the patch below solv= es the
> original issue with Magit?" locally, but apparently did something= wrong.
>
> So yes, it works for me now, sorry.

No need to be sorry, thanks for testing the fix.=C2=A0 I'm therefore closing the bug.

> > I think you are reading too much into what that text says.=C2=A0 = It says
> > that point moves to the edge of such a sequence, and that is what=
> > happens here.=C2=A0 No more, no less.
>
> Yeah, I see now that if you move with C-b, the point disappears within=
> the diff for the previous file, even with Emacs 28, and then Magit
> misbehaves. To be honest, I'm not sure if that is useful (or maybe= there
> is some reason for moving "to the edge" rather than outside = an
> invisible sequence), but that's certainly not a regression in Emac= s.

The "reason" is largely a side-effect of the implementation, I suspect.
--00000000000028634105e73b39cd-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 12:13:12 2022 Received: (at 57433-done) by debbugs.gnu.org; 27 Aug 2022 16:13:12 +0000 Received: from localhost ([127.0.0.1]:56902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyQp-00049Q-Fq for submit@debbugs.gnu.org; Sat, 27 Aug 2022 12:13:12 -0400 Received: from mail-ej1-f48.google.com ([209.85.218.48]:42807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyQm-00049B-HX for 57433-done@debbugs.gnu.org; Sat, 27 Aug 2022 12:13:09 -0400 Received: by mail-ej1-f48.google.com with SMTP id p16so5052680ejb.9 for <57433-done@debbugs.gnu.org>; Sat, 27 Aug 2022 09:13:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=qypG3DXy/4nYrG4HF8+MwJ+b/zh7VZHhJOWalZ5Ivl0=; b=VHlkrR4XITeNnGg6RL8Kb1QPvLZbBGK0CXry2NX3r15qRz4GCR4zjAyHocJiMjkBgX jbiOsQ6Tw5EmPGVYc5yYjJLK7Yg6i3yqagUd0HZ9P5ttuUG5GemUaf7J171SSw3Ga1g+ gTykOwHEq2jUHgMaz7QFSMNToItf+MyVOnKin2L/JAOAlxcOLF/m6P4HUvBIe2ZwCxS5 ILr7kkWa9tNCIKtgqXaG3uDx7+FaIMcQnV7EduwxcChY9XFwp2RkrUGoNqf0o2I4Yhrs qtCMUYnBpDxUJTvysoIdTTLvWotqRqXIOzyLWeeTS4cIcOtgpwjeZpipTVc6NZugSpB+ WmPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=qypG3DXy/4nYrG4HF8+MwJ+b/zh7VZHhJOWalZ5Ivl0=; b=nMUwAFNW9r2CwglDmHKE6Zr1F0KaWis76ro0dK0xGS5/ncOcJq9045Vw4j1qgvlLhg Xan9IqwlhiPWRQg/4oIItJvi9bS+BQOz++ePfte+/FxJmE1GVCX2whkxzgQwaKG6KdaC Bxb25egvgDs4b81uyE8vinFEVLiyrppImt67PK+fyFZNumTUz9RIEa9MQJWQEyhnykrb 17Qdn09zYbK0d1qY8bcwGOKOb5YanUhKne6LWtq6vMOPMx0kP8a8gHeR8EQCl/3YtVZU CxczE5bR7W3R37y/CVMGYmvhwt0nAQOO2iRweCY3xfpY/Dj5RQCxS5lk9k3oJ9Y/0MnS HRqA== X-Gm-Message-State: ACgBeo0t4K7uD+xs98kaQZUEsvgmsYSXg/+Egv0wpan4hJRtyuz6msFb 2SrOaa6IancRoDqQRI5XzXhsLPAoFH68YBFHwA== X-Google-Smtp-Source: AA6agR4YJwvtfqcAWwVZeZI7kPt1F7oPtJsumuIZQsDhc8kiLRcWQN/ErZn4jIIau/cbYzVfQgu1XDd2qPANIjPXG+c= X-Received: by 2002:a17:907:284a:b0:730:a1f1:38b5 with SMTP id el10-20020a170907284a00b00730a1f138b5mr8093845ejc.732.1661616781657; Sat, 27 Aug 2022 09:13:01 -0700 (PDT) MIME-Version: 1.0 References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> <83h71xznnn.fsf@gnu.org> In-Reply-To: From: Paul Pogonyshev Date: Sat, 27 Aug 2022 18:12:49 +0200 Message-ID: Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000060b5405e73b4e40" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433-done Cc: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , 57433-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000060b5405e73b4e40 Content-Type: text/plain; charset="UTF-8" Actually, disregard that. It appears to be a Magit bug. If I switch the buffer to any other mode, everything behaves as expected. Paul On Sat, 27 Aug 2022 at 18:06, Paul Pogonyshev wrote: > > The "reason" is largely a side-effect of the implementation, I > > suspect. > > Would it then not be a good idea to improve it (not as part of this bug, > of course)? E.g. currently the behavior is like below. > > Setup: Magit buffer with staged files, at least two. It looks like this: > > Staged changes (N) > modified file1 > [invisible diff of file1] > modified file2 > [invisible diff of file2] > > so essentially I, as a user, only see this in UI: > > Staged changes (N) > modified file1 > modified file2 > > Now, I put the point at the beginning of the third line ([^] is the point): > > Staged changes (N) > modified file1 > [^]modified file2 > > I press C-b, expecting that the point is moved to the end of the > previous line that I see. But it is not moved there, this is the result: > > Staged changes (N) > modified file1 > [^]modified file2 > > In reality, the point is in the invisible (to me, as the user) diff for > file1. > If I press C-b again, only now point is moved like I expected it to be > moved the last time: > > Staged changes (N) > modified file1[^] > modified file2 > > So, the presence of invisible text between lines 2 and 3 changes the > way C-b behaves and breaks my (as a user of Emacs) expectations, > disrupting established editing flow. I'd say that the invisible text > should count as implementation details and shouldn't affect user- > visible results at all. > > What do you think? > > Paul > > > On Sat, 27 Aug 2022 at 17:55, Eli Zaretskii wrote: > >> > From: Paul Pogonyshev >> > Date: Sat, 27 Aug 2022 17:47:32 +0200 >> > Cc: Eli Zaretskii , 57433@debbugs.gnu.org >> > >> > > Strange. Could you please double-check that you have commit >> > > a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree? >> > >> > I have rebuilt Emacs and now it works. I previously tried with applying >> > the patch from "In that case, can you see if the patch below solves the >> > original issue with Magit?" locally, but apparently did something wrong. >> > >> > So yes, it works for me now, sorry. >> >> No need to be sorry, thanks for testing the fix. I'm therefore >> closing the bug. >> >> > > I think you are reading too much into what that text says. It says >> > > that point moves to the edge of such a sequence, and that is what >> > > happens here. No more, no less. >> > >> > Yeah, I see now that if you move with C-b, the point disappears within >> > the diff for the previous file, even with Emacs 28, and then Magit >> > misbehaves. To be honest, I'm not sure if that is useful (or maybe there >> > is some reason for moving "to the edge" rather than outside an >> > invisible sequence), but that's certainly not a regression in Emacs. >> >> The "reason" is largely a side-effect of the implementation, I >> suspect. >> > --000000000000060b5405e73b4e40 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Actually, disregard that. It appears to be a Magit bug. If= I switch the buffer
to any other mode, everything behaves as expected.=

Paul

On Sat, 27 Aug 2022 at 18:06, Paul Pogo= nyshev <pogonyshev@gmail.com= > wrote:
> The "reason" is largely a side-effect of the im= plementation, I
> suspect.

Would it then not b= e a good idea to improve it (not as part of this bug,
of course)?= E.g. currently the behavior is like below.

Setup:= Magit buffer with staged files, at least two. It looks like this:

Staged changes (N)
modified=C2=A0 =C2=A0 file1
[invisible diff of file1]
modified=C2=A0 =C2=A0 fil= e2
[invisible diff of file2]

so es= sentially I, as a user, only see this in UI:

= Staged changes (N)
modified=C2=A0 =C2=A0 file1
modified= =C2=A0 =C2=A0 file2

Now, I pu= t the point at the beginning of the third line ([^] is the point):

Staged changes (N)
modified=C2=A0 =C2=A0 fi= le1
[^]modified=C2=A0 =C2=A0 file2

I= press C-b, expecting that the point is moved to the end of the
p= revious line that I see. But it is not moved there, this is the result:

Staged changes (N)
modified=C2=A0 =C2= =A0 file1
[^]modified=C2=A0 =C2=A0 file2

=
In reality, the point is in the invisible (to me, as the user) d= iff for file1.
If I press C-b again, only now point is moved like= I expected it to be
moved the last time:

Staged changes (N)
modified=C2=A0 =C2=A0 file1[^]
modified=C2=A0 =C2=A0 file2

So, the pr= esence of invisible text between lines 2 and 3 changes the
way C-= b behaves and breaks my (as a user of Emacs) expectations,
disrup= ting established editing flow. I'd say that the invisible text
should count as implementation details and shouldn't affect user-
visible results at all.

What do you think?<= /div>

Paul

On Sat, = 27 Aug 2022 at 17:55, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Paul Pogonyshev <pogonyshev@gmail.com>
> Date: Sat, 27 Aug 2022 17:47:32 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, 57433@debbugs.gnu.org
>
> > Strange.=C2=A0 Could you please double-check that you have commit=
> > a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree?
>
> I have rebuilt Emacs and now it works. I previously tried with applyin= g
> the patch from "In that case, can you see if the patch below solv= es the
> original issue with Magit?" locally, but apparently did something= wrong.
>
> So yes, it works for me now, sorry.

No need to be sorry, thanks for testing the fix.=C2=A0 I'm therefore closing the bug.

> > I think you are reading too much into what that text says.=C2=A0 = It says
> > that point moves to the edge of such a sequence, and that is what=
> > happens here.=C2=A0 No more, no less.
>
> Yeah, I see now that if you move with C-b, the point disappears within=
> the diff for the previous file, even with Emacs 28, and then Magit
> misbehaves. To be honest, I'm not sure if that is useful (or maybe= there
> is some reason for moving "to the edge" rather than outside = an
> invisible sequence), but that's certainly not a regression in Emac= s.

The "reason" is largely a side-effect of the implementation, I suspect.
--000000000000060b5405e73b4e40-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 12:25:48 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 16:25:49 +0000 Received: from localhost ([127.0.0.1]:56920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyd2-0004SN-GA for submit@debbugs.gnu.org; Sat, 27 Aug 2022 12:25:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyd0-0004SA-QG for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 12:25:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49992) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRycv-0004xi-G3; Sat, 27 Aug 2022 12:25:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DohV8KR0EIL08+629fT+J6Qeg0zJjVz7b/Ii9INV9xs=; b=mnMG7Muia0/IV1vU+gYG bBlRmeG36Ddqv8mZ6D1LGafyVCCkiUjFAMzZka3BwouW1rYWJ8+O6F2Wd2TFo9fj2pMdXNAQFmR/V nVqaGSGEhb4UGRYbLeZc9feHY9MpMEZW5rq+oXX8vmLXUDj3Rng90p0ku55qCZORj2t+rYBKexTn4 dP4vcsGKpelMPjge1Rui+tw0lpkU7rpqz47MLPKMKJqvK/kEe9/cEk7HOEXDEIWT36djF8s8BmHFQ 88zB5b2BXRJgNgs01BOe4iUEuFsxh1aNis9j6nLaphZIjUB5CQvoeCDJSZEx+Hzks/mNRBdWVr1dE JSX1gibYwH8nNw==; Received: from [87.69.77.57] (port=2209 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRycg-0006ry-Ml; Sat, 27 Aug 2022 12:25:36 -0400 Date: Sat, 27 Aug 2022 19:25:42 +0300 Message-Id: <83bks5zm9l.fsf@gnu.org> From: Eli Zaretskii To: Paul Pogonyshev In-Reply-To: (message from Paul Pogonyshev on Sat, 27 Aug 2022 18:06:59 +0200) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> <83h71xznnn.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433 Cc: gerd.moellmann@gmail.com, 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Paul Pogonyshev > Date: Sat, 27 Aug 2022 18:06:59 +0200 > Cc: Gerd Möllmann , > 57433-done@debbugs.gnu.org > > Setup: Magit buffer with staged files, at least two. It looks like this: > > Staged changes (N) > modified file1 > [invisible diff of file1] > modified file2 > [invisible diff of file2] > > so essentially I, as a user, only see this in UI: > > Staged changes (N) > modified file1 > modified file2 > > Now, I put the point at the beginning of the third line ([^] is the point): > > Staged changes (N) > modified file1 > [^]modified file2 > > I press C-b, expecting that the point is moved to the end of the > previous line that I see. But it is not moved there, this is the result: > > Staged changes (N) > modified file1 > [^]modified file2 > > In reality, the point is in the invisible (to me, as the user) diff for file1. > If I press C-b again, only now point is moved like I expected it to be > moved the last time: > > Staged changes (N) > modified file1[^] > modified file2 I cannot reproduce this, if I try to simulate it by having those 4 lines with two lines invisible. So I think there's something else at work here. If you can show a simple recipe that doesn't involve Magit, I can look into what happens there. (And it probably warrants a separate bug report.) What I did was to have this text: modified file1 [invisible diff of file1] modified file2 [invisible diff of file2] (without the indentation) in a buffer, and then I manually put the invisible text property on the 2nd and the 4th lines. Then I moved the cursor with C-b from the beginning of "modified file2", and the cursor was displayed at the end of the previous visible line, the one which says "modified file1". > So, the presence of invisible text between lines 2 and 3 changes the > way C-b behaves and breaks my (as a user of Emacs) expectations, > disrupting established editing flow. I'd say that the invisible text > should count as implementation details and shouldn't affect user- > visible results at all. > > What do you think? It works for me the way you expect it to work, so I'm not yet sure what's going on in the Magit buffer. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 12:29:05 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 16:29:05 +0000 Received: from localhost ([127.0.0.1]:56926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRygD-0004X3-6z for submit@debbugs.gnu.org; Sat, 27 Aug 2022 12:29:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRygB-0004WZ-Jp for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 12:29:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRyg4-0005Sm-6V; Sat, 27 Aug 2022 12:28:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=kibmKy1ixoY1wOzu2Kx/zX3gRxYD16QUltc1gNkHtJk=; b=rX3HK7UDSYgKxilqPusV j9WVehoPGyypL6DdK/ytyS/V39rs4WSkGhQ61dtu/soOrnM+e63aVWvkC/dL+2enEb+fO9WqBOqP2 1aOriqlNBLo41haeFkAonemFmqYpxQC6duPAhNekER6BgyyOkmdfiM+jLbQoGuon5OxLUEhcyUb3k DfZxzRTg0xaYQ2FL9ZMhSdhqE0O3kf7/iOxP2rSdKwxrNK5QPsg6jGS05f6dZ1IKTAeG527TiGFNJ /BxfBqvjMKFap+flpbsAXKrucpvtvJad2L4WjFccbLg4/n1Bc50nrLkfekV8DTYj9Ujsaqw7uQAge SYD/tLUYi6uGjQ==; Received: from [87.69.77.57] (port=2422 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRyg3-0003Sx-Ab; Sat, 27 Aug 2022 12:28:55 -0400 Date: Sat, 27 Aug 2022 19:29:12 +0300 Message-Id: <83a67pzm3r.fsf@gnu.org> From: Eli Zaretskii To: Paul Pogonyshev In-Reply-To: (message from Paul Pogonyshev on Sat, 27 Aug 2022 18:12:49 +0200) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> <83h71xznnn.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433 Cc: gerd.moellmann@gmail.com, 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Paul Pogonyshev > Date: Sat, 27 Aug 2022 18:12:49 +0200 > Cc: Gerd Möllmann , > 57433-done@debbugs.gnu.org > > Actually, disregard that. It appears to be a Magit bug. If I switch the buffer > to any other mode, everything behaves as expected. Right. I suspect that Magit puts something else there, not just the invisible property. What does describe-text-properties say at that point? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 12:32:36 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 16:32:36 +0000 Received: from localhost ([127.0.0.1]:56930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyjb-0004df-Oi for submit@debbugs.gnu.org; Sat, 27 Aug 2022 12:32:36 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:44771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyjZ-0004dR-6q for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 12:32:33 -0400 Received: by mail-ej1-f46.google.com with SMTP id kk26so8200882ejc.11 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 09:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=YHRDV6oxp5gV3xubs3vtnnMViBZZjXf2BdDDc+pxgOM=; b=jlunmYtK3H677Vrz1iiqHcDdHHFtFKHfjPfRlC1CiPzkAv66Gjy70YfGLq2jvnc+Zg 4LqVyX3ZTTK/Q7zZUKxOWRxSRC+XoeqwtVf4jMhSpEq1z895Jlb/b8cZ9X96y1TGoQdK PggO+6VafAbmuwqAjd1fieaRxeljmTj/VwZfvZZ4ANYdUB6IMpkFy9zTgij+LcR10S1S XcmU9hCyfoKkoihMsn4/nHEaG/TFWP9fLJV+y5SK93ssmndDzyn2dI75t2MISIhEi+uA xmAYm2VNTkzXxqeKZrktH5aUOGvVR5U9EFS2BL/G0fZvgMqxhYZsWF6sMZkm5VxrsiLG cEhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=YHRDV6oxp5gV3xubs3vtnnMViBZZjXf2BdDDc+pxgOM=; b=fopyS41cO3SxYOkzXRu1eFcaddNVHVYt1jjLGxayQ+rD/Ua3hfE/chGa0UJx7nL4/z 56syA1qXiC9SMu9hfsiGUe++lqlXJFKEPVjIWekekCFUDhHlr7erB4BVxndPbqD2euhE CNNCBayB4/XZ+Q29FlgA8RpuGzLfMTMb/M3H+1n1+DZBpGJPpDq7dhmyiK7ThP+L9XY2 fJfEvCS/UcqA5XsEHizUJHpo9Ku5TlT8qtFZ+33LdHrF8tcFQRFStEtTaOA0Ahp1TOKM yVK+4ES5d6SVdOA1k/RWTI7Rs989fGPkfK01+/E53tD8p4wmJo7LjTtL+PaRQe2phWT8 zgyA== X-Gm-Message-State: ACgBeo35okqg3ozy6S0vj2dt1tBxRarIUwUjH/CL1QguLlPh3NWFJQ/S 117iu0a8esqcYgav1QXF1z0CZTkaU0WR1TXgYw== X-Google-Smtp-Source: AA6agR6+2Cuvv4Aw8epasKAk0cDSY+A3yj1L/eTayjOaCMkt4oGgy45Vs3rRRKvdn4IBm+7ICQ0LwngMZ+4MukFJb9U= X-Received: by 2002:a17:906:8472:b0:741:5bf7:916d with SMTP id hx18-20020a170906847200b007415bf7916dmr866337ejc.57.1661617947406; Sat, 27 Aug 2022 09:32:27 -0700 (PDT) MIME-Version: 1.0 References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> <83h71xznnn.fsf@gnu.org> <83a67pzm3r.fsf@gnu.org> In-Reply-To: <83a67pzm3r.fsf@gnu.org> From: Paul Pogonyshev Date: Sat, 27 Aug 2022 18:32:15 +0200 Message-ID: Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000081f5ad05e73b934e" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000081f5ad05e73b934e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Now, I put the point at the beginning of the third line ([^] is the point): Text content at position 32867: There is an overlay here: From 32867 to 32901 evaporate t font-lock-face magit-diff-file-heading-highlight There are text properties here: font-lock-face magit-diff-file-heading keymap [Show] magit-section [Show] > I press C-b, expecting that the point is moved to the end of the > previous line that I see. But it is not moved there Text content at position 29881: There is an overlay here: From 29881 to 32867 evaporate t invisible t There are text properties here: font-lock-face magit-diff-hunk-heading keymap [Show] magit-section [Show] > If I press C-b again, only now point is moved Text content at position 29880: There is an overlay here: From 29858 to 29881 evaporate t font-lock-face magit-diff-file-heading-highlight There are text properties here: keymap [Show] magit-section [Show] Paul On Sat, 27 Aug 2022 at 18:28, Eli Zaretskii wrote: > > From: Paul Pogonyshev > > Date: Sat, 27 Aug 2022 18:12:49 +0200 > > Cc: Gerd M=C3=B6llmann , > > 57433-done@debbugs.gnu.org > > > > Actually, disregard that. It appears to be a Magit bug. If I switch the > buffer > > to any other mode, everything behaves as expected. > > Right. I suspect that Magit puts something else there, not just the > invisible property. What does describe-text-properties say at that > point? > --00000000000081f5ad05e73b934e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Now, I put the point at the beginning of the third li= ne ([^] is the point):

Text content at position 3286= 7:

There is an overlay here:
=C2=A0From 32867 to 32901
=C2=A0 = evaporate =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0t
=C2=A0 font-lock-fa= ce =C2=A0 =C2=A0 =C2=A0 magit-diff-file-heading-highlight

There are = text properties here:
=C2=A0 font-lock-face =C2=A0 =C2=A0 =C2=A0 magit-d= iff-file-heading
=C2=A0 keymap =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 [Show]
=C2=A0 magit-section =C2=A0 =C2=A0 =C2=A0 =C2=A0[Show]
> I press C-b, expecting that the point is moved to the end of= the
> previous line that I see. But it is not moved there

Text content at position 29881:

There is= an overlay here:
=C2=A0From 29881 to 32867
=C2=A0 evaporate =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0t
=C2=A0 invisible =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0t

There are text properties here:
=C2=A0 = font-lock-face =C2=A0 =C2=A0 =C2=A0 magit-diff-hunk-heading
=C2=A0 keyma= p =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [Show]
=C2=A0 magit-s= ection =C2=A0 =C2=A0 =C2=A0 =C2=A0[Show]

> = If I press C-b again, only now point is moved

= Text content at position 29880:

There is an overlay here:
=C2=A0F= rom 29858 to 29881
=C2=A0 evaporate =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0t
=C2=A0 font-lock-face =C2=A0 =C2=A0 =C2=A0 magit-diff-file-headi= ng-highlight

There are text properties here:
=C2=A0 keymap =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [Show]
=C2=A0 magit-section = =C2=A0 =C2=A0 =C2=A0 =C2=A0[Show]

Paul

On= Sat, 27 Aug 2022 at 18:28, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Paul Pogonyshev <pogonyshev@gmail.com>
> Date: Sat, 27 Aug 2022 18:12:49 +0200
> Cc: Gerd M=C3=B6llmann <gerd.moellmann@gmail.com>,
>=C2=A0 =C2=A0 =C2=A0 =C2=A057433-done@debbugs.gnu.org
>
> Actually, disregard that. It appears to be a Magit bug. If I switch th= e buffer
> to any other mode, everything behaves as expected.

Right.=C2=A0 I suspect that Magit puts something else there, not just the invisible property.=C2=A0 What does describe-text-properties say at that point?
--00000000000081f5ad05e73b934e-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 12:37:44 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 16:37:44 +0000 Received: from localhost ([127.0.0.1]:56934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyoZ-0004kg-M4 for submit@debbugs.gnu.org; Sat, 27 Aug 2022 12:37:44 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:33690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRyoW-0004kR-1X for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 12:37:42 -0400 Received: by mail-ej1-f47.google.com with SMTP id cu2so8313959ejb.0 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 09:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=/blMuOTKfVYCm/+bBZGFxXOOeX6azbWM29P8dxm5aU4=; b=lMRGwU+SHH8WFVtj7yP7ofQXpYhOF8w0IJQ3QU6vF02wBvW2dM9sy3YaXAyMXvu9Y3 zk30AbYo9iO6HV2QCrSyQj1CIsQ+28cuLd4+ZubrltSv6I1w0Jo5ygyZJMWyYUQVRp2m E66nxfkZkwyTMOa33NNC7NpkyhW+mV8kxB0oBishJKneEnkr3/9WReUF58BgSIv+ORS2 SqdsykIYKssYIKBbCrh2xUZ50mr7Cake99ctjgxcJmB3IKb7xBcD1EAXjk8GvWk/Cd6U 31SVSniE9vq1SfsGKRgiOjDBoIm2HEhNXRC1j7Y8Sm09/FauUqLhJycXuNK8TypQJVQT ETjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=/blMuOTKfVYCm/+bBZGFxXOOeX6azbWM29P8dxm5aU4=; b=k9JthK3kzT4BN1RzZ8PkQNX2OgL2lb6owvSVaYfgB2XGWkXC2McTNFVH/AQu29oW78 9oZ71FRBhvxt1jAeuhF+Lj5Wp63vtQHQZ5pGQtR2t/tk75BW8i5bn6S9Cao1jof6YES0 bH7ARA4/euvgb+AsDY7em0AYGztng3cSH3916eay+5skUaVoTZvN4+gPaWYI2Te3o4Ar 1niT1XadIQWAG31ZHKDbfWvJYNdGHuwvu+nQTWjDTLoMzqenQmHjxQk3lRFkb9ZERk6j avNCXW2OwNfra2nK1Ce7aPmGhRmpP2L5sjfho96ckUAeP3/bt6LnjA6wELaqvMy8ah8B yw0g== X-Gm-Message-State: ACgBeo27nWC/5th29a94POlEhNLlRj9UgV8wsbVXOlhl0jpAsUpZywdD N91N4KKdmFWbg9Ahzw3s4yHUZAh+5C70FDwlIQ== X-Google-Smtp-Source: AA6agR4mxH3Db1l7IM7WSNHsgoNY/92ZNgtfVd2FbmRgd1mEmB0WgerZh4kxU9pk0PQHhH0vHEi3BB2j3BPfAoX6bD0= X-Received: by 2002:a17:907:b10:b0:73d:bedd:3121 with SMTP id h16-20020a1709070b1000b0073dbedd3121mr8200408ejl.530.1661618254231; Sat, 27 Aug 2022 09:37:34 -0700 (PDT) MIME-Version: 1.0 References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> <83h71xznnn.fsf@gnu.org> <83a67pzm3r.fsf@gnu.org> In-Reply-To: From: Paul Pogonyshev Date: Sat, 27 Aug 2022 18:37:22 +0200 Message-ID: Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000cbc08b05e73ba5e1" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000cbc08b05e73ba5e1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Also, the value of `magit-section' is different all three times, if that's important. Paul On Sat, 27 Aug 2022 at 18:32, Paul Pogonyshev wrote: > > Now, I put the point at the beginning of the third line ([^] is the > point): > > Text content at position 32867: > > There is an overlay here: > From 32867 to 32901 > evaporate t > font-lock-face magit-diff-file-heading-highlight > > There are text properties here: > font-lock-face magit-diff-file-heading > keymap [Show] > magit-section [Show] > > > I press C-b, expecting that the point is moved to the end of the > > previous line that I see. But it is not moved there > > Text content at position 29881: > > There is an overlay here: > From 29881 to 32867 > evaporate t > invisible t > > There are text properties here: > font-lock-face magit-diff-hunk-heading > keymap [Show] > magit-section [Show] > > > If I press C-b again, only now point is moved > > Text content at position 29880: > > There is an overlay here: > From 29858 to 29881 > evaporate t > font-lock-face magit-diff-file-heading-highlight > > There are text properties here: > keymap [Show] > magit-section [Show] > > Paul > > On Sat, 27 Aug 2022 at 18:28, Eli Zaretskii wrote: > >> > From: Paul Pogonyshev >> > Date: Sat, 27 Aug 2022 18:12:49 +0200 >> > Cc: Gerd M=C3=B6llmann , >> > 57433-done@debbugs.gnu.org >> > >> > Actually, disregard that. It appears to be a Magit bug. If I switch th= e >> buffer >> > to any other mode, everything behaves as expected. >> >> Right. I suspect that Magit puts something else there, not just the >> invisible property. What does describe-text-properties say at that >> point? >> > --000000000000cbc08b05e73ba5e1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Also, the value of `magit-section' is different all th= ree times, if that's important.

Paul

=
On Sat, 27= Aug 2022 at 18:32, Paul Pogonyshev <pogonyshev@gmail.com> wrote:
> Now, I put the point at the = beginning of the third line ([^] is the point):

Text= content at position 32867:

There is an overlay here:
=C2=A0From = 32867 to 32901
=C2=A0 evaporate =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0t
=C2=A0 font-lock-face =C2=A0 =C2=A0 =C2=A0 magit-diff-file-heading-= highlight

There are text properties here:
=C2=A0 font-lock-face = =C2=A0 =C2=A0 =C2=A0 magit-diff-file-heading
=C2=A0 keymap =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [Show]
=C2=A0 magit-section =C2=A0 = =C2=A0 =C2=A0 =C2=A0[Show]

> I press C-b, expecting that the= point is moved to the end of the
> previous line that I see. = But it is not moved there

Text content at po= sition 29881:

There is an overlay here:
=C2=A0From 29881 to 32867=
=C2=A0 evaporate =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0t
=C2=A0 i= nvisible =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0t

There are text p= roperties here:
=C2=A0 font-lock-face =C2=A0 =C2=A0 =C2=A0 magit-diff-hu= nk-heading
=C2=A0 keymap =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 [Show]
=C2=A0 magit-section =C2=A0 =C2=A0 =C2=A0 =C2=A0[Show]

> If I press C-b again, only now point is moved

Text content at position 29880:

There is= an overlay here:
=C2=A0From 29858 to 29881
=C2=A0 evaporate =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0t
=C2=A0 font-lock-face =C2=A0 =C2=A0 = =C2=A0 magit-diff-file-heading-highlight

There are text properties h= ere:
=C2=A0 keymap =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [Sho= w]
=C2=A0 magit-section =C2=A0 =C2=A0 =C2=A0 =C2=A0[Show]
=
Paul

On Sat, 27 Aug 2022 at 18:28, Eli Zaretskii <eliz@gnu.org> wrote:=
> From: Paul= Pogonyshev <p= ogonyshev@gmail.com>
> Date: Sat, 27 Aug 2022 18:12:49 +0200
> Cc: Gerd M=C3=B6llmann <gerd.moellmann@gmail.com>,
>=C2=A0 =C2=A0 =C2=A0 =C2=A057433-done@debbugs.gnu.org
>
> Actually, disregard that. It appears to be a Magit bug. If I switch th= e buffer
> to any other mode, everything behaves as expected.

Right.=C2=A0 I suspect that Magit puts something else there, not just the invisible property.=C2=A0 What does describe-text-properties say at that point?
--000000000000cbc08b05e73ba5e1-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 12:56:40 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 16:56:41 +0000 Received: from localhost ([127.0.0.1]:56957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRz6u-0005GC-LE for submit@debbugs.gnu.org; Sat, 27 Aug 2022 12:56:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRz6r-0005Fz-Vt for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 12:56:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46336) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRz6m-00018h-OQ; Sat, 27 Aug 2022 12:56:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=1aSC8g2QZXiDUAA0C4gNoW4qOWVdCqbGKzXdhZW2bhY=; b=lR0PMfDnm1EXJDM8jyTw fNMyZ6bx6OsWxK5eEuHzus0/T8WVQt8ZGF+fd5pENua/4/Ih9B+PZur/fGS0PaowIO0FZFGVT005c VvhGBU5v+j22CcErsVqp7MZOhfwM8eUsi9iYLA8VXW/6KTl4p4J0ueXY0cXheoFAQEgoFxe5zVnTD VLPX/YdMNpR+J5qHbC8hE3I8+A98xEVFvUP4DCRCzXBTVQP8MgAnrvhumP/vzjZscBeT322QIpNna FRqU+2YS9eqMXoX9uT7L57h3cgRj3y/oA7NjSlieIysF/1CI+k8THxy5nOIf7QzLcp+5Jcx7oxjYu TdawYFnE6PRjdQ==; Received: from [87.69.77.57] (port=4112 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRz6m-0005FS-4Z; Sat, 27 Aug 2022 12:56:32 -0400 Date: Sat, 27 Aug 2022 19:56:48 +0300 Message-Id: <838rn9zktr.fsf@gnu.org> From: Eli Zaretskii To: Paul Pogonyshev In-Reply-To: (message from Paul Pogonyshev on Sat, 27 Aug 2022 18:32:15 +0200) Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> <83h71xznnn.fsf@gnu.org> <83a67pzm3r.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57433 Cc: gerd.moellmann@gmail.com, 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Paul Pogonyshev > Date: Sat, 27 Aug 2022 18:32:15 +0200 > Cc: Gerd Möllmann , > 57433@debbugs.gnu.org > > > Now, I put the point at the beginning of the third line ([^] is the point): > > Text content at position 32867: > > There is an overlay here: > From 32867 to 32901 > evaporate t > font-lock-face magit-diff-file-heading-highlight > > There are text properties here: > font-lock-face magit-diff-file-heading > keymap [Show] > magit-section [Show] Maybe the 'keymap' part? Could it be that C-b has a binding in that keymap? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 13:02:12 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 17:02:12 +0000 Received: from localhost ([127.0.0.1]:56963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRzCG-0005Pm-CC for submit@debbugs.gnu.org; Sat, 27 Aug 2022 13:02:12 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:38679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRzCD-0005Pa-Fz for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 13:02:11 -0400 Received: by mail-ed1-f48.google.com with SMTP id a36so1710511edf.5 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 10:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=F1ZSeWWZuNmu/7SLKrGOxIlaD0YwPysQ/j+n4bs3iwo=; b=IfYfFSVKLYE8g/56V777YmZUIDdkl0Px/FOu+wCJ8yAGMPsEttayJd6mPPh0cW+YLG vvKVYp/ovrfm47USax9aWj7eaSs2fz6SY+m97u3hP+cefAkHmABC6ePkJpbXiv9P9bH8 lcC8QJAebddhyugskmWc6RLM42OSiRHdW8Kl17aSDBDT7kW7Y1e1EBVEMH4fmS5ncBAH RuNoYFiUeyBK6lbTgR/sN87ws5ND+szW9K3O3drpZDYpnWE1XAfAiak8tCVltesScw/D sxsjzobhSp3C2k01XmfTEeG9qqNixc3h8eTKATY1RkpjnQhz9tirpPzvVt2MuM+lpsUR RDlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=F1ZSeWWZuNmu/7SLKrGOxIlaD0YwPysQ/j+n4bs3iwo=; b=dtLRqSb1XoNh5frKvnaXR6rUEfs/cE+V0k0h7Z8UHnVb5GlHwfqQVFiRnhO9mt9kyO rvapoy9cvxcYlbSxXULBgsFW7ZDDC11sbFn9N0DgtBypgLX0YHVrAAR/N+B3pH0xsORt fPRizgqRFF5J/H7Xg6vGoU7aEJSpEFetEX63PLxePzzefUL8HEUD80CQTSWEDQs+oTRn Gcjf+OuWFDCukjudpFkOFILu2GUovnWRAKZvtlktkBeIsUQ4TQNw095tzxcOozWFWuQ8 nSZvdkcMFTGM63SebqdBqHdmjuH5ypLUwq+2c5pMRnP3/FcAwF8iKctKNH4DhvvnIBpc LPNg== X-Gm-Message-State: ACgBeo28mz58gv3o4xfk4xLhB2sFT4K2S9Ea6zR/xlUd8XGrML5Wjs/H pjtIMzXwe+ZohhlWRfbBPct8afNzhHZ6QbXkgg== X-Google-Smtp-Source: AA6agR7B67lzDWIx8AbkSH+kbaXdthTD/QBQlfindfACpUzKLPGaWwK77nLrZBd7bFfrDW/Ip672Jqn6tXmCN0Y51fU= X-Received: by 2002:a05:6402:35d5:b0:43d:a02f:cbfb with SMTP id z21-20020a05640235d500b0043da02fcbfbmr10213725edc.275.1661619723560; Sat, 27 Aug 2022 10:02:03 -0700 (PDT) MIME-Version: 1.0 References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> <83h71xznnn.fsf@gnu.org> <83a67pzm3r.fsf@gnu.org> <838rn9zktr.fsf@gnu.org> In-Reply-To: <838rn9zktr.fsf@gnu.org> From: Paul Pogonyshev Date: Sat, 27 Aug 2022 19:01:51 +0200 Message-ID: Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000005febc205e73bfd0c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005febc205e73bfd0c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable There is no mode binding (`C-h k C-b' returns `backward-char'). I don't kno= w how to read this (result of showing the keymap in `describe-text-properties= ' buffer; at step 1: (keymap keymap (3 keymap (5 . magit-diff-edit-hunk-commit) (20 . magit-diff-trace-definition)) (67 . magit-commit-add-log) (38 . magit-do-async-shell-command) (117 . magit-unstage) (115 . magit-stage) (97 . magit-apply) (remap keymap (magit-revert-no-commit . magit-reverse) (magit-delete-thing . magit-discard) (magit-visit-thing . magit-diff-visit-file)) (24 keymap (97 . magit-add-change-log-entry) (53 keymap (return . magit-diff-visit-file-other-frame)) (52 keymap (97 . magit-add-change-log-entry-other-window) (return . magit-diff-visit-file-other-window))) (C-return . magit-diff-visit-worktree-file) (10 . magit-diff-visit-worktree-file)) At step 2: (keymap (3 keymap (94 keymap (108 . magit-smerge-keep-lower) (98 . magit-smerge-keep-base) (117 . magit-smerge-keep-upper) (13 . magit-smerge-keep-current))) keymap (3 keymap (5 . magit-diff-edit-hunk-commit) (20 . magit-diff-trace-definition)) (67 . magit-commit-add-log) (38 . magit-do-async-shell-command) (117 . magit-unstage) (115 . magit-stage) (97 . magit-apply) (remap keymap (magit-revert-no-commit . magit-reverse) (magit-delete-thing . magit-discard) (magit-visit-thing . magit-diff-visit-file)) (24 keymap (97 . magit-add-change-log-entry) (53 keymap (return . magit-diff-visit-file-other-frame)) (52 keymap (97 . magit-add-change-log-entry-other-window) (return . magit-diff-visit-file-other-window))) (C-return . magit-diff-visit-worktree-file) Paul (10 . magit-diff-visit-worktree-file)) On Sat, 27 Aug 2022 at 18:56, Eli Zaretskii wrote: > > From: Paul Pogonyshev > > Date: Sat, 27 Aug 2022 18:32:15 +0200 > > Cc: Gerd M=C3=B6llmann , > > 57433@debbugs.gnu.org > > > > > Now, I put the point at the beginning of the third line ([^] is the > point): > > > > Text content at position 32867: > > > > There is an overlay here: > > From 32867 to 32901 > > evaporate t > > font-lock-face magit-diff-file-heading-highlight > > > > There are text properties here: > > font-lock-face magit-diff-file-heading > > keymap [Show] > > magit-section [Show] > > Maybe the 'keymap' part? Could it be that C-b has a binding in that > keymap? > --0000000000005febc205e73bfd0c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
There is no mode binding (`C-h k C-b' returns `backwar= d-char'). I don't know
how to read this (result of showing the = keymap in `describe-text-properties'
buffer; at step 1:
=

(keymap keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (3 keymap=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(5 . magit-diff-edit-hunk-comm= it)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(20 . magit-diff-trace-defi= nition))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (67 . magit-commit-add-log)
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 (38 . magit-do-async-shell-command)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 (117 . magit-unstage)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (115= . magit-stage)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (97 . magit-apply)
=C2=A0= =C2=A0 =C2=A0 =C2=A0 (remap keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(magit-revert-no-commit . magit-reverse)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(magit-delete-thing . magit-di= scard)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(magit-vis= it-thing . magit-diff-visit-file))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (24 keyma= p
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (97 . magit-add-change-log-e= ntry)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (53 keymap
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (return . magit-diff-visit-fi= le-other-frame))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (52 keymap=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (97 . magit-add-ch= ange-log-entry-other-window)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 (return . magit-diff-visit-file-other-window)))
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 (C-return . magit-diff-visit-worktree-file)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 (10 . magit-diff-visit-worktree-file))

=
At step 2:

(keymap
=C2=A0(3 keymap=C2=A0 =C2=A0 (94 keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (108 . magit-smer= ge-keep-lower)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (98 . magit-smerge-keep-base)=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (117 . magit-smerge-keep-upper)
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 (13 . magit-smerge-keep-current)))
=C2=A0keymap
= =C2=A0(3 keymap
=C2=A0 =C2=A0 (5 . magit-diff-edit-hunk-commit)
=C2= =A0 =C2=A0 (20 . magit-diff-trace-definition))
=C2=A0(67 . magit-commit-= add-log)
=C2=A0(38 . magit-do-async-shell-command)
=C2=A0(117 . magit= -unstage)
=C2=A0(115 . magit-stage)
=C2=A0(97 . magit-apply)
=C2= =A0(remap keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (magit-revert-no-commit . m= agit-reverse)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (magit-delete-thing . magit-di= scard)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (magit-visit-thing . magit-diff-visit= -file))
=C2=A0(24 keymap
=C2=A0 =C2=A0 =C2=A0(97 . magit-add-change-l= og-entry)
=C2=A0 =C2=A0 =C2=A0(53 keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(return . magit-diff-visit-file-other-frame))
=C2=A0 =C2=A0 =C2=A0= (52 keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(97 . magit-add-change-log-= entry-other-window)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(return . magit-di= ff-visit-file-other-window)))
=C2=A0(C-return . magit-diff-visit-worktre= e-file)

Paul
=C2=A0(10 . magit-diff-visit-workt= ree-file))

On Sat, 27 Aug 2022 at 18:56, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Paul Pogonyshev <pogonyshev@gmail.com= >
> Date: Sat, 27 Aug 2022 18:32:15 +0200
> Cc: Gerd M=C3=B6llmann <gerd.moellmann@gmail.com>,
>=C2=A0 =C2=A0 =C2=A0 =C2=A057433@debbugs.gnu.org
>
> > Now, I put the point at the beginning of the third line ([^] is t= he point):
>
> Text content at position 32867:
>
> There is an overlay here:
>=C2=A0 From 32867 to 32901
>=C2=A0 =C2=A0evaporate=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 t
>=C2=A0 =C2=A0font-lock-face=C2=A0 =C2=A0 =C2=A0 =C2=A0magit-diff-file-h= eading-highlight
>
> There are text properties here:
>=C2=A0 =C2=A0font-lock-face=C2=A0 =C2=A0 =C2=A0 =C2=A0magit-diff-file-h= eading
>=C2=A0 =C2=A0keymap=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0[Show]
>=C2=A0 =C2=A0magit-section=C2=A0 =C2=A0 =C2=A0 =C2=A0 [Show]

Maybe the 'keymap' part?=C2=A0 Could it be that C-b has a binding i= n that
keymap?
--0000000000005febc205e73bfd0c-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 13:11:53 2022 Received: (at 57433) by debbugs.gnu.org; 27 Aug 2022 17:11:53 +0000 Received: from localhost ([127.0.0.1]:56976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRzLc-0005dD-Gz for submit@debbugs.gnu.org; Sat, 27 Aug 2022 13:11:53 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:38536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRzLa-0005cz-QM for 57433@debbugs.gnu.org; Sat, 27 Aug 2022 13:11:51 -0400 Received: by mail-ej1-f46.google.com with SMTP id u9so8347290ejy.5 for <57433@debbugs.gnu.org>; Sat, 27 Aug 2022 10:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=G8+f4EVT/xPSGlgpbPpTDW69n213u6m6x0YLkSjup4s=; b=jTjjpnLFRCdCcSxCMlCJgT6vgj4ECrYTR8B7npFrGWll72COHPLdI7BhaB0xn7zNtX nCzJ7QcmgiyxkquuqglHU+wOQX/Me4uNY+oNty5SIxHF8athx5GEEAAkrSEFMEFkouIu G4k6YTzawAKxCltz6wOWvtGEA/2ejRhahqLbq3Qyve+mBpxQMGeI8+OcwVVZPDUBjLLC 0ItijBxI0DCWSrX4Mxop11AMYjImdc79TLprlcYY/obXJ/qlA7rW79v9KNSNN2mcjU0Z MSN0StxegEJtTF5UHzQrlrtmIR/0yqOLPS9R2Iud3MgAbruu6BYAkm8CA/dv6FLLrEWS O/bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=G8+f4EVT/xPSGlgpbPpTDW69n213u6m6x0YLkSjup4s=; b=eK9hdqzGZiUXFXP0PETpfpPgUy5EDRQ4HeG1TYHOvmZi5bFzOVmS2Qa19//ajQSsPJ D//hYqgWNIZxsrMSJ28HVA2vS5jkdf6h0C/PpKiUvW/NMlTRzrBqYgsRchmS2DAKopBJ dxVfyEcpprGgc3hmxr/KcG3LViNUJDiddMH/3sQJ6bzJsYfjbvhBx7Ma2KbYICP1sgNu cpNXjgz0Oz3vW3GnmBPNuXvicOdId3VhQjC/v/Pg1xhM9GOJgtPaarf8OXnExuMHig+i 4NgJBqUmNMHEQEc0r1eCjNgAyoLqxehw6L/3EcYTlRkrFSEfAtytGclcPXnIcC8D5rak /a4A== X-Gm-Message-State: ACgBeo0jJwE5KjhnIISASzhvFJBX9MqoHhIE0U2WXNA/jo13B51VEPYt W66KM/5unoBF4ZpXcMJ6MzVu7j9LfqEzc/V4IQ== X-Google-Smtp-Source: AA6agR4KsY2gFO9VhjWyhkbnyZu+rfZ8yonQ4WsA92YBp7eOIW4S3cr42nar2HrGa1cbHXq3fk594zrB6htf4GEfCdQ= X-Received: by 2002:a17:907:7243:b0:733:2c:14cf with SMTP id ds3-20020a170907724300b00733002c14cfmr8602688ejc.485.1661620304808; Sat, 27 Aug 2022 10:11:44 -0700 (PDT) MIME-Version: 1.0 References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> <83h71xznnn.fsf@gnu.org> <83a67pzm3r.fsf@gnu.org> <838rn9zktr.fsf@gnu.org> In-Reply-To: From: Paul Pogonyshev Date: Sat, 27 Aug 2022 19:11:33 +0200 Message-ID: Subject: Re: bug#57433: Emacs no longer moves point into visible port of the buffer To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000050e5505e73c208f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57433 Cc: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , 57433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000050e5505e73c208f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable By the way, here is a simple way to test Magit without installing it in you= r Emacs. However, you will need Eldev (external relative to Emacs). 1. Install Eldev (https://github.com/doublep/eldev#installation) 2. Check out Magit sources, e.g. to `~/git/magit' 3. Run `$ cd ~/git/magit/*lisp*' (I don't know why they have this layout) 4. Create file `Eldev-local' with the following contents (since the project doesn't use Eldev, you have to do this manually): (setf eldev-project-main-file "magit.el") (eldev-use-package-archive 'gnu-elpa) (eldev-use-package-archive 'melpa) 5. Run e.g. like this: `$ eldev emacs --eval "(magit-status-setup-buffer \"~/emacs\")" ', assuming `~/emacs' is a Git checkout you work on. Paul On Sat, 27 Aug 2022 at 19:01, Paul Pogonyshev wrote: > There is no mode binding (`C-h k C-b' returns `backward-char'). I don't > know > how to read this (result of showing the keymap in > `describe-text-properties' > buffer; at step 1: > > (keymap keymap > (3 keymap > (5 . magit-diff-edit-hunk-commit) > (20 . magit-diff-trace-definition)) > (67 . magit-commit-add-log) > (38 . magit-do-async-shell-command) > (117 . magit-unstage) > (115 . magit-stage) > (97 . magit-apply) > (remap keymap > (magit-revert-no-commit . magit-reverse) > (magit-delete-thing . magit-discard) > (magit-visit-thing . magit-diff-visit-file)) > (24 keymap > (97 . magit-add-change-log-entry) > (53 keymap > (return . magit-diff-visit-file-other-frame)) > (52 keymap > (97 . magit-add-change-log-entry-other-window) > (return . magit-diff-visit-file-other-window))) > (C-return . magit-diff-visit-worktree-file) > (10 . magit-diff-visit-worktree-file)) > > At step 2: > > (keymap > (3 keymap > (94 keymap > (108 . magit-smerge-keep-lower) > (98 . magit-smerge-keep-base) > (117 . magit-smerge-keep-upper) > (13 . magit-smerge-keep-current))) > keymap > (3 keymap > (5 . magit-diff-edit-hunk-commit) > (20 . magit-diff-trace-definition)) > (67 . magit-commit-add-log) > (38 . magit-do-async-shell-command) > (117 . magit-unstage) > (115 . magit-stage) > (97 . magit-apply) > (remap keymap > (magit-revert-no-commit . magit-reverse) > (magit-delete-thing . magit-discard) > (magit-visit-thing . magit-diff-visit-file)) > (24 keymap > (97 . magit-add-change-log-entry) > (53 keymap > (return . magit-diff-visit-file-other-frame)) > (52 keymap > (97 . magit-add-change-log-entry-other-window) > (return . magit-diff-visit-file-other-window))) > (C-return . magit-diff-visit-worktree-file) > > Paul > (10 . magit-diff-visit-worktree-file)) > > On Sat, 27 Aug 2022 at 18:56, Eli Zaretskii wrote: > >> > From: Paul Pogonyshev >> > Date: Sat, 27 Aug 2022 18:32:15 +0200 >> > Cc: Gerd M=C3=B6llmann , >> > 57433@debbugs.gnu.org >> > >> > > Now, I put the point at the beginning of the third line ([^] is the >> point): >> > >> > Text content at position 32867: >> > >> > There is an overlay here: >> > From 32867 to 32901 >> > evaporate t >> > font-lock-face magit-diff-file-heading-highlight >> > >> > There are text properties here: >> > font-lock-face magit-diff-file-heading >> > keymap [Show] >> > magit-section [Show] >> >> Maybe the 'keymap' part? Could it be that C-b has a binding in that >> keymap? >> > --000000000000050e5505e73c208f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
By the way, here is a simple way to test Magit without ins= talling it in your
Emacs. However, you will need Eldev (external relati= ve to Emacs).


2. Check out Magit sources, e.g. t= o `~/git/magit'

3. Run `$ cd ~/git/magit/li= sp' (I don't know why they have this layout)

4. Create file `Eldev-local' with the following contents (since = the
project doesn't use Eldev, you have to do this manually):=

(setf eldev-project-main-file "magit.el"= ;)
(eldev-use-package-archive 'gnu-elpa)
(eldev-use-package-archi= ve 'melpa)

5. Run e.g. like this: `$=C2=A0= eldev emacs --eval "(magit-status-setup-buffer \"~/emacs\")&= quot; ',
assuming `~/emacs' is a Git checkout you work on= .

Paul

<= div dir=3D"ltr" class=3D"gmail_attr">On Sat, 27 Aug 2022 at 19:01, Paul Pog= onyshev <pogonyshev@gmail.com> wrote:
There is no mode binding (`C-h k C-b' returns `backward-c= har'). I don't know
how to read this (result of showing the key= map in `describe-text-properties'
buffer; at step 1:

(keymap keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (3 keymap=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(5 . magit-diff-edit-hunk-commit)=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(20 . magit-diff-trace-definit= ion))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (67 . magit-commit-add-log)
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 (38 . magit-do-async-shell-command)
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 (117 . magit-unstage)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (115 . m= agit-stage)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (97 . magit-apply)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 (remap keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(magit-revert-no-commit . magit-reverse)
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(magit-delete-thing . magit-discar= d)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(magit-visit-t= hing . magit-diff-visit-file))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (24 keymap=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (97 . magit-add-change-log-entry= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (53 keymap
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (return . magit-diff-visit-file-o= ther-frame))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (52 keymap
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (97 . magit-add-change= -log-entry-other-window)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 (return . magit-diff-visit-file-other-window)))
=C2=A0 =C2=A0= =C2=A0 =C2=A0 (C-return . magit-diff-visit-worktree-file)
=C2=A0 =C2=A0= =C2=A0 =C2=A0 (10 . magit-diff-visit-worktree-file))

At step 2:

(keymap
=C2=A0(3 keymap
= =C2=A0 =C2=A0 (94 keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (108 . magit-smerge= -keep-lower)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (98 . magit-smerge-keep-base)=C2=A0 =C2=A0 =C2=A0 =C2=A0 (117 . magit-smerge-keep-upper)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 (13 . magit-smerge-keep-current)))
=C2=A0keymap
=C2= =A0(3 keymap
=C2=A0 =C2=A0 (5 . magit-diff-edit-hunk-commit)
=C2=A0 = =C2=A0 (20 . magit-diff-trace-definition))
=C2=A0(67 . magit-commit-add-= log)
=C2=A0(38 . magit-do-async-shell-command)
=C2=A0(117 . magit-uns= tage)
=C2=A0(115 . magit-stage)
=C2=A0(97 . magit-apply)
=C2=A0(re= map keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (magit-revert-no-commit . magit-r= everse)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (magit-delete-thing . magit-discard)=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (magit-visit-thing . magit-diff-visit-file)= )
=C2=A0(24 keymap
=C2=A0 =C2=A0 =C2=A0(97 . magit-add-change-log-ent= ry)
=C2=A0 =C2=A0 =C2=A0(53 keymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (return . magit-diff-visit-file-other-frame))
=C2=A0 =C2=A0 =C2=A0(52 ke= ymap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(97 . magit-add-change-log-entry-= other-window)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(return . magit-diff-vis= it-file-other-window)))
=C2=A0(C-return . magit-diff-visit-worktree-file= )

Paul
=C2=A0(10 . magit-diff-visit-worktree-fi= le))

On Sat, 27 Aug 2022 at 18:56, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Paul Pogonysh= ev <pogonyshev= @gmail.com>
> Date: Sat, 27 Aug 2022 18:32:15 +0200
> Cc: Gerd M=C3=B6llmann <gerd.moellmann@gmail.com>,
>=C2=A0 =C2=A0 =C2=A0 =C2=A057433@debbugs.gnu.org
>
> > Now, I put the point at the beginning of the third line ([^] is t= he point):
>
> Text content at position 32867:
>
> There is an overlay here:
>=C2=A0 From 32867 to 32901
>=C2=A0 =C2=A0evaporate=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 t
>=C2=A0 =C2=A0font-lock-face=C2=A0 =C2=A0 =C2=A0 =C2=A0magit-diff-file-h= eading-highlight
>
> There are text properties here:
>=C2=A0 =C2=A0font-lock-face=C2=A0 =C2=A0 =C2=A0 =C2=A0magit-diff-file-h= eading
>=C2=A0 =C2=A0keymap=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0[Show]
>=C2=A0 =C2=A0magit-section=C2=A0 =C2=A0 =C2=A0 =C2=A0 [Show]

Maybe the 'keymap' part?=C2=A0 Could it be that C-b has a binding i= n that
keymap?
--000000000000050e5505e73c208f-- From unknown Sat Aug 09 13:07:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 Sep 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator