Subject: bug#57426: closed (Re: [bug#57426] [PATCH] gnu: Add emacs-consult-org-roam.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 27 Aug 2022 08:20:02 +0000

Your bug report

#57426: [PATCH] gnu: Add emacs-consult-org-roam.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
57426: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57426
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#57426] [PATCH] gnu: Add emacs-consult-org-roam.
From: Nicolas Goaziou <[email-masked]>
To: Nicolas Graves via Guix-patches via <[email-masked]>
Cc: Nicolas Graves <[email-masked]>, [email-masked]
Date: Sat, 27 Aug 2022 10:18:54 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Nicolas Graves via Guix-patches via <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-consult-org-roam): New variable.

Applied with the changes below. Thank you.

> +(define-public emacs-consult-org-roam
> +  (let* ((commit "9b51aed939054c54934a6969290ad78587051cde")

I used latest commit instead.

> +         (revision "0"))
> +    (package
> +      (name "emacs-consult-org-roam")
> +      (version (git-version "0" revision commit))

Base version is "0.1" according to "Version:" keyword.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/jgru/consult-org-roam.git")

I removed the ".git" suffix from URL.

> +      (propagated-inputs (list emacs-org-roam emacs-consult))

I sorted inputs alphabetically.

> +      (description
> +       "This is a set of functions to use org-roam with consult.  This
> +packages replaces org-roam's own completing read functions with equivalent
> +versions utilizing consult's internal API.  By doing so, one gains all
> +advantages of consult which enhances Emacs' own completing-read
> +funcionality.")

I removed last sentence, which didn't seem useful in a description.
Also, I used capitalization for project's names (e.g., Consult).

> +      (license license:gpl3))))

License is actually GPL3+.

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] gnu: Add emacs-consult-org-roam.
From: Nicolas Graves <[email-masked]>
To: [email-masked]
Date: Fri, 26 Aug 2022 15:23:29 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/emacs-xyz.scm (emacs-consult-org-roam): New variable.
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e6fb7572cc..6a9244dde3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9232,6 +9232,33 @@ (define-public emacs-consult-notmuch
 and present results either as single emails or full trees.")
     (license license:gpl3+)))
 
+(define-public emacs-consult-org-roam
+  (let* ((commit "9b51aed939054c54934a6969290ad78587051cde")
+         (revision "0"))
+    (package
+      (name "emacs-consult-org-roam")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/jgru/consult-org-roam.git")
+               (commit commit)))
+         (sha256
+          (base32
+           "160rix04azd1wc7fls29bhssjwzwmmnnqcfbkvapsyryvn80q219"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-org-roam emacs-consult))
+      (home-page "https://github.com/jgru/consult-org-roam")
+      (synopsis "Consult integration for org-roam")
+      (description
+       "This is a set of functions to use org-roam with consult.  This
+packages replaces org-roam's own completing read functions with equivalent
+versions utilizing consult's internal API.  By doing so, one gains all
+advantages of consult which enhances Emacs' own completing-read
+funcionality.")
+      (license license:gpl3))))
+
 (define-public emacs-consult-eglot
   (package
    (name "emacs-consult-eglot")
-- 
2.37.2

<#secure method=pgpmime mode=sign>

-- 
Best regards,
Nicolas Graves