GNU bug report logs - #57406
[PATCH] qtile desktop file install

Previous Next

Package: guix-patches;

Reported by: jonscoresby <at> mailbox.org

Date: Thu, 25 Aug 2022 15:36:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <marius <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57406 in the body.
You can then email your comments to 57406 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#57406; Package guix-patches. (Thu, 25 Aug 2022 15:36:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jonscoresby <at> mailbox.org:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 25 Aug 2022 15:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jonscoresby <at> mailbox.org
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] qtile desktop file install
Date: Thu, 25 Aug 2022 05:48:22 -0600 (MDT)
[Message part 1 (text/plain, inline)]
I don't know if my previous patch will be discarded or not, but it had an error (this is my first time). This is the revised, working patch.
---
gnu/packages/wm.scm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 7ea6840689..5084d194a6 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -579,7 +579,16 @@ (define-public qtile
(assoc-ref inputs "pango") "/lib/libpango-1.0.so.0\")\n"))
(("^pangocairo = ffi.dlopen.*")
(string-append "pangocairo = ffi.dlopen(\""
- (assoc-ref inputs "pango") "/lib/libpangocairo-1.0.so.0\")\n"))))))))
+ (assoc-ref inputs "pango") "/lib/libpangocairo-1.0.so.0\")\n")))))
+ (add-after 'install 'install-xsession
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (xsessions (string-append out "/share/xsessions"))
+ (qtile (string-append out "/bin/qtile start")))
+ (mkdir-p xsessions)
+ (copy-file "resources/qtile.desktop" (string-append xsessions "/qtile.desktop"))
+ (substitute* (string-append xsessions "/qtile.desktop")
+ (("qtile start") qtile))))))))
(inputs
(list glib pango pulseaudio))
(propagated-inputs
base-commit: 80baa8f87aa69151dffe04fb432a37c91d4dd242
--
2.37.2
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#57406; Package guix-patches. (Fri, 26 Aug 2022 15:29:02 GMT) Full text and rfc822 format available.

Message #8 received at 57406 <at> debbugs.gnu.org (full text, mbox):

From: jonscoresby <at> mailbox.org
To: "57406 <at> debbugs.gnu.org" <57406 <at> debbugs.gnu.org>
Subject: Format Fix
Date: Fri, 26 Aug 2022 09:28:20 -0600 (MDT)
I realized my email client messed up the formatting. Here is the formatted patch.

---
 gnu/packages/wm.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 7ea6840689..5084d194a6 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -579,7 +579,16 @@ (define-public qtile
                   (assoc-ref inputs "pango") "/lib/libpango-1.0.so.0\")\n"))
                 (("^pangocairo = ffi.dlopen.*")
                  (string-append "pangocairo = ffi.dlopen(\""
-                  (assoc-ref inputs "pango") "/lib/libpangocairo-1.0.so.0\")\n"))))))))
+                  (assoc-ref inputs "pango") "/lib/libpangocairo-1.0.so.0\")\n")))))
+       (add-after 'install 'install-xsession
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (xsessions (string-append out "/share/xsessions"))
+                    (qtile (string-append out "/bin/qtile start")))
+               (mkdir-p xsessions)
+               (copy-file "resources/qtile.desktop" (string-append xsessions "/qtile.desktop"))
+               (substitute* (string-append xsessions "/qtile.desktop")
+                 (("qtile start") qtile))))))))
     (inputs
       (list glib pango pulseaudio))
     (propagated-inputs

base-commit: 80baa8f87aa69151dffe04fb432a37c91d4dd242
-- 
2.37.2




Reply sent to Marius Bakke <marius <at> gnu.org>:
You have taken responsibility. (Sat, 27 Aug 2022 21:48:01 GMT) Full text and rfc822 format available.

Notification sent to jonscoresby <at> mailbox.org:
bug acknowledged by developer. (Sat, 27 Aug 2022 21:48:02 GMT) Full text and rfc822 format available.

Message #13 received at 57406-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: jonscoresby <at> mailbox.org, "57406 <at> debbugs.gnu.org"
 <57406-done <at> debbugs.gnu.org>
Subject: Re: [bug#57406] Format Fix
Date: Sat, 27 Aug 2022 23:47:29 +0200
[Message part 1 (text/plain, inline)]
jonscoresby--- via Guix-patches via <guix-patches <at> gnu.org> skriver:

> I realized my email client messed up the formatting. Here is the formatted patch.

Applied (with an appropriate commit message), thanks!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 25 Sep 2022 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 324 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.