GNU bug report logs - #57400
29.0.50; Support sending patches from VC directly

Previous Next

Package: emacs;

Reported by: Antoine Kalmbach <ane <at> iki.fi>

Date: Thu, 25 Aug 2022 08:49:01 UTC

Severity: normal

Found in version 29.0.50

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rpluim <at> gmail.com, 57400 <at> debbugs.gnu.org, ane <at> iki.fi, juri <at> linkov.net
Subject: bug#57400: 29.0.50; Support sending patches from VC directly
Date: Sat, 15 Oct 2022 15:15:02 +0000
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: juri <at> linkov.net,  rpluim <at> gmail.com,  57400 <at> debbugs.gnu.org,  ane <at> iki.fi
>> Date: Sat, 15 Oct 2022 11:44:58 +0000
>> 
>> The function does accept everything that "git name-rev" accepts, after
>> all it just passes commit to the subcommand.  What FORCE does is
>> restrict what "git name-rev" response is accepted to be returned by
>> `vc-git-symbolic-commit'.
>
> Ah, so this is what I was missing...
>
> Then how about
>
>    If the optional argument FORCE is non-nil, the returned value is
>    allowed to include revision specifications like \"master~8\"
>    (the 8th parent of the commit currently pointed to by the master
>    branch), otherwise such revision specifications are rejected, and
>    the function returns nil.

Sounds good to me.




This bug report was last modified 2 years and 219 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.