GNU bug report logs - #57387
[PATCH] gnu: Add restartd.

Previous Next

Full log

Message #35 received at 57387 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Nicolas Graves <ngraves <at> ngraves.fr>, 57387 <at> debbugs.gnu.org
Subject: Re: [bug#57387] [PATCH] gnu: Add restartd.
Date: Fri, 26 Aug 2022 21:07:03 +0200

[Message part 1 (text/plain, inline)]

On 26-08-2022 18:57, Nicolas Graves wrote:

>> A bit of a nitpick, but Yin Kagkai was not involved in this patch, I
>> wrote it myself ...
>> ... the commenting syslog thing was an unrelated patch, maybe various
>> commits were squashed?
> Sorry, I should have explained.
> Applying both pull requests 6 and 8 failed because 3 lines were common
> to both.
Hm, I didn't encounter that, maybe I accidentally removed one of the 
pre-existing patches or even removed my own patch.
> I resolved that by merging both and recreating a new patch, thus giving
> credit to both authors. Is that OK ?

OK, but some commit messages are getting lost, maybe add a link to the 
two upstream PRs to make clear it's a combination of multiple 
independent -- Yin Kangkai did some presumably useful things, but it's 
not adding error handling unlike what the current patch message and file 
name implies.

Greetings,
Maxime.

[Message part 2 (text/html, inline)]

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.