Subject: bug#57377: closed (Re: bug#57377: [PATCH] api-coverage.texi: fix example, remove mentions of unimplemented features)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 01 Oct 2022 13:59:02 +0000

Your bug report

#57377: [PATCH] api-coverage.texi: fix example, remove mentions of unimplemented features

which was filed against the guile package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
57377: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57377
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#57377: [PATCH] api-coverage.texi: fix example, remove mentions of unimplemented features
From: Ludovic Courtès <[email-masked]>
To: Antoine Kalmbach <[email-masked]>
Cc: [email-masked]
Date: Sat, 01 Oct 2022 15:57:46 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Antoine,

Antoine Kalmbach <[email-masked]> skribis:

> * doc/ref/api-coverage.texi (Code Coverage): #:modules is not
>   supported... never seems to have been supported?
>   (example): close port, not file.

In commit 4456245753ff925cafd3e72d130761b6f1c2c419, Jessica Talon added
support for #:modules.

I applied the fix for the typo you found in the example, though.

Thank you!

Ludo’.

Subject: [PATCH] api-coverage.texi: fix example, remove mentions of unimplemented features
From: Antoine Kalmbach <[email-masked]>
To: [email-masked]
Date: Wed, 24 Aug 2022 12:09:00 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* doc/ref/api-coverage.texi (Code Coverage): #:modules is not
  supported... never seems to have been supported?
  (example): close port, not file.
---
 doc/ref/api-coverage.texi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/ref/api-coverage.texi b/doc/ref/api-coverage.texi
index 5081d343b..61ac4abf1 100644
--- a/doc/ref/api-coverage.texi
+++ b/doc/ref/api-coverage.texi
@@ -25,12 +25,12 @@ Return @code{#t} if @var{obj} is a @dfn{coverage data} object as returned by
 @code{with-code-coverage}.
 @end deffn
 
-@deffn {Scheme Procedure} coverage-data->lcov data port #:key modules
+@deffn {Scheme Procedure} coverage-data->lcov data port
 Traverse code coverage information @var{data}, as obtained with
 @code{with-code-coverage}, and write coverage information to port in the
 @code{.info} format used by @url{http://ltp.sourceforge.net/coverage/lcov.php,
-LCOV}.  The report will include all of @var{modules} (or, by default, all the
-currently loaded modules) even if their code was not executed.
+LCOV}.  The report will include all the modules loaded at the time
+coverage data was gathered, even if their code was not executed.
 
 The generated data can be fed to LCOV's @command{genhtml} command to produce an
 HTML report, which aids coverage data visualization.
@@ -49,7 +49,7 @@ Here's an example use:
   (lambda (data result)
     (let ((port (open-output-file "lcov.info")))
       (coverage-data->lcov data port)
-      (close file))))
+      (close port))))
 @end example
 
 In addition, the module provides low-level procedures that would make it
-- 
2.35.1