From unknown Sun Jun 22 00:44:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57377: [PATCH] api-coverage.texi: fix example, remove mentions of unimplemented features Resent-From: Antoine Kalmbach Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 24 Aug 2022 09:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57377 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: 57377@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166133216016486 (code B ref -1); Wed, 24 Aug 2022 09:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Aug 2022 09:09:20 +0000 Received: from localhost ([127.0.0.1]:45654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQmO0-0004Hp-65 for submit@debbugs.gnu.org; Wed, 24 Aug 2022 05:09:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:44624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQmNy-0004Hh-0l for submit@debbugs.gnu.org; Wed, 24 Aug 2022 05:09:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQmNx-0002Nw-O8 for bug-guile@gnu.org; Wed, 24 Aug 2022 05:09:17 -0400 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]:46680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQmNv-0004xt-AI for bug-guile@gnu.org; Wed, 24 Aug 2022 05:09:17 -0400 Received: from thanatos (91-157-197-22.elisa-laajakaista.fi [91.157.197.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ane) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 5CC631B001A3 for ; Wed, 24 Aug 2022 12:09:07 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1661332147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=6qaLcdJqIYPaQMEoAGE41WCdL+mm/w9nCOddQZ9oZGg=; b=ve+yEyd1bIREW5f9RRBDgalVmB+Eaz9vg0POcLcrCwqtOYLpOpuXImZGw2PDh12Vm4Q+uY +/VinyZTS662QotOxpXEJPw3PDlqIszh/9F2jDTp6iu3wFqeWi2EldNib1c033E54mCY8q q8/wkah5SBV5CAby6syYqtWkuaq5Oke65ryMTWtIJ+MGBBGpxHEyIQbVNNZQjgMtECFHR1 ajUpLx98LkWBjBQc8sawJeTM+hheaLgw6oKX4lyW+mK8Uht6RWDow+H3LAUBZYa/S8Zvtr gdrZv/XA6dYGkglb8usruAq9DMEXuo1UuTFMPC6EUWEKUcK7FVZcE/9vneTJig== From: Antoine Kalmbach Date: Wed, 24 Aug 2022 12:09:00 +0300 Message-ID: <84fshmovo3.fsf@iki.fi> MIME-Version: 1.0 Content-Type: text/plain ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1661332147; a=rsa-sha256; cv=none; b=v0+HaJAapmgXKiG1G3XYFYYFpaqJU8+AStJJ5W6DMvAOM/FCSMmWKINn1TcGS3n95v48IW iQlnqu990qGuyR1DhaAO2MuIRjbXyTDbb0s0lNLoNpYydMHgnzYPzMJrp/kiU+eD/d+0eD T3rpRnvPsPdZXgyH/6l+GEtLcDb89F3EnIXTOJNXb7d/OQ2VZzs717vIEyup0cH/BokbSq 1xgLK0C5pC4zvbe8Y2mXSuRa0wYnrMUGnptddG4e9X8T9qu/GA7ACtwN2sM6dn13JyeBKF FgGE2yfzd62Z7k5wCLo9GGQgV9FjiyW2E9BmE8vjxeVDYNQCvPBiv2UWgpdXhA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=ane smtp.mailfrom=ane@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1661332147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=6qaLcdJqIYPaQMEoAGE41WCdL+mm/w9nCOddQZ9oZGg=; b=CXuj2GH3iPbUwftI8HKyBI1sX7KA06HdWjFZWOsgPP4cvCJEJo5LaMNh9kS1selWSY+3Wd 21IQ3fclHXqD+DpgqvXTagV53Edc3bI02T/TpMnwX59WUohwXgjVlpuiw49X+9OIJZmIuz kclWAcdfIhqov441a/X7urlvIZLdtooE8pkNTGid2rnrB/6XsJuGkUaLL9DD89RcRLgGTE P71BadvOSghDnSZ6Rv9k1VYe7v4KETzeGVUYal8jLcEm9T18kfHW6YdtHwUnV328N8BPbA iMNAGd1mlCADQuH/AVdhFfIEEy+wfuncH5ClVpkYXtZdPuhJrfLjv0OuSpHK1A== Received-SPF: pass client-ip=2a0b:5c81:1c1::37; envelope-from=ane@iki.fi; helo=lahtoruutu.iki.fi X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * doc/ref/api-coverage.texi (Code Coverage): #:modules is not supported... never seems to have been supported? (example): close port, not file. --- doc/ref/api-coverage.texi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/ref/api-coverage.texi b/doc/ref/api-coverage.texi index 5081d343b..61ac4abf1 100644 --- a/doc/ref/api-coverage.texi +++ b/doc/ref/api-coverage.texi @@ -25,12 +25,12 @@ Return @code{#t} if @var{obj} is a @dfn{coverage data} object as returned by @code{with-code-coverage}. @end deffn -@deffn {Scheme Procedure} coverage-data->lcov data port #:key modules +@deffn {Scheme Procedure} coverage-data->lcov data port Traverse code coverage information @var{data}, as obtained with @code{with-code-coverage}, and write coverage information to port in the @code{.info} format used by @url{http://ltp.sourceforge.net/coverage/lcov.php, -LCOV}. The report will include all of @var{modules} (or, by default, all the -currently loaded modules) even if their code was not executed. +LCOV}. The report will include all the modules loaded at the time +coverage data was gathered, even if their code was not executed. The generated data can be fed to LCOV's @command{genhtml} command to produce an HTML report, which aids coverage data visualization. @@ -49,7 +49,7 @@ Here's an example use: (lambda (data result) (let ((port (open-output-file "lcov.info"))) (coverage-data->lcov data port) - (close file)))) + (close port)))) @end example In addition, the module provides low-level procedures that would make it -- 2.35.1 From unknown Sun Jun 22 00:44:43 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Antoine Kalmbach Subject: bug#57377: closed (Re: bug#57377: [PATCH] api-coverage.texi: fix example, remove mentions of unimplemented features) Message-ID: References: <871qrrfxyd.fsf@gnu.org> <84fshmovo3.fsf@iki.fi> X-Gnu-PR-Message: they-closed 57377 X-Gnu-PR-Package: guile X-Gnu-PR-Keywords: patch Reply-To: 57377@debbugs.gnu.org Date: Sat, 01 Oct 2022 13:59:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1664632742-24507-1" This is a multi-part message in MIME format... ------------=_1664632742-24507-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #57377: [PATCH] api-coverage.texi: fix example, remove mentions of unimplem= ented features which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 57377@debbugs.gnu.org. --=20 57377: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D57377 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1664632742-24507-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 57377-done) by debbugs.gnu.org; 1 Oct 2022 13:58:07 +0000 Received: from localhost ([127.0.0.1]:45436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oed0I-0006Lw-Jx for submit@debbugs.gnu.org; Sat, 01 Oct 2022 09:58:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oed0G-0006LK-Tx for 57377-done@debbugs.gnu.org; Sat, 01 Oct 2022 09:58:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oed0A-0002UG-Vi; Sat, 01 Oct 2022 09:57:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=lAGbK7HNbHm+l5oj3A2dvPLafHQPNsRUvS2V+o26tnc=; b=Ln7JXaz5pZeYXS2mvj0K KuqbBKLLlEyhvQodF0wRLBEIANw+1Vh3p2v2Yl3XbIbdS5Dq23sJvlFVdzWZ2U1lnrnFsgMuZ5qul GqMvqXh/d7IvxFJfjIgf3jv9gDRu7/swQ8vTgblVyCdq+KIM12VqtVC0kuycMpYpHo5yqNwQgIDgR R+2wCGEIW6nZLcbfybhW/AzuuXDwauAWZsjseL95fq4uf8BHl4yKweZxkr5mvH3Mfr4jmb/WDEXvi qhFHMd43HB1apH2JTH1wdpUnyrUSAg51wL4oVvw3MrVcEUaVE9UnNqUNVruhMhx9UUNSEPV1eMiIz WUiDsPQtq705FQ==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34592 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeczz-0002so-W9; Sat, 01 Oct 2022 09:57:58 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Antoine Kalmbach Subject: Re: bug#57377: [PATCH] api-coverage.texi: fix example, remove mentions of unimplemented features References: <84fshmovo3.fsf@iki.fi> Date: Sat, 01 Oct 2022 15:57:46 +0200 In-Reply-To: <84fshmovo3.fsf@iki.fi> (Antoine Kalmbach's message of "Wed, 24 Aug 2022 12:09:00 +0300") Message-ID: <871qrrfxyd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57377-done Cc: 57377-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Antoine, Antoine Kalmbach skribis: > * doc/ref/api-coverage.texi (Code Coverage): #:modules is not > supported... never seems to have been supported? > (example): close port, not file. In commit 4456245753ff925cafd3e72d130761b6f1c2c419, Jessica Talon added support for #:modules. I applied the fix for the typo you found in the example, though. Thank you! Ludo=E2=80=99. ------------=_1664632742-24507-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Aug 2022 09:09:20 +0000 Received: from localhost ([127.0.0.1]:45654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQmO0-0004Hp-65 for submit@debbugs.gnu.org; Wed, 24 Aug 2022 05:09:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:44624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQmNy-0004Hh-0l for submit@debbugs.gnu.org; Wed, 24 Aug 2022 05:09:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQmNx-0002Nw-O8 for bug-guile@gnu.org; Wed, 24 Aug 2022 05:09:17 -0400 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]:46680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQmNv-0004xt-AI for bug-guile@gnu.org; Wed, 24 Aug 2022 05:09:17 -0400 Received: from thanatos (91-157-197-22.elisa-laajakaista.fi [91.157.197.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ane) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 5CC631B001A3 for ; Wed, 24 Aug 2022 12:09:07 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1661332147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=6qaLcdJqIYPaQMEoAGE41WCdL+mm/w9nCOddQZ9oZGg=; b=ve+yEyd1bIREW5f9RRBDgalVmB+Eaz9vg0POcLcrCwqtOYLpOpuXImZGw2PDh12Vm4Q+uY +/VinyZTS662QotOxpXEJPw3PDlqIszh/9F2jDTp6iu3wFqeWi2EldNib1c033E54mCY8q q8/wkah5SBV5CAby6syYqtWkuaq5Oke65ryMTWtIJ+MGBBGpxHEyIQbVNNZQjgMtECFHR1 ajUpLx98LkWBjBQc8sawJeTM+hheaLgw6oKX4lyW+mK8Uht6RWDow+H3LAUBZYa/S8Zvtr gdrZv/XA6dYGkglb8usruAq9DMEXuo1UuTFMPC6EUWEKUcK7FVZcE/9vneTJig== From: Antoine Kalmbach To: bug-guile@gnu.org Subject: [PATCH] api-coverage.texi: fix example, remove mentions of unimplemented features Date: Wed, 24 Aug 2022 12:09:00 +0300 Message-ID: <84fshmovo3.fsf@iki.fi> MIME-Version: 1.0 Content-Type: text/plain ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1661332147; a=rsa-sha256; cv=none; b=v0+HaJAapmgXKiG1G3XYFYYFpaqJU8+AStJJ5W6DMvAOM/FCSMmWKINn1TcGS3n95v48IW iQlnqu990qGuyR1DhaAO2MuIRjbXyTDbb0s0lNLoNpYydMHgnzYPzMJrp/kiU+eD/d+0eD T3rpRnvPsPdZXgyH/6l+GEtLcDb89F3EnIXTOJNXb7d/OQ2VZzs717vIEyup0cH/BokbSq 1xgLK0C5pC4zvbe8Y2mXSuRa0wYnrMUGnptddG4e9X8T9qu/GA7ACtwN2sM6dn13JyeBKF FgGE2yfzd62Z7k5wCLo9GGQgV9FjiyW2E9BmE8vjxeVDYNQCvPBiv2UWgpdXhA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=ane smtp.mailfrom=ane@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1661332147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=6qaLcdJqIYPaQMEoAGE41WCdL+mm/w9nCOddQZ9oZGg=; b=CXuj2GH3iPbUwftI8HKyBI1sX7KA06HdWjFZWOsgPP4cvCJEJo5LaMNh9kS1selWSY+3Wd 21IQ3fclHXqD+DpgqvXTagV53Edc3bI02T/TpMnwX59WUohwXgjVlpuiw49X+9OIJZmIuz kclWAcdfIhqov441a/X7urlvIZLdtooE8pkNTGid2rnrB/6XsJuGkUaLL9DD89RcRLgGTE P71BadvOSghDnSZ6Rv9k1VYe7v4KETzeGVUYal8jLcEm9T18kfHW6YdtHwUnV328N8BPbA iMNAGd1mlCADQuH/AVdhFfIEEy+wfuncH5ClVpkYXtZdPuhJrfLjv0OuSpHK1A== Received-SPF: pass client-ip=2a0b:5c81:1c1::37; envelope-from=ane@iki.fi; helo=lahtoruutu.iki.fi X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * doc/ref/api-coverage.texi (Code Coverage): #:modules is not supported... never seems to have been supported? (example): close port, not file. --- doc/ref/api-coverage.texi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/ref/api-coverage.texi b/doc/ref/api-coverage.texi index 5081d343b..61ac4abf1 100644 --- a/doc/ref/api-coverage.texi +++ b/doc/ref/api-coverage.texi @@ -25,12 +25,12 @@ Return @code{#t} if @var{obj} is a @dfn{coverage data} object as returned by @code{with-code-coverage}. @end deffn -@deffn {Scheme Procedure} coverage-data->lcov data port #:key modules +@deffn {Scheme Procedure} coverage-data->lcov data port Traverse code coverage information @var{data}, as obtained with @code{with-code-coverage}, and write coverage information to port in the @code{.info} format used by @url{http://ltp.sourceforge.net/coverage/lcov.php, -LCOV}. The report will include all of @var{modules} (or, by default, all the -currently loaded modules) even if their code was not executed. +LCOV}. The report will include all the modules loaded at the time +coverage data was gathered, even if their code was not executed. The generated data can be fed to LCOV's @command{genhtml} command to produce an HTML report, which aids coverage data visualization. @@ -49,7 +49,7 @@ Here's an example use: (lambda (data result) (let ((port (open-output-file "lcov.info"))) (coverage-data->lcov data port) - (close file)))) + (close port)))) @end example In addition, the module provides low-level procedures that would make it -- 2.35.1 ------------=_1664632742-24507-1--