GNU bug report logs - #57376
28.1; rcirc-fill-flag ignored after 27->28 upgrade

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Trent W. Buck" <trentbuck <at> gmail.com>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 57376 <at> debbugs.gnu.org
Subject: bug#57376: 28.1; rcirc-fill-flag ignored after 27->28 upgrade
Date: Wed, 24 Aug 2022 13:45:29 +0200

"Trent W. Buck" <trentbuck <at> gmail.com> writes:

> I just upgraded from 1:27.1+1-3.1 to 1:28.1+1-2~bpo11+1.2.
> Now, even though (setq rcirc-fill-flag nil) in my .emacs,
> I am getting hard wrapping.
>
> None of these (evaluated in-buffer with M-:) stopped new messages being
> hard-wrapped at 70 columns:
>
>    (setq rcirc-fill-flag nil)
>    (auto-fill-mode -1)
>    (defun rcirc-markup-fill (x y))  ; nop out this unwanted function
>    (defun rcirc-fill-paragraph (&optional x))  ; nop out this unwanted function

I haven't tested myself, but it seems like the code in this area was
changed by:

commit 849e71fd83fa8796198035464897bf2f28f6226c
Author:     Philip Kaludercic <philipk <at> posteo.net>
AuthorDate: Wed Jun 9 17:55:55 2021 +0200

    Implement server-time extension
    
    * rcirc.el (rcirc-implemented-capabilities): Add new capability
    (rcirc-print): Insert messages in the right position
    (rcirc-log): Use right time value
    (rcirc-markup-timestamp): Use right time value

In particular, this:

- 	    ;; squeeze spaces out of text before rcirc-text
-	    (fill-region fill-start
-			 (1- (or (next-single-property-change fill-start
-							      'rcirc-text)
-				 rcirc-prompt-end-marker)))

was changed to this:

+              ;; squeeze spaces out of text before rcirc-text
+              (fill-region (point-min) (point-max))

But I don't really know the code well.  Adding Philip to the CCs.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.