GNU bug report logs - #57367
[PATCH] Speed up em-smart

Previous Next

Full log

Message #42 received at 57367-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>,
 Stefan Kangas <stefankangas <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 57367-done <at> debbugs.gnu.org
Subject: Re: bug#57367: [PATCH v3] Speed up em-smart
Date: Sat, 28 Oct 2023 15:47:52 -0700

Version: 30.1

On 10/18/2023 8:46 AM, Morgan Smith wrote:
> Thanks for the ping.  Reading the documentation for
> `window-configuration-change-hook' I found out I can run the scroll
> command only on updated windows.  Furthermore, that hook selects the
> window which is nice.  I believe the problems pointed out above stem
> from using `(point)` to scroll a window that wasn't actually selected.
> 
> Anyways here is V3

Thanks for the updated patch. As far as I can tell (I don't use the 
smart display module in Eshell), everything works here, and you even 
fixed a bug I noticed on master with long output! (Previously, if you 
ran a command with a lot of output, the prompt got hidden for some 
reason, probably due to using field properties for the prompt/output. 
That's fixed now.)

I've merged this to master as e08238cdd74 now. Closing this bug. Thanks 
again.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.