GNU bug report logs - #57367
[PATCH] Speed up em-smart

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#57367: closed ([PATCH] Speed up em-smart)
Date: Sat, 28 Oct 2023 22:49:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 28 Oct 2023 15:47:52 -0700
with message-id <b6a0aa04-b8e5-da0a-3313-d2eb2211f562 <at> gmail.com>
and subject line Re: bug#57367: [PATCH v3] Speed up em-smart
has caused the debbugs.gnu.org bug report #57367,
regarding [PATCH] Speed up em-smart
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
57367: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57367
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: bug-gnu-emacs <at> gnu.org
Cc: johnw <at> gnu.org
Subject: [PATCH] Speed up em-smart
Date: Tue, 23 Aug 2022 16:06:21 -0400

[Message part 3 (text/plain, inline)]

Hello,

em-smart is very slow.  This patch makes it much faster.  idk why there
was all this redisplay stuff in the module as everything seems to work
great when I remove it all.

Thanks John Wiegley for writing this module!  It's a pretty cool concept
and I'm having fun playing with it

Thanks,

Morgan

[0001-Speed-up-em-smart.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>,
 Stefan Kangas <stefankangas <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 57367-done <at> debbugs.gnu.org
Subject: Re: bug#57367: [PATCH v3] Speed up em-smart
Date: Sat, 28 Oct 2023 15:47:52 -0700

Version: 30.1

On 10/18/2023 8:46 AM, Morgan Smith wrote:
> Thanks for the ping.  Reading the documentation for
> `window-configuration-change-hook' I found out I can run the scroll
> command only on updated windows.  Furthermore, that hook selects the
> window which is nice.  I believe the problems pointed out above stem
> from using `(point)` to scroll a window that wasn't actually selected.
> 
> Anyways here is V3

Thanks for the updated patch. As far as I can tell (I don't use the 
smart display module in Eshell), everything works here, and you even 
fixed a bug I noticed on master with long output! (Previously, if you 
ran a command with a lot of output, the prompt got hidden for some 
reason, probably due to using field properties for the prompt/output. 
That's fixed now.)

I've merged this to master as e08238cdd74 now. Closing this bug. Thanks 
again.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.