GNU bug report logs - #57367
[PATCH] Speed up em-smart

Previous Next

Full log

Message #13 received at 57367 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>,
 Morgan Smith <Morgan.J.Smith <at> outlook.com>
Cc: johnw <at> gnu.org, 57367 <at> debbugs.gnu.org
Subject: Re: bug#57367: [PATCH] Speed up em-smart
Date: Mon, 5 Sep 2022 12:01:21 -0700

On 9/4/2022 2:56 PM, Lars Ingebrigtsen wrote:
> Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:
> 
>> em-smart is very slow.  This patch makes it much faster.  idk why there
>> was all this redisplay stuff in the module as everything seems to work
>> great when I remove it all.
> 
> Skimming the patch, I think it makes sense, but I'm not that familiar
> with eshell.  Perhaps Jim has some comments; added to the CCs.

I don't know much about the smart scrolling module in Eshell, but I'll 
try to familiarize myself with it and then take a look. I'm slightly 
hesitant about deleting a bunch of code until I know why it was there in 
the first place; from the comments in em-smart.el, it sounds like these 
hooks are intentional:

  ;; @ While output is being generated from a command, the window will
  ;;   be constantly reconfigured (until it would otherwise make no
  ;;   difference) in order to always show you the most output from the
  ;;   command possible.  This happens if you change window sizes,
  ;;   scroll, etc.

However, maybe there's a better way to do this, or failing that, to at 
least provide some more options in the module so that users can tune the 
performance to their liking.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.