Subject: Re: bug#57365: [PATCH] gnu: guile-smc: Update to 0.5.0

From: Mathieu Othacehe <[email-masked]>
Date: Fri, 26 Aug 2022 15:34:36 +0200

Hey Artyom,

> -              (string-append
> -               "(add-handler! %logger\n"
> -               "              (make <rotating-log>\n"
> -               "                    #:file-name \"smc.log\"))\n")))
> -             #t))
> +               (("\\(add-handler! %logger %syslog\\)")
> +                (string-append
> +                 "(add-handler! %logger\n"
> +                 "              (make <port-log/us>\n"
> +                 "                    #:port (open-file \"/tmp/smc.log\" \"a+\")))\n")))))

What is this patch about? Can't it be upstreamed?

> +     (list autoconf automake pkg-config texinfo help2man))

You need to describe it in the commit message:

[native-inputs]: Add help2man.

> +     (list bash-minimal
> +           guile-3.0
> +           guile-lib
> +           inetutils))

Ditto:

[inputs]: Use the new inputs style.

Can you send an updated patch?

Thanks,

Mathieu