Subject: bug#57363: closed (Re: [PATCH v2] shepherd: Set #o640 permissions for log file of service in container.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 02 Sep 2022 11:21:02 +0000

Your bug report

#57363: [PATCH 0/1] Set #o640 permissions for log file of shepherd service in container.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
57363: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57363
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH v2] shepherd: Set #o640 permissions for log file of service in container.
From: Arun Isaac <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked], Maxime Devos <[email-masked]>
Date: Fri, 02 Sep 2022 16:50:43 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

>> * gnu/build/shepherd.scm (make-forkexec-constructor/container): Set #o640
>> permissions for log file.
>
> LGTM!

Thanks, pushed!

> However, note that ‘make-forkexec-constructor/container’ is now
> deprecated in favor of (guix least-authority); apparently PageKite and
> Jami are the only real users left.

Ah, I didn't know. I've been making extensive use of
make-forkexec-constructor/container in guix-forge and all my
services. Time to switch!

Subject: [PATCH 0/1] Set #o640 permissions for log file of shepherd service in container.
From: Arun Isaac <[email-masked]>
To: [email-masked]
Cc: Arun Isaac <[email-masked]>,Ludovic Courtès <[email-masked]>
Date: Tue, 23 Aug 2022 23:01:02 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

When a shepherd service is run using make-forkexec-constructor, the log file
has #o640 permissions. This is set in the shepherd source code.
=> https://git.savannah.gnu.org/cgit/shepherd.git/tree/modules/shepherd/service.scm?h=v0.9.1#n987

However, when a shepherd service is run using
make-forkexec-constructor/container, the log file has #o644 permissions. This
patch corrects that.

CCing Ludo since they wrote the code adjacent to this patch.

Thanks!

Arun Isaac (1):
  shepherd: Set #o640 permissions for log file of service in container.

 gnu/build/shepherd.scm | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.37.1