GNU bug report logs - #57361
[PATCH] gnu: Add solvespace.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kristian Lein-Mathisen <kristianlein <at> gmail.com>
Subject: bug#57361: closed (Re: bug#57361: [PATCH] gnu: Add solvespace.)
Date: Sun, 11 Sep 2022 14:14:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#57361: [PATCH] gnu: Add solvespace.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 57361 <at> debbugs.gnu.org.

-- 
57361: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57361
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 57361-done <at> debbugs.gnu.org, Kristian Lein-Mathisen <kristianlein <at> gmail.com>
Subject: Re: bug#57361: [PATCH] gnu: Add solvespace.
Date: Sun, 11 Sep 2022 16:13:33 +0200

Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:

> Am Donnerstag, dem 08.09.2022 um 15:14 +0200 schrieb Ludovic Courtès:
>> Hi,
>> 
>> Kristian Lein-Mathisen <kristianlein <at> gmail.com> skribis:
>> 
>> > From a19e2d22f52b71db2ddc14b5dcaa6acb57c27484 Mon Sep 17 00:00:00
>> > 2001
>> > From: Kristian Lein-Mathisen <kristianlein <at> gmail.com>
>> > Date: Mon, 5 Sep 2022 21:49:03 +0200
>> > Subject: [PATCH 1/2] gnu: Add mimalloc.
>> > 
>> > * gnu/packages/c.scm (mimalloc): New variable.
>> 
>> [...]
>> 
>> > From a2967120d10320962a0298caa412d320bca7804a Mon Sep 17 00:00:00
>> > 2001
>> > From: Kristian Lein-Mathisen <kristianlein <at> gmail.com>
>> > Date: Tue, 6 Sep 2022 10:24:01 +0200
>> > Subject: [PATCH 2/2] gnu: Add solvespace.
>> > 
>> > * gnu/packages/engineering.scm (solvespace): New variable.
>> 
>> Applied both, the latter with the cosmetic changes below.
> Should we mark this as done then?

Yes, sorry.  Done!

[Message part 3 (message/rfc822, inline)]

From: Kristian Lein-Mathisen <kristianlein <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add solvespace.
Date: Tue, 23 Aug 2022 14:08:31 +0200

[Message part 4 (text/plain, inline)]

Hi everyone,

I'm new to Guix and I'm enjoying it very much so far. Here is my little
contribution: a lightweight CAD package. I don't have a lot of experience
with SolveSpace, so I haven't done any testing other than checking if
export to DXF works and drawing some sketches.

I think I've managed to follow the steps in the Submitting Patches
<https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html>
guide. The package has a couple of TODO's though, mostly regarding
extracting dependencies instead of building the git submodules in-place:

- mimalloc This just points to Microsoft's upstream
<https://github.com/microsoft/mimalloc/tree/f819dbb4e4813fab464aee16770f39f11476bfea>,
very close to version 2.0.6. The only other use of mimalloc I found was
rust-mimalloc, but it seems to be
<https://github.com/purpleprotocol/mimalloc_rust/tree/v0.1.20/libmimalloc-sys/c_src>
on version mimalloc 1.6.4.

- dxfrw: I believe this is an independent fork
<https://github.com/solvespace/libdxfrw>, which is unlikely useful
elsewhere.

Please consider this for inclusion,
Thank you.
K.

[Message part 5 (text/html, inline)]

[0001-gnu-Add-solvespace.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.