GNU bug report logs - #57347
[PATCH] packages: Add man-pages-posix.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57347 in the body.
You can then email your comments to 57347 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: guix-patches <at> gnu.org
Subject: [PATCH] packages: Add man-pages-posix.
Date: Mon, 22 Aug 2022 15:42:58 -0500

* gnu/packages/man.scm (man-pages-posix): New variable.
---
 gnu/packages/man.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/man.scm b/gnu/packages/man.scm
index 1c1d82758b..e6f4a8bb5b 100644
--- a/gnu/packages/man.scm
+++ b/gnu/packages/man.scm
@@ -302,6 +302,39 @@ (define-public man-pages
     ;; Each man page has its own license; some are GPLv2+, some are MIT/X11.
     (license license:gpl2+)))
 
+(define-public man-pages-posix
+  (package
+    (name "man-pages-posix")
+    (version "2013-a")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kernel.org/linux/docs/man-pages/"
+                            "man-pages-posix/man-pages-posix-" version
+                            ".tar.xz"))
+        (sha256
+         (base32 "0258j05zdrxpgdj8nndbyi7bvrs8fxdksb0xbfrylzgzfmf3lqqr"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:tests? #f
+       #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")))
+       #:license-file-regexp "POSIX-COPYRIGHT"
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure)
+                  (replace 'build
+                    (lambda _
+                      ;; make all is useless due to guix build semantics, so just gzip.
+                      ;; Parallel builds are useless with how the Makefile's setup.
+                      (invoke "make" "gz"))))))
+    (home-page "https://www.kernel.org/doc/man-pages/")
+    (synopsis "Man pages from the POSIX.1-2013 standard")
+    (description "This package contains excerpts from the POSIX.1-2008 and TC1
+standards (collectively, POSIX.1-2013) in manual page form.")
+    (license (license:fsdg-compatible "file://POSIX-COPYRIGHT"
+              "Redistribution of this material is permitted so long as this
+notice and the corresponding notices within each POSIX manual page are retained
+on any distribution, and the nroff source is included."))))
+
 (define-public help2man
   ;; TODO: Manual pages for languages not available from the implicit
   ;; input "locales" contain the original (English) text.

base-commit: ff3cecffafad0ddf5cc2af6cb676e73bcf58e431
-- 
2.37.1

Message #8 received at 57347 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Lilah Tascheter <lilah <at> lunabee.space>, 57347 <at> debbugs.gnu.org
Subject: Re: [bug#57347] [PATCH] packages: Add man-pages-posix.
Date: Tue, 23 Aug 2022 01:50:34 +0200

[Message part 1 (text/plain, inline)]

On 22-08-2022 22:42, Lilah Tascheter via Guix-patches via wrote:

> +    (home-page"https://www.kernel.org/doc/man-pages/")
> +    (synopsis "Man pages from the POSIX.1-2013 standard")
> +    (description "This package contains excerpts from the POSIX.1-2008 and TC1
> +standards (collectively, POSIX.1-2013) in manual page form.")

This package can easily be confused with 'man-pages' -- at least, I 
initially confused this as a duplicate of man-pages. Could the 
relationship be clarified in the description?

> +    (arguments
> +     '(#:tests? #f
> +       #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")))
> +       #:license-file-regexp "POSIX-COPYRIGHT"
> +       #:phases (modify-phases %standard-phases
> +                  (delete 'configure)
> +                  (replace 'build
> +                    (lambda _
> +                      ;; make all is useless due to guix build semantics, so just gzip.
> +                      ;; Parallel builds are useless with how the Makefile's setup.
> +                      (invoke "make" "gz"))))))
Maybe (assoc-ref %outputs "out") -> #$output and '(#:tests? ...) -> 
(list #:tests? #f #:make-flags #~(list ...) #:phases #~(...)), now we 
have G-exps.

Also, IIRC there's a #:make-target and #:parallel-build? #false

As a bonus, you could update the 'man-pages' package to the new G-exps, 
though not required.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #11 received at 57347 <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: Maxime Devos <maximedevos <at> telenet.be>, 57347 <at> debbugs.gnu.org
Subject: Re: [bug#57347] [PATCH] packages: Add man-pages-posix.
Date: Mon, 22 Aug 2022 22:33:59 -0500

On Tue, Aug 23, 2022 at 01:50:34AM +0200, Maxime Devos wrote:
> This package can easily be confused with 'man-pages' -- at least, I
> initially confused this as a duplicate of man-pages. Could the relationship
> be clarified in the description?
That's fair. How does this revised description sound? "Excerpts from the
POSIX.1-2008 and TC1 standards (collectively, POSIX.1-2013) in manual
page form. While the Linux man-pages project documents the system as it
exists, this package documents the portable software API nominally
implemented by many unix-likes."

> Maybe (assoc-ref %outputs "out") -> #$output and '(#:tests? ...) -> (list
> #:tests? #f #:make-flags #~(list ...) #:phases #~(...)), now we have G-exps.
Sounds good!

> Also, IIRC there's a #:make-target and #:parallel-build? #false
There is a #:parallel-build? #f, but no #:make-target field, as far as I
could tell. Though, the build phase doesn't explicitly target all, so it
would be possible to provide the gz target through #:make-flags.

But, also, all the build phase does is compress the manpages, which
could entirely be done by the compress-documentation phase with some
edits done to it; at the moment, its regex for detecting manpages
doesn't take into account the [023]p format of this package's manpages.

Thoughts?

> As a bonus, you could update the 'man-pages' package to the new G-exps,
> though not required.
Sure! I'll submit that with v2 as a patchset.

Thanks!
Lilah

Message #14 received at 57347 <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: Maxime Devos <maximedevos <at> telenet.be>, 57347 <at> debbugs.gnu.org
Subject: Re: [bug#57347] [PATCH] packages: Add man-pages-posix.
Date: Tue, 23 Aug 2022 08:08:58 -0500

On Tue, Aug 23, 2022 at 01:50:34AM +0200, Maxime Devos wrote:
> This package can easily be confused with 'man-pages' -- at least, I
> initially confused this as a duplicate of man-pages. Could the relationship
> be clarified in the description?
That's fair. How does this revised description sound? "Excerpts from the
POSIX.1-2008 and TC1 standards (collectively, POSIX.1-2013) in manual
page form. While the Linux man-pages project documents the system as it
exists, this package documents the portable software API nominally
implemented by many unix-likes."

> Maybe (assoc-ref %outputs "out") -> #$output and '(#:tests? ...) -> (list
> #:tests? #f #:make-flags #~(list ...) #:phases #~(...)), now we have G-exps.
Sounds good!

> Also, IIRC there's a #:make-target and #:parallel-build? #false
There is a #:parallel-build? #f, but no #:make-target field, as far as I
could tell. Though, the build phase doesn't explicitly target all, so it
would be possible to provide the gz target through #:make-flags.

But, also, all the build phase does is compress the manpages, which
could entirely be done by the compress-documentation phase with some
edits done to it; at the moment, its regex for detecting manpages
doesn't take into account the [023]p format of this package's manpages.

Thoughts?

> As a bonus, you could update the 'man-pages' package to the new G-exps,
> though not required.
Sure! I'll submit that with v2 as a patchset.

Thanks!
Lilah

Message #17 received at 57347 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Lilah Tascheter <lilah <at> lunabee.space>, 57347 <at> debbugs.gnu.org
Subject: Re: [bug#57347] [PATCH] packages: Add man-pages-posix.
Date: Fri, 26 Aug 2022 15:41:53 +0200

[Message part 1 (text/plain, inline)]

On 23-08-2022 05:33, Lilah Tascheter wrote:
> On Tue, Aug 23, 2022 at 01:50:34AM +0200, Maxime Devos wrote:
>> This package can easily be confused with 'man-pages' -- at least, I
>> initially confused this as a duplicate of man-pages. Could the relationship
>> be clarified in the description?
> That's fair. How does this revised description sound? "Excerpts from the
> POSIX.1-2008 and TC1 standards (collectively, POSIX.1-2013) in manual
> page form. While the Linux man-pages project documents the system as it
> exists, this package documents the portable software API nominally
> implemented by many unix-likes."
>
'as it exists' -> 'as it exists on Linux- and glibc-based systems', as 
we also support the Hurd.

Otherwise looks good to me.

>> Also, IIRC there's a #:make-target and #:parallel-build? #false
> There is a #:parallel-build? #f, but no #:make-target field, as far as I
> could tell. Though, the build phase doesn't explicitly target all, so it
> would be possible to provide the gz target through #:make-flags.
Right, there's a #:test-target but not #:make-target.
> But, also, all the build phase does is compress the manpages, which
> could entirely be done by the compress-documentation phase with some
> edits done to it; at the moment, its regex for detecting manpages
> doesn't take into account the [023]p format of this package's manpages.
>
> Thoughts?
I think we could do #:make-flags "gz" for now, extending the regex to 
[023]p is more of a long-term thing (while a simple change, it would 
cause many rebuilds and hence needs to be done on core-updates).

Greetings,
Maxime.

[Message part 2 (text/html, inline)]

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #20 received at 57347 <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: Maxime Devos <maximedevos <at> telenet.be>,
	57347 <at> debbugs.gnu.org
Cc: Lilah Tascheter <lilah <at> lunabee.space>
Subject: [PATCH v2 1/2] packages: Add man-pages-posix.
Date: Sat, 27 Aug 2022 18:37:54 -0500

* gnu/packages/man.scm (man-pages-posix): New variable.
---
 gnu/packages/man.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/man.scm b/gnu/packages/man.scm
index 1c1d82758b..a3c6bb6aa4 100644
--- a/gnu/packages/man.scm
+++ b/gnu/packages/man.scm
@@ -302,6 +302,38 @@ (define-public man-pages
     ;; Each man page has its own license; some are GPLv2+, some are MIT/X11.
     (license license:gpl2+)))
 
+(define-public man-pages-posix
+  (package
+    (name "man-pages-posix")
+    (version "2013-a")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kernel.org/linux/docs/man-pages/"
+                            "man-pages-posix/man-pages-posix-" version
+                            ".tar.xz"))
+        (sha256
+         (base32 "0258j05zdrxpgdj8nndbyi7bvrs8fxdksb0xbfrylzgzfmf3lqqr"))))
+    (build-system gnu-build-system)
+    (arguments
+      `(#:tests? #f
+        ;; The compress-documentation phase doesn't pick up on our manpages as
+        ;; its regex doesn't support trailing letters, so manually compress.
+        #:make-flags ,#~(list (string-append "prefix=" #$output) "gz")
+        #:license-file-regexp "POSIX-COPYRIGHT"
+        #:phases (modify-phases %standard-phases (delete 'configure))))
+    (home-page "https://www.kernel.org/doc/man-pages/")
+    (synopsis "Man pages from the POSIX.1-2013 standard")
+    (description "Excerpts from the POSIX.1-2008 and TC1 standards
+(collectively, POSIX.1-2013) in manual page form. While the Linux man-pages
+project documents the system as it exists on Linux- and glibc-based systems,
+this package documents the portable software API as nominally implemented by
+many unix-likes.")
+    (license (license:fsdg-compatible "file://POSIX-COPYRIGHT"
+               "Redistribution of this material is permitted so long as this
+notice and the corresponding notices within each POSIX manual page are retained
+on any distribution, and the nroff source is included."))))
+
 (define-public help2man
   ;; TODO: Manual pages for languages not available from the implicit
   ;; input "locales" contain the original (English) text.

base-commit: ff3cecffafad0ddf5cc2af6cb676e73bcf58e431
-- 
2.37.2

Message #23 received at 57347 <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: Maxime Devos <maximedevos <at> telenet.be>,
	57347 <at> debbugs.gnu.org
Cc: Lilah Tascheter <lilah <at> lunabee.space>
Subject: [PATCH v2 2/2] packages: Update man-pages package to newer style.
Date: Sat, 27 Aug 2022 18:37:55 -0500

* gnu/packages/man.scm (man-pages)[arguments]: Refer to package output
  using gexps instead of assoc-ref on a parameter.
---
 gnu/packages/man.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/man.scm b/gnu/packages/man.scm
index a3c6bb6aa4..863006f3cc 100644
--- a/gnu/packages/man.scm
+++ b/gnu/packages/man.scm
@@ -282,7 +282,7 @@ (define-public man-pages
         (base32 "12vb15gs56g8wl5nqlm4llr508brh4m2lfknhq4lizbxzqzawkb1"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:phases (modify-phases %standard-phases (delete 'configure))
+     `(#:phases (modify-phases %standard-phases (delete 'configure))
 
        ;; The 'all' target depends on three targets that directly populate
        ;; $(MANDIR) based on its current contents.  Doing that in parallel
@@ -290,9 +290,7 @@ (define-public man-pages
        #:parallel-build? #f
 
        #:tests? #f
-       #:make-flags (list (string-append "mandir="
-                                         (assoc-ref %outputs "out")
-                                         "/share/man"))))
+       #:make-flags ,#~(list (string-append "mandir=" #$output "/share/man"))))
     (home-page "https://www.kernel.org/doc/man-pages/")
     (synopsis "Development manual pages from the Linux project")
     (description
-- 
2.37.2

Message #26 received at 57347 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Lilah Tascheter <lilah <at> lunabee.space>, 57347 <at> debbugs.gnu.org
Subject: Re: [PATCH v2 1/2] packages: Add man-pages-posix.
Date: Mon, 29 Aug 2022 21:36:27 +0200

[Message part 1 (text/plain, inline)]

These two patches look good to me (not verified locally, but if it 
builds for you it should build for everyone).

Greetings,
Maxime (not a committer, though I do some reviewing)

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #31 received at 57347-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Lilah Tascheter <lilah <at> lunabee.space>
Cc: 57347-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#57347: [PATCH] packages: Add man-pages-posix.
Date: Thu, 08 Sep 2022 14:55:09 +0200

Hi Lilah,

Lilah Tascheter <lilah <at> lunabee.space> skribis:

> * gnu/packages/man.scm (man-pages-posix): New variable.

[...]

> * gnu/packages/man.scm (man-pages)[arguments]: Refer to package output
>   using gexps instead of assoc-ref on a parameter.

Applied (with minor tweaks to the man-pages-posix description), thanks!

And thank you Maxime for reviewing.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.