GNU bug report logs - #57337
[PATCH 0/2] Add docxbox

Previous Next

Full log

Message #41 received at 57337 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Wiktor Żelazny <wz <at> freeshell.de>
Cc: 57337 <at> debbugs.gnu.org
Subject: Re: [v2 1/2] gnu: Add miniz-cpp.
Date: Wed, 25 Jan 2023 23:17:18 +0100

Hi Wiktor,

Apologies for the delay.

Wiktor Żelazny <wz <at> freeshell.de> skribis:

> * gnu/packages/cpp.scm (miniz-cpp): New variable.
> ---
>  gnu/local.mk                                  |    1 +
>  gnu/packages/cpp.scm                          |   35 +
>  .../miniz-cpp-fixed-duplicated-symbols.patch  | 2734 +++++++++++++++++
>  3 files changed, 2770 insertions(+)
>  create mode 100644 gnu/packages/patches/miniz-cpp-fixed-duplicated-symbols.patch

That’s a pretty big patch, and we don’t usually take that big a patch
downstream, but…

> +                (patches (search-patches
> +                          ;; To be removed once https://github.com/tfussell/miniz-cpp/pull/11
> +                          ;; gets merged.
> +                          "miniz-cpp-fixed-duplicated-symbols.patch"))))

Looking at the GitHub issue, it seems the solution could be merge soon.

How about (1) pinging upstream asking whether they could merge it, and
(2) referring to the commit of this pull request in the package
definition in the meantime, with a comment explaining why?

Thanks in advance,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.