GNU bug report logs - #57337
[PATCH 0/2] Add docxbox

Previous Next

Full log

Message #20 received at 57337 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Wiktor Żelazny <wz <at> freeshell.de>
Cc: Wiktor Żelazny <wzelazny <at> vurv.cz>, 57337 <at> debbugs.gnu.org
Subject: Re: bug#57337: [PATCH 0/2] Add docxbox
Date: Thu, 08 Sep 2022 14:49:15 +0200

Wiktor Żelazny <wz <at> freeshell.de> skribis:

> From: Wiktor Żelazny <wzelazny <at> vurv.cz>
>
> * gnu/packages/textutils.scm (docxbox): New variable.

[...]

> +              (snippet '(begin
> +                          (for-each delete-file-recursively
> +                                    '("bin" "vendor/json" "vendor/miniz-cpp"
> +                                      "vendor/tinyxml2")) #t))))

You can remove the trailing #t, it’s no longer necessary.

> +    (build-system cmake-build-system)
> +    ;; (native-inputs (list bats)) ; Enable after fixing tests, use bash module
> +    (inputs `(("json-modern-cxx-source" ,(package-source json-modern-cxx))
> +              ("miniz-cpp-source" ,(package-source miniz-cpp))
> +              ("tinyxml2-source" ,(package-source tinyxml2))))

I’d suggest using the new style, which is to refer to those right in the
code, like so:

  (arguments
    (list #:phases #~(modify-phases …
                       …
                       (invoke "tar" "xf" #$(package-source whatever)))))

However, it would be best if, instead of re-building those three
libraries, docxbox would instead link against the .so provided by their
respective packages.

> +    (synopsis "CLI tool for MS Word DOCX templating and analysis")

s/CLI/Command-line/ (in general, avoid acronyms)

s/DOCX/@file{.docx}/ I would say.

Could you send updated patches?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.