GNU bug report logs - #57334
28.1; Fix wdired with (dired '(dir f1 f2 ...))

Previous Next

Full log

View this message in rfc822 format

From: Thierry Volpiatto <thievol <at> posteo.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57334 <at> debbugs.gnu.org
Subject: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...))
Date: Tue, 23 Aug 2022 10:53:12 +0000

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Thierry Volpiatto <thievol <at> posteo.net> writes:
>
>> The tests succeed with following patch (avoid setting dired-directory to
>> nil).
>
> Michael noted that there's more fundamental problems in this area,

Indeed there is other problems, like Michael mentionned but also Eli.

I had also problems with `wdired-get-filename` which at the end use
(concat dir file) instead of (expand-file-name file dir).
If filename is absolute we endup with
e.g. "/home/you/tmp//home/you/tmp/foo.txt" instead of
"/home/you/tmp/foo.txt".
Curiously this happen in emacs-28 but not in 29 (why I submitted no
patch for this).

> so perhaps more work is needed later, but your change makes sense
> anyway, I think, so I've now pushed it to Emacs 29.

Great thanks.

-- 
Thierry

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.