From unknown Sat Sep 20 14:39:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#57334 <57334@debbugs.gnu.org> To: bug#57334 <57334@debbugs.gnu.org> Subject: Status: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Reply-To: bug#57334 <57334@debbugs.gnu.org> Date: Sat, 20 Sep 2025 21:39:45 +0000 retitle 57334 28.1; Fix wdired with (dired '(dir f1 f2 ...)) reassign 57334 emacs submitter 57334 Thierry Volpiatto severity 57334 normal tag 57334 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 02:36:18 2022 Received: (at submit) by debbugs.gnu.org; 22 Aug 2022 06:36:19 +0000 Received: from localhost ([127.0.0.1]:37632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ12o-000799-72 for submit@debbugs.gnu.org; Mon, 22 Aug 2022 02:36:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:52062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ12k-00078z-6r for submit@debbugs.gnu.org; Mon, 22 Aug 2022 02:36:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ12j-00043i-KA for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 02:36:14 -0400 Received: from mout01.posteo.de ([185.67.36.65]:57919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ12g-0001yA-Qt for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 02:36:13 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 736E124002A for ; Mon, 22 Aug 2022 08:36:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661150165; bh=Ps/U5Plxo0TCm8GgEPhjT/RYht48aqNTEDnxFDfGEzo=; h=From:To:Subject:Date:Autocrypt:OpenPGP:From; b=cvu+4Fy/1F4UMYdKKAYeer20pJmXb8SX9cokdQVmbgeeoGWRbGZxhdhXxX4FYJ2ET Jfn1JQzhskdSOPx9CD3VRNEM5vuQ6bTgDZdrkhBqOA3O8RzipKFaW2jP6Hi+JziPYL 9gkSIhZ3HLN/FCbPf9Lu6iyfvtR+goP145Bn7/k8kCHlsKsN4+toUMfb7pnCGLSNf3 naZ+TsyamsqH75LtPhrY5GZTBKUxVoAcLJF5qNlF4J206Ca/x3yoIknpXtirEgvcwc 2mYXOu723XqfEwMsScqPsUJzAer83JFRugUoqzGmG/d5FGdzzOuiE3GZiSCw58YT7I dyt23Ljt1kAaA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MB2gS3K8sz9rxG for ; Mon, 22 Aug 2022 08:36:03 +0200 (CEST) From: Thierry Volpiatto To: bug-gnu-emacs@gnu.org Subject: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Mon, 22 Aug 2022 06:23:52 +0000 Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <878rng23aq.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello Emacs, there is an action in helm that allows creating a dired buffer with marked files for further editing with wdired. For this I have to call dired with its dirname argument as a list: (dired ' (dir f1 f2 f3)) Unfortunately this is broken since years and until now I had to use an advi= ce to fix it. The advice is working up to emacs-28.1 but now it becomes difficult to write an advice compatible with all emacs versions, here is a patch to apply on 29.0.50. To reproduce the bug from emacs -Q: 1) Ensure ~/tmp/test.txt and ~/tmp/test2.txt exist 2) (dired '("~/tmp" "/home/thierry/tmp/test.txt" "/home/thierry/tmp/test2.t= xt")) 3) M-x wdired-change-to-dired-mode (C-x C-q) 4) Rename test.txt to test1.txt 5) C-x C-s diff --git a/lisp/wdired.el b/lisp/wdired.el index 106d57174d5..7322eeff872 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -537,15 +537,23 @@ non-nil means return old filename." (wdired-change-to-dired-mode) (if changes (progn - ;; If we are displaying a single file (rather than the - ;; contents of a directory), change dired-directory if that - ;; file was renamed. (This ought to be generalized to - ;; handle the multiple files case, but that's less trivial). - (when (and (stringp dired-directory) - (not (file-directory-p dired-directory)) - (null some-file-names-unchanged) - (=3D (length files-renamed) 1)) - (setq dired-directory (cdr (car files-renamed)))) + (cond ((and (stringp dired-directory) + (not (file-directory-p dired-directory)) + (null some-file-names-unchanged) + (=3D (length files-renamed) 1)) + (setq dired-directory (cdr (car files-renamed)))) + ;; Fix dired buffers created with + ;; (dired '(foo f1 f2 f3)). + ((and (consp dired-directory) + (cdr dired-directory) + files-renamed) + (setcdr dired-directory + ;; Replace in `dired-directory' files that have + ;; been modified with their new name keeping + ;; the ones that are unmodified at the same place. + (cl-loop for f in (cdr dired-directory) + collect (or (assoc-default f files-renam= ed) + f))))) ;; Re-sort the buffer. (revert-buffer) (let ((inhibit-read-only t)) In GNU Emacs 28.1 (build 2, x86_64-pc-linux-gnu, Motif Version 2.3.8, cairo= version 1.16.0) of 2022-04-20 built on IPad-S340 Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Linux Mint 20.3 Configured using: 'configure CFLAGS=3D-O8 --with-mailutils --with-cairo --without-dbus --without-gconf --without-gsettings --with-x-toolkit=3Dmotif' Configured features: ACL CAIRO FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM MOTIF ZLIB Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: =C4=B0=C4=BD Minor modes in effect: global-undo-tree-mode: t undo-tree-mode: t psession-mode: t psession-savehist-mode: t global-git-gutter-mode: t display-time-mode: t winner-mode: t helm-epa-mode: t helm-descbinds-mode: t helm-adaptive-mode: t helm-mode: t helm-minibuffer-history-mode: t helm-ff-icon-mode: t shell-dirtrack-mode: t helm-popup-tip-mode: t async-bytecomp-package-mode: t dired-async-mode: t minibuffer-depth-indicate-mode: t gcmh-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow epa-mail face-remap emacsbug helm-command whitespace tabify tramp-cache tv-mu4e-config mu4e-contrib mu4e-patch mu4e mu4e-org mu4e-main mu4e-view gnus-art mm-uu mml2015 mm-view mml-smime smime dig mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail sendmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message flow-fill hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-vars mu4e-helpers mu4e-config ido helm-ring helm-dabbrev smerge-mode helm-x-files helm-for-files image-file image-converter char-fold tramp-archive tramp-gvfs rst vc-filewise vc-rcs conf-mode ledger-config ledger-mode ledger-check ledger-texi ledger-test ledger-sort ledger-report ledger-reconcile ledger-occur ledger-fonts ledger-fontify ledger-state ledger-complete ledger-schedule ledger-init ledger-xact ledger-post ledger-exec ledger-navigate eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util ledger-context ledger-commodities ledger-regex checkdoc lisp-mnt markdown-mode make-mode flymake-shellcheck flymake-proc flymake project warnings sh-script smie executable bug-reference naquadah-theme solar cal-dst holidays hol-loaddefs tv-utils osm yaml-mode undo-tree diff queue rainbow-mode color psession frameset log-view pcvs-util bash-completion cl-indent pcase ffap thingatpt autocrypt-message autocrypt-gnus addressbook-bookmark gnus-sum shr kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win message rmc puny rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 mail-utils mm-util mail-prsvr autocrypt-mu4e autocrypt ietf-drums config-w3m git-gutter mule-util appt diary-lib diary-loaddefs gud wdired dired-extension org-config ob-gnuplot org-crypt net-utils time winner autotest-mode autoconf-mode woman man ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util init-helm helm-ls-git vc-git diff-mode vc vc-dispatcher helm-fd epa derived epg rfc6068 epg-config helm-epa helm-imenu imenu helm-elisp-package helm-find helm-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol rx org-keys oc org-compat advice org-macs org-loaddefs cal-menu calendar cal-loaddefs helm-external isearch-light helm-descbinds helm-wikipedia all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons cus-edit wid-edit helm-ipython helm-elisp helm-eval edebug backtrace find-func python tramp-sh helm-bookmark helm-net xml helm-info bookmark pp helm-adaptive helm-mode helm-misc helm-files image-dired image-mode exif filenotify tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep wgrep-helm wgrep grep compile text-property-search comint ring helm-regexp format-spec ansi-color helm-utils helm-help helm-types helm-extensions-autoloads helm-config helm-autoloads helm helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source helm-multi-match helm-lib dired-async dired-aux dired dired-loaddefs async popup diminish mb-depth server edmacro kmacro avoid cus-load gcmh cl-extra help-mode use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib info w3m-load iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads inotify lcms2 dynamic-setting font-render-setting cairo motif x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 895555 348095) (symbols 48 43408 4) (strings 32 257791 42475) (string-bytes 1 7581558) (vectors 16 88254) (vector-slots 8 1888821 470585) (floats 8 3310 1630) (intervals 56 21597 12985) (buffers 992 134)) <#secure method=3Dpgpmime mode=3Dsign> --=20 Thierry From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 06:27:21 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 10:27:21 +0000 Received: from localhost ([127.0.0.1]:37983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ4eO-0000la-O6 for submit@debbugs.gnu.org; Mon, 22 Aug 2022 06:27:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ4eM-0000lL-Pl for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 06:27:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8Kx5CfEEK6LL/dSB3J0dadQU0ijYBAefsUHfdXfCY60=; b=fp2TElGX/3iyIJ6N4yP5PNW1J1 //3IZAuuRiU55COlJeZi9UZyCcRIu+HKvvVGXSgkb5m5GkyszAVkgp6hFLzixyh51ptdTXMa4gRNY J3FyA2C3EDq4g7hpsEPRfUapFb0XV8P37FKyfdbfx9OgUO3wGZf3wWvEtrSujPgCBvyc=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ4eE-0004Pn-7I; Mon, 22 Aug 2022 12:27:12 +0200 From: Lars Ingebrigtsen To: Thierry Volpiatto Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) In-Reply-To: <878rng23aq.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 22 Aug 2022 06:23:52 +0000") References: <878rng23aq.fsf@posteo.net> X-Now-Playing: Bertine Zetlitz's _Sweet Injections_: "Blow over" Date: Mon, 22 Aug 2022 12:27:09 +0200 Message-ID: <877d30bmki.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thierry Volpiatto writes: > + (setcdr dired-directory > + ;; Replace in `dired-directory' files that have > + ;; been modified with their new name keeping > + ; ; the ones that are unmodified at the same place. > + (cl-loop for [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thierry Volpiatto writes: > + (setcdr dired-directory > + ;; Replace in `dired-directory' files that have > + ;; been modified with their new name keeping > + ;; the ones that are unmodified at the same place. > + (cl-loop for f in (cdr dired-directory) > + collect (or (assoc-default f files-renamed) > + f))))) This isn't obviously safe -- I think you're changing the list that `dired' was originally called with here, which we shouldn't do. (It may even be a constant.) So I think this should be changed to not do that. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 06:27:25 2022 Received: (at control) by debbugs.gnu.org; 22 Aug 2022 10:27:25 +0000 Received: from localhost ([127.0.0.1]:37986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ4eT-0000ls-3d for submit@debbugs.gnu.org; Mon, 22 Aug 2022 06:27:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ4eQ-0000lQ-L6 for control@debbugs.gnu.org; Mon, 22 Aug 2022 06:27:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/g7mnrAOZkviTQ0BOfhBp2CnUw+QNjn2exxDmVrsrtk=; b=l7JlfiyttCKIumfkrQsX7387KL U8NgLvf6/R1W1vqQGFkOH1T617dQEpox5X+7iotp0aqvJyM46BphCfGwFZbr8TNQ28nrvC7qSaY0K +PXzHMGPkF1j2DjN80sUfFKejwyUnUPpHzTR9F/WIhe0QSGEBVPU7Dp6t029fmFxvp+Q=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ4eI-0004Pv-TQ for control@debbugs.gnu.org; Mon, 22 Aug 2022 12:27:16 +0200 Date: Mon, 22 Aug 2022 12:27:14 +0200 Message-Id: <875yikbmkd.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57334 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 57334 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 57334 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 07:27:02 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 11:27:02 +0000 Received: from localhost ([127.0.0.1]:38141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ5aA-0002bM-9f for submit@debbugs.gnu.org; Mon, 22 Aug 2022 07:27:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ5a8-0002b4-Ru for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 07:27:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40698) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ5a3-0006I0-LE; Mon, 22 Aug 2022 07:26:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DYMqTBPLirTdc7KrzMcsKTBWK+TzomxMOS7FOE2A25Q=; b=XypS0MoogJka RSmuSYg6HGoFgsEhl3qMrN1TGXnv0sBmEJUmRzN/TYbanGtwLze0my0+S6+N+HC9LkiH8x+3sVLEG QJGslpYzq0G6iA940QfY6bX91ABadZ3FpccIKOckKIT1x9vSAmU4F2//iJ78eQNv2O7/rBAVZnbMR JqDgcjhVMxKczsBEFzoJpV9EKbv277iGgNvabIMLBs0yAums9TrdcaZZj9piXAUNV4ie4fORMyDt7 c6mSLs/fO7g3UI6VPdv5hrgAd3GlZuRzCsszvnG02yYgHPkV9U1kCCAqyLQ6jfA4sFnAqtbV17plp Vz4TSnci9XJ5Q3AZvKyixw==; Received: from [87.69.77.57] (port=2374 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ5a3-0001BK-0B; Mon, 22 Aug 2022 07:26:55 -0400 Date: Mon, 22 Aug 2022 14:26:58 +0300 Message-Id: <83czcsbjst.fsf@gnu.org> From: Eli Zaretskii To: Thierry Volpiatto In-Reply-To: <878rng23aq.fsf@posteo.net> (message from Thierry Volpiatto on Mon, 22 Aug 2022 06:23:52 +0000) Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) References: <878rng23aq.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Thierry Volpiatto > Date: Mon, 22 Aug 2022 06:23:52 +0000 > > there is an action in helm that allows creating a dired buffer with > marked files for further editing with wdired. > For this I have to call dired with its dirname argument as a list: > (dired ' (dir f1 f2 f3)) > Unfortunately this is broken since years and until now I had to use an advice > to fix it. > The advice is working up to emacs-28.1 but now it becomes difficult to > write an advice compatible with all emacs versions, here is a patch to > apply on 29.0.50. > > To reproduce the bug from emacs -Q: > > 1) Ensure ~/tmp/test.txt and ~/tmp/test2.txt exist > 2) (dired '("~/tmp" "/home/thierry/tmp/test.txt" "/home/thierry/tmp/test2.txt")) > 3) M-x wdired-change-to-dired-mode (C-x C-q) > 4) Rename test.txt to test1.txt > 5) C-x C-s Is this the same problem as reported here: https://lists.gnu.org/archive/html/help-gnu-emacs/2022-08/msg00093.html And if so, does the patch I posted in response, here: https://lists.gnu.org/archive/html/help-gnu-emacs/2022-08/msg00102.html solve it, perhaps? From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 10:51:29 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 14:51:29 +0000 Received: from localhost ([127.0.0.1]:41443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8m0-0002xl-TJ for submit@debbugs.gnu.org; Mon, 22 Aug 2022 10:51:29 -0400 Received: from mout01.posteo.de ([185.67.36.65]:58527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8lv-0002xU-FW for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 10:51:27 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DC9FB24002C for <57334@debbugs.gnu.org>; Mon, 22 Aug 2022 16:51:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661179876; bh=smONrUsYhC7plU00HJ7y7QuenX28goDILMgV/OB37Ok=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=JTODczDjFriY55MKQYKGqnk4nGe5ti7F5/eW7Mvu5zKxw6aesKyj27FbqN1jFHPJV T7Zo1xX+MYk//n8eDfR6ku1lLfvdGxEyZYI2DGiAjLcsVTKT9zXBlEdOzScvlSf7s6 afktEmvoJWBXXsszPhW0EPHpibhZrYI5o/3zeB65nCyJEA/xa2qoZCiG/tXpKMuLBg ruVOaB09E4V+SiYgPWBhd/3ZxHooGor9lMEl7ATbegjKh9nUhiNhg5FZYJv/prTU5D sKZyv+wj9NAwsHMEj6synqvlkGBYf1uYChVzrZVtPHCWmEpVZYH3ZBWZNurk0MxPd1 fFGOHkTQxrCOw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MBFfp4Q09z9rxh; Mon, 22 Aug 2022 16:51:13 +0200 (CEST) References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> From: Thierry Volpiatto To: Lars Ingebrigtsen Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Mon, 22 Aug 2022 14:42:31 +0000 In-reply-to: <877d30bmki.fsf@gnus.org> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <875yik49ic.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Thierry Volpiatto writes: > >> + (setcdr dired-directory >> + ;; Replace in `dired-directory' files that have >> + ;; been modified with their new name keeping >> + ;; the ones that are unmodified at the same pl= ace. >> + (cl-loop for f in (cdr dired-directory) >> + collect (or (assoc-default f files-re= named) >> + f))))) > > This isn't obviously safe -- I think you're changing the list that > `dired' was originally called with here, Of course it have to be changed, it has been modified by wdired at this poi= nt, so if you want to redisplay a dired buffer reflecting your changes you have to modify it no ? > which we shouldn't do. You already do it when DIRNAME is a string isn't it? > (It may even be a constant.) Can you elaborate? > So I think this should be changed to not do that. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmMDl9sTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk8txC/wMCXW9u/HO2ChnNpUX3pEKzJnguHl2 3j27Nodo8G893TmlQyDeM75yoUugezc9rsp5ZIHIWimqPd1fuhmenwAnJTuxRUM2 Ajwp6PrlbIuuRT0YDlZSG/89h+v6+fwphg/MqhRrP6VTRIoXlU/NoWY7DGwpY6JL 9ivUM0nsGsxR1vub4KVvFFUBYFAv4tV03I++M1pPWrmTnTyzfJ6v1omCh/XcoGOI odyrc0/xoEI3l3KC/LhQxiS1pV3fT3CNd29EQcsJbZbcBtuDdBG8Ic3lNfE5AvWg YVNohYlrQeV0lcuW3ihzHe2g2BVBQl2PzREvdk+VpojVSqAdUWoheLTyTrLULy7c l+QI1fLTB19HJuIOseshvZFd71aGBilmDa8Q9mnYbfermJJcU+oHPDU3KDLgVoZt tPWXNGZDxG9vUQ2iUcSfpZoJE9zZp8nHqVQljGFGDAg/hJSN3dZL7xAQpBhfQ1xh n7L8xMz8z8pz1YptINULlHzzg8i8Or4YqbA= =yn5l -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 10:53:30 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 14:53:30 +0000 Received: from localhost ([127.0.0.1]:41447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8ny-00030f-CP for submit@debbugs.gnu.org; Mon, 22 Aug 2022 10:53:30 -0400 Received: from mout01.posteo.de ([185.67.36.65]:58337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8nw-00030S-UO for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 10:53:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5FC19240027 for <57334@debbugs.gnu.org>; Mon, 22 Aug 2022 16:53:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661180003; bh=wYWKQCDgFi1qBFJ9evOqNisFxAjPDNyX6SX2O+likBw=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=bK5uKd1Vg9TLaouunnJciWf1wd/Hwn0AOm+t3krzPPnVjW8GuP5wLJpkY9GvjxHl2 GwKdJpWze29mhst7m89X2igBSL/aVI+N1WwuXHxbP5bb5GUtmw8ZZg4V1kMFNTvfoL YmTKeRBw0Tw1Okr2xlQJkxoUGLRyvFKK5UfEJ/ByLcn1PHGPSfUjuwZSqceZd0zz1w asPcgcf5TbW9x9u6paXXfiemmb3B6IcA4sRrAXZP0XrFQ4UIPM0HqP+/3FlUXf8HNB J0p6LxTmXpZI6oEp9/qlw6Oo6knojRelZNByQ9SJwhZbjPZ3X5+0YzQ8P+ugBUOTP1 Yki2idTJ0slag== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MBFjG2rMzz6tmJ; Mon, 22 Aug 2022 16:53:19 +0200 (CEST) References: <878rng23aq.fsf@posteo.net> <83czcsbjst.fsf@gnu.org> From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Mon, 22 Aug 2022 14:51:31 +0000 In-reply-to: <83czcsbjst.fsf@gnu.org> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <871qt849et.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Thierry Volpiatto >> Date: Mon, 22 Aug 2022 06:23:52 +0000 >>=20 >> there is an action in helm that allows creating a dired buffer with >> marked files for further editing with wdired. >> For this I have to call dired with its dirname argument as a list: >> (dired ' (dir f1 f2 f3)) >> Unfortunately this is broken since years and until now I had to use an a= dvice >> to fix it. >> The advice is working up to emacs-28.1 but now it becomes difficult to >> write an advice compatible with all emacs versions, here is a patch to >> apply on 29.0.50. >>=20 >> To reproduce the bug from emacs -Q: >>=20 >> 1) Ensure ~/tmp/test.txt and ~/tmp/test2.txt exist >> 2) (dired '("~/tmp" "/home/thierry/tmp/test.txt" "/home/thierry/tmp/test= 2.txt")) >> 3) M-x wdired-change-to-dired-mode (C-x C-q) >> 4) Rename test.txt to test1.txt >> 5) C-x C-s > > Is this the same problem as reported here: > > https://lists.gnu.org/archive/html/help-gnu-emacs/2022-08/msg00093.html Not really, the dired call is more or less the same but the action is different, here it is wdired which is involved. > And if so, does the patch I posted in response, here: > > https://lists.gnu.org/archive/html/help-gnu-emacs/2022-08/msg00102.html > > solve it, perhaps? Didn't try but I guess no. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmMDmFoTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk0ZHC/wPisUIMbBRORhyGI0F9GQsMHztw2Ti p5kg+f0YNXu0Y4BzRiwO1743jMN0KAFIbXXncMZbcO5LVbUCR1UmdKnp/PWbKoTL 6fSvUeQcJ2H7Loe6m3r7cfSPLf6o10//W/r8cLo/Jv2a1xiWq/WLJgDxNnBfqqPS 9H5BmyDElY37W1+5/QIcP4YuFLuBIHbLMA9WJyd2Jy5JOF0OYJKMKNIuNVgXS9YG lluvnecvSawUfJv5dVnQoVn6hUZMOsh6M0fM8S7ZSdfusC2azKqB3BIDHakPc782 Rn6R1a9VK4PSBTjmlZkvZfIL4S+szWEVOTXAQ+C61NUOKIEEoEbNSseuiCbMiTuO 8xDcjLOb2EjCSumWTP8AvVIfhh8vEAoDyOg37BVOu9GhqfAgL/IwXkKn3ksrHSKw ayQ3p2JQsUxkv0TXlLDaH2C631BkOITjPlpMnpVJGF/YE6UfC2DgoZNmHBjVDodb nPUh8p4noflnPh4InF7y+LAgn+6afey5tIU= =OLhl -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 10:55:06 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 14:55:06 +0000 Received: from localhost ([127.0.0.1]:41450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8pV-00033C-Uv for submit@debbugs.gnu.org; Mon, 22 Aug 2022 10:55:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8pT-00032c-Gz for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 10:55:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=49s/J6I5M7yxlL/ZdV7ZkqqwU4qF+qcH8v86IdtZvl8=; b=CVghB6O86B/B+5bWuu2zA88gjz veYhHJ9t3IABRINqQZJAjOS6dxDmvq3koBZ3sXykXpgBXfRB9l1hqeAdR/K2j0aF95ql6yNKJrk6Q l/g+jiaINoT03nRDNkKe55tg4YYQOUrBW2kyoXyZuUGSZ9e9jn8TscTJkj/MOJJQGMXw=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ8pL-0006eP-7d; Mon, 22 Aug 2022 16:54:57 +0200 From: Lars Ingebrigtsen To: Thierry Volpiatto Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) In-Reply-To: <875yik49ic.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 22 Aug 2022 14:42:31 +0000") References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXv4c/BtaeJgHdW UUv///8yXQ++AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YIFg40ChiqJl4AAAGkSURBVDjLXVOLFcMg CARdAM0Cigsksv9uBVFjw2sT4/HxDgQkWPauzAIXoJgpI3aCYlv6wAKx9atH5tYqCzexVe9sgDTO 7elcxX79ynLxUzQVdw5Xy5wSM+tf/TgXQC7wb+wvZPoA8zvKnedOhUBNhukBMZkHU7jVFfWTrdLK glBj13c7I4pXiY+7vBGEZdcAnBHiuRK8iqVh80MgllVsPGlTCWU40wSS5wlSNIKm/1eIZfhApnEO 1S2xBX7aFYQly/Axf+V+H+G2OwlaLlxAdD5pSTTkmQz/0jsPTw4ZPoYzrGn9UHDEBTribWvL+Q7X 0V6smGmxul4ghUe73eaR0Iu3fp6NVI84glD7gy9j2sSCSBkk0oiqWz0HtlVY/QVvtbWW1hC4DJcK WbFOgKgeco23Z3cyx8XawNgKe2UAvnyS8qDBIi2JNJWuaaiiRUdOnBkZkRC+VnVa3EXnzC+FF692 13CfzP+7M/j3pIR2o+Zs6+CmCaRzNHbxHBIvtUuU0uwI8pxOCgQ2HhkcsI7Q8tKhhUsB624sKDek GT5AB3S8uPwAvKgswflmujsAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDgtMjJUMTQ6NTI6MTAr MDA6MDCcT/BSAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA4LTIyVDE0OjUyOjEwKzAwOjAw7RJI 7gAAAABJRU5ErkJggg== X-Now-Playing: Jordan Rakei's _Blue Note Re:imagined (1)_: "Wind Parade" Date: Mon, 22 Aug 2022 16:54:54 +0200 Message-ID: <877d3049c1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thierry Volpiatto writes: >>> + (setcdr dired-directory [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thierry Volpiatto writes: >>> + (setcdr dired-directory [...] > Of course it have to be changed, it has been modified by wdired at this point, > so if you want to redisplay a dired buffer reflecting your changes you > have to modify it no ? I don't understand what you mean. >> which we shouldn't do. > > You already do it when DIRNAME is a string isn't it? Strings can't be modified. >> (It may even be a constant.) > > Can you elaborate? If the list is in purespace, for instance, it can't be modified. In case there's any misunderstanding here, I'm talking about the destructive alteration of the list pointed to by dired-directory by that `setcdr' -- not the altering of the dired-directory variable. So the safe change here would be something like (setq dired-directory (cons (car dired-directory) (mapcar ...))) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 10:59:48 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 14:59:48 +0000 Received: from localhost ([127.0.0.1]:41453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8u4-00039X-K1 for submit@debbugs.gnu.org; Mon, 22 Aug 2022 10:59:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8u2-00039K-Cf for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 10:59:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3ggd1VzxOmkKVXE+0CcnqNO4WGw0YcIOiGXpva3XJHU=; b=XYb7sXfCvJ9UmTG+LYKkQKFQRP UHFKEEHI9GnqqAP5XOC5DMJsYr+V4KAVvvV62wyDi5+TTsRpdviuzENRap7jeGzgW+8+OJ96HXIIX YkAryUpAvSxtCb9NxoSuMsVMLXPPl3Ay/nj29cs2ZyU/sD3/km4cHNJ4GIbQ4JCIFrjs=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ8tu-0006hb-AW; Mon, 22 Aug 2022 16:59:40 +0200 From: Lars Ingebrigtsen To: Thierry Volpiatto Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) In-Reply-To: <877d3049c1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 22 Aug 2022 16:54:54 +0200") References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXv4c/BtaeJgHdW UUv///8yXQ++AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YIFg40ChiqJl4AAAGkSURBVDjLXVOLFcMg CARdAM0Cigsksv9uBVFjw2sT4/HxDgQkWPauzAIXoJgpI3aCYlv6wAKx9atH5tYqCzexVe9sgDTO 7elcxX79ynLxUzQVdw5Xy5wSM+tf/TgXQC7wb+wvZPoA8zvKnedOhUBNhukBMZkHU7jVFfWTrdLK glBj13c7I4pXiY+7vBGEZdcAnBHiuRK8iqVh80MgllVsPGlTCWU40wSS5wlSNIKm/1eIZfhApnEO 1S2xBX7aFYQly/Axf+V+H+G2OwlaLlxAdD5pSTTkmQz/0jsPTw4ZPoYzrGn9UHDEBTribWvL+Q7X 0V6smGmxul4ghUe73eaR0Iu3fp6NVI84glD7gy9j2sSCSBkk0oiqWz0HtlVY/QVvtbWW1hC4DJcK WbFOgKgeco23Z3cyx8XawNgKe2UAvnyS8qDBIi2JNJWuaaiiRUdOnBkZkRC+VnVa3EXnzC+FF692 13CfzP+7M/j3pIR2o+Zs6+CmCaRzNHbxHBIvtUuU0uwI8pxOCgQ2HhkcsI7Q8tKhhUsB624sKDek GT5AB3S8uPwAvKgswflmujsAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDgtMjJUMTQ6NTI6MTAr MDA6MDCcT/BSAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA4LTIyVDE0OjUyOjEwKzAwOjAw7RJI 7gAAAABJRU5ErkJggg== X-Now-Playing: Alfa Mist's _Blue Note Re:imagined (1)_: "Galaxy" Date: Mon, 22 Aug 2022 16:59:37 +0200 Message-ID: <8735do4946.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Strings can't be modified. (Well, that's not accurate -- you can modify (some) strings with `aset'.) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Strings can't be modified. (Well, that's not accurate -- you can modify (some) strings with `aset'.) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 11:51:55 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 15:51:55 +0000 Received: from localhost ([127.0.0.1]:41540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ9iU-0000PM-JV for submit@debbugs.gnu.org; Mon, 22 Aug 2022 11:51:54 -0400 Received: from mout01.posteo.de ([185.67.36.65]:39551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ9iR-0000P8-50 for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 11:51:52 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D2D13240028 for <57334@debbugs.gnu.org>; Mon, 22 Aug 2022 17:51:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661183504; bh=lteM5mzp/wVvQSLuTR8fao+WSsLmFCGmhZWXz/P7LZE=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=SHB4wtpyp2d+pP6vB6DZ+xeLw2H58dT45L7bU3H1kyNX10MnuBYnR8pFyUJ7YBIZF FPAtA3LnSokx6tK2JQAuQJFP9yCqkD7Q+BQPweMWA1l2vYj8H9spZ3UADGyQAEFFUV 0ghIp0bq2KM74XsWhjlZB0+pu/rBcrPHNIq59fuVKXbo9Z0rvyEi3kOZQBe00pq/Yt ne7aTbaFBVFP+5+BtReVD7/m6TPZlaYIJeZTSjy6gcbjb1giGICe0lNkxkWWImNUL8 bP71r0U059RN1fEdkiL2LABHPWkSJqKxag2wkVFEoqc5je0csyWxJ5UJpB3GMlOObO 1OUKtvPDh9Tdw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MBH0b3y8dz6tpL; Mon, 22 Aug 2022 17:51:43 +0200 (CEST) References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> From: Thierry Volpiatto To: Lars Ingebrigtsen Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Mon, 22 Aug 2022 15:45:03 +0000 In-reply-to: <877d3049c1.fsf@gnus.org> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <87sflo2s52.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Thierry Volpiatto writes: > >>>> + (setcdr dired-directory > > [...] > >> Of course it have to be changed, it has been modified by wdired at this = point, >> so if you want to redisplay a dired buffer reflecting your changes you >> have to modify it no ? > > I don't understand what you mean. Well, you dired buffer is not the same before and after editing and saved. >>> which we shouldn't do. >> >> You already do it when DIRNAME is a string isn't it? > > Strings can't be modified. You are speaking of destructive operations, ok, I am just saying you just modify the string non destructively yes, but you modify it. >>> (It may even be a constant.) >> >> Can you elaborate? > > If the list is in purespace, for instance, it can't be modified. Yes but I hardly see how it would be the case for this. > In case there's any misunderstanding here, I'm talking about the > destructive alteration of the list pointed to by dired-directory by that > `setcdr' -- not the altering of the dired-directory variable. So the > safe change here would be something like > > (setq dired-directory (cons (car dired-directory) (mapcar ...))) Ok, so here a new patch which works same as the previous: diff --git a/lisp/wdired.el b/lisp/wdired.el index 106d57174d5..74d05a093b4 100644 =2D-- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -537,15 +537,27 @@ non-nil means return old filename." (wdired-change-to-dired-mode) (if changes (progn =2D ;; If we are displaying a single file (rather than the =2D ;; contents of a directory), change dired-directory if that =2D ;; file was renamed. (This ought to be generalized to =2D ;; handle the multiple files case, but that's less trivial). =2D (when (and (stringp dired-directory) =2D (not (file-directory-p dired-directory)) =2D (null some-file-names-unchanged) =2D (=3D (length files-renamed) 1)) =2D (setq dired-directory (cdr (car files-renamed)))) + (setq dired-directory + (cond (;; If we are displaying a single file (rather than the + ;; contents of a directory), change dired-directory if that + ;; file was renamed. + (and (stringp dired-directory) + (not (file-directory-p dired-directory)) + (null some-file-names-unchanged) + (=3D (length files-renamed) 1)) + (cdr (car files-renamed))) + ;; Fix dired buffers created with + ;; (dired '(foo f1 f2 f3)). + ((and (consp dired-directory) + (cdr dired-directory) + files-renamed) + (cons (car dired-directory) + ;; Replace in `dired-directory' files that ha= ve + ;; been modified with their new name keeping + ;; the ones that are unmodified at the same p= lace. + (cl-loop for f in (cdr dired-directory) + collect (or (assoc-default f files-r= enamed) + f)))))) ;; Re-sort the buffer. (revert-buffer) (let ((inhibit-read-only t)) =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmMDpgkTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkzXIC/0dFt5gVHVVsn8C72LL4Zh1y/CWk6CQ KRj6MPh4aiXSRBppbLAU6AwyKNilKHdMEjnzyGEMAwsP5dvy1itTP6aqfZoqjRMk 79tN+uVZNtrfX5ER70sQvZn255wOwFeO8iHiS/JSOYCLYuvQRcJsNyGTdsSuhS9m aUcC2Nq+3b+HSVET7qlb+T+BdvdFn7rMBM69f2HHpPm3SjGt62xftbCvw0/8O5LE BAoJRpmQvAGI24XnsPu6Z6ra/bdDAd+ZA82f967++W+LlmvH6IX8+SuS7EMfAH6/ llmzu+6p7o8ZF8pCqjwjODi2qdmkCcm/lZokM0Od3MYCuNJVQ15p2JRzm1GncTVb GcyWa3+x7dKNTPHEio1m4vLtmk4MgTCRl9dsZR29iuRT47L8OVZbHttVTw9FDo6Z +v0N5BCmQ0n2Jk0lPM6WY0PnoMLMybLLq/39MyTjJy4ZHqyBhv7l/qUl9F00hI0h AXrjSQ9eCtAO7xcrtoPNUCQOsjSp2nwfR+4= =/Iff -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 11:57:03 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 15:57:03 +0000 Received: from localhost ([127.0.0.1]:41554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ9nT-0000YI-3k for submit@debbugs.gnu.org; Mon, 22 Aug 2022 11:57:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ9nP-0000Xl-Qc for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 11:57:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ymmXUpIJyEppO74qPMYSrHRva4vhsjKY4+Y/eqDw39w=; b=B9YxQ5UFL5ZSTgak3X1bl/Px7U mgtRiWYYPbiMcWBQsF5kUyvmhN2IGZmzkmogvwSysGRR8ZbK2DuVPj5Bnwyshw1KZSCPg/iZHn/kg Tz7WNLYQWFG/kj7VRdnhLVKucYXtHDRIyEFfztUeaZbHgeSj8vG/63X3Zs9fqHvN4CvE=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ9nH-00077N-50; Mon, 22 Aug 2022 17:56:53 +0200 From: Lars Ingebrigtsen To: Thierry Volpiatto Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) In-Reply-To: <87sflo2s52.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 22 Aug 2022 15:45:03 +0000") References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> <87sflo2s52.fsf@posteo.net> X-Now-Playing: John Duncan's _Mort Aux Vaches: Seek_: "(untitled)" Date: Mon, 22 Aug 2022 17:56:50 +0200 Message-ID: <87k0702rwd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thierry Volpiatto writes: > Ok, so here a new patch which works same as the previous: Thanks. But this leads to the following test failures: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thierry Volpiatto writes: > Ok, so here a new patch which works same as the previous: Thanks. But this leads to the following test failures: 3 unexpected results: FAILED wdired-test-bug32173-01 FAILED wdired-test-bug32173-02 FAILED wdired-test-bug34915 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 14:48:13 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 18:48:13 +0000 Received: from localhost ([127.0.0.1]:41731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCSz-0002vd-VS for submit@debbugs.gnu.org; Mon, 22 Aug 2022 14:48:12 -0400 Received: from mout01.posteo.de ([185.67.36.65]:39575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCSv-0002uE-8a for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 14:48:04 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9FCA1240027 for <57334@debbugs.gnu.org>; Mon, 22 Aug 2022 20:47:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661194074; bh=GthD57xlkrT2CrEOhndrpDzNj7ELuUOj13/bkvqkeb8=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=kdAznLEDMB4U4IC27m57R+fGXEeJO/ksCAXYXFe2n1xTryELo+hWE4TowsaX0ox2Z VyGAq3+h1c4IshYgBdXs5vltTkIeSmdVTzcUPc3SSCgSE9831Z/SuimHBVE5rMpWMI SVgvGDnYNDDdKGQgFeedA4+x4fFkhtWaVQ2jg1xbaK60CPP3l5VEcdqxoPX3D2m1YX iyl3nujsT6AnxRkRW3RxgIabt3xAKrzhSDNOHgKwUERuhu6+92CXfxSZTEJU48WeYT lIzAEllHtu2v4gt6pMnN8ADpzQ7C2BjWwLPR1J/s6xvhXZm4CGVVvgK7ax4m5TYPwW rcTF28gzT7klg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MBLvs3yp7z9rxF; Mon, 22 Aug 2022 20:47:53 +0200 (CEST) References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> <87sflo2s52.fsf@posteo.net> <87k0702rwd.fsf@gnus.org> From: Thierry Volpiatto To: Lars Ingebrigtsen Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Mon, 22 Aug 2022 18:46:37 +0000 In-reply-to: <87k0702rwd.fsf@gnus.org> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <87k0702jze.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Thierry Volpiatto writes: > >> Ok, so here a new patch which works same as the previous: > > Thanks. But this leads to the following test failures: > > 3 unexpected results: > FAILED wdired-test-bug32173-01 > FAILED wdired-test-bug32173-02 > FAILED wdired-test-bug34915 Sorry but I am not a big fan of ERT, I have no idea what these tests do. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmMDz1UTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk2pKC/4jRoWL0JuoLfdY+vnPZh35Aplrcx8D VxzJO6fX659oQQOTXRRI67PKFH0RWXk4GEWprQU7x5p3TnNfItiFWTlaNvdUTdRS BTalGRqp3qyNr/gnWALYuragm9OclzYmGk1zWWS1iHH0YFCBdNCC4oybCHFi7jQO YwamIm3LHuBAGFdGGLL6QIKojr3LZdXOivgU05iXpvrtmQT7k1H1Ann5msaUZ0b9 XzpBUTmqpaWvsqw0MVgFEdA/RN5geAxsfwaaXPSXOv7QKOD3YpAdW0fjhfHNtiUo kRBYSKcO0pk27EY24RMa7KL41v8JvKmYKviJE83KNDZlbNNs3u1iW9rKZEzCdy6+ pinc1Y1o8XCHa2vu7L+pRsB8t3CkDjXNG/HafXGliNYbEM4UVS3Tr4NbKG6XPLnB bOmW7IRJ0xjhgFTWREbyIiVA6NBxTygu662Ia5llC8076OvmQyZjpkaVbaLIfuCV Y5ICQCUhqoSr1hBxWQ7FLr6Ne+2MqtVfm0o= =/yLw -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 14:49:18 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 18:49:18 +0000 Received: from localhost ([127.0.0.1]:41735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCUA-0002xw-2h for submit@debbugs.gnu.org; Mon, 22 Aug 2022 14:49:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCU8-0002xh-9z for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 14:49:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tmchZiOTqJGYZw2MUyY0xtrRMjkCvi4SjR770lrsF5g=; b=sCOV0c766qJuhYryOeGNyd89QO BuJn5ywACh4g9+y+lOASs98Zcts/mx8tqSK5z8teUhwxF79KjwyflkSgW2XbWCudELtSXpr6Jgc+s HucKjoVl/Bv/MxO48+2gcGApXan6SgQ/+kireXA7JOj0GbrGz1OlTaueVYeOsjmFEmK4=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQCTy-0008Sr-Tr; Mon, 22 Aug 2022 20:49:09 +0200 From: Lars Ingebrigtsen To: Thierry Volpiatto Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) In-Reply-To: <87k0702jze.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 22 Aug 2022 18:46:37 +0000") References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> <87sflo2s52.fsf@posteo.net> <87k0702rwd.fsf@gnus.org> <87k0702jze.fsf@posteo.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEXJVz3WnVR1eoBW XVZFRkYtKzDPv6z///+Dbrc9AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YIFhIwDxmQTcEAAAGuSURB VDjLjdTNbuMgEAdw2Eh7NvbK5+2Q5twwJOesgT5A5NxrXM37P0IZHNs4TaXlkEj88udjGEUIIRUP QB8cItpwy0NkAJ7xAfnrtoKAtwkuW8hjh/NSz+Ai/g9klgnE23NwQjwulQB0pxPPoFSelweisSOK S6KlKs2nOxL9NQeCBYiokkJGaLU2SACnJdEObSVIm2NlajTt6wKDUtVvQFVrfFENjMvmDDvAw14d 7YDGLqAYfA/H2jRw6v0Gmv6K0Y/nP/vbv9MMfNyXPXSf1/E6nnE4FTffKYrd6KIZ30mFsiTGQEcj tfodzKZWiMGkqxIE50qQ9mKRQdvGFqDUzuicGFHPXTI1T3rAVEWgmNYs76EaPKaSc+lL4FRzpjzW 92DgCG+REuD7AlpKvXiO0B2iLxJUtUMN3LXO+g18SBVz96ZWWPtK8aPLZ5ACQtYZHHpXwJBKAjNg 0T4JBKyJ+bh0B3hciuhjAp3AbqDKe+RECS2LBP0NpocCzY3u/CP84kM9g3w/DD8kLIP3W9A/Qd7i xhA2MP1lLMAfc7+l+RX6Ahwv3n/bg38f7nCXL3Rt88i7TJqGAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIyLTA4LTIyVDE4OjQ4OjE1KzAwOjAwgmEpBwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOC0y MlQxODo0ODoxNSswMDowMPM8kbsAAAAASUVORK5CYII= X-Now-Playing: Honey Badger's _Dorcha_: "Last Minute" Date: Mon, 22 Aug 2022 20:49:04 +0200 Message-ID: <87o7wc15cv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thierry Volpiatto writes: >> 3 unexpected results: >> FAILED wdired-test-bug32173-01 >> FAILED wdired-test-bug32173-02 >> FAILED wdired-test-bug34915 > > Sorry but I am not a big fan of ERT, I have no idea what these tests do. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thierry Volpiatto writes: >> 3 unexpected results: >> FAILED wdired-test-bug32173-01 >> FAILED wdired-test-bug32173-02 >> FAILED wdired-test-bug34915 > > Sorry but I am not a big fan of ERT, I have no idea what these tests do. If you say "make wdired-tests" in the "test" directory, the output will tell you what the problem is. (I didn't examine the output myself.) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 16:11:33 2022 Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 20:11:33 +0000 Received: from localhost ([127.0.0.1]:41864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQDll-000133-7r for submit@debbugs.gnu.org; Mon, 22 Aug 2022 16:11:33 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQDlh-00012o-1c for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 16:11:32 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E4836240101 for <57334@debbugs.gnu.org>; Mon, 22 Aug 2022 22:11:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661199082; bh=qwzEPXhmDmewgP1NAhTm1UzdwMnEaXH3pJZNFqU/VyE=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=hsVVcR8E0aV3a4ZlfFshCqcuG84Z/f+XJIDzoVukSMa3bJA/0dD6xvOHLIDs0fUra Zy4gRfDtVmOOk7qnM+xGadzfjiqEsvdpR997F0ur8+CKOHxMQqOGjpiH9AmsT9DVwx E4iWoXGecAquFcaHYRs4e18Hj5nrxeg5OTnEKu3co12278D0zmeNXhajn1TGLFGrQk cyeahA76F9qPqw7t3Nlo0kIDSMURukEoOf+qn1sxR2VbAFKstLSPFdXGsNjdsjO6Y5 ItyQcB7GYfeeGAaexlL7ozVM3NS4kW+nay2AWa23yRtQSmJXzPRU4cEB6wCjyyB2v5 d0gGewIffzxFw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MBNm65nSdz9rxN; Mon, 22 Aug 2022 22:11:17 +0200 (CEST) References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> <87sflo2s52.fsf@posteo.net> <87k0702rwd.fsf@gnus.org> <87k0702jze.fsf@posteo.net> <87o7wc15cv.fsf@gnus.org> From: Thierry Volpiatto To: Lars Ingebrigtsen Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Mon, 22 Aug 2022 20:05:52 +0000 In-reply-to: <87o7wc15cv.fsf@gnus.org> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <87ilmkkpi6.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Thierry Volpiatto writes: > >>> 3 unexpected results: >>> FAILED wdired-test-bug32173-01 >>> FAILED wdired-test-bug32173-02 >>> FAILED wdired-test-bug34915 >> >> Sorry but I am not a big fan of ERT, I have no idea what these tests do. > > If you say "make wdired-tests" in the "test" directory, the output will > tell you what the problem is. (I didn't examine the output myself.) The output is unuseful =3D> (wrong-type-argument stringp ni). No backtrace, so we don't know what the error could be. Thus I guess the tests are written with the possible existing bugs in mind and behave with these bugs behavior (not sure if I explain myself correctly sorry). =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmMD4uETHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk4uAC/0TZWzke/45tJ1C+64hpGWFDBFhGEQo FywXabVwx8F7nzfKsowf4kvsxPD9dl+C8xDYSjVo2ut9GSLmewQiYSc0QxVHbNnz vfuTvHMsdLKnyVyLdsIZjhKPae1EY6IMyp3NX0I4l/9+w56O6IONiYRPj2oYiNam kFsXz0eIEVSelMY/uxoEJkQ5SSdFAyDRiT9JLM3piTufAtqPI/usWSBFYaPvXTi8 c4u9pbfOqT9ZBbytlquqYPK78MhDrOAMp3Ni6dcbokL4uqhD2Y6v0dhM/Hm65Ggz 0xFOGoFinVni0Ui2YJ3mIlgZPp73TkDWiBAOfnrJzJ0qtxmq3j91MSCPktfvlnYF LtJo1RpfGwx4TTTEkBz8tMqrZi273Opd89LrkhV9WeuG1Lfa7tlUfmFJUFlbY4GU qgZFKFPZdkj/FTM2aTdwTZgkZyM2xrmMrX5RY/c+m4kmgoQHJDKq5NjMCH+phymF gBgHRTunWlEc9EfDX+fy82st6mnBjSPKRIM= =ukPZ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 21:02:12 2022 Received: (at 57334) by debbugs.gnu.org; 23 Aug 2022 01:02:12 +0000 Received: from localhost ([127.0.0.1]:42106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQIJ1-0004EE-VU for submit@debbugs.gnu.org; Mon, 22 Aug 2022 21:02:12 -0400 Received: from mout.web.de ([212.227.15.4]:60711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQIIx-0004Dw-Qv for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 21:02:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1661216521; bh=GCAWWOd+wDv6m0fon7h0Y5FmNoKQnEtVtwindsjp6T0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=fsTNH+KoKN4aos6DwAtZsQtRYdQab6xkYp1EzQ3vi1O1j3A1PKCLa/ph3XOow91M0 WZmeg5Pbfpe7BgRJ8Q+Gu7G+7cww9njhwfpa0iNAq45CqAciWUlrb2rIQ9IbBXMokE q1BHj4P1I93jax3OQEVEkMhakPW9IJp3UGw08lbQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MsrhU-1pJVS43Mts-00tO5W; Tue, 23 Aug 2022 03:02:00 +0200 From: Michael Heerdegen To: Thierry Volpiatto Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) In-Reply-To: <878rng23aq.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 22 Aug 2022 06:23:52 +0000") References: <878rng23aq.fsf@posteo.net> Date: Tue, 23 Aug 2022 03:01:59 +0200 Message-ID: <874jy3kc1k.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:w+l+uVUmhjjKzd/xd9G2CB29nh7ZNr+jRGDDHieVnXysjqd+bxT XGyQQxdi/FXy/t+rPnlAtc2NZ8UEhjscvatUpkUDp1X6IQ3nSXxX8h0uf86ryASdo+Q2xXP nnHEn+KXoT3ehGahWmwkdfUn2AM7eOM9ti4ww0hrb3/6lh7wH2VsgWfLLCvK34EKdCtU7dW zcfs32nIQYzP7O7g42C9A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:mTchfHw5V7Y=:DL6Jj2/X7PTZXtOy0bLlB0 S98UTuVobQ+RW3nOGjJPwIq9SzDu8fVrtgwszoKb1ItiPSk5RpqpsIgNOVGFRDGspJSdxEQ3g tdX07PpSqc4sQL1WNPx203O+QyZn1c3hH6310Z32mi7mM9goyY5Y7OO3733OnEps40SkozYSQ Kvp4+Oj/aWuHCySA4om+t5TO/loi23Rz4TnsVf13TYJswIGY46a8EB66funjQy35WWDM4U29y aRX9ZEvXxI6fgicnq+kmbM9zUSdYztKRBlbMWhk94H8fWH20DZXyTSh05sT9wsUcrHbo8JciC xZkT1eq2ud80V+4Zpp8DzsEsCjUk0LMMEsiY/tjy19sH01CP7Xi+67R/lVTYdZ+SOeRPxJnM6 /2KifZzu5CKblfGqaJjxP/Z/v9lNuH3mhzB7hi6VKN7n0rvFx0DV7y9z7DMxdWNSeGRxIPyui smllh7u8p0u2a6a5xOMx6/BHjeiw8Keja8RWibDT/C+KUMcK7VGeJFsDJVFYaZ+7TKqXL9SeQ 7Wfh5YOF+7Alt7bulTvgUA6hEJda4x0CltyQ8E2r/PPUzZWhI8FMqCsD+YEJn8NyWZCt7iu0a xL5XjthCcIXCgtKmXoEEEMkf8h/r6jSZltpwrBphVDaliiKVbeP/YFgNpvhrX9Nm22RDGsJ2B VF3KBfaq3j+EIsuOHnWz9y30YjJgBS+PbftsdItL3e3QG7t74Cg7SMelS+IDgoHq01R6SAdfs 4sq/tVexXlbPaUmqOX5ze9wkcnJBxN/IbGWzs2ePo6oFq2l3srk9dz+DXNt6i4aHOkk6F3XdI r7m0bCkFWachxP6vcpLhLzv/MIPdIrW/R5HrYhdEpzrXl7Ilhx5+3aeQ5P1nEyHTOa+o6HKsV jdIx4Qc1Tw+fh6aqwgGrCqKiHPLl5hggEtTyMYOAlfgrG/v+UyH/UbbmvmFGaAK3McFylq6dl nu/4e6z+DWfS1XMcKtrX/iIfQnGW9PJL/RIPq94iomKQt81t4OaDjhy6TBDMqBYhlcpBnFd29 1WgA93n230xsnpTtXejm8xcfmIUGgvr1NjMvvMXkIZ680Zx7/8GaW3H+6zXqqRfUIsq79YmwB SBA9Wec+PwlpfNxwDMCEZR4o1KKTTUJ/zdjWiE+lXdfM6PubK3DnckMZg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thierry Volpiatto writes: > Hello Emacs, > > there is an action in helm that allows creating a dired buffer with > marked files for further editing with wdired. > For this I have to call dired with its dirname argument as a list: > (dired ' (dir f1 f2 f3)) > Unfortunately this is broken since years and until now I had to use an advice > to fix it. > The advice is working up to emacs-28.1 but now it becomes difficult to > write an advice compatible with all emacs versions, here is a patch to > apply on 29.0.50. I do also have such an advice. My approach is to make `wdired-finish-edit' _not_ call `revert-buffer'. This is faster and doesn't mess the original file order. AFAIR one also has to avoid the `dired-advertize' call for such buffers, else they are confused with normal buffers displayed the DIR. And file changes are not propagated to other dired buffers, that's also something I do manually. And a different thing is that changes in other dired buffers are not propagated to these special file-list buffers. This is a tricky matter. I think fixing all problems will require some work. They are not independent. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 00:52:05 2022 Received: (at 57334) by debbugs.gnu.org; 23 Aug 2022 04:52:05 +0000 Received: from localhost ([127.0.0.1]:42237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQLtV-0001Wq-6e for submit@debbugs.gnu.org; Tue, 23 Aug 2022 00:52:05 -0400 Received: from mout02.posteo.de ([185.67.36.66]:41551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQLtR-0001WJ-Qj for 57334@debbugs.gnu.org; Tue, 23 Aug 2022 00:52:04 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 62D42240103 for <57334@debbugs.gnu.org>; Tue, 23 Aug 2022 06:51:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661230315; bh=jGqWkLSwARRFXcfXZV6A/TdxQm9MT7GaZPrU3lHfk24=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=aIwOQINUfGwyloOy4YhnYFmhJnnduzWD2H4mAON0jWuE+9yGIzUxteySen34h6/fG gpYwKl6LEnePVZaY5Vr2mA8NXSKovmffcWvHwA0IJ2+pGXJfQjKjYbiH6eedkHWEcb 2EQzm7RJtoUnf+xOp2KJMqWkRya1kVYzQsIShbeeByZ77r4s1natqcATlAUUHpaDTC iPbj3spE8YaD5eFEBjvxPVXaPUSXhcWxWzY7hhFiprCVmqMLXgKYp6br34emVX3bpP OgzFnfV37BG5RZPv/5msPygrdG1nASNep8Rep1ZX1vxmklmEPk8tJaClX3G6B/D25x 04i+pJyS2Ww7A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MBcJl6k12z6tnm; Tue, 23 Aug 2022 06:51:49 +0200 (CEST) References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> <87sflo2s52.fsf@posteo.net> <87k0702rwd.fsf@gnus.org> <87k0702jze.fsf@posteo.net> <87o7wc15cv.fsf@gnus.org> From: Thierry Volpiatto To: Lars Ingebrigtsen Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Tue, 23 Aug 2022 04:50:20 +0000 In-reply-to: <87o7wc15cv.fsf@gnus.org> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <87a67vsgtb.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Thierry Volpiatto writes: > >>> 3 unexpected results: >>> FAILED wdired-test-bug32173-01 >>> FAILED wdired-test-bug32173-02 >>> FAILED wdired-test-bug34915 >> >> Sorry but I am not a big fan of ERT, I have no idea what these tests do. > > If you say "make wdired-tests" in the "test" directory, the output will > tell you what the problem is. (I didn't examine the output myself.) The tests succeed with following patch (avoid setting dired-directory to nil). diff --git a/lisp/wdired.el b/lisp/wdired.el index 106d57174d5..40008f186eb 100644 =2D-- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -537,15 +537,27 @@ non-nil means return old filename." (wdired-change-to-dired-mode) (if changes (progn =2D ;; If we are displaying a single file (rather than the =2D ;; contents of a directory), change dired-directory if that =2D ;; file was renamed. (This ought to be generalized to =2D ;; handle the multiple files case, but that's less trivial). =2D (when (and (stringp dired-directory) =2D (not (file-directory-p dired-directory)) =2D (null some-file-names-unchanged) =2D (=3D (length files-renamed) 1)) =2D (setq dired-directory (cdr (car files-renamed)))) + (cond (;; If we are displaying a single file (rather than the + ;; contents of a directory), change dired-directory if that + ;; file was renamed. + (and (stringp dired-directory) + (not (file-directory-p dired-directory)) + (null some-file-names-unchanged) + (=3D (length files-renamed) 1)) + (setq dired-directory (cdr (car files-renamed)))) + ;; Fix dired buffers created with + ;; (dired '(foo f1 f2 f3)). + ((and (consp dired-directory) + (cdr dired-directory) + files-renamed) + (setq dired-directory + (cons (car dired-directory) + ;; Replace in `dired-directory' files that ha= ve + ;; been modified with their new name keeping + ;; the ones that are unmodified at the same p= lace. + (cl-loop for f in (cdr dired-directory) + collect (or (assoc-default f files-r= enamed) + f)))))) ;; Re-sort the buffer. (revert-buffer) (let ((inhibit-read-only t)) =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmMEXOATHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk+tJC/wNxFKHEErephPSNMzIvbApj2F0UazE 92FO5J3wu3xWbWJ45qdLnAgrlWNR836kazBZeCbWhmYYEVmADmFsxIPFa7cpGY+o gTwU6iB9sS+b5vxMpFAJQ0Wujp0Y8Fu+ZKY2eiL+IXDXqVurbTHiziFWJLMhbgaS HgLApk9D1b6QvXuP0h72LerQ0NQSrlw/QmIhIrnTbwOPn2h4Vid3NWq2YjM7z+BF wbx7/u86b7xJH+7eJzMdHQbE2G0PirxBfR2jAFlRGMGyPBryry8bc6tS7yKK1yGK O9RfyGXR2r2RgZEg/HU3utkmOnkr7KtVCnjh4yKr8usoQO5j1b8lZ9j2/90Agmt/ Jy/0jiFJ1KGmdWKvJxDu91VV8Kd1dmYSUiVTgI2SdBqQbAfEM5k27PsEIa22qjSk NrzEZ1nHfyt1FaGpByK+oIn81a2y1csafa1n2SaMvd/azScTN1GDJbhRUi+hdGWe GSfFTqifK85g7Cke2Fcw/sWB35Hmr+P8Bi4= =2EIi -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 06:05:08 2022 Received: (at 57334) by debbugs.gnu.org; 23 Aug 2022 10:05:08 +0000 Received: from localhost ([127.0.0.1]:42658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQmR-0005Zv-VC for submit@debbugs.gnu.org; Tue, 23 Aug 2022 06:05:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQmJ-0005ZD-IL for 57334@debbugs.gnu.org; Tue, 23 Aug 2022 06:05:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3NvqKDqDrgwXx5dQVjjy2kVLz+LIas0AfKIOJgy8N9k=; b=l/F9WTMkktLOLX+h6EZXIF1gtB 265kc8YmzTIGDE5SPmuHz656CujV2HF8a52uoL9i5n026/sTlWkQXN7DPsgS/Frp4eR8+FMWvnGMA QjYGkewHyhBiJHXfHfp1JBERkh6hZPa0xQ61I1sKvDOUeKL4SajB9nYT7ua0X/O0YRhY=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQQmA-0007Dd-VS; Tue, 23 Aug 2022 12:04:53 +0200 From: Lars Ingebrigtsen To: Thierry Volpiatto Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) In-Reply-To: <87a67vsgtb.fsf@posteo.net> (Thierry Volpiatto's message of "Tue, 23 Aug 2022 04:50:20 +0000") References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> <87sflo2s52.fsf@posteo.net> <87k0702rwd.fsf@gnus.org> <87k0702jze.fsf@posteo.net> <87o7wc15cv.fsf@gnus.org> <87a67vsgtb.fsf@posteo.net> X-Now-Playing: Fairport Convention's _Come All Ye (6)_: "Down in the Flood" Date: Tue, 23 Aug 2022 12:04:46 +0200 Message-ID: <87r117tgw1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thierry Volpiatto writes: > The tests succeed with following patch (avoid setting dired-directory to > nil). Michael noted that there's more fundamental problems in this area, so perhaps more work is needed later, but your change makes sense anyway, I think, so I've now pushed it to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thierry Volpiatto writes: > The tests succeed with following patch (avoid setting dired-directory to > nil). Michael noted that there's more fundamental problems in this area, so perhaps more work is needed later, but your change makes sense anyway, I think, so I've now pushed it to Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 06:05:11 2022 Received: (at control) by debbugs.gnu.org; 23 Aug 2022 10:05:11 +0000 Received: from localhost ([127.0.0.1]:42661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQmV-0005aE-G8 for submit@debbugs.gnu.org; Tue, 23 Aug 2022 06:05:11 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQmT-0005Zm-OS for control@debbugs.gnu.org; Tue, 23 Aug 2022 06:05:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hnVqanjP8f0Le+iYpbatfi6scdd88RUPDD2XdZ9Ygl0=; b=KNl/cnA2IvRkvIDjnuGzk96Vqd Zdv9hgX39K6PmF/1QrIB/d5zEOi9NpnxlkSNi4dje4VN17LW9c6PxJ8Slq+RG1c6jrnUwrz9UbMYK nAzZL70AtRdabu4wJ93xRrs7nOKTqrfUFTFiQPPwVyBXnZ1tU3lRS77SeWAt9mSs7kGI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQQmL-0007Dn-WE for control@debbugs.gnu.org; Tue, 23 Aug 2022 12:05:04 +0200 Date: Tue, 23 Aug 2022 12:05:01 +0200 Message-Id: <87pmgrtgvm.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57334 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 57334 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 57334 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 07:11:30 2022 Received: (at 57334) by debbugs.gnu.org; 23 Aug 2022 11:11:30 +0000 Received: from localhost ([127.0.0.1]:42800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQRof-0005Y9-Rr for submit@debbugs.gnu.org; Tue, 23 Aug 2022 07:11:30 -0400 Received: from mout01.posteo.de ([185.67.36.65]:50009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQRoc-0005Xu-TI for 57334@debbugs.gnu.org; Tue, 23 Aug 2022 07:11:27 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8AE29240027 for <57334@debbugs.gnu.org>; Tue, 23 Aug 2022 13:11:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661253080; bh=n4hhZiVdal1z+K7Nqk/Uj/z6FRF0b3FncwuHa+rclEY=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=V/nHM73fIRhxXdyEydN4dzEuvCcs16uZtRqLwtgpQh4UXmjgUh9sD9NuESXNqRR5r Uj59s6wAjT6UKZjHFcY1ZF7KMiZT8DQ7k4KPIrOI7BDaWHU7COyvDKtBUxQ9XqNNcc i2drhxAp+JDRl9CbsVru+YzuTSqq8yzhoVkq/vdFX2p7DwMRze9B+M1kWaSOyGMYuT PnwVJVmIAM1tgyRIN0rzeJTO5trDaty6U3uptrRHnNZlkWa4jpEx1dTCPxhDQ/tGbf zb0mOn38SkgsqOF6mkRMh9OUneUtMmQ9+ik3yst32OekLIFZCj00fsOKPrbUo3GIVf GBk85zgkWO3KA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MBmkb2LrCz6tnD; Tue, 23 Aug 2022 13:11:16 +0200 (CEST) References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> <87sflo2s52.fsf@posteo.net> <87k0702rwd.fsf@gnus.org> <87k0702jze.fsf@posteo.net> <87o7wc15cv.fsf@gnus.org> <87a67vsgtb.fsf@posteo.net> <87r117tgw1.fsf@gnus.org> From: Thierry Volpiatto To: Lars Ingebrigtsen Subject: Re: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Tue, 23 Aug 2022 10:53:12 +0000 In-reply-to: <87r117tgw1.fsf@gnus.org> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <87tu63usdu.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57334 Cc: 57334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Thierry Volpiatto writes: > >> The tests succeed with following patch (avoid setting dired-directory to >> nil). > > Michael noted that there's more fundamental problems in this area, Indeed there is other problems, like Michael mentionned but also Eli. I had also problems with `wdired-get-filename` which at the end use (concat dir file) instead of (expand-file-name file dir). If filename is absolute we endup with e.g. "/home/you/tmp//home/you/tmp/foo.txt" instead of "/home/you/tmp/foo.txt". Curiously this happen in emacs-28 but not in 29 (why I submitted no patch for this). > so perhaps more work is needed later, but your change makes sense > anyway, I think, so I've now pushed it to Emacs 29. Great thanks. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmMEtc0THHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk0pXC/0cXB+dXhMLAxnYsptzHP96uY930fr+ c0a01Sz+wDjBofORMVpy0TRVwsy9//GfM2GiAaz8rMRJ5iZPJUX4SJp+nTPNrmJ7 SP+AtlZX4vGRi4ljNGKSJ2q7Yrx5V/nTCUHlcM6Qv6t2bokPM9Km1dPHib2Z12L3 cZNZ7B3/JsjnsZTLQDPlekQECLIujyJ5h3lWPRxaC4AoPqiKvtLr2eRibB8wbKyY C7Va1pq00GpGb8rWlWKxSbLJFsqXCzgFS+DI7YTCmdwEQilk5mtZqXWfG1KkEYT5 Gvb49nbU5jujMljIQ/PnqRZTfS/q2axOkkyDwVv8jcLhElZAn1j5vVdkgBz+UemS w/1UBoea33ATRHaFYrPSG+7voRIdJi2iUhe0YKR/iGQ56XV1ItTBx9J7gJru+P9M NxRkrVikr+wzUsdGo8WAFL527OLFEnvd0AbT2POBtXI6N/Nj6aSovvsor22yQ6Uk vN4Dzc2U+tybQSdg6bGNjGizeECSWI6LP1A= =E7qM -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 20 14:39:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Sep 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator