GNU bug report logs - #57327
Bug in vhdl-mode design hierarchy extraction

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57327 in the body.
You can then email your comments to 57327 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Bug in vhdl-mode design hierarchy extraction
Date: Sun, 21 Aug 2022 09:30:00 +0200

[Message part 1 (text/plain, inline)]

Hi,

First of all, thanks a lot for actively developing and maintaining Emacs.
It is something that makes me very happy in my daily work.

Some time ago I found a bug in vhdl-mode.el after trying to extract the
hierarchy in speedbar of the current design. The design I'm trying to parse
is the one based on the following repo:
- https://github.com/gmlarumbe/axi_if_converter

After opening the following file (*src/top/rtl/axi_if_converter.vhd*),
starting speedbar and pressing 'h' to get the hierarchy I get the following
error:
- WARNING:  ERROR:  Invalid hierarchy information, unable to display
correctly

When I first debugged this issue some time ago it seemed it had to do with
lexical-binding and the function `vhdl-speedbar-insert-hierarchy`. I made
some changes that made it work and could help debugging in a branch of my
emacs-mirror fork:
https://github.com/emacs-mirror/emacs/compare/master...gmlarumbe:emacs:vhdl-projects

Yesterday I also checked that vhdl-mode has received some updates since
then, some of them in this particular `vhdl-speedbar-insert-hierarchy`
function that actually had to do with lexical-binding (commit a769cbfcfb by
Eli Zaretskii). I made some new simple changes that I attach in a diff file
and seem to fix the issue. However, maybe the author/maintainer knows a
better way of fixing this.

Thanks a lot for your effort,

Best,

Gonzalo

[Message part 2 (text/html, inline)]

[vhdl-mode.diff (text/x-patch, attachment)]

Message #8 received at 57327 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>
Cc: 57327 <at> debbugs.gnu.org
Subject: Re: bug#57327: Bug in vhdl-mode design hierarchy extraction
Date: Mon, 22 Aug 2022 01:29:35 +0200

Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com> writes:

> Yesterday I also checked that vhdl-mode has received some updates since then,
> some of them in this particular `vhdl-speedbar-insert-hierarchy` function that
> actually had to do with lexical-binding (commit a769cbfcfb by Eli Zaretskii). I made
> some new simple changes that I attach in a diff file and seem to fix the issue.

I think that looks like the correct solution here, so I've pushed your
patch to Emacs 29.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.