GNU bug report logs - #57297
[PATCH 0/7] Update vulkan packages and add vulkan-validationlayers

Previous Next

Package: guix-patches;

Reported by: Kaelyn Takata <kaelyn.alexi <at> protonmail.com>

Date: Fri, 19 Aug 2022 14:49:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 57297 <at> debbugs.gnu.org
Subject: [bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validationlayers
Date: Thu, 01 Sep 2022 09:44:04 +0200

Thank you for the patches.  Overall they look good to me, but I have
some comments:

- the first patch updates spriv-headers from 1.5.3 to 1.2.198.0.  This
  looks like a downgrade.  Is this jump in version numbers expected?

- the commit message for the vulkan-loader update should mention the
  changes in the build system arguments:

* gnu/packages/vulkan.scm (vulkan-loader): Update to 1.2.202.
[arguments]: Enable tests by removing obsolete build phase
'disable-loader-tests and adjusting configure flags.

- in the patch for vulkan-validationlayers I’d use #$output instead of
  binding out to (assoc-ref outputs "out").

Other than that this all looks good to me!

-- 
Ricardo
This bug report was last modified 2 years and 223 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.