From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 18 23:11:56 2022 Received: (at submit) by debbugs.gnu.org; 19 Aug 2022 03:11:56 +0000 Received: from localhost ([127.0.0.1]:56999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOsQN-0002cZ-LW for submit@debbugs.gnu.org; Thu, 18 Aug 2022 23:11:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:38552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOsQL-0002cQ-Aq for submit@debbugs.gnu.org; Thu, 18 Aug 2022 23:11:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOsQL-00007q-4Q for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2022 23:11:53 -0400 Received: from shell1.rawbw.com ([198.144.192.42]:64633) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOsQJ-0008EM-2j for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2022 23:11:52 -0400 Received: from alto (135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 27J3BfBZ011111 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 18 Aug 2022 20:11:47 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged) claimed to be alto From: Mike Kupfer To: bug-gnu-emacs@gnu.org Subject: 29.0.50; query-replace with Wdired skips symlink target X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <60772.1660878696.1@alto> Content-Transfer-Encoding: quoted-printable Date: Thu, 18 Aug 2022 20:11:36 -0700 Message-ID: <60773.1660878696@alto> Received-SPF: none client-ip=198.144.192.42; envelope-from=mkupfer@alum.berkeley.edu; helo=shell1.rawbw.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) =46rom "emacs -Q": 1. Create a file foo, and create a symlink bar that points to foo. S lrwxrwxrwx 1 kupfer kupfer 3 Aug 18 19:48 bar -> foo -rw-r--r-- 1 kupfer kupfer 0 Aug 18 19:46 foo 2. Visit the directory with dired and type C-x C-q. 3. Move point to the start of the buffer. 4. M-% foo RET baz RET I expect query-replace to ask me about both the file foo and the symlink target foo. That's what Emacs 28.1 does, and it's quite handy. Instead, query-replace asks me only about the file foo, ignoring the symlink target. S lrwxrwxrwx 1 kupfer kupfer 3 Aug 18 19:48 bar -> foo -rw-r--r-- 1 kupfer kupfer 0 Aug 18 19:46 baz I can still manually fix the symlink (replace "foo" with "baz") while in Wdired, but I think query-replace should be able to do this for me. The build is Emacs master 7dab52dfbc plus a couple local fixes to MH-E, so I expect it's reproducible with just 7dab52dfbc. In GNU Emacs 29.0.50 (build 14, x86_64-pc-linux-gnu, X toolkit, cairo vers= ion 1.16.0, Xaw scroll bars) of 2022-08-18 built on alto Repository revision: d3fd48a98606cd8d8de577af114ce0eb046ff210 Repository branch: master-mdk Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --prefix=3D/usr/new' Configured features: CAIRO FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM LUCID ZLIB Important settings: value of $LC_TIME: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Shell Minor modes in effect: shell-dirtrack-mode: t delete-selection-mode: t global-eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t column-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow mh-identity emacsbug misearch multi-isearch wdired dired-aux dired-x shr-color color textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check qp mm-archive mail-extr mh-mime pp mule-util mh-search mh-letter mh-show goto-addr thingatpt gnus-cite mh-thread mh-inc hl-line mh-tool-bar mh-acros mh-seq mh-xface mh-utils mh-folder which-func imenu files-x mdk-mail gnus-mh gnus-msg mh-comp mh-scan mh-gnus gnus-dup nnmh gnus-score score-mode gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs json map gv url-vars gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win gnus nnheader range wid-edit mh-e mh-buffers mh-loaddefs message sendmail mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader server noutline outline easy-mmode icons cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs byte-opt bytecomp byte-compile cconv shell subr-x pcomplete comint ansi-color ring xcscope advice delsel vc vc-dispatcher timeclock cl-loaddefs cl-lib mdk-hacks rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 341028 35766) (symbols 48 19344 2) (strings 32 82149 1520) (string-bytes 1 2322871) (vectors 16 64652) (vector-slots 8 1498444 216905) (floats 8 324 210) (intervals 56 3883 77) (buffers 992 24)) From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 20 20:47:29 2022 Received: (at 57293) by debbugs.gnu.org; 21 Aug 2022 00:47:29 +0000 Received: from localhost ([127.0.0.1]:33620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPZ7h-00087L-Lv for submit@debbugs.gnu.org; Sat, 20 Aug 2022 20:47:29 -0400 Received: from mout.web.de ([212.227.15.4]:44285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPZ7f-000877-Fq for 57293@debbugs.gnu.org; Sat, 20 Aug 2022 20:47:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1661042840; bh=r4EBqNi4pxlGB2DPgbYOUiNv+Uy4E/Srofwvd6jFBFo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=mN0dgEp+GSOd13ce8gFjYCcKfEuxaCWv3lwgI1+6V5vicqQY3Yv6bb5tt6ST0rBIN TcfV90PpHFBOiIGQoHFCTjT1mWAhE3x8vyuKV0yrID2QnALh1HEIVs0BbiIeHYmo6A ff9lmvDqK0VqbUStZsUIW/LQvUlosU3l0p5JRhNM= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MLifk-1ohEWt4B4y-00HuFZ; Sun, 21 Aug 2022 02:47:20 +0200 From: Michael Heerdegen To: Mike Kupfer Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <60773.1660878696@alto> (Mike Kupfer's message of "Thu, 18 Aug 2022 20:11:36 -0700") References: <60773.1660878696@alto> Date: Sun, 21 Aug 2022 02:47:16 +0200 Message-ID: <87a67y1kyz.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Kslf33nm0eI6/A0kpoBkkIH1D5wBPOlhk5fBsYbG6wBkkX3O7Hz S0SCgN972IUUDLsgcXl6/maQR/hyDKXS3Xj3+WEpx2qXmy5NTP7WASaQ8AlakuMRf6TC71g QPsSPISWZizQv81ktLae2gMdxSh34ouzkTpvaylm67xOaS5qf51IPZ1HiXcpSUtBg0d5xZt MRDOZPPbqMsqZIwkBNCVg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jQPBwOaXZcs=:jRbzd/nmSvv15dwMlkzX8V votb7QEEoewHRL2eSizEG8f3uB9n4bJgRq8Ni93x8MNdJa5Tb+APob4OxZlFh3NO3vshVn20e z/uMHMTsKlaIDIO7tYFMM/xmxu6H85E0st5vBBxTNr603ggGc259qUIB89xuyR6Xhs8JQepTN qxJ9JZjyCjTwAAkBh7gG2v5sYx2+Yj/4ZOZ0MFGMm8eOKzsnWlH7GmJUnFz1g8Dzfh2v1CgYt YrEtoI+3qVL6thC/F5hp4p8qAbfvvJPxUGo9inzFqNTayG9ugkSjgf48eqZX87aogrRxC5xRS p5xbV81W7vLAiuu6UABaMOcHQkShvORGgtV1Nre3hujn08L75JBePRHF74CMjLEkQz0k0t/NO ZYkrDkbZaH/yqeREppZPqLn26yYogv0ACXdszxoasb+Ad35Bp6xWy54pbFN/6W+NI408VMgGG Tp4LmWSS7uX0ns4bAZarlUESoDz+0B3pciS//0KlRbdX/SWW41p4E8DZfpogrOQsjm733hOTv HI0C8Kq3Wh6itV6+Oh2FDlOhGRDg0Uao991yUf7LVE10zwqLRe/hIMu5y141JpK9ljbVyub0m ljDVGXKHLtA5DTrB2wIO8m7rIKsKsxlbMybxOCuchP15kvCnG9E6IgjUY2FV+nvBbZMwZljrR F6CF+AfEiejV7pk+7RqIZ1t+RmLD44Ikmboh2V4PnM+Ve4SADzcRkc8Lh/jqDdaLJ2W9yNcNK zvPn8qAV3/RN0m0GMlY8vTGwuiY4BEDwP2dqNNw9CHpB02uKfvyVmuvQ8l+olk/qV3Ts20B8g t4wTdBO6xgngBpAjua/ToryWaWTIT8IknbZsT9QBaxbQ5Sv3Brg+0Ev7DDXElmCjEpEDHykqT Wk09XPrHks4e+dF6Im/IbxDfEeOBZkoMSc+pNeenJIpSJffLm1aDVoIKnfYW9GQE0BWqWgGh+ cFnVpCqtnRCkXQedNzcpa/x9eqI7FEJe9pDz6TqXWKvBFTOevGruxuIMWZrMw4CyITjgk8Kcm TVcjTWPi2W4EgpbZemEVZolELbc+faJvYOeXPFLWYu4jxOsCysuJfUcc1Wu98lJL72N7+D9EL a7p8ycrGaIBS6477+RFGJd+ujns5A+y+dG2Wu1iiVQ0Ky24NE14Sue8rQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mike Kupfer writes: > I expect query-replace to ask me about both the file foo and the symlink > target foo. That's what Emacs 28.1 does, and it's quite handy. > Instead, query-replace asks me only about the file foo, ignoring the > symlink target. Thanks for the report, Mike. See the new option `wdired-search-replace-filenames' to turn off the new behavior. Maybe turning this new behavior on by default was too much (Juri)? BTW, shouldn't the "\M-sf" key prefix work in wdired? And when starting a search in a wdired mode buffer, a subsequent M-% doesn't inherit the we-are-searching-filenames state from the search, only the binding of `wdired-search-replace-filenames' counts. If that worked, it would allow to get the other query-replace behavior wrt filename replacing without the need to touch the option. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 20 21:07:27 2022 Received: (at 57293) by debbugs.gnu.org; 21 Aug 2022 01:07:27 +0000 Received: from localhost ([127.0.0.1]:33625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPZR1-0000Cd-Gx for submit@debbugs.gnu.org; Sat, 20 Aug 2022 21:07:27 -0400 Received: from mail-vs1-f50.google.com ([209.85.217.50]:35393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPZQx-0000CM-B5 for 57293@debbugs.gnu.org; Sat, 20 Aug 2022 21:07:25 -0400 Received: by mail-vs1-f50.google.com with SMTP id 67so7892903vsv.2 for <57293@debbugs.gnu.org>; Sat, 20 Aug 2022 18:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc; bh=XQh35FmEXEVYLVvf7t6SS1QLzVKaSy+R5nEHjAhFYZw=; b=Wz7w0C3rDzIwlONkncdTJacFXGLJKGvYh9yA5afz/bW+kCgjKB6y5sieHzB00tpX73 4pVDrRH2aAVWX1IoyeOCEYqbcM+TNE38UME9lDTDhJDgr18th0sliAR6v5sK/4UiwNJo w2B5xQq3y7zXijRRCb75rwsk9nQVe0x5OvkafXck7FoUdFk5JMBR8+odxaFTgAUJEqey pmE2qbOSc+uBC50sIKzVzbpEHtJQgfO2KGRtR1Ar8TAVvv4PP0FlHIcjt/AfSu25zR4A j2dv7Gzm3uym18IBPs8k0veuJpv/xSzjqhi5IhG98DHtBIUE6LKPtEAivwtIRORTPjlW KW/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc; bh=XQh35FmEXEVYLVvf7t6SS1QLzVKaSy+R5nEHjAhFYZw=; b=AnbsUqv2D4cor7QXBuNgsoodfNMUzguGOibWxr4NwR/9aofDYoBDWFq7mFcreAWBpE i1K+PRVd4o9N5M02aYs3qberoqJrVuWe1Z/bQSfWy8kxaVTeY1webwH1gwNYTWpF5rsC WT8K4kCRGl6Hh/o7mTuXIOpJEgk5Uy7jK6y7+JABqsXSbm5wCYIJP5RO3zQ54vtSrQ7P C8UZRriK5uEb9yOwcI/rt3QYl03aKel0awSvTbPEdyF3z0GtZQuo04AtgdV8jtwlKR51 s2BDyahb9/zwnKWbgkhYh4aArRbgeVuwYkXajeNUglWOp+EYDJ2nlirPwu7tAhCV8vdy D8XQ== X-Gm-Message-State: ACgBeo3imi8bpj29QSl225v5ToNN++dZGBfUCSnIcj5QWjAouLDBj61z xKy2oh0Xk/Yy3pOuNJgj9Z+XLOLNA89pbN+Zfu4= X-Google-Smtp-Source: AA6agR480TvvHbsucRaBtzEio2iaxadaRMc7IJhubIPBRqxHzcvbnWM3U/unEyNcRWEFhpD8UqD1XNuWfuZp+sJmy9Y= X-Received: by 2002:a05:6102:313b:b0:38f:7ffa:166c with SMTP id f27-20020a056102313b00b0038f7ffa166cmr4752898vsh.46.1661044037635; Sat, 20 Aug 2022 18:07:17 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 20 Aug 2022 18:07:17 -0700 From: Stefan Kangas In-Reply-To: <87a67y1kyz.fsf@web.de> References: <60773.1660878696@alto> <87a67y1kyz.fsf@web.de> X-Hashcash: 1:20:220821:michael_heerdegen@web.de::rpuNCsqVqRdyKvHj:6vlH MIME-Version: 1.0 Date: Sat, 20 Aug 2022 18:07:17 -0700 Message-ID: Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target To: Michael Heerdegen , Mike Kupfer Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > Mike Kupfer writes: > >> I expect query-replace to ask me about both the file foo and the symlink >> target foo. That's what Emacs 28.1 does, and it's quite handy. >> Instead, query-replace asks me only about the file foo, ignoring the >> symlink target. > > Thanks for the report, Mike. See the new option > `wdired-search-replace-filenames' to turn off the new behavior. > > Maybe turning this new behavior on by default was too much (Juri)? Shouldn't we get the Emacs 28 behavior whether or not that option is enabled though? IOW, isn't this just a bug? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 20 21:46:22 2022 Received: (at 57293) by debbugs.gnu.org; 21 Aug 2022 01:46:22 +0000 Received: from localhost ([127.0.0.1]:33632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPa2f-00019S-Uy for submit@debbugs.gnu.org; Sat, 20 Aug 2022 21:46:22 -0400 Received: from mout.web.de ([212.227.15.4]:58409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPa2b-00019B-Qy for 57293@debbugs.gnu.org; Sat, 20 Aug 2022 21:46:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1661046369; bh=GJwtcf3QZ54xCW94fIJXcZ+64B/1AtGpZboYqxZ/40M=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=WdMbdtxKkDUOhgFvZP/8f1uowQonV7tEHBZ95ahafphL9FtoTUjseZorxvPigt7fy a5Qqh1N+XhpcR+wes0Ua1U28P6G4qz++nByg38ASolAyJTkqrpeTllXng+EebYaTB/ MyQz3g5IiTHL0QMzN8rjOlIMyo+AXYxB8zdsXhXA= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N8Epo-1pTYiv37C4-014MBe; Sun, 21 Aug 2022 03:46:09 +0200 From: Michael Heerdegen To: Stefan Kangas Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: (Stefan Kangas's message of "Sat, 20 Aug 2022 18:07:17 -0700") References: <60773.1660878696@alto> <87a67y1kyz.fsf@web.de> Date: Sun, 21 Aug 2022 03:46:08 +0200 Message-ID: <875yim1i8v.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:s2B5IX8WsAgMqE+bNWsVwvoCCntrxTgwhGh1fm251xkBggEaImG 9uGlAFJPOd2ojmLNulTl03paf5trj4Ah2zeLzaaq+DXSCM9MUj1/yp7SzZUjsHyeJoK7Wzs /PCcaMJy/R8v2wmp2HBNpPMcDA32K8z/PS52tMeu4jrdseMTZVtzElvWIJmm/a+oLeFgNm9 kjz1K5yoXcqa402jZ+jwQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:H5s0cCYyTOo=:iB+cDPrEbEiKOsEKPtCcV5 /cCwlWYRiLv+QnwDSXnIrAVXbUi1Cibhy3oZOH0Q4cOPtnri5IKBKZS6ZNVElbZmQFFUwzhHo KAgDXdjgAwcazY7Ef4IEt30dKCP+8EV8RWzIgej9AoKLP7LvETo7ctMuS+ziWTVQ8MDTHS5iQ 5qeYCtASyzQmWOJfNVRGhGf4WjB6RfXHVfKlrTCO0XwtpxlkLlxSxPRLta5eXyXYY1IzAN2zc KQR+yiJcu8CCxbRjzOVqj65cdAQvLmHY1pRJE4zy+STMcMl6ST6RTQCEZf7+41SGr1OCmQrqa XpDjewFgPxeEpoFuyN/U3pcBNwaCi8a7mNVL9UmXSb9zewxYffkE1f4MnwQ14GLAqOkQBwl+e E/PcE006Q7FsvLVx8/M+0m1mt6lwZScXk+x+21lMXanM7edLOnnBEZox/1NnQAMqtTk5nSJcy 1ytGWWVQ8Y3dL4ZfAJ3W36fgLjfAlC+O2zTkzC4rdD2JQsdr3lloqNjbhVECkA/i+j4fIm5Kd qtE3+NWtLnZtfMc94onyc+Lqes5kPPL9DSPgPOBy7fTxXgLne6qHKfS1DvyFUIvFnHoJ2h8Vy cKLJe9yXrGmGizuFS7Kie3zPUfef/hC6aLIqXDq2mrR85SJZKrFnV5MKVBB4Gv/5IFnkLj3H0 nc86xE7Itp+DWSyEUIjaMmDWObu0KtHiAT4km8mQSkkBr84xk+lHevWzo8QFYvS+V+5qKmeoW AodCNmYOjUNyF8LOHnQAnFZk4iEYajvoX6i0toPx4ciqFglBvB/diECyXvDw+Qa+jA7RnQK/e mEssJnofob3RCsg7y2B9ilbMVFe3RerCEixUOGi9EI4qdXOgzmkYHDp4JN+/rZyQbPiBC+NQI bgAmg24jP/WIgoyGY0jirdlGUip1q98lPV9z5a76khNhOYRKBsxSznZbOPyJHJmLU6qpGxnCS Z5gHH4Je+jCMYQtsca+KE7/h2h74VrChrC/q+a0fQ8+krqqoP6AFUkgzXvqNY++fYCHMPTjEL cvGUyv4nVoDq8rAkMcbVJbUsPRCy612q0bjXVoSChj3c7JtBDhn8sigyAAqLOnx5KYCvZyVuU 55D/q7hGZVGYUaL2IK5OK0Ng6GmqWAFj0SIF07a+ZsPbLtd0IAvddz3FA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Juri Linkov , Mike Kupfer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: > Shouldn't we get the Emacs 28 behavior whether or not that option is > enabled though? IOW, isn't this just a bug? In the sense of user-visible (default) behavior change that is not fixing a bug - yes, I think so. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 20 21:54:58 2022 Received: (at 57293) by debbugs.gnu.org; 21 Aug 2022 01:54:58 +0000 Received: from localhost ([127.0.0.1]:33637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPaAz-0001O6-Si for submit@debbugs.gnu.org; Sat, 20 Aug 2022 21:54:58 -0400 Received: from shell1.rawbw.com ([198.144.192.42]:58253 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPaAu-0001Ns-Od for 57293@debbugs.gnu.org; Sat, 20 Aug 2022 21:54:56 -0400 Received: from alto (135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 27L1sjxK028056 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 20 Aug 2022 18:54:50 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged) claimed to be alto From: Mike Kupfer To: Stefan Kangas Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: Your message of "Sat, 20 Aug 2022 18:07:17 -0700." X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <40516.1661046885.1@alto> Date: Sat, 20 Aug 2022 18:54:45 -0700 Message-ID: <40517.1661046885@alto> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 57293 Cc: Michael Heerdegen , 57293@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas wrote: > Michael Heerdegen writes: > > > Mike Kupfer writes: > > > >> I expect query-replace to ask me about both the file foo and the symlink > >> target foo. That's what Emacs 28.1 does, and it's quite handy. > >> Instead, query-replace asks me only about the file foo, ignoring the > >> symlink target. > > > > Thanks for the report, Mike. See the new option > > `wdired-search-replace-filenames' to turn off the new behavior. > > > > Maybe turning this new behavior on by default was too much (Juri)? > > Shouldn't we get the Emacs 28 behavior whether or not that option is > enabled though? IOW, isn't this just a bug? The docstring says Non-nil to search and replace in file names only. so it does look like the relevant control. (But I wouldn't be surprised if I were missing something.) I have a slight preference for getting the Emacs 28 behavior by default, but I'm okay either way. If there had been a NEWS entry about the new option (hint hint :-)) I wouldn't have filed a bug. I agree with Michael's point about "\M-sf". Right now, you get the filename-only behavior for isearch via a specific functions and keybindings, but for query-replace, the behavior is controlled by a user option. More consistency between isearch and query-replace seems like it would be a good thing. I did notice this NEWS entry: *** Search and replace in Dired/Wdired supports more regexps. For example, the regexp ".*" will match only characters that are part of the file name. Also "^.*$" can be used to match at the beginning of the file name and at the end of the file name. Does that functionality require wdired-search-replace-filenames to be non-nil? cheers, mike From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 21 12:50:20 2022 Received: (at 57293) by debbugs.gnu.org; 21 Aug 2022 16:50:21 +0000 Received: from localhost ([127.0.0.1]:36656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPo9U-0006M7-Dc for submit@debbugs.gnu.org; Sun, 21 Aug 2022 12:50:20 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:41751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPo9Q-0006Ll-Fo for 57293@debbugs.gnu.org; Sun, 21 Aug 2022 12:50:18 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 2AB131BF205; Sun, 21 Aug 2022 16:50:05 +0000 (UTC) From: Juri Linkov To: Mike Kupfer Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <40517.1661046885@alto> (Mike Kupfer's message of "Sat, 20 Aug 2022 18:54:45 -0700") Organization: LINKOV.NET References: <40517.1661046885@alto> Date: Sun, 21 Aug 2022 19:37:13 +0300 Message-ID: <86a67xk46m.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57293 Cc: Michael Heerdegen , 57293@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > Maybe turning this new behavior on by default was too much (Juri)? >> >> Shouldn't we get the Emacs 28 behavior whether or not that option is >> enabled though? IOW, isn't this just a bug? > > The docstring says > > Non-nil to search and replace in file names only. > > so it does look like the relevant control. (But I wouldn't be surprised > if I were missing something.) The main question is what constitutes a file name? The old definition was that replaceable file names are everywhere where read-only is nil. The new definition is that file names are everywhere where the text property 'dired-filename' is non-nil. So if "foo" in "bar -> foo" had the text property 'dired-filename', query-replace would visit it as well. But wouldn't such change break some other commands? > I have a slight preference for getting the Emacs 28 behavior by default, > but I'm okay either way. If there had been a NEWS entry about the new > option (hint hint :-)) I wouldn't have filed a bug. A NEWS entry could be added too unless something like below will make it obsolete. > I agree with Michael's point about "\M-sf". Right now, you get the > filename-only behavior for isearch via a specific functions and > keybindings, but for query-replace, the behavior is controlled by a user > option. More consistency between isearch and query-replace seems like > it would be a good thing. Please note that unlike the corresponding option dired-isearch-filenames that is nil, it makes much more sense to enable wdired-search-replace-filenames by default because renaming file names is the primary use of WDired. > I did notice this NEWS entry: > > *** Search and replace in Dired/Wdired supports more regexps. > For example, the regexp ".*" will match only characters that are part > of the file name. Also "^.*$" can be used to match at the beginning > of the file name and at the end of the file name. > > Does that functionality require wdired-search-replace-filenames to be > non-nil? Indeed, when wdired-search-replace-filenames is nil, ".*" matches whole lines. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 02:17:09 2022 Received: (at 57293) by debbugs.gnu.org; 22 Aug 2022 06:17:09 +0000 Received: from localhost ([127.0.0.1]:37586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ0kF-0006f5-DU for submit@debbugs.gnu.org; Mon, 22 Aug 2022 02:17:09 -0400 Received: from mout.web.de ([217.72.192.78]:39895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ0jy-0006eF-HL for 57293@debbugs.gnu.org; Mon, 22 Aug 2022 02:17:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1661149002; bh=A82JjXjW8yv4lX5N6wHvhpL9g+fWsqEFZIIdgVxfZ+s=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=DaNxnZPS9o7y7PlHCAy5yj6F/CtUDfxFlwKz0DQffO7JIgP4vadFm1Wkups93ou9F Rk+/8F8hKzJ7gFAuwFnfDmPORc/6eMjpy3fky2ewe/WiX7hVfKDcnTTIgFufE83Nfl Y8ijFnLFVygmDaYwr/EqWy9jMV2wDiIBknvyPqwc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MBjMM-1oc8EH3hRE-00CDhm; Mon, 22 Aug 2022 08:16:41 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <86a67xk46m.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 21 Aug 2022 19:37:13 +0300") References: <40517.1661046885@alto> <86a67xk46m.fsf@mail.linkov.net> Date: Mon, 22 Aug 2022 08:16:38 +0200 Message-ID: <87v8qk246x.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:p0ULyyuB4VcVU/yfX30ox3A7VpLf/RT1Hluq2rWmbwlS5YShVBW qm5wYnjboNHKzbr7dxYTxBsMRowlRIfxm1qk9MBXcNNbyJ0VGoSoGLqV2/qvbcV6C+qTk+k Hz/x+GVIXzoOAGg5ClFdqWlahCGrNOU9t0ygkJNDEC/sUE7mdGL3K03YtELTijH+euVm2rv W/kpaviFwW9Jj+RaAgt3Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:wOq61UD3kns=:C2bDPBZ+fExPl1OCXmb5Sx ueNjSCTJzWTH9ablipQTFqso6o7fU2C8c/iA7CPVVzdR1uBv16J2Bb4WcN1vX7ac3qyQwvZ6g 1+vgn3jYvUr9Ih+rO0oKbgEOagfeV3Y2E13dC9P4wktBnKE58T0hbd1NWjnx1pJKxJmb3kNQC dYzL9YQt0dljvzVI5NE34LeVWJhXfIXp2bA+X8pOyy0QOaY1JSVSvc4vdceAKYjiq4QOnMHFR ZtsOPbK7F6d9uF/w6ErLUn3R+HYqm3/IvZI2Xf1PH1C5RBXq1DLIRUgqZxMct7qEkXTIBHvHB taEMVt9HcQ2q4LY1RbQXLugG5a/tBxbsngJhNIAA9AsZOtr77DXT5ThvHsDmCATB1tOSaOOyQ yc1WPmol5BY37vgExhZemYzf1m3tXNJHrDWhOefRG+UBoee1MuUdVsadQbTBJAqLigb7Jwh26 oQMUGQDobNQBEYTX2N7EYzqtpXGw31IXTcnJj1mxHOGKligqVityk6HTWAGFdJ7yVz6iJHbDL K6AFJsw1lncqn1IHDmYPFz8SqFu/bqFa6TWwqkMasfWKTDPY8G8arlJ40D44h3aJ2ejkXiTN/ /X1haIrsiI++2ZCOIYbpFUqe+p3PpAtGi9Fpj9qTtpWEXGO65e1kVDHK9FPJ6Qg3wv0cAWHri ne7P21KuJYNyfewIJHT8TC/oXKzASeT5+dW46ORpDAN82ynCF+Ncq0xK20+WUphxppWlxwINV SF5E4K/LzLRJFufPA0dsVD9LbJtisk6SMLgqLbhMjUx/9f2eieHoEJQYVZQEqGWI8jYRJv4W4 yLn663avYsS/efUrxNeqd/40mF4OlXmrhthkkKL472cUFUeyObakyP6bBCuxJw7HSuShp44Gb lTyJNxaWIaCB5R5EGZ4N+tp5OoQSE7Fs6Ry9SgSjvGF7ZXZ1Fgq7XY+G0TijVuKQkxq9M6Hqt 720TQ6j1HKy4QhlL6dGX4e4CrS3ypMqhos6V4SrB/kcLAsgfRLIL5B08pQtzYzT8+MJ7KRoc+ 8U5nNRoMN3AS9ZZHXgUqFTAeiDSj/TUOz39g8tKrd5iUY1Rw+NoeKc6veOPY4BTI1VDCDikmn HouzfscfvYiffa1oU70PI+Z/BZq8Jy5e9WooqH338pHEOAypWpUtFlpDQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Stefan Kangas , Mike Kupfer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > So if "foo" in "bar -> foo" had the text property 'dired-filename', > query-replace would visit it as well. > > But wouldn't such change break some other commands? That property plays a central role in dired buffers, I would be surprised if nothing would break. Even third party code might rely on the current placement. I would rather try to generalize the query-replace semantics further, even when that might be a harder task. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 02:55:09 2022 Received: (at 57293) by debbugs.gnu.org; 22 Aug 2022 06:55:09 +0000 Received: from localhost ([127.0.0.1]:37653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ1L3-0007fF-Gp for submit@debbugs.gnu.org; Mon, 22 Aug 2022 02:55:09 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:36793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ1Kv-0007e9-UJ for 57293@debbugs.gnu.org; Mon, 22 Aug 2022 02:55:02 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 92EE01C0006; Mon, 22 Aug 2022 06:54:51 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <87v8qk246x.fsf@web.de> (Michael Heerdegen's message of "Mon, 22 Aug 2022 08:16:38 +0200") Organization: LINKOV.NET References: <40517.1661046885@alto> <86a67xk46m.fsf@mail.linkov.net> <87v8qk246x.fsf@web.de> Date: Mon, 22 Aug 2022 09:52:51 +0300 Message-ID: <86ilmkixbw.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Stefan Kangas , Mike Kupfer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> So if "foo" in "bar -> foo" had the text property 'dired-filename', >> query-replace would visit it as well. >> >> But wouldn't such change break some other commands? > > That property plays a central role in dired buffers, I would be > surprised if nothing would break. Even third party code might rely on > the current placement. > > I would rather try to generalize the query-replace semantics further, > even when that might be a harder task. Maybe then it's possible to add a new text property on symlink file names? Then query-replace could check for two text properties: 'dired-filename' and 'dired-symlink-filename'. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 18:20:47 2022 Received: (at 57293) by debbugs.gnu.org; 22 Aug 2022 22:20:47 +0000 Received: from localhost ([127.0.0.1]:41970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQFmo-00009D-PB for submit@debbugs.gnu.org; Mon, 22 Aug 2022 18:20:47 -0400 Received: from mout.web.de ([212.227.15.14]:33871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQFmn-00008y-0n for 57293@debbugs.gnu.org; Mon, 22 Aug 2022 18:20:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1661206834; bh=wqtUDrp6tbCAQXifiw+7re3HjehRrYVtOCyZIX2oRuo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=KFjyzr814S+OMlThTnZYGHKior0DOzVNJuH1soC3p4TV99qo+W0Z/YlxZG1ERCaL9 WwsaWztw6eDKZwcwtFBAc9idPp77bbRxO6s+gKcCsT0Dyf56o+UVS7+VEQJfz4aLRs gZdMo5DaSOALnhA0zZyhYwYF9SLIbamfDVl9EiRk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MovjW-1pEVMS21mg-00ql0E; Tue, 23 Aug 2022 00:20:34 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <86ilmkixbw.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 22 Aug 2022 09:52:51 +0300") References: <40517.1661046885@alto> <86a67xk46m.fsf@mail.linkov.net> <87v8qk246x.fsf@web.de> <86ilmkixbw.fsf@mail.linkov.net> Date: Tue, 23 Aug 2022 00:20:33 +0200 Message-ID: <877d2z2a4u.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:4gE0TzcyI28MyTp7P2QCbl0GkuObluGORKly2TH6QIa+QoKlOwh 5g3IYUkhD9qxHH9cv+nEA8gOuB3ujsK0GcL+r742eAE38vUdnPtLGzsi5Lzx+BczUwKQA7K PtI6pBXOg13Xr3+eQVwS6Up2Yed6bfnkvU00mxiinHcs0nzstqwGSsBByzp+JidxIpzHleN nG7Y7RpWBZyybwD8qlLSQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:KikSK1CNsk0=:ciA2hZ3vv1k26ELB0SsAL3 z43t+bJMgVJVYPi+GAYI6k5rKUcn3nwv0OEf/fQb1xHJ5gOw97fnLLCXlOMDFgf2Hw4mQ/9dC pGyEQRbE+Hi2+FxyMBBF5tgbeXKbhCWZmhM2/qOiC5x29l2l+xWErLK+HfRTCUaDxvXAu1r2O ih8pYBYn/xxePzhiL+so6EDCcSSqFUdfWXnJEyc8URIvhyHUEROHZJ4I9xf+lZS9CzypIwT5v jT6dETkGKm33TheF9t7h4uPQqSG4ItagHVBXQdr26Qw+g9xySeACVvnm2XvkSRmL4ajdAJ6Bj XogJoZkauoG9EpGtkGcYaZhjoth+LqdZVUdHY4c+/V/FSuczWYAziVXV6HvdhVGWFxzlLFDc6 9jngLnQ3y3SyaAFHhzzZYefGloU5VR5ibiQhmvrj6t1fOBU0PyTxlqgEI3OlvSq2Ec/F7KJwg cij8o0jZ3JHad30C6PkpV9ggXt+cdvu/UpKb9E/IaGdQOaMHRUnViKkkQFE9Z7XAQBrn0PB+c ZoKxlFvctPKIOchaYheiqpbRNALmIzVpD4B+zPunEjsJicD7C2rvBti5q5nB12PFok4ZF/qV5 s7EO8i9EF0FStejmeUG4aJ7qg428EOf8bXpvJYRynu8EOYlIZV2u2NzVAhgS8ut3VzGSvhgAr DCHz4qPHs1K7hZtzta39QRLDdFfVwJdpVksmP7Tklegd+5piOqC/oVBpmqavCEWCi20YnWSKQ oZMqr59Nz/NG0Gcd+f8IQnK+S/Tjef1CbLAefxo/7tRRNadyJgsx59y/ZakZZDrYP0IEIBdml qnkbxtPcC9h4clEbzndXw4lt+tztiiyg1NWeOkj0WE+aLLeFZrXZFx2uON47tB899phU7GqoT UzC0YU+kzMrJa3mo67O9r7IuYeipoSs4R3N34sEQB4TfJTy0ie6DI187snaTnRWwlKwiQD0vg GgRvDJZpVd6AXcUllDAaU4/jlOr/E9UPKQf12Xu6RkGap+uXHEAk1g7V8VU+MNq9TOFBWLoGd rH0m3L7FBrkxdLZal6qhZwCuitOcLIf+5kXsQKWyGu5nGzdfLsESUhxra250PofUuozduXltk l9zgSYCN2wOcjbE9R02+W1PNmGA0lq+q0GHVWUBtYIuyXKvutxzzsswdw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Stefan Kangas , Mike Kupfer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > Maybe then it's possible to add a new text property on symlink file names? > Then query-replace could check for two text properties: > 'dired-filename' and 'dired-symlink-filename'. Yes, I think we could do that. Note that `dired-insert-set-properties' already sets the invisible text property to 'dired-hide-details-link'. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 15:31:44 2022 Received: (at 57293) by debbugs.gnu.org; 23 Aug 2022 19:31:44 +0000 Received: from localhost ([127.0.0.1]:45085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQZcm-0006HR-5g for submit@debbugs.gnu.org; Tue, 23 Aug 2022 15:31:44 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:59435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQZck-0006HD-1w for 57293@debbugs.gnu.org; Tue, 23 Aug 2022 15:31:43 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id A13E51C0002; Tue, 23 Aug 2022 19:31:32 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <877d2z2a4u.fsf@web.de> (Michael Heerdegen's message of "Tue, 23 Aug 2022 00:20:33 +0200") Organization: LINKOV.NET References: <40517.1661046885@alto> <86a67xk46m.fsf@mail.linkov.net> <87v8qk246x.fsf@web.de> <86ilmkixbw.fsf@mail.linkov.net> <877d2z2a4u.fsf@web.de> Date: Tue, 23 Aug 2022 22:27:57 +0300 Message-ID: <861qt6oj42.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Stefan Kangas , Mike Kupfer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit >> Maybe then it's possible to add a new text property on symlink file names? >> Then query-replace could check for two text properties: >> 'dired-filename' and 'dired-symlink-filename'. > > Yes, I think we could do that. > > Note that `dired-insert-set-properties' already sets the invisible text > property to 'dired-hide-details-link'. Ok, here is the fix to support search and query-replace of e.g. "fo* → baz": --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dired-symlink-filename.patch diff --git a/etc/NEWS b/etc/NEWS index 83fa28b325..596e52b4a2 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -2002,7 +2002,9 @@ the buffer will take you to that directory. *** Search and replace in Dired/Wdired supports more regexps. For example, the regexp ".*" will match only characters that are part of the file name. Also "^.*$" can be used to match at the beginning -of the file name and at the end of the file name. +of the file name and at the end of the file name. In Wdired this can +be used when the new user option 'wdired-search-replace-filenames' is +non-nil (which is the default). ** Bookmarks diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index 94b2baf72d..06f0b86fc4 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -3544,7 +3544,8 @@ dired-isearch-search-filenames The returned function narrows the search to match the search string only as part of a file name enclosed by the text property `dired-filename'. It's intended to override the default search function." - (isearch-search-fun-in-text-property (funcall orig-fun) 'dired-filename)) + (isearch-search-fun-in-text-property + (funcall orig-fun) '(dired-filename dired-symlink-filename))) ;;;###autoload (defun dired-isearch-filenames () diff --git a/lisp/dired.el b/lisp/dired.el index f45d215ed6..fa06c8fd44 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -786,7 +786,7 @@ dired-font-lock-keywords nil '(1 'dired-broken-symlink) '(2 dired-symlink-face) - '(3 'dired-broken-symlink))) + '(3 '(face dired-broken-symlink dired-symlink-filename t)))) ;; ;; Symbolic link to a directory. (list dired-re-sym @@ -798,7 +798,7 @@ dired-font-lock-keywords '(dired-move-to-filename) nil '(1 dired-symlink-face) - '(2 dired-directory-face))) + '(2 '(face dired-directory-face dired-symlink-filename t)))) ;; ;; Symbolic link to a non-directory. (list dired-re-sym @@ -812,7 +812,7 @@ dired-font-lock-keywords '(dired-move-to-filename) nil '(1 dired-symlink-face) - '(2 'default))) + '(2 '(face default dired-symlink-filename t)))) ;; ;; Sockets, pipes, block devices, char devices. (list dired-re-special diff --git a/lisp/isearch.el b/lisp/isearch.el index 31fcf01949..7fdae06c96 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -4512,21 +4522,34 @@ isearch-search-fun-in-noncontiguous-region (setq bounds (cdr bounds)))) found)))) -(defun isearch-search-fun-in-text-property (search-fun property) - "Return the function to search inside text that has the specified PROPERTY. +(defun isearch-search-fun-in-text-property (search-fun properties) + "Return the function to search inside text that has the specified PROPERTIES. The function will limit the search for matches only inside text which has -this property in the current buffer. +these list of PROPERTIES in the current buffer. The argument SEARCH-FUN provides the function to search text, and defaults to the value of `isearch-search-fun-default' when nil." (apply-partially #'search-within-boundaries search-fun - (lambda (pos) (get-text-property (if isearch-forward pos - (max (1- pos) (point-min))) - property)) - (lambda (pos) (if isearch-forward - (next-single-property-change pos property) - (previous-single-property-change pos property))))) + (lambda (pos) + (let ((pos (if isearch-forward pos (max (1- pos) (point-min))))) + (seq-some (lambda (property) + (get-text-property pos property)) + (ensure-list properties)))) + (lambda (pos) + (let ((pos-list (if isearch-forward + (mapcar (lambda (property) + (next-single-property-change + pos property)) + (ensure-list properties)) + (mapcar (lambda (property) + (previous-single-property-change + pos property)) + (ensure-list properties))))) + (setq pos-list (delq nil pos-list)) + (when pos-list (if isearch-forward + (seq-min pos-list) + (seq-max pos-list))))))) (defun search-within-boundaries ( search-fun get-fun next-fun string &optional bound noerror count) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 19:40:22 2022 Received: (at 57293) by debbugs.gnu.org; 23 Aug 2022 23:40:22 +0000 Received: from localhost ([127.0.0.1]:45258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQdV9-00069r-Fx for submit@debbugs.gnu.org; Tue, 23 Aug 2022 19:40:22 -0400 Received: from mout.web.de ([212.227.17.11]:55713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQdV7-000698-5d for 57293@debbugs.gnu.org; Tue, 23 Aug 2022 19:40:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1661297995; bh=UEUomNG8WdelGs5N/pbJaI3kinMt8H105KuHNglkOeM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=bsR9x5KqKQ/cSYRfGwuXwOFOS+16He9T3EJsDZTMSRsWMyf9QY2jLHtEMlkV5MdZQ Q1Y4HpXwafQv42n+gbFQe+dmEzRQVb9g3NlQkOCmWwg5rRv4L9dehk2ZDSj8ll2xj/ bGitwrzbot3FC8eCUdLCrCteT7tRMboathiNIE4w= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MG994-1oevFn1Rim-00GlMC; Wed, 24 Aug 2022 01:39:55 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <861qt6oj42.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 23 Aug 2022 22:27:57 +0300") References: <40517.1661046885@alto> <86a67xk46m.fsf@mail.linkov.net> <87v8qk246x.fsf@web.de> <86ilmkixbw.fsf@mail.linkov.net> <877d2z2a4u.fsf@web.de> <861qt6oj42.fsf@mail.linkov.net> Date: Wed, 24 Aug 2022 01:39:54 +0200 Message-ID: <8735dmil6d.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:U8AI9QRi9a4lS78SwDT+sEeQ1JA/bKojwtFnlYoaRXDYmb/bIWZ QR00TsAQcXMiZcsUZfXvh0JCOFRN2DPA8dqgYMGxH9s4Z84SF/tp43IUtEPU4tc1j59DZ8A SivoQD3U5WFjl9a00N7hZAt7dW6n7WmONGezUrqvqQ/1QhlC6dl+KmOyKI8ffmoA91Ymmx1 v5ZhkQANApJr2hsHSNApA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:B1zdmGjGTEU=:iZT0yS0a1cUP8Q3lEnSwMB KZeiiP/IsKIjqUrZpcRYwRV/TbL+5KXEFb6mxpVfg3xDkw1oKEQ3EDVWnbh2H6KDy8vt1hKFK S1V3fysflNsraeEfIUFb9cJ/8exO9MFoV36+Bv26HECXFmg8U5vucHtxTWSmhLhChO9NOZR9x uG/1Uaz84gBd4Zqj7B5FZysZ3Zkcj/CcyRn1ouvjPUiN9Obm6rmkpGE0V5gUP1wAdklhTD3PC KrjGLtPL8c0poxw4o/30QGHBJJeKOkRoz51kv6WjurCjDX81rGTbwk7kQnyDv7xRkGQIZFtNb VYn74yykJxWHjuXo1VXxXS7WeBM/X73s2rco/6RfurkkLpn/rt5xSHUAra7WaLrNFFszHg8bc Ja18dpPaCaX1nZAhfANTdTFOOIKgUvMY2Uj8NEHmBRXoJFdCirytQ4TdBq8s7opvs4fCP+Jok 9mSQtfDHI9H4BoIS0D9SyiGqoFymHr0BrVVb5paLZXBwZ9hRf2Jr2Jce+Og+XLht3E/95aluw lHgzzfNJ7ftxYH/ewDd3UnbZYwJ9O7OgVCFC4aeaKq63rt/N6hNJ8Xoq4z1G/t2YVZcrFJ+c7 egddWJP/86Umdig06jiN7P3Dcbi140n5XOoR/8Qc7MuPnXqXPlWcv57HqTKmGGU9AuO7JtVRG qcvKkz4ZBR1QOwdXqCFexar+JkJozJrg1RrJCT2XyOX8Zop8FXsjKvX7/HwxVSqEhPx5vCgJW bDQCfXRNydUBotHR7pMaJPb6H0M23kggDvbeGo3kflzgA4h3gsc38tGu+2m8+cYign3eeYhPK 7smWGLVt/u5W7KmJNVDNwwFIlCMk8MkXAe8I1rAFL6baq9U1IrIe0K4hVKH8FHAHPPKa6XY1N oTboo/Wa5uZIJ4Tjv47WRjLNmbJwfZ0dWo62p8KRsKRvPHKamqmMOsnXGxXgV1LNTw6a2dVcV pl7dSrkpPiHir7qcO6vrTE39XamFtfc9kKn3BvZolzPaX5RidAY5xMAzvdA1UU+22DG9P+oRK njdrdDxyhtu2gnfVPdJTS1URk7RT+jNJYLBs3d3ETW7Xbu+VNKkLOEChtouJ6LSafzJXRVwfY QrUVgWVF4E3esHN7kBrSOt3IFJC80bXyNT1DRj7+HnWb5Md1Iuq1Es/GQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Stefan Kangas , Mike Kupfer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Ok, here is the fix to support search and query-replace of e.g. "fo* =E2= =86=92 > baz": Great - thanks. Mike, can you maybe give it a try? > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -2002,7 +2002,9 @@ the buffer will take you to that directory. > *** Search and replace in Dired/Wdired supports more regexps. > For example, the regexp ".*" will match only characters that are part > of the file name. Also "^.*$" can be used to match at the beginning > -of the file name and at the end of the file name. > +of the file name and at the end of the file name. In Wdired this can > +be used when the new user option 'wdired-search-replace-filenames' is > +non-nil (which is the default). Can we say that the behavior in dired is optional, too, and maybe just list the options (and commands) at the end? > -(defun isearch-search-fun-in-text-property (search-fun property) > - "Return the function to search inside text that has the specified PROP= ERTY. > +(defun isearch-search-fun-in-text-property (search-fun properties) > + "Return the function to search inside text that has the specified PROP= ERTIES. > The function will limit the search for matches only inside text which has > -this property in the current buffer. > +these list of PROPERTIES in the current buffer. "which has at least one of the text PROPERTIES" may be better (I also added "text" so that the docstring at least once tells that this is only about text props). The rest of the patch looks good to me, but I didn't test. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 21:15:43 2022 Received: (at 57293) by debbugs.gnu.org; 24 Aug 2022 01:15:43 +0000 Received: from localhost ([127.0.0.1]:45287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQeze-000068-SN for submit@debbugs.gnu.org; Tue, 23 Aug 2022 21:15:43 -0400 Received: from shell1.rawbw.com ([198.144.192.42]:20892 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQezd-000060-39 for 57293@debbugs.gnu.org; Tue, 23 Aug 2022 21:15:41 -0400 Received: from alto (135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 27O1FX8c025608 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 23 Aug 2022 18:15:38 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged) claimed to be alto From: Mike Kupfer To: Michael Heerdegen Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: Your message of "Wed, 24 Aug 2022 01:39:54 +0200." <8735dmil6d.fsf@web.de> X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 23 Aug 2022 18:15:33 -0700 Message-ID: <48818.1661303733@alto> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Stefan Kangas , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen wrote: > Juri Linkov writes: >=20 > > Ok, here is the fix to support search and query-replace of e.g. "fo* = =E2=86=92 > > baz": >=20 > Great - thanks. Mike, can you maybe give it a try? Will do, though it may be a few days before I can get to it. cheers, mike From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 00:04:00 2022 Received: (at 57293) by debbugs.gnu.org; 27 Aug 2022 04:04:00 +0000 Received: from localhost ([127.0.0.1]:54951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRn3A-0005j8-7m for submit@debbugs.gnu.org; Sat, 27 Aug 2022 00:04:00 -0400 Received: from shell1.rawbw.com ([198.144.192.42]:36617 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRn36-0005ix-Jh for 57293@debbugs.gnu.org; Sat, 27 Aug 2022 00:03:58 -0400 Received: from alto (135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 27R43j9H020574 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 26 Aug 2022 21:03:50 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged) claimed to be alto From: Mike Kupfer To: Michael Heerdegen Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: Your message of "Wed, 24 Aug 2022 01:39:54 +0200." <8735dmil6d.fsf@web.de> X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 26 Aug 2022 21:03:45 -0700 Message-ID: <5019.1661573025@alto> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Stefan Kangas , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen wrote: > Juri Linkov writes: >=20 > > Ok, here is the fix to support search and query-replace of e.g. "fo* = =E2=86=92 > > baz": >=20 > Great - thanks. Mike, can you maybe give it a try? It works great. Thanks, Juri! mike From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 15:46:29 2022 Received: (at 57293) by debbugs.gnu.org; 27 Aug 2022 19:46:29 +0000 Received: from localhost ([127.0.0.1]:57131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oS1lF-00015a-3S for submit@debbugs.gnu.org; Sat, 27 Aug 2022 15:46:29 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:40789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oS1lB-00015I-Am for 57293@debbugs.gnu.org; Sat, 27 Aug 2022 15:46:27 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id C0C6260002; Sat, 27 Aug 2022 19:46:16 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <8735dmil6d.fsf@web.de> (Michael Heerdegen's message of "Wed, 24 Aug 2022 01:39:54 +0200") Organization: LINKOV.NET References: <40517.1661046885@alto> <86a67xk46m.fsf@mail.linkov.net> <87v8qk246x.fsf@web.de> <86ilmkixbw.fsf@mail.linkov.net> <877d2z2a4u.fsf@web.de> <861qt6oj42.fsf@mail.linkov.net> <8735dmil6d.fsf@web.de> Date: Sat, 27 Aug 2022 22:44:56 +0300 Message-ID: <861qt1o4hz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Stefan Kangas , Mike Kupfer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> *** Search and replace in Dired/Wdired supports more regexps. >> For example, the regexp ".*" will match only characters that are part >> of the file name. Also "^.*$" can be used to match at the beginning >> -of the file name and at the end of the file name. >> +of the file name and at the end of the file name. In Wdired this can >> +be used when the new user option 'wdired-search-replace-filenames' is >> +non-nil (which is the default). > > Can we say that the behavior in dired is optional, too, and maybe just > list the options (and commands) at the end? I tried to improve this, please check. >> -(defun isearch-search-fun-in-text-property (search-fun property) >> - "Return the function to search inside text that has the specified PROPERTY. >> +(defun isearch-search-fun-in-text-property (search-fun properties) >> + "Return the function to search inside text that has the specified PROPERTIES. >> The function will limit the search for matches only inside text which has >> -this property in the current buffer. >> +these list of PROPERTIES in the current buffer. > > "which has at least one of the text PROPERTIES" may be better (I also > added "text" so that the docstring at least once tells that this is only > about text props). Fixed this as well. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 15:46:35 2022 Received: (at 57293) by debbugs.gnu.org; 27 Aug 2022 19:46:35 +0000 Received: from localhost ([127.0.0.1]:57134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oS1lL-00015y-Da for submit@debbugs.gnu.org; Sat, 27 Aug 2022 15:46:35 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oS1lI-00015S-PK; Sat, 27 Aug 2022 15:46:33 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 20EC9E0002; Sat, 27 Aug 2022 19:46:21 +0000 (UTC) From: Juri Linkov To: Mike Kupfer Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <5019.1661573025@alto> (Mike Kupfer's message of "Fri, 26 Aug 2022 21:03:45 -0700") Organization: LINKOV.NET References: <5019.1661573025@alto> Date: Sat, 27 Aug 2022 22:45:23 +0300 Message-ID: <86tu5xmpws.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57293 Cc: Michael Heerdegen , 57293@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 57293 29.0.50 thanks >> > Ok, here is the fix to support search and query-replace of e.g. "fo* → >> > baz": >> >> Great - thanks. Mike, can you maybe give it a try? > > It works great. Thanks, Juri! Thanks for confirming. Now pushed. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 22:34:44 2022 Received: (at 57293) by debbugs.gnu.org; 28 Aug 2022 02:34:44 +0000 Received: from localhost ([127.0.0.1]:57379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oS88J-00052b-PJ for submit@debbugs.gnu.org; Sat, 27 Aug 2022 22:34:43 -0400 Received: from mout.web.de ([212.227.15.14]:53763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oS88D-00052E-S8 for 57293@debbugs.gnu.org; Sat, 27 Aug 2022 22:34:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1661654070; bh=SoHsYazTMSsj/axH903PiDIDoshL1zQfCU+e/MI+IJk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=RGHTNMwQWyMunv5DL1CW+eH9boetkxk/laCxzjdM9+Y5maQ2qSo496AwaCq+0AdDo pkeKEhv4dNxAMjU1scKRirfT9gXh4d3XKQ/D7DgyzEQemH+F85aY02OfDN5UiXzY9e p7OtQZwk9Fyotu1kNug7AXQCUulKYm6hJnlQAx14= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MLRUV-1ojOAH1wxP-00IfRd; Sun, 28 Aug 2022 04:34:30 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#57293: 29.0.50; query-replace with Wdired skips symlink target In-Reply-To: <861qt1o4hz.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 27 Aug 2022 22:44:56 +0300") References: <40517.1661046885@alto> <86a67xk46m.fsf@mail.linkov.net> <87v8qk246x.fsf@web.de> <86ilmkixbw.fsf@mail.linkov.net> <877d2z2a4u.fsf@web.de> <861qt6oj42.fsf@mail.linkov.net> <8735dmil6d.fsf@web.de> <861qt1o4hz.fsf@mail.linkov.net> Date: Sun, 28 Aug 2022 04:34:29 +0200 Message-ID: <87v8qdhz9m.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:vJQES8Pb535Un5s7DRC0B5+QRWR3F/kV7X1fQ0UeRlARHbXh1pS mM/bMoo5knS8aqiz1R5EZNbvGTnrhScaGcSI4QMU5AYJXbE4Wu2sOkfIU3ZLKi0FJEsvJQ2 iLaWKSkJ73/9vntW8UJipZsBfaIpRFcIDPI359qPOvjlMqmv6kDtKqXpzcbZi14kquIrTHF I61RsgGwVgPN6lkUA2Q6Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:eTrG1PKKL7E=:Zp1ZTnmo3xWa18puWcJMnZ 55AIOY8iK2m+IEGu49aDS5kAmVWj22Q1mFakCSxsrlXd8mRAsJdPpREMgPvu3rswsKYIEyfIZ 5po0a61JSKAxJeTT0q+/HoB91psDbGUj6mDEwQPwke+H9CATqY68TPVRMlmACV3Lym7L9k+pc NaK3/vQ+N/6m1AMX0p2MFvcZy1NaVzQZzQpKpi+4q6Xx/bQOj4s4rISY7QoU5Mta57PbpxAVs hZWmEh1wkKcFOhl3KjyCoVO0fqE5IrtqO2C2RoZ+yYavOQG6MFqTeN6uhOyA15qQFoLx6djn4 MA2UXti6NIKC8P+zKG0i0sokp0xJFyjHIWGeTu+F5xvHGKBkfP0e8NKHWvXrO1XWf8o2ARFaq ruTn7bDDSNk3Q3OkNuz+l/VczNh5cdfX+I9M6MyUNiNSm0Oumv82EAr2i6u5S35GrXIhINq3v 8KqZ5RJeUBuqegjkLFHVlS46gR2NEXG6ZxocREfv8/vZCa0mJVFOdyVwp/CAWxxI/lkWGylE/ LWuE5ZzbRqqM3uSb/S86I5VcnxNryk0CFMYG5An8srLViaUgpDVohvY0H1ZIkVSTd5rlTPfSP BSGFTX7gkTEYCdcQj6e/XqNTS/yvzkC1WPSjdxmNclUoyaqj87ju0ezRWXO9BDkUwWyIWPhk7 UTRkTCd7jIksxqh9atMTLBEvprxfnSBAw8qYS882z1jN2WpPFGJP5jIxwvLpWfc2aWzBeFjSH Nb69fZSY+IwYwpuqZa3CyLng5LXfECI4+R9CjpXdLNllVMh/8K9DUFWkszf7+sI7xxiiBmEzM QuDU71zxP79weYAEx4If0j6yQZN8euL0BD0xHWWTxftg4DvybJyikOhvL7oql+sQBdRsSwJBC bDdnQ+GQ3CHMnE55NN0jEyP6EGJFb/MBaOqkjZGdvIulGEYXgkdzw4VBabcMBtTDm+FVdHZ8o 35QmOwpMFrjSevEXJ03pOwLmmDCrl+lIluPb9URGtdHSI1Ycv8D94Yr5azID6kyLpB/gdmBAc gwlqRDihNJLLcaX8qd+L8jVBhVSRKJSBkiEA9K3BuBElrC/2kmZZRkHQxEKVpO/fySw8iscAj o4x93Fpjj+SlCofBphim2Gq6XR6UQNkblmPsrUxpM4zaofdtSPQkuaY5A== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57293 Cc: 57293@debbugs.gnu.org, Stefan Kangas , Mike Kupfer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri, looks all good to me - thanks. Michael. From unknown Tue Jun 24 22:38:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 Sep 2022 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator