GNU bug report logs - #57291
New package: fftgen

Previous Next

Package: guix-patches;

Reported by: Gabriel Wicki <gabriel <at> erlikon.ch>

Date: Thu, 18 Aug 2022 23:20:01 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 57291 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Gabriel Wicki <gabriel <at> erlikon.ch>, 57291 <at> debbugs.gnu.org
Subject: Re: [bug#57291] New package: fftgen
Date: Fri, 2 Sep 2022 20:57:59 +0200

[Message part 1 (text/plain, inline)]
On 19-08-2022 01:18, Gabriel Wicki wrote:
> +                (file-name (git-file-name name
> +                                          (string-take commit 8)))

You don't have to string-take, the standard pattern is (git-file-name 
name version), as in (guix)Version Numbers.

> +       `(#:tests? #f
Why are tests disabled?  There is a bench-test target, maybe you need 
#:test-target "bench-test"? I hope that means "test bench" and not 
"benchmark" though.

On the license: some parts are GPL3+ (see: 
https://github.com/ZipCPU/dblclockfft/blob/master/sw/legal.h), that 
sounds important to add to the license field to me (license 
(license:lgpl3+ license:gpl3+)).

Greetings,
Maxime.



[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]
This bug report was last modified 2 years and 261 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.