GNU bug report logs - #57257
[PATCH 00/31] Update LXQt to 1.1.0

Previous Next

Package: guix-patches;

Reported by: iyzsong <at> envs.net

Date: Wed, 17 Aug 2022 03:22:01 UTC

Severity: normal

Tags: patch

Done: 宋文武 <iyzsong <at> envs.net>

Bug is archived. No further changes may be made.

Full log

Message #104 received at 57257 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Ricardo Wurmus" <rekado <at> elephly.net>, <57257 <at> debbugs.gnu.org>,
 <iyzsong <at> member.fsf.org>
Subject: Re: [bug#57257] [PATCH 00/31] Update LXQt to 1.1.0
Date: Sun, 21 Aug 2022 12:03:33 +0100

On Sun Aug 21, 2022 at 11:55 AM BST, Ricardo Wurmus wrote:
> - this diff looks wrong to me:
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index 08e33ca0e3..d2cbd1e131 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -843,32 +843,31 @@ (define-public libfm-qt
>  (define-public pcmanfm-qt
>    (package
>      (name "pcmanfm-qt")
> […]
> +    (arguments
> +     (list
> +      #:tests? #f                       ; no tests
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-before 'configure 'patch-settings.conf.in
> +            (lambda* (#:key inputs #:allow-other-keys)
> +              (let ((wallpaper (search-input-file inputs
> +                                "share/lxqt/wallpapers/waves-logo.png")))
> --8<---------------cut here---------------end--------------->8---
>
>   Shouldn’t it be "/share/lxqt…"?

No, this use of search-input-file is correct.

    -- (
This bug report was last modified 2 years and 334 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.