Subject: Re: [PATCH 00/31] Update LXQt to 1.1.0

From: 宋文武 <[email-masked]>
Date: Mon, 22 Aug 2022 08:55:03 +0800

Ricardo Wurmus <[email-masked]> writes:

> Hi,
>
> overall this looks good to me.  Thank you for working on it!
>
> There are just a few questions:
>
> - does it really work to use relative file names?  Would it be possible
>   to test this roughly in a system test?
Yes, the relative file names are for install, at runtime most things
works as designed with XDG_DATA_DIRS and XDG_CONFIG_DIRS.

A system test could verify items in lxqt-config, will look it later...

>
> - you’re removing a lot of patch-source phases.  Why are these no longer
>   needed?

Yeah, I find that use relative file names in LXQtConfigVars.cmake remove
the need of patching other cmake files.
>
> - you’re also removing patch-translations-dir phases.  Do translations
>   still work after applying these changes?

Yes, at runtime they are found under XDG_DATA_DIRS, by
lxqttranslator.cpp:

*searchPath << XdgDirs::dataDirs(QL1C('/') + QL1S(LXQT_RELATIVE_SHARE_TRANSLATIONS_DIR));

> [...]
> Feel free to push this!

Okay, thanks for the review!