Subject: [bug#57257] [PATCH 00/31] Update LXQt to 1.1.0

From: Ricardo Wurmus <[email-masked]>
Date: Sun, 21 Aug 2022 12:55:44 +0200

Hi,

overall this looks good to me.  Thank you for working on it!

There are just a few questions:

- does it really work to use relative file names?  Would it be possible
  to test this roughly in a system test?

- you’re removing a lot of patch-source phases.  Why are these no longer
  needed?

- you’re also removing patch-translations-dir phases.  Do translations
  still work after applying these changes?

- this diff looks wrong to me:

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 08e33ca0e3..d2cbd1e131 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -843,32 +843,31 @@ (define-public libfm-qt
 (define-public pcmanfm-qt
   (package
     (name "pcmanfm-qt")
[…]
+    (arguments
+     (list
+      #:tests? #f                       ; no tests
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'configure 'patch-settings.conf.in
+            (lambda* (#:key inputs #:allow-other-keys)
+              (let ((wallpaper (search-input-file inputs
+                                "share/lxqt/wallpapers/waves-logo.png")))
--8<---------------cut here---------------end--------------->8---

  Shouldn’t it be "/share/lxqt…"?

Feel free to push this!

-- 
Ricardo