GNU bug report logs - #57247
[PATCH] em-unix.el: only pass -H option to grep

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57247 in the body.
You can then email your comments to 57247 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Brendan O'Dea" <bod <at> debian.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] em-unix.el: only pass -H option to grep
Date: Tue, 16 Aug 2022 13:17:40 -0400

[Message part 1 (text/plain, inline)]

Tags: patch

A recent change to eshell-grep added the -H option to cmd in order to
ensure that the filename is always included in the output.

This is fine for grep/egrep/fgrep, but breaks other uses if they don't
support that flag: e.g. agrep/glimpse appear to use -H for a
completely different purpose, one which requires an argument.

In my case, I'm using it to define some eshell commands for some
internal search tools which don't support the flag.

Attached is a patch which moves the addition of the -H option only to
the functions which call grep.

--bod

[em-unix.patch (text/x-patch, attachment)]

Message #8 received at 57247 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Brendan O'Dea" <bod <at> debian.org>
Cc: 57247 <at> debbugs.gnu.org
Subject: Re: bug#57247: [PATCH] em-unix.el: only pass -H option to grep
Date: Wed, 17 Aug 2022 13:20:29 +0200

"Brendan O'Dea" <bod <at> debian.org> writes:

> Attached is a patch which moves the addition of the -H option only to
> the functions which call grep.

Thanks; pushed to Emacs 29.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.