GNU bug report logs - #57241
Commit b87400c broke master

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57241 in the body.
You can then email your comments to 57241 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Jim Porter <jporterbugs <at> gmail.com>
Subject: Commit b87400c broke master
Date: Tue, 16 Aug 2022 14:39:04 +0200

(I am using Gmail's webmail; here's hoping its Plain text mode works.)

Running `make bootstrap' results in:

In toplevel form:
xwidget.el:33:2: Error: Symbol’s function definition is void:
fringe-custom-set-bitmap
make[4]: *** [xwidget.elc] Error 1

I suspect a `require' or an autoload cookie is missing.  Adding
`(require 'fringe)' to lisp/bookmark.el works, but is probably not the
best solution.

Best regards,
Dario

Message #8 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Cc: 57241 <at> debbugs.gnu.org, jporterbugs <at> gmail.com
Subject: Re: bug#57241: Commit b87400c broke master
Date: Tue, 16 Aug 2022 15:55:14 +0300

> Cc: Jim Porter <jporterbugs <at> gmail.com>
> From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
> Date: Tue, 16 Aug 2022 14:39:04 +0200
> 
> (I am using Gmail's webmail; here's hoping its Plain text mode works.)
> 
> Running `make bootstrap' results in:
> 
> In toplevel form:
> xwidget.el:33:2: Error: Symbol’s function definition is void:
> fringe-custom-set-bitmap
> make[4]: *** [xwidget.elc] Error 1

Please show all the information about your build.
fringe-custom-set-bitmap is in fringe.el, which is preloaded in the X
build.  Are you building --without-x or something?

Message #11 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57241 <at> debbugs.gnu.org, jporterbugs <at> gmail.com
Subject: Re: bug#57241: Commit b87400c broke master
Date: Tue, 16 Aug 2022 15:07:29 +0200

On Tue, Aug 16, 2022 at 2:55 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> Please show all the information about your build.
> fringe-custom-set-bitmap is in fringe.el, which is preloaded in the X
> build.  Are you building --without-x or something?

Yes, I am building --without-x --with-json --with-native-compilation.
Also --prefix=$HOME/.local/opt/emacs.  All passed via `make bootstrap
configure="..."'.

Best regards,
Dario

Message #14 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Cc: 57241 <at> debbugs.gnu.org, jporterbugs <at> gmail.com
Subject: Re: bug#57241: Commit b87400c broke master
Date: Tue, 16 Aug 2022 16:16:50 +0300

> From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
> Date: Tue, 16 Aug 2022 15:07:29 +0200
> Cc: 57241 <at> debbugs.gnu.org, jporterbugs <at> gmail.com
> 
> On Tue, Aug 16, 2022 at 2:55 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
> >
> > Please show all the information about your build.
> > fringe-custom-set-bitmap is in fringe.el, which is preloaded in the X
> > build.  Are you building --without-x or something?
> 
> Yes, I am building --without-x --with-json --with-native-compilation.
> Also --prefix=$HOME/.local/opt/emacs.  All passed via `make bootstrap
> configure="..."'.

Can you (load "fringe") in such a build?  If not, a simple 'require'
won't help.

Message #17 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57241 <at> debbugs.gnu.org, jporterbugs <at> gmail.com
Subject: Re: bug#57241: Commit b87400c broke master
Date: Tue, 16 Aug 2022 15:23:58 +0200

On Tue, Aug 16, 2022 at 3:17 PM Eli Zaretskii <eliz <at> gnu.org> wrote:>
> Can you (load "fringe") in such a build?  If not, a simple 'require'
> won't help.

Yes, I can.

Message #20 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Cc: 57241 <at> debbugs.gnu.org, jporterbugs <at> gmail.com
Subject: Re: bug#57241: Commit b87400c broke master
Date: Tue, 16 Aug 2022 16:42:07 +0300

> From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
> Date: Tue, 16 Aug 2022 15:23:58 +0200
> Cc: 57241 <at> debbugs.gnu.org, jporterbugs <at> gmail.com
> 
> On Tue, Aug 16, 2022 at 3:17 PM Eli Zaretskii <eliz <at> gnu.org> wrote:>
> > Can you (load "fringe") in such a build?  If not, a simple 'require'
> > won't help.
> 
> Yes, I can.

OK, I tried to fix this now.

Jim, I wonder whether the default value should be nil on TTY frames.

Message #23 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>,
 Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Cc: 57241 <at> debbugs.gnu.org
Subject: Re: bug#57241: Commit b87400c broke master
Date: Tue, 16 Aug 2022 11:51:07 -0700

On 8/16/2022 6:42 AM, Eli Zaretskii wrote:
>> From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
>> Date: Tue, 16 Aug 2022 15:23:58 +0200
>> Cc: 57241 <at> debbugs.gnu.org, jporterbugs <at> gmail.com
>>
>> On Tue, Aug 16, 2022 at 3:17 PM Eli Zaretskii <eliz <at> gnu.org> wrote:>
>>> Can you (load "fringe") in such a build?  If not, a simple 'require'
>>> won't help.
>>
>> Yes, I can.
> 
> OK, I tried to fix this now.

Maybe it would make sense for fringe.el to be loaded in all builds, but 
to have more things be stub implementations like 'define-fringe-bitmap' 
is? Or maybe 'fringe-custom-set-bitmap' should just be autoloaded?

'require' works here, but if other places start using 
'fringe-custom-set-bitmap' they'll break --without-x builds too. For 
example, gdb-mi.el and edebug.el seem like good candidates for 
eventually doing something like bookmark.el does.

> Jim, I wonder whether the default value should be nil on TTY frames.

It could make sense on --without-x builds, but I don't think it should 
depend on the frame type. With the Emacs daemon, you might switch 
between TTY and GUI frames, and it would be strange if you didn't see 
the fringe indicator in a GUI frame if you had set the indicator in a 
TTY frame.

That said, on --without-x builds, setting a fringe indicator on a 
particular line of text should be safe, right? It just doesn't display 
anything, I think. Previously, I believe the code would (try to) set the 
fringe indicator on --without-x builds, and it seems to not be a 
problem, or else someone would have filed a bug about that against Emacs 28.

Message #26 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 57241 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Subject: bug#57241: Commit b87400c broke master
Date: Fri, 26 Aug 2022 21:06:35 +0200

Looks like test-custom-opts are still broken with respect to bookmark-fringe-mark, at least on EMBA.

Message #29 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 57241 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 control <at> debbugs.gnu.org, Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Subject: Re: bug#57241: Commit b87400c broke master
Date: Tue, 30 Aug 2022 16:55:15 +0200

reopen 57241
stop

For the test-custom-opts failure.

Message #32 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 57241 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>, control <at> debbugs.gnu.org
Subject: Re: bug#57241: Commit b87400c broke master
Date: Wed, 31 Aug 2022 22:55:56 -0700

[Message part 1 (text/plain, inline)]

On 8/30/2022 7:55 AM, Mattias Engdegård wrote:
> reopen 57241
> stop
> 
> For the test-custom-opts failure.

The attached patch fixes this for me. Does this seem like a reasonable 
way to go about it?

[0001-Under-no-X-builds-allow-any-value-for-fringe-bitmap-.patch (text/plain, attachment)]

Message #35 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 57241 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Subject: Re: bug#57241: Commit b87400c broke master
Date: Thu, 1 Sep 2022 10:04:54 +0200

1 sep. 2022 kl. 07.55 skrev Jim Porter <jporterbugs <at> gmail.com>:

> The attached patch fixes this for me. Does this seem like a reasonable way to go about it?

Looks reasonable. Let's give it a try!

Message #38 received at 57241 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 57241 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Subject: Re: bug#57241: Commit b87400c broke master
Date: Thu, 1 Sep 2022 18:36:41 -0700

On 9/1/2022 1:04 AM, Mattias Engdegård wrote:
> 1 sep. 2022 kl. 07.55 skrev Jim Porter <jporterbugs <at> gmail.com>:
> 
>> The attached patch fixes this for me. Does this seem like a reasonable way to go about it?
> 
> Looks reasonable. Let's give it a try!

Ok, merged as 4db596d316263a12bacf1632092a04032a8cde1c.

Message #43 received at 57241-done <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 57241-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Subject: Re: bug#57241: Commit b87400c broke master
Date: Fri, 2 Sep 2022 13:43:54 +0200

> Ok, merged as 4db596d316263a12bacf1632092a04032a8cde1c.

Thank you, and it seems that emba.gnu.org is happy now (in this respect) so I'm marking the bug as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.